coreboot-gerrit February 2025

coreboot-gerrit@coreboot.org

1 participants
2886 discussions

[S] Change in coreboot[main]: soc/intel/pantherlake: Add support for VMD device
by Ronak Kanabar (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Pranava Y N, Subrata Banik. Ronak Kanabar has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/86301?usp=email ) Change subject: soc/intel/pantherlake: Add support for VMD device ...................................................................... Patch Set 3: (2 comments) Patchset: PS2: > Please remove [WIP] tag if ready for review. Done Commit Message: https://review.coreboot.org/c/coreboot/+/86301/comment/56c44bb7_e685672f?us… : PS2, Line 9: This commit adds support for the VMD in the Pantherlake SoC. > Could you explain what VMD is in the commit message ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86301?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie391196e7b4537d1146ac30177a0ba472a1bfb43 Gerrit-Change-Number: 86301 Gerrit-PatchSet: 3 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 14 Feb 2025 10:12:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jayvik Desai <jayvik(a)google.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Add support for VMD device
by Ronak Kanabar (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik. Ronak Kanabar has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/86301?usp=email ) Change subject: soc/intel/pantherlake: Add support for VMD device ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86301?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie391196e7b4537d1146ac30177a0ba472a1bfb43 Gerrit-Change-Number: 86301 Gerrit-PatchSet: 3 Gerrit-Owner: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Fri, 14 Feb 2025 10:08:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brox: Use early power off support
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86356?usp=email ) Change subject: mb/google/brox: Use early power off support ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > > Never mind, I get your idea to HAVE_EARLY_POWEROFF_SUPPORT for all boards that use ChromeEC. Since poweroff() is called from romstage only on platforms with Early Sign of Life, it should be fine. > > > please find the reason behind keeping HAVE_EARLY_POWEROFF_SUPPORT inside board/SoC layer and not at chromeec/Kconfig > > https://review.coreboot.org/c/coreboot/+/86379/comment/44335126_17c184d1/ marking this comment resolved as i have refactored the code to accommodate your feedback. https://review.coreboot.org/c/coreboot/+/86379/comment/44335126_17c184d1/ -- To view, visit https://review.coreboot.org/c/coreboot/+/86356?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib748cb4d540c631afd0f6bd5bff23ec17601f3ed Gerrit-Change-Number: 86356 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 14 Feb 2025 10:08:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[XS] Change in coreboot[main]: ec/google/chromeec: Implement early power off support
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Julius Werner, Karthik Ramasubramanian. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86379?usp=email ) Change subject: ec/google/chromeec: Implement early power off support ...................................................................... Patch Set 3: (1 comment) File src/ec/google/chromeec/reset.c: https://review.coreboot.org/c/coreboot/+/86379/comment/922cbd36_6ecc4521?us… : PS1, Line 8: google_chromeec_do_early_poweroff(); > > Actually, not sure this needs to be an extra file either. If you move the Kconfig `select` into `chromeec/Kconfig` as suggested on CB:86356, this will always be enabled anyway, so you might as well just put it in the main ec.c. > > `HAVE_EARLY_POWEROFF_SUPPORT` cannot be moved to `chromeec/Kconfig` because the `platform_do_early_poweroff` API, declared in intelblocks/pmclib.h, is specific to Intel platforms and not available to other architectures (ARM, AMD) using E`C_GOOGLE_CHROMEEC`. To prevent header inclusion errors, platform_do_early_poweroff is implemented within a file controlled by HAVE_EARLY_POWEROFF_SUPPORT, limiting its current applicability to Intel platforms. with help of CB:86417, I'm able to address your feedback. marking it resolved. please open otherwise. -- To view, visit https://review.coreboot.org/c/coreboot/+/86379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0c634d69de36fe8bdb6a61c121e321d3626ac3ff Gerrit-Change-Number: 86379 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Fri, 14 Feb 2025 10:06:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: soc/intel/cmn/pmc: Add support for early power off
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Subrata Banik. Hello Angel Pons, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86336?usp=email to look at the new patch set (#9). The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Code-Review+2 by Karthik Ramasubramanian, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: soc/intel/cmn/pmc: Add support for early power off ...................................................................... soc/intel/cmn/pmc: Add support for early power off This commit adds support for early power off on Intel platforms along with existing PMC based implementation to support power off at later stage (like ramstage). A new function, `platform_do_early_poweroff`, is added to the pmclib to handle platform-specific early power off procedures. This function is called before memory initialization (in romstage or earlier). Note: While Intel chipsets do not support power off before silicon initialization, this change leverages Chrome EC APIs to enable power off in romstage for low-battery boot on ChromeOS devices. Power off failures in ramstage prior to FSP-S are outside the scope of this change. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/86336/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/86336?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b Gerrit-Change-Number: 86336 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[S] Change in coreboot[main]: soc/intel/cmn/pmc: Add support for early power off
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Intel coreboot Reviewers. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86418?usp=email ) Change subject: soc/intel/cmn/pmc: Add support for early power off ...................................................................... soc/intel/cmn/pmc: Add support for early power off This commit adds support for early power off on Intel platforms along with existing PMC based implementation to support power off at later stage (like ramstage). A new function, `platform_do_early_poweroff`, is added to the pmclib to handle platform-specific early power off procedures. This function is called before memory initialization (in romstage or earlier). Note: While Intel chipsets do not support power off before silicon initialization, this change leverages Chrome EC APIs to enable power off in romstage for low-battery boot on ChromeOS devices. Power off failures in ramstage prior to FSP-S are outside the scope of this change. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b Change-Id: I57286a327765254f261c5ef5077bc5966e04cffb Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/common/block/pmc/pmclib.c 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/86418/1 diff --git a/src/soc/intel/common/block/pmc/pmclib.c b/src/soc/intel/common/block/pmc/pmclib.c index 8c48e88..64b9bb9 100644 --- a/src/soc/intel/common/block/pmc/pmclib.c +++ b/src/soc/intel/common/block/pmc/pmclib.c @@ -15,6 +15,7 @@ #include <intelblocks/gpio.h> #include <intelblocks/tco.h> #include <option.h> +#include <reset.h> #include <security/vboot/vboot_common.h> #include <soc/pci_devs.h> #include <soc/pm.h> @@ -615,7 +616,8 @@ pmc_write_pm1_control(pm1_cnt); } -void poweroff(void) +/* Helper function to perform poweroff operation using PMC chipset register. */ +static void pmc_control_poweroff(void) { pmc_enable_pm1_control(SLP_EN | (SLP_TYP_S5 << SLP_TYP_SHIFT)); @@ -628,6 +630,19 @@ halt(); } +void poweroff(void) +{ + if (!ENV_ROMSTAGE_OR_BEFORE) { + pmc_control_poweroff(); + } else if (CONFIG(HAVE_EARLY_POWEROFF_SUPPORT)) { + platform_do_early_poweroff(); + } else { + printk(BIOS_EMERG, "This platform cannot be powered off until the silicon" + " initialization is complete, hanging!\n"); + halt(); + } +} + void pmc_gpe_init(void) { uint32_t gpio_cfg = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/86418?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I57286a327765254f261c5ef5077bc5966e04cffb Gerrit-Change-Number: 86418 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>

1 0

[S] Change in coreboot[main]: lib: Introduce early power off support Kconfig option
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86417?usp=email ) Change subject: lib: Introduce early power off support Kconfig option ...................................................................... lib: Introduce early power off support Kconfig option This commit introduces the `HAVE_EARLY_POWEROFF_SUPPORT` Kconfig option and the `platform_do_early_poweroff()` API. The Kconfig option enables platform-specific early power off support, which is often required on Intel platforms. The corresponding API allows platforms to implement the necessary hardware operations for early power off, typically before memory initialization. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I05b9882e100825a4fb733163a65f820c8c943361 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/include/reset.h M src/lib/Kconfig 2 files changed, 31 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/86417/1 diff --git a/src/include/reset.h b/src/include/reset.h index 95fe066..a5d5aec 100644 --- a/src/include/reset.h +++ b/src/include/reset.h @@ -41,4 +41,19 @@ */ void do_board_reset(void); +/* + * Performs platform-specific actions for early power off. + * + * This function handles the necessary steps to initiate an early power off + * sequence. This might involve configuring specific hardware registers, + * sending commands to power management controllers, or performing other + * platform-specific operations. It is crucial that this + * function is implemented correctly to ensure a clean and controlled shutdown. + * + * Note: Issuing power off early before memory initialization is not supported use case on + * Intel chipset, therefore, it might need a special platform specific handing + * to power-off the platform early. + */ +void platform_do_early_poweroff(void); + #endif diff --git a/src/lib/Kconfig b/src/lib/Kconfig index 2c1a93c..ad70626 100644 --- a/src/lib/Kconfig +++ b/src/lib/Kconfig @@ -159,3 +159,19 @@ config HAVE_CUSTOM_BMP_LOGO def_bool n depends on BMP_LOGO + +config HAVE_EARLY_POWEROFF_SUPPORT + bool + help + Enable platform-specific early power off support. + + This option should be selected if the platform requires special handling + to power off the system before memory initialization. This is often + necessary on Intel platforms, as directly powering off before memory + initialization is typically not supported by the chipset. + + Selecting this option indicates that the platform implements the + `platform_do_early_poweroff()` function, which performs the + necessary hardware operations to initiate an early power off sequence. + This might involve configuring hardware registers, sending commands to + power management controllers, or other platform-specific operations. -- To view, visit https://review.coreboot.org/c/coreboot/+/86417?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05b9882e100825a4fb733163a65f820c8c943361 Gerrit-Change-Number: 86417 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: soc/intel/common: Add low battery shutdown function
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Angel Pons, Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian. Hello Angel Pons, Intel coreboot Reviewers, Julius Werner, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86361?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/intel/common: Add low battery shutdown function ...................................................................... soc/intel/common: Add low battery shutdown function This commit adds a `do_low_battery_poweroff()` function to handle platform power off due to critically low battery levels. This provides a standardized way to handle low battery shutdowns across platforms. BUG=b:339673254 TEST=Able to build and boot google/brox. Change-Id: I92e9003c70c2608770972f1a302f954ebdf17bc4 Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/soc/intel/common/reset.c M src/soc/intel/common/reset.h 2 files changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/86361/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/86361?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I92e9003c70c2608770972f1a302f954ebdf17bc4 Gerrit-Change-Number: 86361 Gerrit-PatchSet: 5 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[XS] Change in coreboot[main]: ec/google/chromeec: Implement early power off support
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Attention is currently required from: Boris Mittelberg, Caveh Jalali, Julius Werner, Karthik Ramasubramanian. Hello Boris Mittelberg, Caveh Jalali, Julius Werner, Karthik Ramasubramanian, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86379?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Karthik Ramasubramanian, Verified+1 by build bot (Jenkins) Change subject: ec/google/chromeec: Implement early power off support ...................................................................... ec/google/chromeec: Implement early power off support This commit adds early power off support for the Chrome EC. It selects the `HAVE_EARLY_POWEROFF_SUPPORT` Kconfig option, and implements the `platform_do_early_poweroff()` API by calling `google_chromeec_do_early_poweroff()`. This allows platforms using the Chrome EC to perform early power off procedures. Change-Id: I0c634d69de36fe8bdb6a61c121e321d3626ac3ff Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/ec/google/chromeec/Kconfig M src/ec/google/chromeec/ec.c 2 files changed, 7 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/86379/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86379?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0c634d69de36fe8bdb6a61c121e321d3626ac3ff Gerrit-Change-Number: 86379 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: Use early power off support
by Subrata Banik (Code Review) 14 Feb '25

14 Feb '25

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86359?usp=email ) Change subject: mb/google/fatcat: Use early power off support ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6b31d6916898541b0396002376910eed5d26b06 Gerrit-Change-Number: 86359 Gerrit-PatchSet: 4 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit February 2025