coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
830 discussions

Start a nNew thread

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

1 0

[S] Change in coreboot[main]: mb/hp/pro_3500_series: Move usb configuration
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Václav Straka has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/85831?usp=email ) Change subject: mb/hp/pro_3500_series: Move usb configuration ...................................................................... mb/hp/pro_3500_series: Move usb configuration Since commit 943b5409147 USB configurations are read from the southbridge devicetree This change only moves the USB configuration from early_init.c to the devicetree Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184 Signed-off-by: Vesek <venda.straka(a)gmail.com> --- M src/mainboard/hp/pro_3500_series/devicetree.cb M src/mainboard/hp/pro_3500_series/early_init.c 2 files changed, 16 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/85831/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184 Gerrit-Change-Number: 85831 Gerrit-PatchSet: 2 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/hp/pro_3500_series: Move usb configuration
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Václav Straka has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85831?usp=email ) Change subject: mb/hp/pro_3500_series: Move usb configuration ...................................................................... mb/hp/pro_3500_series: Move usb configuration Since commit 943b5409147 USB configurations are read from the southbridge devicetree This change only moves the USB configuration from early_init.c to the devicetree Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184 Signed-off-by: Vesek <venda.straka(a)gmail.com> --- M src/mainboard/hp/pro_3500_series/devicetree.cb M src/mainboard/hp/pro_3500_series/early_init.c 2 files changed, 16 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/85831/1 diff --git a/src/mainboard/hp/pro_3500_series/devicetree.cb b/src/mainboard/hp/pro_3500_series/devicetree.cb index cf75313..3d9cf61 100644 --- a/src/mainboard/hp/pro_3500_series/devicetree.cb +++ b/src/mainboard/hp/pro_3500_series/devicetree.cb @@ -22,6 +22,22 @@ register "sata_port_map" = "0x33" register "spi_lvscc" = "0x2005" register "spi_uvscc" = "0x2005" + register "usb_port_config" = "{ + { 1, 6, 0 }, + { 1, 6, 0 }, + { 1, 6, 1 }, + { 1, 9, 1 }, + { 1, 10, 2 }, + { 1, 11, 2 }, + { 1, 6, 3 }, + { 1, 6, 3 }, + { 1, 6, 4 }, + { 1, 12, 4 }, + { 1, 6, 6 }, + { 1, 11, 5 }, + { 1, 6, 5 }, + { 1, 6, 6 }, + }" device ref ehci2 on end device ref hda on end device ref pcie_rp2 on end # MINI_PCIE diff --git a/src/mainboard/hp/pro_3500_series/early_init.c b/src/mainboard/hp/pro_3500_series/early_init.c index fbf73cfb..1e149b5 100644 --- a/src/mainboard/hp/pro_3500_series/early_init.c +++ b/src/mainboard/hp/pro_3500_series/early_init.c @@ -8,23 +8,6 @@ #include "common_defines.h" #include "led.h" -const struct southbridge_usb_port mainboard_usb_ports[] = { - { 1, 6, 0 }, - { 1, 6, 0 }, - { 1, 6, 1 }, - { 1, 9, 1 }, - { 1, 10, 2 }, - { 1, 11, 2 }, - { 1, 6, 3 }, - { 1, 6, 3 }, - { 1, 6, 4 }, - { 1, 12, 4 }, - { 1, 6, 6 }, - { 1, 11, 5 }, - { 1, 6, 5 }, - { 1, 6, 6 }, -}; - void bootblock_mainboard_early_init(void) { pci_write_config16(PCH_LPC_DEV, LPC_EN, CNF1_LPC_EN | KBC_LPC_EN); -- To view, visit https://review.coreboot.org/c/coreboot/+/85831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184 Gerrit-Change-Number: 85831 Gerrit-PatchSet: 1 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Angel Pons. Václav Straka has uploaded a new patch set (#4). ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... mb/hp: Add Pro 3400 Based on autoport and HP Pro 3500. As part of this change renamed 3500 to 3x00 and added this as it's variant. It's an almost identical board to the 3500 but has a smaller flash. Other differences between boards were identified by autoport. They may or may not important but were included anyway. Tested on HP Pro 3400, behaves exactly as 3500 described in the docs. Changes were not significant enough to require retesting on 3500. Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Signed-off-by: Vesek <venda.straka(a)gmail.com> --- D Documentation/mainboard/hp/pro_3500_series.md A Documentation/mainboard/hp/pro_3x00_series.md R Documentation/mainboard/hp/pro_3x00_series_flash.avif R Documentation/mainboard/hp/pro_3x00_series_jumper.avif M Documentation/mainboard/index.md D src/mainboard/hp/pro_3500_series/Kconfig A src/mainboard/hp/pro_3x00_series/Kconfig R src/mainboard/hp/pro_3x00_series/Kconfig.name R src/mainboard/hp/pro_3x00_series/Makefile.mk R src/mainboard/hp/pro_3x00_series/acpi/ec.asl R src/mainboard/hp/pro_3x00_series/acpi/platform.asl R src/mainboard/hp/pro_3x00_series/acpi/superio.asl R src/mainboard/hp/pro_3x00_series/acpi_tables.c A src/mainboard/hp/pro_3x00_series/board_info.txt A src/mainboard/hp/pro_3x00_series/cmos.default A src/mainboard/hp/pro_3x00_series/cmos.layout R src/mainboard/hp/pro_3x00_series/common_defines.h R src/mainboard/hp/pro_3x00_series/devicetree.cb R src/mainboard/hp/pro_3x00_series/dsdt.asl R src/mainboard/hp/pro_3x00_series/early_init.c R src/mainboard/hp/pro_3x00_series/gma-mainboard.ads R src/mainboard/hp/pro_3x00_series/hda_verb.c R src/mainboard/hp/pro_3x00_series/led.c R src/mainboard/hp/pro_3x00_series/led.h R src/mainboard/hp/pro_3x00_series/mainboard.c R src/mainboard/hp/pro_3x00_series/smihandler.c C src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/data.vbt A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/gpio.c A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/data.vbt R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/gpio.c A src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb 34 files changed, 499 insertions(+), 165 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/85825/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 4 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Angel Pons. Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 3: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85825/comment/d139cc43_1fa6f77e?us… : PS1, Line 11: As a side effect fixed 3500's USB. (broken since 81878) > I'm basing this off https://doc.coreboot.org/contributing/gerrit_guidelines. […] Okay, I'll create a new change and rebase this one on top of that. File src/mainboard/hp/pro_3x00_series/Kconfig: https://review.coreboot.org/c/coreboot/+/85825/comment/b0e0ff76_c05b4160?us… : PS1, Line 47: default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(CONFIG_VARIANT_DIR)/data.vbt" > That's true. I assumed it isn't and just copied it from hp/snb_ivb_desktops. I will remove it. Done File src/mainboard/hp/pro_3x00_series/cmos.default: https://review.coreboot.org/c/coreboot/+/85825/comment/f865e6cb_e337f536?us… : PS1, Line 6: nmi=Enable > Acknowledged Done File src/mainboard/hp/pro_3x00_series/cmos.layout: https://review.coreboot.org/c/coreboot/+/85825/comment/208ae70a_27b0479e?us… : PS1, Line 26: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 : 960 16 r 0 mrc_scrambler_seed_chk > Acknowledged Done File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85825/comment/6609a9a3_f1f1a601?us… : PS1, Line 24: device ref mei1 off end > I copied this from autoport's output, i probably had the FDO jumper on at that time without realizin […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 3 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 15:35:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Václav Straka <venda.straka(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Václav Straka. Václav Straka has uploaded a new patch set (#3). ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... mb/hp: Add Pro 3400 Based on autoport and HP Pro 3500. As part of this change renamed 3500 to 3x00 and added this as it's variant. It's an almost identical board to the 3500 but has a smaller flash. Other differences between boards were identified by autoport. They may or may not important but were included anyway. Tested on HP Pro 3400, behaves exactly as 3500 described in the docs. Changes were not significant enough to require retesting on 3500. Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Signed-off-by: Vesek <venda.straka(a)gmail.com> --- D Documentation/mainboard/hp/pro_3500_series.md A Documentation/mainboard/hp/pro_3x00_series.md R Documentation/mainboard/hp/pro_3x00_series_flash.avif R Documentation/mainboard/hp/pro_3x00_series_jumper.avif M Documentation/mainboard/index.md D src/mainboard/hp/pro_3500_series/Kconfig A src/mainboard/hp/pro_3x00_series/Kconfig R src/mainboard/hp/pro_3x00_series/Kconfig.name R src/mainboard/hp/pro_3x00_series/Makefile.mk R src/mainboard/hp/pro_3x00_series/acpi/ec.asl R src/mainboard/hp/pro_3x00_series/acpi/platform.asl R src/mainboard/hp/pro_3x00_series/acpi/superio.asl R src/mainboard/hp/pro_3x00_series/acpi_tables.c A src/mainboard/hp/pro_3x00_series/board_info.txt A src/mainboard/hp/pro_3x00_series/cmos.default A src/mainboard/hp/pro_3x00_series/cmos.layout R src/mainboard/hp/pro_3x00_series/common_defines.h R src/mainboard/hp/pro_3x00_series/devicetree.cb R src/mainboard/hp/pro_3x00_series/dsdt.asl R src/mainboard/hp/pro_3x00_series/early_init.c R src/mainboard/hp/pro_3x00_series/gma-mainboard.ads R src/mainboard/hp/pro_3x00_series/hda_verb.c R src/mainboard/hp/pro_3x00_series/led.c R src/mainboard/hp/pro_3x00_series/led.h R src/mainboard/hp/pro_3x00_series/mainboard.c R src/mainboard/hp/pro_3x00_series/smihandler.c C src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/data.vbt A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/gpio.c A src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/data.vbt R src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/gpio.c A src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/overridetree.cb 34 files changed, 499 insertions(+), 165 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/85825/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 3 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Angel Pons (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Václav Straka. Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85825/comment/e11073d6_fe483e2f?us… : PS1, Line 11: As a side effect fixed 3500's USB. (broken since 81878) I'm basing this off https://doc.coreboot.org/contributing/gerrit_guidelines.html#recommendation… > Each patch should be kept to one logical change, which should be described in the title of the patch. File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85825/comment/7490d766_440d4521?us… : PS1, Line 25: device ref pci_bridge off end > I tried finding a workaround for it, but leaving a redundant device in the overlay seems to be the o […] Ah, right, there needs to be a device. I'd say use an EHCI device as dummy, with a comment saying why it's there -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 2 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 15:14:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Václav Straka <venda.straka(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

1 0

[L] Change in coreboot[main]: mb/hp: Add Pro 3400
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Angel Pons. Václav Straka has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email ) Change subject: mb/hp: Add Pro 3400 ...................................................................... Patch Set 2: (6 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85825/comment/d330d012_2f6e5f70?us… : PS1, Line 11: As a side effect fixed 3500's USB. (broken since 81878) > This should belong to a separate commit. I'm not sure what exactly fixed the USB ports. […] USB ports were configured in early_init.c and this change moved it to the devicetree. I just moved the code. I don't think this needs to be another commit since the values are the same just in a different place. I'll fix the reference. File src/mainboard/hp/pro_3x00_series/Kconfig: https://review.coreboot.org/c/coreboot/+/85825/comment/a23801f0_5bcb1c24?us… : PS1, Line 47: default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(CONFIG_VARIANT_DIR)/data.vbt" > I think this is the default path That's true. I assumed it isn't and just copied it from hp/snb_ivb_desktops. I will remove it. File src/mainboard/hp/pro_3x00_series/cmos.default: https://review.coreboot.org/c/coreboot/+/85825/comment/34149a65_80d897e1?us… : PS1, Line 6: nmi=Enable > I would disable NMI by default, IIRC the state isn't properly saved/restored so NMI ends up disabled […] Acknowledged File src/mainboard/hp/pro_3x00_series/cmos.layout: https://review.coreboot.org/c/coreboot/+/85825/comment/0a4d3691_f5271523?us… : PS1, Line 26: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 : 960 16 r 0 mrc_scrambler_seed_chk > Unused with native raminit, which is forced on (`select USE_NATIVE_RAMINIT`). Please remove. Acknowledged File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85825/comment/9dc3fa12_35015754?us… : PS1, Line 24: device ref mei1 off end > Why is this off? If you used me_cleaner or the FDO jumper, the ME stops working properly and vendor […] I copied this from autoport's output, i probably had the FDO jumper on at that time without realizing it. I'll remove this. https://review.coreboot.org/c/coreboot/+/85825/comment/8a519481_1858cea1?us… : PS1, Line 25: device ref pci_bridge off end > This is the default state. This line can be removed. I would remove this but then there would be no devices left on this chip so it wouldn't build. CB:51119 -- To view, visit https://review.coreboot.org/c/coreboot/+/85825?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I833996f6eddcaac91fb0ad0cd95fcc2a99447387 Gerrit-Change-Number: 85825 Gerrit-PatchSet: 2 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 15:02:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

← Newer
1
...
71
72
73
74
75
76
77
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025