coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
830 discussions

[S] Change in coreboot[main]: commonlib/device_tree.c: Add a function that reads FDT ints
by Benjamin Doron (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Benjamin Doron, Julius Werner, Lean Sheng Tan. Hello Julius Werner, Lean Sheng Tan, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85643?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+2 by Julius Werner, Verified+1 by build bot (Jenkins) Change subject: commonlib/device_tree.c: Add a function that reads FDT ints ...................................................................... commonlib/device_tree.c: Add a function that reads FDT ints Follow the recommendation at https://review.coreboot.org/c/coreboot/+/84796/comment/21f615a2_99a41147/ and implement support for reading integer properties generically, using their size to determine how much to read. This will be used for reading `load`, `entry` and perhaps others. Change-Id: I02d27eb5e23dfbfc1404d209ee8d60968e22bb80 Signed-off-by: Benjamin Doron <benjamin.doron(a)9elements.com> --- M src/commonlib/device_tree.c M src/commonlib/include/commonlib/device_tree.h 2 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/85643/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02d27eb5e23dfbfc1404d209ee8d60968e22bb80 Gerrit-Change-Number: 85643 Gerrit-PatchSet: 6 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com>

1 0

[XS] Change in coreboot[main]: Documentation: Fix make rule for sphinx-autobuild
by Václav Straka (Code Review) 02 Jan '25

02 Jan '25

Václav Straka has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85833?usp=email ) Change subject: Documentation: Fix make rule for sphinx-autobuild ...................................................................... Documentation: Fix make rule for sphinx-autobuild Add source directory to arguments of sphinx-autobuild Tested in docker and natively Change-Id: I3d3b0547acd7b070925d9bee818ee1ef230f5f46 Signed-off-by: Vesek <venda.straka(a)gmail.com> --- M Documentation/Makefile.sphinx 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/85833/1 diff --git a/Documentation/Makefile.sphinx b/Documentation/Makefile.sphinx index c4984ec..164f90e 100644 --- a/Documentation/Makefile.sphinx +++ b/Documentation/Makefile.sphinx @@ -21,7 +21,7 @@ @echo "Starting sphinx-autobuild. The HTML pages are in $(BUILDDIR)." @echo "Press Ctrl-C to stop." @echo - $(SPHINXAUTOBUILD) -b html $(ALLSPHINXOPTS) $(BUILDDIR) + $(SPHINXAUTOBUILD) -b html "$(SOURCEDIR)" $(ALLSPHINXOPTS) $(BUILDDIR) # Catch-all target: route all unknown targets to Sphinx using the new # "make mode" option. $(O) is meant as a shortcut for $(SPHINXOPTS). -- To view, visit https://review.coreboot.org/c/coreboot/+/85833?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3d3b0547acd7b070925d9bee818ee1ef230f5f46 Gerrit-Change-Number: 85833 Gerrit-PatchSet: 1 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com>

1 0

[M] Change in coreboot[main]: cpu/x86/64bit: Install extended page tables in BSS
by Jérémy Compostella (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Christian Walter, Johnny Lin, Jonathan Zhang, Patrick Rudolph, Shuo Liu, Tim Chu. Jérémy Compostella has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85806?usp=email ) Change subject: cpu/x86/64bit: Install extended page tables in BSS ...................................................................... Patch Set 3: (4 comments) File src/cpu/x86/64bit/mmu.c: https://review.coreboot.org/c/coreboot/+/85806/comment/6773cc75_93c50cab?us… : PS3, Line 12: #define _PRES (1ULL << 0) Can't you use the BIT macro? https://review.coreboot.org/c/coreboot/+/85806/comment/a5df0763_15d5152b?us… : PS3, Line 64: int size_t https://review.coreboot.org/c/coreboot/+/85806/comment/1bafc4aa_8da36ea0?us… : PS3, Line 59: if (cpu_supports_1gb_hugepage()) { : const uintptr_t max_addr = 1ULL * GiB * 512ULL * 512ULL; : const uint64_t incr = 1ULL * GiB; : : /* Build P4MLE */ : for (int i = 0; i < 512; i++) : p4mle[i] = _GEN_DIR(&pdpt[i * 512]); : : /* Build PDPT */ : uint64_t *page_table_ptr = pdpt; : for (uintptr_t addr = 0; addr < max_addr; addr += incr, page_table_ptr++) : *page_table_ptr = _GEN_PAGE(addr); : } else { : const uintptr_t max_addr = 2ULL * MiB * 512ULL * 512ULL; : const uint64_t incr = 2ULL * MiB; : : /* Build P4MLE */ : p4mle[0] = _GEN_DIR(&pdpt[0]); : : /* Build PDPT */ : for (int i = 0; i < 512; i++) : pdpt[i] = _GEN_DIR(&pdt[i * 512]); : : /* Build PDT */ : uint64_t *page_table_ptr = pdt; : for (uintptr_t addr = 0; addr < max_addr; addr += incr, page_table_ptr++) : *page_table_ptr = _GEN_PAGE(addr); : } : There are a lot in common between these two branches, isn't it a way to share more code ? https://review.coreboot.org/c/coreboot/+/85806/comment/60ed878c_1b7db564?us… : PS3, Line 150: else unnecessary `else` keyword. -- To view, visit https://review.coreboot.org/c/coreboot/+/85806?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifab50975e0382a1f5c27b55bca1dbbb66b37ba3a Gerrit-Change-Number: 85806 Gerrit-PatchSet: 3 Gerrit-Owner: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 18:57:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: lib/{fit,fit_payload}.c: Enhance support for FIT images
by Julius Werner (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Benjamin Doron, Felix Held, Lean Sheng Tan, Matt DeVillier, Maximilian Brune, Philipp Hug, ron minnich. Julius Werner has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/84796?usp=email ) Change subject: lib/{fit,fit_payload}.c: Enhance support for FIT images ...................................................................... Patch Set 10: (3 comments) File payloads/Kconfig: https://review.coreboot.org/c/coreboot/+/84796/comment/89b7803b_cfe6c752?us… : PS9, Line 186: default y if PAYLOAD_LINUX && (ARCH_ARM64 || ARCH_RISCV || ARCH_ARM) > Oh, I think that made it align with other instances of this dependency in the file, which allowed me […] Acknowledged File src/lib/fit_payload.c: https://review.coreboot.org/c/coreboot/+/84796/comment/bb528311_24a2157d?us… : PS9, Line 29: printk(BIOS_ERR, "WEAK: %s:%s() called to add %s to FDT\n", __FILE__, __func__, name); > Do you have any ideas for paths? Possibly, `/firmware/secondary-images`. If we decide on some path and a PR for the spec is up, I'll change this code to reflect that and drop the callout. You mean in the FDT? That's the problem, the FDT is really specific to the payload you're loading, there are no "universal" rules on paths. `/firmware/coreboot` and all that stuff is specific to the Linux kernel. UPL has its own spec on how the FDT is supposed to look like, which tries to vaguely match the kernel in style where that works but is really not the same. If you say that there are other firmware payloads that are loaded by this but are not UPL, then I don't know how the FDT is supposed to look like for them, that's up to them. The entire point of UPL was to standardize that FDT, after all. > No, see section 4.1 of the FIT spec. You mean the one that only goes up to section 3.4 here: https://fitspec.osfw.foundation/ ? ;) It sounds like I need some extra context that's not yet officially published(?) and maybe then I'll have an easier time following what all this is supposed to do. https://review.coreboot.org/c/coreboot/+/84796/comment/0611fae8_89a52d48?us… : PS9, Line 403: &fdt, &initrd > Yes. […] Oh, okay, I see how the FDT thing gets added in the later patches. But for initrd, if one specific UPL payload had an initrd, wouldn't that just be just another secondary loadable for it? Wouldn't `load_secondaries()` take care of it? -- To view, visit https://review.coreboot.org/c/coreboot/+/84796?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6a21954c0dc5fd820d135e8cd0599ce87903a1c0 Gerrit-Change-Number: 84796 Gerrit-PatchSet: 10 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 02 Jan 2025 18:54:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Benjamin Doron <benjamin.doron00(a)gmail.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>

1 0

[S] Change in coreboot[main]: mb/hp/pro_3500_series: Move usb configuration
by Keith Hui (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Keith Hui, Nicholas Chin, Václav Straka. Keith Hui has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85831?usp=email ) Change subject: mb/hp/pro_3500_series: Move usb configuration ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: This reminds me to sweep again for any leftovers. -- To view, visit https://review.coreboot.org/c/coreboot/+/85831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184 Gerrit-Change-Number: 85831 Gerrit-PatchSet: 2 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 18:35:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: commonlib/device_tree.c: Add a function that reads FDT ints
by Julius Werner (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Benjamin Doron, Lean Sheng Tan. Julius Werner has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/85643?usp=email ) Change subject: commonlib/device_tree.c: Add a function that reads FDT ints ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85643/comment/5b18fc62_a597e002?us… : PS5, Line 13: / typo File src/commonlib/device_tree.c: https://review.coreboot.org/c/coreboot/+/85643/comment/2ef119c5_0c06b5a9?us… : PS5, Line 266: printk(BIOS_ERR, "FDT integer property of size %u @%p doesn't match expected cell count %u\n", prop->size, prop->data, cells); Should at least drop the arguments after the format string into a continuation line. -- To view, visit https://review.coreboot.org/c/coreboot/+/85643?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02d27eb5e23dfbfc1404d209ee8d60968e22bb80 Gerrit-Change-Number: 85643 Gerrit-PatchSet: 5 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 18:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: device/pci_ids: Add Panther Lake Intel Touch Controller PCI IDs
by Jérémy Compostella (Code Review) 02 Jan '25

02 Jan '25

Jérémy Compostella has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85814?usp=email ) Change subject: device/pci_ids: Add Panther Lake Intel Touch Controller PCI IDs ...................................................................... device/pci_ids: Add Panther Lake Intel Touch Controller PCI IDs The IDs comes from document #815002 Panther Lake External Design Specification volume 1. Change-Id: I23927631b165ded552860acf44dc8b67d41951c7 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85814 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/include/device/pci_ids.h 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 553d855..4279588 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -4949,6 +4949,14 @@ #define PCI_DID_INTEL_MTL_THC0_SPI 0x7e49 #define PCI_DID_INTEL_MTL_THC1_INTEL 0x7e4a #define PCI_DID_INTEL_MTL_THC1_SPI 0x7e4b +#define PCI_DID_INTEL_PTL_U_H_THC0_I2C 0xe348 +#define PCI_DID_INTEL_PTL_U_H_THC0_SPI 0xe349 +#define PCI_DID_INTEL_PTL_U_H_THC1_I2C 0xe34a +#define PCI_DID_INTEL_PTL_U_H_THC1_SPI 0xe34b +#define PCI_DID_INTEL_PTL_H_THC0_I2C 0xe448 +#define PCI_DID_INTEL_PTL_H_THC0_SPI 0xe449 +#define PCI_DID_INTEL_PTL_H_THC1_I2C 0xe44a +#define PCI_DID_INTEL_PTL_H_THC1_SPI 0xe44b #define PCI_VID_COMPUTONE 0x8e0e #define PCI_DID_COMPUTONE_IP2EX 0x0291 -- To view, visit https://review.coreboot.org/c/coreboot/+/85814?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I23927631b165ded552860acf44dc8b67d41951c7 Gerrit-Change-Number: 85814 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: device/pci_ids: Rename Meteor Lake Intel Touch Controller PCI IDs
by Jérémy Compostella (Code Review) 02 Jan '25

02 Jan '25

Jérémy Compostella has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85644?usp=email ) Change subject: device/pci_ids: Rename Meteor Lake Intel Touch Controller PCI IDs ...................................................................... device/pci_ids: Rename Meteor Lake Intel Touch Controller PCI IDs This commit renames the Meteor lake Touch Controller device IDs to include the supported bus/protocol for clarity. The IDs comes from document #640228 - Meteor Lake External Design Specification volume 1. Change-Id: I60d9bec60d0578bd5a12a4df25248b7ae58539d6 Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85644 Reviewed-by: Subrata Banik <subratabanik(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/include/device/pci_ids.h 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 60ed807..553d855 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -4945,10 +4945,10 @@ #define PCI_DID_INTEL_EHL_GBE_PSE_1 0x4BB0 /* Intel Touch Controller */ -#define PCI_DID_INTEL_MTL_THC0_1 0x7e48 -#define PCI_DID_INTEL_MTL_THC0_2 0x7e49 -#define PCI_DID_INTEL_MTL_THC1_1 0x7e4a -#define PCI_DID_INTEL_MTL_THC1_2 0x7e4b +#define PCI_DID_INTEL_MTL_THC0_INTEL 0x7e48 +#define PCI_DID_INTEL_MTL_THC0_SPI 0x7e49 +#define PCI_DID_INTEL_MTL_THC1_INTEL 0x7e4a +#define PCI_DID_INTEL_MTL_THC1_SPI 0x7e4b #define PCI_VID_COMPUTONE 0x8e0e #define PCI_DID_COMPUTONE_IP2EX 0x0291 -- To view, visit https://review.coreboot.org/c/coreboot/+/85644?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I60d9bec60d0578bd5a12a4df25248b7ae58539d6 Gerrit-Change-Number: 85644 Gerrit-PatchSet: 3 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: Documentation/mb/asus/p8z77-m: Document latest test results
by Nicholas Chin (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Angel Pons, Keith Hui, Kevin Keijzer, Paul Menzel. Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/78204?usp=email ) Change subject: Documentation/mb/asus/p8z77-m: Document latest test results ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f4c9268cd272caa83267be3f71d4a2022c26a1c Gerrit-Change-Number: 78204 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 17:44:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/hp/pro_3500_series: Move usb configuration
by Angel Pons (Code Review) 02 Jan '25

02 Jan '25

Attention is currently required from: Nicholas Chin, Václav Straka. Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85831?usp=email ) Change subject: mb/hp/pro_3500_series: Move usb configuration ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85831?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I69f1f800e4e2de5367795400d619bf9c000ff184 Gerrit-Change-Number: 85831 Gerrit-PatchSet: 2 Gerrit-Owner: Václav Straka <venda.straka(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Václav Straka <venda.straka(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Jan 2025 17:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

← Newer
1
...
70
71
72
73
74
75
76
...
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025