coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[XS] Change in coreboot[main]: soc/intel/tigerlake: Change the maximum C state to C8
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Intel coreboot Reviewers, Nick Vaccaro, Sean Rhodes, Subrata Banik. Hello Intel coreboot Reviewers, Jérémy Compostella, Nick Vaccaro, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86199?usp=email to look at the new patch set (#2). Change subject: soc/intel/tigerlake: Change the maximum C state to C8 ...................................................................... soc/intel/tigerlake: Change the maximum C state to C8 The EDS says that Tiger Lake "supports C0, C2, C3, C6, C8, and C10 package states". Update the highest state for non-S0ix boards accordingly. Change-Id: I3fe0f5a8f9b52a44d1951037d74df4a244ba602e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/intel/tigerlake/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/86199/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86199?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3fe0f5a8f9b52a44d1951037d74df4a244ba602e Gerrit-Change-Number: 86199 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: soc/intel/meteorlake: Change the maximum C state to C8
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85690?usp=email ) Change subject: soc/intel/meteorlake: Change the maximum C state to C8 ...................................................................... soc/intel/meteorlake: Change the maximum C state to C8 The EDS says that Meteor Lake "supports C0, C2, C3, C6, C8, and C10 package states". Update the highest state for non-S0ix boards accordingly. Change-Id: I7de1220b0e26aa9dcca71e58caf17a0f168e7b24 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85690 Reviewed-by: Kapil Porwal <kapilporwal(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> --- M src/soc/intel/meteorlake/acpi.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jérémy Compostella: Looks good to me, approved build bot (Jenkins): Verified Kapil Porwal: Looks good to me, but someone else must approve diff --git a/src/soc/intel/meteorlake/acpi.c b/src/soc/intel/meteorlake/acpi.c index e3aa44e..f32ba56 100644 --- a/src/soc/intel/meteorlake/acpi.c +++ b/src/soc/intel/meteorlake/acpi.c @@ -104,7 +104,7 @@ static int cstate_set_non_s0ix[] = { C_STATE_C1, C_STATE_C6_LONG_LAT, - C_STATE_C7S_LONG_LAT + C_STATE_C8 }; static int cstate_set_s0ix[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/85690?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7de1220b0e26aa9dcca71e58caf17a0f168e7b24 Gerrit-Change-Number: 85690 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starfighter: Disable SATA
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86187?usp=email ) Change subject: mb/starlabs/starfighter: Disable SATA ...................................................................... mb/starlabs/starfighter: Disable SATA The mass produced boards did not support SATA, so disable it. Change-Id: I7477b46c929a9d9e0d0351de6146112f78cece9f Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86187 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index db31d8d..50cb8ae 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -183,11 +183,6 @@ end end device ref shared_sram on end - device ref sata on - register "sata_salp_support" = "1" - register "sata_ports_enable[1]" = "1" - register "sata_ports_dev_slp[1]" = "1" - end device ref pcie_rp5 on # WiFi chip drivers/wifi/generic register "enable_cnvi_ddr_rfim" = "true" -- To view, visit https://review.coreboot.org/c/coreboot/+/86187?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7477b46c929a9d9e0d0351de6146112f78cece9f Gerrit-Change-Number: 86187 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Correct the enable GPIO for WLAN
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86184?usp=email ) Change subject: mb/starlabs/*: Correct the enable GPIO for WLAN ...................................................................... mb/starlabs/*: Correct the enable GPIO for WLAN These are configured incorrectly, to use the WLAN WAKE GPIOs as enable GPIOS. Correct these to use WIFI RF KILL, and disconnect the now unused WLAN WAKE GPIOs. Change-Id: I12797875acacc231e155ab4e427a950a3b1b9703 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86184 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 10 files changed, 10 insertions(+), 10 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 6353d64..5e9ca3f 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -223,7 +223,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: Test Point 10 */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 9c19348..341ea40 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -162,7 +162,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index dae0df2..ec32e83 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -222,7 +222,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb index d9892c5..af9e30e 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb @@ -170,7 +170,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "1" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index ed759d4..79a4c4c 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -222,7 +222,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index cc31831..abc4a7a 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -199,7 +199,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "skip_on_off_support" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 4ef11d4..a17c00f 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -222,7 +222,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index 5dfba49..db31d8d 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -205,7 +205,7 @@ "M.2/M 2230" "SlotDataBusWidth1X" chip soc/intel/common/block/pcie/rtd3 - register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E3)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" register "add_acpi_dma_property" = "true" diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index b0fb7cd..23ca3e5 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -227,7 +227,7 @@ /* D12: ES8336_INT_N */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: CPU M.2 SSD Power Enable */ PAD_CFG_GPO(GPP_D14, 1, PLTRST), /* D15: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index 7c614fa..2ee5c67 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -221,7 +221,7 @@ /* D12: GSPI 2 MOSI FPS */ PAD_NC(GPP_D12, NONE), /* D13: Wireless LAN Wake */ - PAD_CFG_GPO(GPP_D13, 1, PLTRST), + PAD_NC(GPP_D13, NONE), /* D14: ALS Interrupt */ PAD_NC(GPP_D14, NONE), /* D15: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86184?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I12797875acacc231e155ab4e427a950a3b1b9703 Gerrit-Change-Number: 86184 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Configure TPM IRQ for all board with a dTPM
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86182?usp=email ) Change subject: mb/starlabs/*: Configure TPM IRQ for all board with a dTPM ...................................................................... mb/starlabs/*: Configure TPM IRQ for all board with a dTPM Configure the relavant GPIO for APIC. Change-Id: I4f6bc21d32e8436bc91f077fd61da59565d62204 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86182 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/adl_n/gpio.c M src/mainboard/starlabs/starbook/variants/mtl/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starfighter/Kconfig M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c 7 files changed, 15 insertions(+), 5 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index e5ceb08..5ba827c 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -217,6 +217,12 @@ config SOC_INTEL_CSE_SEND_EOP_EARLY default n +config TPM_PIRQ + depends on MAINBOARD_HAS_TPM2 + default 0x56 if BOARD_STARLABS_STARBOOK_TGL + default 0x3d if BOARD_STARLABS_STARBOOK_MTL + default 0x37 + config UART_FOR_CONSOLE default 2 if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML || BOARD_STARLABS_STARBOOK_TGL default 0 diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index f3f26f2..dae0df2 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -261,7 +261,7 @@ /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ - PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E12: Touchpad Interrupt */ PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* E13: Not connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c index 71b64bd..ed759d4 100644 --- a/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl_n/gpio.c @@ -261,7 +261,7 @@ /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ - PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E12: Touchpad Interrupt */ PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* E13: Not connected */ diff --git a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c index 4ae9d69..943998c 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/gpio.c @@ -331,7 +331,7 @@ /* F12: */ PAD_NC(GPP_F12, NONE), /* F13: TPM_IRQ */ - PAD_CFG_NF(GPP_F13, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC_LOW(GPP_F13, NONE, PLTRST), /* F14: */ PAD_NC(GPP_F14, NONE), /* F15: */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 020f0af..4ef11d4 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -261,7 +261,7 @@ /* E10: PWD Amplifier Input */ PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ - PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC_LOW(GPP_E11, NONE, PLTRST), /* E12: Touchpad Interrupt */ PAD_CFG_GPI_APIC_LOW(GPP_E12, NONE, PLTRST), /* E13: Not connected */ diff --git a/src/mainboard/starlabs/starfighter/Kconfig b/src/mainboard/starlabs/starfighter/Kconfig index e9c3b63..fbddb45 100644 --- a/src/mainboard/starlabs/starfighter/Kconfig +++ b/src/mainboard/starlabs/starfighter/Kconfig @@ -117,6 +117,10 @@ config SOC_INTEL_CSE_SEND_EOP_EARLY default n +config TPM_PIRQ + depends on MAINBOARD_HAS_TPM2 + default 0x37 + config UART_FOR_CONSOLE default 0 diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 479f984..b0fb7cd 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -221,7 +221,7 @@ /* D9: PWD_AMP_IN */ PAD_NC(GPP_D9, NONE), /* D10: TPM_IRQ */ - PAD_NC(GPP_D10, NONE), + PAD_CFG_GPI_APIC_LOW(GPP_D10, NONE, PLTRST), /* D11: TCHPAD_INT_N */ PAD_CFG_GPI_APIC_LOW(GPP_D11, NONE, PLTRST), /* D12: ES8336_INT_N */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4f6bc21d32e8436bc91f077fd61da59565d62204 Gerrit-Change-Number: 86182 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starfighter/rpl: Disconnect unused GPIOs
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86181?usp=email ) Change subject: mb/starlabs/starfighter/rpl: Disconnect unused GPIOs ...................................................................... mb/starlabs/starfighter/rpl: Disconnect unused GPIOs These GPIO's are not used, so disconnect them or set the outputs low accordingly. Change-Id: If7eab6e3f6ff94054c0101b794b960626d1df92a Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86181 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c 1 file changed, 20 insertions(+), 19 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index c28592e..479f984 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -36,11 +36,11 @@ /* GPD3: Power Button */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), + PAD_NC(GPD4, NONE), /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), + PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ - PAD_CFG_NF(GPD6, NONE, DEEP, NF1), + PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD8: Suspend Clock */ @@ -48,7 +48,7 @@ /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: Sleep S5 */ - PAD_CFG_NF(GPD10, NONE, DEEP, NF1), + PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), @@ -94,7 +94,6 @@ /* A23: Not Connected */ PAD_NC(GPP_A23, NONE), - /* B0: Core Vendor ID 0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* B1: Core Vendor ID 1 */ @@ -120,7 +119,7 @@ /* B11: I2C PMC PD Interrupt */ PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ - PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), + PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* B14: Not Connected */ @@ -247,7 +246,7 @@ /* E1: Not Connected */ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ - PAD_CFG_GPO(GPP_E2, 1, PLTRST), + PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Retimer Force Power */ @@ -307,18 +306,20 @@ PAD_NC(GPP_F5, NONE), /* F6: Not used */ PAD_NC(GPP_F6, NONE), - /* F7: GPPC_F7 */ - PAD_NC(GPP_F7, NONE), + /* F7: TBT LSX VCCIO Weak Internal PD 20K + Low: 1.8V + High: 3.3V */ + PAD_CFG_GPO(GPP_F7, 0, DEEP), /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: EC Sleep S0 */ - PAD_CFG_GPO(GPP_F9, 1, PLTRST), + PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_F10, 1, PLTRST), + PAD_CFG_GPO(GPP_F10, 0, PLTRST), /* F11: TPM ID */ - PAD_CFG_GPI_TRIG_OWN(GPP_F11, NONE, DEEP, OFF, ACPI), + PAD_NC(GPP_F11, NONE), /* F16: Not Connected */ - PAD_CFG_GPO(GPP_F16, 1, RSMRST), + PAD_NC(GPP_F16, NONE), /* F17: Not used Touch Panel Reset */ PAD_NC(GPP_F17, NONE), /* F18: Not used Touch Panel Interrupt */ @@ -328,16 +329,16 @@ /* F20: CPU M.2 SSD Reset */ PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ - PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), /* F23: Not Connected */ PAD_NC(GPP_F23, NONE), /* H0: PCH M.2 SSD Reset */ -PAD_CFG_GPO(GPP_H0, 1, PLTRST), + PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_H1, 1, PLTRST), + PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ @@ -357,7 +358,7 @@ /* H12: Not Connected */ PAD_NC(GPP_H12, NONE), /* H13: PCH M.2 SSD Device Sleep */ -PAD_CFG_GPO(GPP_H13, 0, PLTRST), + PAD_CFG_GPO(GPP_H13, 0, PLTRST), /* H14: Not Connected */ PAD_NC(GPP_H14, NONE), /* H15: DDPB Control Clock */ @@ -384,9 +385,9 @@ /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), /* S2: DMIC Clock */ - PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), + PAD_NC(GPP_S2, NONE), /* S3: DMIC Data */ - PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), + PAD_NC(GPP_S3, NONE), /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), /* S5: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If7eab6e3f6ff94054c0101b794b960626d1df92a Gerrit-Change-Number: 86181 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/rpl: Disconnect unused GPIOs
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86180?usp=email ) Change subject: mb/starlabs/starbook/rpl: Disconnect unused GPIOs ...................................................................... mb/starlabs/starbook/rpl: Disconnect unused GPIOs These GPIO's are not used, so disconnect them or set the outputs low accordingly. Change-Id: I1fbb43f7081c09848dc80a6ddedfa284a8fcce44 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86180 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/rpl/gpio.c 1 file changed, 13 insertions(+), 14 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 9b7b25c..020f0af 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -27,11 +27,11 @@ /* GPD3: Power Button */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), + PAD_NC(GPD4, NONE), /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), + PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ - PAD_CFG_NF(GPD6, NONE, DEEP, NF1), + PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD8: Suspend Clock */ @@ -39,7 +39,7 @@ /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: Sleep S5 */ - PAD_CFG_NF(GPD10, NONE, DEEP, NF1), + PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), @@ -85,7 +85,6 @@ /* A23: Not Connected */ PAD_NC(GPP_A23, NONE), - /* B0: Core Vendor ID 0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* B1: Core Vendor ID 1 */ @@ -111,13 +110,13 @@ /* B11: I2C PMC PD Interrupt */ PAD_CFG_NF(GPP_B11, NONE, DEEP, NF1), /* B12: PM SLP S0 */ - PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), + PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* B14: Top Swap Override Weak Internal PD 20K High: Enabled Low: Disabled */ - PAD_CFG_GPO(GPP_B14, 0, PLTRST), + PAD_NC(GPP_B14, NONE), /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), /* B16: Not Connected */ @@ -260,7 +259,7 @@ /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: PWD Amplifier Input */ - PAD_CFG_GPO(GPP_E10, 0, PLTRST), + PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), /* E12: Touchpad Interrupt */ @@ -305,13 +304,13 @@ /* F7: TBT LSX VCCIO Weak Internal PD 20K Low: 1.8V High: 3.3V */ - PAD_NC(GPP_F7, NONE), + PAD_CFG_GPO(GPP_F7, 0, DEEP), /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: EC Sleep S0 */ PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_F10, 1, PLTRST), + PAD_CFG_GPO(GPP_F10, 0, PLTRST), /* F11: TPM ID */ PAD_NC(GPP_F11, NONE), /* F12: Not Connected */ @@ -333,7 +332,7 @@ /* F20: CPU M.2 SSD Reset */ PAD_CFG_GPO(GPP_F20, 1, PLTRST), /* F21: GPPC_F21 */ - PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), /* F23: Not Connected */ @@ -342,7 +341,7 @@ /* H0: PCH M.2 SSD Reset */ PAD_NC(GPP_H0, NONE), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_H1, 1, PLTRST), + PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ @@ -389,9 +388,9 @@ /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), /* S2: DMIC Clock */ - PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), + PAD_NC(GPP_S2, NONE), /* S3: DMIC Data */ - PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), + PAD_NC(GPP_S3, NONE), /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), /* S5: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1fbb43f7081c09848dc80a6ddedfa284a8fcce44 Gerrit-Change-Number: 86180 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/adl: Disconnect unused GPIOs
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86178?usp=email ) Change subject: mb/starlabs/starbook/adl: Disconnect unused GPIOs ...................................................................... mb/starlabs/starbook/adl: Disconnect unused GPIOs These GPIO's are not used, so disconnect them or set the outputs low accordingly. Change-Id: I9472e003b730646fea9860d9da960d7f766bdda9 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86178 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl/gpio.c 1 file changed, 18 insertions(+), 19 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index 00a4a08..f3f26f2 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -27,11 +27,11 @@ /* GPD3: Power Button */ PAD_CFG_NF(GPD3, UP_20K, DEEP, NF1), /* GPD4: Sleep S3 */ - PAD_CFG_NF(GPD4, NONE, DEEP, NF1), + PAD_NC(GPD4, NONE), /* GPD5: Sleep S4 */ - PAD_CFG_NF(GPD5, NONE, DEEP, NF1), + PAD_NC(GPD5, NONE), /* GPD6: Sleep A */ - PAD_CFG_NF(GPD6, NONE, DEEP, NF1), + PAD_NC(GPD6, NONE), /* GPD7: Power Adapter Disable */ PAD_CFG_GPO(GPD7, 0, PWROK), /* GPD8: Suspend Clock */ @@ -39,7 +39,7 @@ /* GPD9: Wireless LAN Sleep */ PAD_CFG_NF(GPD9, NONE, DEEP, NF1), /* GPD10: Sleep S5 */ - PAD_CFG_NF(GPD10, NONE, DEEP, NF1), + PAD_NC(GPD10, NONE), /* GPD11: LAN PHY Enable */ PAD_NC(GPD11, NONE), @@ -85,7 +85,6 @@ /* A23: Not Connected */ PAD_NC(GPP_A23, NONE), - /* B0: Core Vendor ID 0 */ PAD_CFG_NF(GPP_B0, NONE, DEEP, NF1), /* B1: Core Vendor ID 1 */ @@ -111,13 +110,13 @@ /* B11: I2C PMC PD Interrupt Test Point 28 */ PAD_NC(GPP_B11, NONE), /* B12: PM SLP S0 */ - PAD_CFG_NF(GPP_B12, NONE, DEEP, NF1), + PAD_NC(GPP_B12, NONE), /* B13: PLT RST */ PAD_CFG_NF(GPP_B13, NONE, DEEP, NF1), /* B14: Top Swap Override Weak Internal PD 20K High: Enabled Low: Disabled */ - PAD_CFG_GPO(GPP_B14, 0, PLTRST), + PAD_NC(GPP_B14, NONE), /* B15: Not Connected */ PAD_NC(GPP_B15, NONE), /* B16: Not Connected */ @@ -242,7 +241,7 @@ /* E1: Not used Accelerometer Interrupt */ PAD_NC(GPP_E1, NONE), /* E2: Not Connected */ - PAD_CFG_GPO(GPP_E2, 1, PLTRST), + PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Test Point 14 */ @@ -260,7 +259,7 @@ /* E9: USB OverCurrent 0 */ PAD_CFG_NF(GPP_E9, NONE, DEEP, NF1), /* E10: PWD Amplifier Input */ - PAD_CFG_GPO(GPP_E10, 0, PLTRST), + PAD_NC(GPP_E10, NONE), /* E11: TPM IRQ */ PAD_CFG_NF(GPP_E11, NONE, DEEP, NF1), /* E12: Touchpad Interrupt */ @@ -274,7 +273,7 @@ /* E16: Not Connected */ PAD_NC(GPP_E16, NONE), /* E17: Not Connected */ - PAD_CFG_GPO(GPP_E17, 1, PLTRST), + PAD_NC(GPP_E17, NONE), /* E18: Not Connected */ PAD_NC(GPP_E18, NONE), /* E19: Thunderbolt LSX RXD */ @@ -305,15 +304,15 @@ /* F7: TBT LSX VCCIO Weak Internal PD 20K Low: 1.8V High: 3.3V */ - PAD_NC(GPP_F7, NONE), + PAD_CFG_GPO(GPP_F7, 0, DEEP), /* F8: Not Connected */ PAD_NC(GPP_F8, NONE), /* F9: EC Sleep S0 */ - PAD_CFG_GPO(GPP_F9, 1, PLTRST), + PAD_NC(GPP_F9, NONE), /* F10: Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_F10, 1, PLTRST), + PAD_CFG_GPO(GPP_F10, 0, PLTRST), /* F11: TPM ID */ - PAD_CFG_GPI_TRIG_OWN(GPP_F11, NONE, DEEP, OFF, ACPI), + PAD_NC(GPP_F11, NONE), /* F12: Not Connected */ PAD_NC(GPP_F12, NONE), /* F13: Not Connected */ @@ -323,7 +322,7 @@ /* F15: Not used Accelerometer Interrupt 2*/ PAD_NC(GPP_F15, NONE), /* F16: Not Connected */ - PAD_CFG_GPO(GPP_F16, 1, RSMRST), + PAD_NC(GPP_F16, NONE), /* F17: Not used Touch Panel Reset */ PAD_NC(GPP_F17, NONE), /* F18: Not used Touch Panel Interrupt */ @@ -333,7 +332,7 @@ /* F20: CPU M.2 SSD Reset */ PAD_NC(GPP_F20, NONE), /* F21: GPPC_F21 */ - PAD_CFG_NF(GPP_F21, NONE, DEEP, NF1), + PAD_NC(GPP_F21, NONE), /* F22: Not Connected */ PAD_NC(GPP_F22, NONE), /* F23: Not Connected */ @@ -342,7 +341,7 @@ /* H0: PCH M.2 SSD Reset */ PAD_CFG_GPO(GPP_H0, 1, PLTRST), /* H1: BFX Strap 2 Bit 3 Weak Internal PD 20K */ - PAD_CFG_GPO(GPP_H1, 1, PLTRST), + PAD_CFG_GPO(GPP_H1, 0, DEEP), /* H2: Wireless LAN Reset */ PAD_CFG_GPO(GPP_H2, 1, PLTRST), /* H3: Not Connected */ @@ -389,9 +388,9 @@ /* S1: Not Connected */ PAD_NC(GPP_S1, NONE), /* S2: DMIC Clock */ - PAD_CFG_NF(GPP_S2, NONE, DEEP, NF2), + PAD_NC(GPP_S2, NONE), /* S3: DMIC Data */ - PAD_CFG_NF(GPP_S3, NONE, DEEP, NF2), + PAD_NC(GPP_S3, NONE), /* S4: Not Connected */ PAD_NC(GPP_S4, NONE), /* S5: Not Connected */ -- To view, visit https://review.coreboot.org/c/coreboot/+/86178?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9472e003b730646fea9860d9da960d7f766bdda9 Gerrit-Change-Number: 86178 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Fallback to the GNA being disabled
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86176?usp=email ) Change subject: mb/starlabs/starbook/mtl: Fallback to the GNA being disabled ...................................................................... mb/starlabs/starbook/mtl: Fallback to the GNA being disabled Most users leave the GNA disabled, so adjust the fallback to match this. Change-Id: I7779781266a63c8c9f779d25ff2c692bb498c594 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86176 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/mtl/devtree.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/mtl/devtree.c b/src/mainboard/starlabs/starbook/variants/mtl/devtree.c index a97ff8a..a894479 100644 --- a/src/mainboard/starlabs/starbook/variants/mtl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/mtl/devtree.c @@ -61,6 +61,6 @@ cfg->usb2_ports[3].enable = 0; /* Enable/Disable GNA based on CMOS settings */ - if (get_uint_option("gna", 1) == 0) + if (get_uint_option("gna", 0) == 0) gna_dev->enabled = 0; } -- To view, visit https://review.coreboot.org/c/coreboot/+/86176?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7779781266a63c8c9f779d25ff2c692bb498c594 Gerrit-Change-Number: 86176 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook: Remove unused header from DSDT
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86175?usp=email ) Change subject: mb/starlabs/starbook: Remove unused header from DSDT ...................................................................... mb/starlabs/starbook: Remove unused header from DSDT Change-Id: I2a0c0652c8584fc492222f9a845f723630f9855e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86175 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/dsdt.asl 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/dsdt.asl b/src/mainboard/starlabs/starbook/dsdt.asl index 169731c..a1e4115 100644 --- a/src/mainboard/starlabs/starbook/dsdt.asl +++ b/src/mainboard/starlabs/starbook/dsdt.asl @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <acpi/acpi.h> -#include <soc/gpio.h> DefinitionBlock( "dsdt.aml", -- To view, visit https://review.coreboot.org/c/coreboot/+/86175?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2a0c0652c8584fc492222f9a845f723630f9855e Gerrit-Change-Number: 86175 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025