coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[XS] Change in coreboot[main]: mb/google/fatcat/var/fatcat: disable ISH UART0 RX pin
by Kapil Porwal (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Bora Guvendik, Jérémy Compostella, Li1 Feng, Paul Menzel, Pranava Y N. Kapil Porwal has posted comments on this change by Li1 Feng. ( https://review.coreboot.org/c/coreboot/+/86005?usp=email ) Change subject: mb/google/fatcat/var/fatcat: disable ISH UART0 RX pin ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86005?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic84f8ead6a1fd056e649edbb1471bcb913a0a09a Gerrit-Change-Number: 86005 Gerrit-PatchSet: 5 Gerrit-Owner: Li1 Feng <li1.feng(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Li1 Feng <li1.feng(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 14:00:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Don't set ccc_config to 0
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86208?usp=email ) Change subject: mb/starlabs/starlite_adl: Don't set ccc_config to 0 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86208?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4b20ae41aef55c89b4fd95707564d246bf9b38fc Gerrit-Change-Number: 86208 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:47:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starfighter/rpl: Don't set ccc_config to 0
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86210?usp=email ) Change subject: mb/starlabs/starfighter/rpl: Don't set ccc_config to 0 ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86210?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I38f14b216c4cfd277890e6b06904ac53d8fb31f4 Gerrit-Change-Number: 86210 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:47:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Correct HDA Subsystem ID
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86212?usp=email ) Change subject: mb/starlabs/starbook/mtl: Correct HDA Subsystem ID ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I400d8a4f8472359e5213a1ce9d51a69cde051098 Gerrit-Change-Number: 86212 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: soc/intel/cmn/cnvi: Add RTD3 support for CNVi
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Intel coreboot Reviewers, Sean Rhodes. Hello Intel coreboot Reviewers, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86197?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: soc/intel/cmn/cnvi: Add RTD3 support for CNVi ...................................................................... soc/intel/cmn/cnvi: Add RTD3 support for CNVi Change-Id: Ia951d7951effd6a63f2dcb5e004c17dacb2fe010 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/soc/intel/common/block/cnvi/cnvi.c M src/soc/intel/common/block/include/intelblocks/cnvi.h 2 files changed, 57 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/86197/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/86197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia951d7951effd6a63f2dcb5e004c17dacb2fe010 Gerrit-Change-Number: 86197 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com>

1 0

[S] Change in coreboot[main]: soc/intel/common/block/cse: Add API to match current PM event
by Kapil Porwal (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Intel coreboot Reviewers, Jérémy Compostella, Karthik Ramasubramanian, Krishna P Bhat D, Sowmya Aralguppe. Kapil Porwal has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86169?usp=email ) Change subject: soc/intel/common/block/cse: Add API to match current PM event ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86169?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie9a49382ee2c1a8f59da6233e510cf2e38ac32ad Gerrit-Change-Number: 86169 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sowmya Aralguppe <sowmya.aralguppe(a)intel.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: payloads/external/Makefile.mk: Update linuxboot warning
by Elyes Haouas (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Martin L Roth, Maximilian Brune. Elyes Haouas has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85957?usp=email ) Change subject: payloads/external/Makefile.mk: Update linuxboot warning ...................................................................... Patch Set 1: (1 comment) File payloads/external/Makefile.mk: https://review.coreboot.org/c/coreboot/+/85957/comment/0687fd47_ea40b140?us… : PS1, Line 393: ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE),y) : ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH),"") : # use coreboots cross toolchain : CONFIG_LINUXBOOT_CROSS_COMPILE_PATH=$(CROSS_COMPILE_$(LINUXBOOT_CROSS_COMPILE_ARCH-y)) : endif # CONFIG_LINUXBOOT_CROSS_COMPILE_PATH : else # CONFIG_LINUXBOOT_CROSS_COMPILE : ifeq ($(CONFIG_PAYLOAD_LINUXBOOT),y) : # only print warning when Linuxboot payload is actually selected : $(warning "Using host toolchain to build Linuxboot") : endif # CONFIG_PAYLOAD_LINUXBOOT : endif # CONFIG_LINUXBOOT_CROSS_COMPILE I'm not sure, but about this: ```suggestion ifeq ($(CONFIG_LINUXBOOT_CROSS_COMPILE),y) ifeq ($(strip $(CONFIG_LINUXBOOT_CROSS_COMPILE_PATH)),) # No custom toolchain specified, use the coreboot cross toolchain CONFIG_LINUXBOOT_CROSS_COMPILE_PATH := $(CROSS_COMPILE_$(LINUXBOOT_CROSS_COMPILE_ARCH)) endif else ifeq ($(CONFIG_PAYLOAD_LINUXBOOT),y) # Print a warning that we are using the host toolchain $(warning "Using host toolchain to build LinuxBoot") endif endif ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5008d685c52c1d4e0d7eba44c964c51a2a6f99c3 Gerrit-Change-Number: 85957 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:37:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/intel/alderlake/romstage: Update UFS disable sequence
by Kapil Porwal (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Jérémy Compostella, Karthik Ramasubramanian, Nick Vaccaro. Kapil Porwal has posted comments on this change by Karthik Ramasubramanian. ( https://review.coreboot.org/c/coreboot/+/86170?usp=email ) Change subject: soc/intel/alderlake/romstage: Update UFS disable sequence ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I85cad1a1eb00a2a7f520a57cda789ad6737fcb97 Gerrit-Change-Number: 86170 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:37:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/intel/cmn/cnvi: Add RTD3 support for CNVi
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86197?usp=email ) Change subject: soc/intel/cmn/cnvi: Add RTD3 support for CNVi ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86197?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia951d7951effd6a63f2dcb5e004c17dacb2fe010 Gerrit-Change-Number: 86197 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/*: Correct/set UserBd in romstage
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86206?usp=email ) Change subject: mb/starlabs/*: Correct/set UserBd in romstage ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86206?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id0c21cc30a0cfc1dccc3f9863e8f3d522afdf31a Gerrit-Change-Number: 86206 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:11:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025