coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Unselect unused Kconfig values
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86203?usp=email ) Change subject: mb/starlabs/starbook/mtl: Unselect unused Kconfig values ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86203?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id13bb7fc1f9a8f00c10effeaf4b8e1970a173e36 Gerrit-Change-Number: 86203 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:11:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/mtl: Correct alignment in devicetree
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86204?usp=email ) Change subject: mb/starlabs/starbook/mtl: Correct alignment in devicetree ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86204?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3017b4a79f044a7312520469fa185c355f3970c0 Gerrit-Change-Number: 86204 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:11:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Correct configuration of GPIOs used in ACPI
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/86205?usp=email ) Change subject: mb/starlabs/*: Correct configuration of GPIOs used in ACPI ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/86205?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I31b49beeb932d9b59b094dcfe182cfc4d91c2562 Gerrit-Change-Number: 86205 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Wed, 29 Jan 2025 13:11:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: drivers/mrc_cache: Measure MRC cache as runtime data
by Ivan Kuzneczov (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Arthur Heymans, Christian Walter, Julius Werner, Paul Menzel. Ivan Kuzneczov has posted comments on this change by Ivan Kuzneczov. ( https://review.coreboot.org/c/coreboot/+/85605?usp=email ) Change subject: drivers/mrc_cache: Measure MRC cache as runtime data ...................................................................... Patch Set 6: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85605/comment/1b8ff41d_42f0911d?us… : PS5, Line 10: restore > Which commit changed it? Added. https://review.coreboot.org/c/coreboot/+/85605/comment/34324de8_53837d50?us… : PS5, Line 16: https://badram.eu/ )will > Space after ). Done File src/security/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/85605/comment/09403620_aed5cd3b?us… : PS5, Line 87: Measures MRC cache as runtime data > Maybe elaborate for users, why this is useful? Added. -- To view, visit https://review.coreboot.org/c/coreboot/+/85605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d82642c24de1b317851d0afd44985195e92c104 Gerrit-Change-Number: 85605 Gerrit-PatchSet: 6 Gerrit-Owner: Ivan Kuzneczov <ivan.kuzneczov(a)hardenedvault.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 29 Jan 2025 12:58:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: drivers/mrc_cache: Measure MRC cache as runtime data
by Ivan Kuzneczov (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Arthur Heymans, Christian Walter, Ivan Kuzneczov, Julius Werner. Hello Arthur Heymans, Christian Walter, Julius Werner, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85605?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: drivers/mrc_cache: Measure MRC cache as runtime data ...................................................................... drivers/mrc_cache: Measure MRC cache as runtime data MRC cache used to be measured as runtime data when it was resided in CBFS before commit 82aa8338c74 ("drivers/mrc_cache: Always generate an FMAP region"). This patch will restore this behavior for MRC cache stored in FMAP region outside of CBFS. Now, MRC cache will be measured at the end of mrc_cache_load_current(), mrc_cache_current_mmap_leak() and update_mrc_cache_by_type(), to guarantee that a tamper with the memory (like https://badram.eu/ ) will be detected, controlled by Kconfig option TPM_MEASURE_MRC_CACHE. TEST=Empty MRC cache is not measured. Changing DIMM causes both the old cache and new cache being measured, and so the runtime data measurement, which could be used as an alarm for memory tampering. Starting from the second boot after changing DIMM, the runtime data measurement becomes stable. Signed-off-by: Ivan Kuzneczov <ivan.kuzneczov(a)hardenedvault.net> Change-Id: I0d82642c24de1b317851d0afd44985195e92c104 --- M src/drivers/mrc_cache/mrc_cache.c M src/security/tpm/Kconfig 2 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/85605/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85605?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0d82642c24de1b317851d0afd44985195e92c104 Gerrit-Change-Number: 85605 Gerrit-PatchSet: 6 Gerrit-Owner: Ivan Kuzneczov <ivan.kuzneczov(a)hardenedvault.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ivan Kuzneczov <ivan.kuzneczov(a)hardenedvault.net>

1 0

[XS] Change in coreboot[main]: payloads/external/Makefile.mk: Update linuxboot warning
by Ana Carolina Cabral (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Martin L Roth, Maximilian Brune. Ana Carolina Cabral has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/85957?usp=email ) Change subject: payloads/external/Makefile.mk: Update linuxboot warning ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85957?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5008d685c52c1d4e0d7eba44c964c51a2a6f99c3 Gerrit-Change-Number: 85957 Gerrit-PatchSet: 1 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Ana Carolina Cabral <ana.cpmelo95(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 12:47:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: payloads/external/iPXE: introduce support for named configurations
by Filip Lewiński (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Felix Singer, Krystian Hebel, Martin L Roth, Michał Kopeć. Filip Lewiński has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82041?usp=email ) Change subject: payloads/external/iPXE: introduce support for named configurations ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82041/comment/2478b198_07f04438?us… : PS2, Line 9: general.h > I like the idea 👍 @krystian.hebel@3mdeb.com @service+coreboot-gerrit@felixsinger.de I've rewritten the patch to allow utilizing named configs as per iPXE docs. Please let me know what you think of this implementation. -- To view, visit https://review.coreboot.org/c/coreboot/+/82041?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf7c2d9e4407035bfdf0115f4628f23b38272656 Gerrit-Change-Number: 82041 Gerrit-PatchSet: 7 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 12:18:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: payloads/external/iPXE: introduce support for named configurations
by Filip Lewiński (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Filip Lewiński, Krystian Hebel, Martin L Roth, Michał Kopeć. Hello Krystian Hebel, Martin L Roth, Michał Kopeć, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82041?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: payloads/external/iPXE: introduce support for named configurations ...................................................................... payloads/external/iPXE: introduce support for named configurations This commit adds support for iPXE's named configuration mechanism, allowing for optional customization of configuration headers without modifying iPXE source files directly. Named configurations align with iPXE's documented practices and provide a structured way to apply customizations, while keeping the source tree clean. - A new `payloads/external/iPXE/named-configs` directory was introduced to hold named configuration files (e.g., `general.h`, `console.h`, `serial.h`) for specific use cases. - The `Makefile` was updated to: - Copy named configuration files into `src/config/local/<name>` within the iPXE build directory during the build process, if a named configuration is explicitly enabled via `CONFIG_IPXE_NAMED_CONFIG`. - Retain the existing `sed`-based modifications to configuration files for legacy and default workflows. - A new Kconfig option (`CONFIG_IPXE_NAMED_CONFIG`) was added to allow users to specify a named configuration. If unset, the named configuration logic is skipped entirely, ensuring no impact on existing builds. The previous workflow relied entirely on `sed` commands to modify iPXE header files during the build. While this approach works, it directly modifies the source tree, which: - Can complicate branch switching or repository updates. - Does not utilize iPXE's native named configuration mechanism, which provides a cleaner and more maintainable way to handle customizations. Named configurations offer an alternative that avoids directly altering iPXE's source files. This is particularly useful for maintaining reproducible and isolated builds. While the existing `sed` logic is preserved, named configurations could potentially replace it in the future. - No changes were made to the default workflow. Builds that do not specify `CONFIG_IPXE_NAMED_CONFIG` continue to rely on the existing `sed` logic. - The named configuration mechanism is entirely optional and will only apply if explicitly enabled by setting `CONFIG_IPXE_NAMED_CONFIG` in the platform's defconfig. To use a named configuration: 1. Create a directory under `payloads/external/iPXE/named-configs/<name>` with custom header files (e.g., `general.h`, `console.h`). 2. Set `CONFIG_IPXE_NAMED_CONFIG="<name>"` in the platform's defconfig. 3. Build as usual. If no named configuration is specified, the build process remains unchanged. Change-Id: Ibf7c2d9e4407035bfdf0115f4628f23b38272656 Signed-off-by: Filip Lewiński <filip.lewinski(a)3mdeb.com> --- M payloads/external/Makefile.mk M payloads/external/iPXE/Kconfig M payloads/external/iPXE/Makefile A payloads/external/iPXE/named-configs/.gitkeep 4 files changed, 36 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/82041/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/82041?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibf7c2d9e4407035bfdf0115f4628f23b38272656 Gerrit-Change-Number: 82041 Gerrit-PatchSet: 7 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: tree: Use true, false for DspEnable
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Elyes Haouas, Jonathon Hall, Michał Żygowski, Piotr Król. Sean Rhodes has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86189?usp=email ) Change subject: tree: Use true, false for DspEnable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86189?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5bab9db3632848f92732160bb821dda8cdb14281 Gerrit-Change-Number: 86189 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 11:48:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: tree: Use true false for PcieRpEnable[]
by Sean Rhodes (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Angel Pons, Christian Walter, Elyes Haouas, Frans Hendriks, Jeremy Soller, Jonathon Hall, Maxim Polyakov, Michael Niewöhner, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Subrata Banik, Tim Crawford. Sean Rhodes has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86192?usp=email ) Change subject: tree: Use true false for PcieRpEnable[] ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86192?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8e67a33f82b7dfa1864016ccd5cd1b7ec119c528 Gerrit-Change-Number: 86192 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com> Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 29 Jan 2025 11:48:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025