coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: mb/google/fatcat: Select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
by Jayvik Desai (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Jayvik Desai, Pranava Y N. Hello Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85920?usp=email to look at the new patch set (#4). Change subject: mb/google/fatcat: Select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ...................................................................... mb/google/fatcat: Select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image. BUG=b:370984186 TEST=Build and boot google/fatcat, config exists in coreboot.config Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/85920/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85920?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Gerrit-Change-Number: 85920 Gerrit-PatchSet: 4 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
by Subrata Banik (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Jayvik Desai, Pranava Y N. Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email ) Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85920/comment/45a2fe60_49151459?us… : PS3, Line 7: select Select ? https://review.coreboot.org/c/coreboot/+/85920/comment/c0f7f190_fe7bdaad?us… : PS3, Line 9: This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image. looks to me a wrap up test ? should limit the commit msg < 72 char per line -- To view, visit https://review.coreboot.org/c/coreboot/+/85920?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Gerrit-Change-Number: 85920 Gerrit-PatchSet: 3 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 17:34:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
by Jayvik Desai (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Pranava Y N, Subrata Banik. Jayvik Desai has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email ) Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85920/comment/93ac6071_81c7de6b?us… : PS2, Line 9: since > Isn't "since" the first word in this sentence? should be `Since` ? […] Acknowledged https://review.coreboot.org/c/coreboot/+/85920/comment/7cb1db9e_0c0a5066?us… : PS2, Line 12: none > please use ISH enablement bug id ? Acknowledged https://review.coreboot.org/c/coreboot/+/85920/comment/89d575f6_e685bf59?us… : PS2, Line 13: =b > Build ? Acknowledged https://review.coreboot.org/c/coreboot/+/85920/comment/4ed47923_1a628dbc?us… : PS2, Line 13: fatcat > google/fatcat Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85920?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Gerrit-Change-Number: 85920 Gerrit-PatchSet: 3 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 17:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
by Jayvik Desai (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Jayvik Desai, Pranava Y N. Hello Pranava Y N, Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85920?usp=email to look at the new patch set (#3). Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ...................................................................... mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image. BUG=b:370984186 TEST=Build and boot google/fatcat, config exists in coreboot.config Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/85920/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85920?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Gerrit-Change-Number: 85920 Gerrit-PatchSet: 3 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8186/rtc: Remove unused variable "sw"
by Yu-Ping Wu (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85921?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/mt8186/rtc: Remove unused variable "sw" ...................................................................... soc/mediatek/mt8186/rtc: Remove unused variable "sw" The function rtc_get_frequency_meter() already uses the wait_us() macro, so the stopwatch variable "sw" is not needed. Change-Id: I7e282b6ce881f4e8f9d5e1c92803fda363fe28d7 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- M src/soc/mediatek/mt8186/rtc.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/85921/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e282b6ce881f4e8f9d5e1c92803fda363fe28d7 Gerrit-Change-Number: 85921 Gerrit-PatchSet: 2 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8186/rtc: Remove unused variable "sw"
by Yu-Ping Wu (Code Review) 09 Jan '25

09 Jan '25

Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85921?usp=email ) Change subject: soc/mediatek/mt8186/rtc: Remove unused variable "sw" ...................................................................... soc/mediatek/mt8186/rtc: Remove unused variable "sw" The function rtc_get_frequency_meter() already uses the wait_us() macro, so the stopwatch variable "sw" is not needed. Change-Id: I7e282b6ce881f4e8f9d5e1c92803fda363fe28d7 Signed-off-by: Yu-Ping Wu <yupingso(a)chromium.org> --- A .tmpconfig.lintOWrINL M src/soc/mediatek/mt8186/rtc.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/85921/1 diff --git a/.tmpconfig.lintOWrINL b/.tmpconfig.lintOWrINL new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/.tmpconfig.lintOWrINL diff --git a/src/soc/mediatek/mt8186/rtc.c b/src/soc/mediatek/mt8186/rtc.c index 056c65c..7bf5bc8 100644 --- a/src/soc/mediatek/mt8186/rtc.c +++ b/src/soc/mediatek/mt8186/rtc.c @@ -77,7 +77,6 @@ { u16 bbpu, osc32con; u16 fqmtr_busy, fqmtr_data, fqmtr_rst, fqmtr_tcksel; - struct stopwatch sw; rtc_read(RTC_BBPU, &bbpu); rtc_write(RTC_BBPU, bbpu | RTC_BBPU_KEY | RTC_BBPU_RELOAD); @@ -120,7 +119,6 @@ rtc_write(PMIC_RG_FQMTR_CON0, fqmtr_tcksel | PMIC_FQMTR_CON0_FQMTR_EN); udelay(100); - stopwatch_init_usecs_expire(&sw, FQMTR_TIMEOUT_US); /* FQMTR read until ready */ if (!wait_us(FQMTR_TIMEOUT_US, rtc_read(PMIC_RG_FQMTR_CON0, &fqmtr_busy) == 0 && -- To view, visit https://review.coreboot.org/c/coreboot/+/85921?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e282b6ce881f4e8f9d5e1c92803fda363fe28d7 Gerrit-Change-Number: 85921 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: Makefile: Fix indentation in help_coreboot
by Christian Walter (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Andy Ebrahiem, Martin L Roth. Christian Walter has posted comments on this change by Andy Ebrahiem. ( https://review.coreboot.org/c/coreboot/+/85895?usp=email ) Change subject: Makefile: Fix indentation in help_coreboot ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85895?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I51b052e4d9d358e92c8105cc23997d6d35bc4d8d Gerrit-Change-Number: 85895 Gerrit-PatchSet: 2 Gerrit-Owner: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andy Ebrahiem <ahmet.ebrahiem(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:58:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/starlabs/starbook: Add AlderLake-N variant
by Matt DeVillier (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email ) Change subject: mb/starlabs/starbook: Add AlderLake-N variant ...................................................................... Patch Set 10: (1 comment) File src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85714/comment/62b12548_0037e518?us… : PS10, Line 203: 1 > true? yeah it's a bool -- To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Gerrit-Change-Number: 85714 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:37:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XL] Change in coreboot[main]: mb/starlabs/starbook: Add AlderLake-N variant
by Sean Rhodes (Code Review) 09 Jan '25

09 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email ) Change subject: mb/starlabs/starbook: Add AlderLake-N variant ...................................................................... Patch Set 10: (1 comment) File src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85714/comment/571a5686_60ac0b37?us… : PS10, Line 203: 1 true? -- To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Gerrit-Change-Number: 85714 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:35:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: mb/starlabs/starbook: Add AlderLake-N variant
by Matt DeVillier (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email ) Change subject: mb/starlabs/starbook: Add AlderLake-N variant ...................................................................... Patch Set 10: Code-Review+1 (3 comments) File src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85714/comment/f4f3f987_97333bd6?us… : PS10, Line 4: 1 true https://review.coreboot.org/c/coreboot/+/85714/comment/e2a72b81_a17bf591?us… : PS10, Line 179: 1 true https://review.coreboot.org/c/coreboot/+/85714/comment/385fe17c_080cd3e4?us… : PS10, Line 205: 1 true -- To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Gerrit-Change-Number: 85714 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:34:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025