coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[S] Change in coreboot[main]: Documentation: Fix wrong link to commit message guidelines
by Werner Zeh (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Martin L Roth. Werner Zeh has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email ) Change subject: Documentation: Fix wrong link to commit message guidelines ...................................................................... Patch Set 1: (1 comment) File Documentation/contributing/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/85915/comment/c407b71c_20ccd6bc?us… : PS1, Line 442: The first line of the commit message consists of a short : (less than 65 characters, absolute maximum is 75) summary > I realize this is just ported over, but I think we may want to update/clarify it in a follow-on patc […] Yes, this is what I realized, too. I can start a discussion on the mailing list and get peoples suggestions here. -- To view, visit https://review.coreboot.org/c/coreboot/+/85915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544 Gerrit-Change-Number: 85915 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:25:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[S] Change in coreboot[main]: Documentation: Fix wrong link to commit message guidelines
by Matt DeVillier (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Martin L Roth, Werner Zeh. Matt DeVillier has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email ) Change subject: Documentation: Fix wrong link to commit message guidelines ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: looks great, thanks for fixing. File Documentation/contributing/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/85915/comment/53834aaa_1d58087d?us… : PS1, Line 442: The first line of the commit message consists of a short : (less than 65 characters, absolute maximum is 75) summary I realize this is just ported over, but I think we may want to update/clarify it in a follow-on patch. Typically we start the commit subject with the path (sometimes abbreviated) and component being modified. This makes the 75/65 char limit nearly impossible to stay under and give a useful message. A quick scan of the last ~100 commit msgs shows quite a few over 80 char. -- To view, visit https://review.coreboot.org/c/coreboot/+/85915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544 Gerrit-Change-Number: 85915 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:17:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
by Subrata Banik (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Jayvik Desai, Pranava Y N. Subrata Banik has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email ) Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85920/comment/36524821_27c9b4e7?us… : PS2, Line 9: since Isn't "since" the first word in this sentence? should be `Since` ? ideally we don't use statements starting with since. ```This patch selects the ISH main firmware Kconfig to prevent google/fatcat from trying to retrieve a dummy ISH SHIM firmware version, since ISH FW in google/fatcat will be part of the kernel firmware image.``` https://review.coreboot.org/c/coreboot/+/85920/comment/f468d096_61427bf9?us… : PS2, Line 12: none please use ISH enablement bug id ? https://review.coreboot.org/c/coreboot/+/85920/comment/b10caa35_4c165492?us… : PS2, Line 13: fatcat google/fatcat https://review.coreboot.org/c/coreboot/+/85920/comment/9057422c_c75ca7f3?us… : PS2, Line 13: =b Build ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85920?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Gerrit-Change-Number: 85920 Gerrit-PatchSet: 2 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 14:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: drivers/amd/opensil: Add openSIL timepoint calls
by Felix Held (Code Review) 09 Jan '25

09 Jan '25

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85631?usp=email ) Change subject: drivers/amd/opensil: Add openSIL timepoint calls ...................................................................... drivers/amd/opensil: Add openSIL timepoint calls Place openSIL timepoints 1, 2 and 3 calls in the driver, which will serve as the central point for invoking SoC-specific vendorcode implementations. TP1 and TP2 will initialize silicon pre- and post-PCIe enumeration, respectively. TP3 then performs late SoC IPs programming and register locking closer to payload load prior to OS handoff. Add a Kconfig option for selecting and including the openSIL driver source code in the build. Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da Signed-off-by: Nicolas Kochlowski <nickkochlowski(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85631 Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- A src/drivers/amd/opensil/Kconfig A src/drivers/amd/opensil/Makefile.mk A src/drivers/amd/opensil/opensil.h A src/drivers/amd/opensil/ramstage.c M src/soc/amd/genoa_poc/Kconfig M src/soc/amd/genoa_poc/chip.c M src/soc/amd/phoenix/Kconfig M src/soc/amd/phoenix/chip.c 8 files changed, 55 insertions(+), 8 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/drivers/amd/opensil/Kconfig b/src/drivers/amd/opensil/Kconfig new file mode 100644 index 0000000..b3dfb8e --- /dev/null +++ b/src/drivers/amd/opensil/Kconfig @@ -0,0 +1,6 @@ +# SPDX-License-Identifier: GPL-2.0-only + +config OPENSIL_DRIVER + bool + help + Indicate that the openSIL driver is being used on the platform. diff --git a/src/drivers/amd/opensil/Makefile.mk b/src/drivers/amd/opensil/Makefile.mk new file mode 100644 index 0000000..4b4e07e --- /dev/null +++ b/src/drivers/amd/opensil/Makefile.mk @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-only + +ifeq ($(CONFIG_OPENSIL_DRIVER),y) + +ramstage-y += ramstage.c + +endif diff --git a/src/drivers/amd/opensil/opensil.h b/src/drivers/amd/opensil/opensil.h new file mode 100644 index 0000000..a82d2d1 --- /dev/null +++ b/src/drivers/amd/opensil/opensil.h @@ -0,0 +1,9 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#ifndef OPENSIL_DRIVER_H +#define OPENSIL_DRIVER_H + +/* Set up openSIL env and call TP1 */ +void amd_opensil_silicon_init(void); + +#endif /* OPENSIL_DRIVER_H */ diff --git a/src/drivers/amd/opensil/ramstage.c b/src/drivers/amd/opensil/ramstage.c new file mode 100644 index 0000000..c7e0e06 --- /dev/null +++ b/src/drivers/amd/opensil/ramstage.c @@ -0,0 +1,26 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <bootstate.h> +#include <vendorcode/amd/opensil/opensil.h> + +#include "opensil.h" + +void amd_opensil_silicon_init(void) +{ + setup_opensil(); + opensil_xSIM_timepoint_1(); +} + +static void call_opensil_xSIM_timepoint_2(void *arg) +{ + opensil_xSIM_timepoint_2(); +} + +static void call_opensil_xSIM_timepoint_3(void *arg) +{ + opensil_xSIM_timepoint_3(); +} + +BOOT_STATE_INIT_ENTRY(BS_DEV_RESOURCES, BS_ON_EXIT, call_opensil_xSIM_timepoint_2, NULL); +BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_EXIT, call_opensil_xSIM_timepoint_3, NULL); +BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, call_opensil_xSIM_timepoint_3, NULL); diff --git a/src/soc/amd/genoa_poc/Kconfig b/src/soc/amd/genoa_poc/Kconfig index f4bd7d6..25dd914 100644 --- a/src/soc/amd/genoa_poc/Kconfig +++ b/src/soc/amd/genoa_poc/Kconfig @@ -48,6 +48,7 @@ select SOC_AMD_COMMON_BLOCK_USE_ESPI select SOC_AMD_OPENSIL select SOC_AMD_OPENSIL_GENOA_POC + select OPENSIL_DRIVER select X86_CUSTOM_BOOTMEDIA config USE_X86_64_SUPPORT diff --git a/src/soc/amd/genoa_poc/chip.c b/src/soc/amd/genoa_poc/chip.c index 75f5bcc..98a995f 100644 --- a/src/soc/amd/genoa_poc/chip.c +++ b/src/soc/amd/genoa_poc/chip.c @@ -3,16 +3,15 @@ #include <amdblocks/acpi.h> #include <amdblocks/data_fabric.h> #include <device/device.h> +#include <drivers/amd/opensil/opensil.h> #include <soc/southbridge.h> #include <soc/southbridge.h> -#include <vendorcode/amd/opensil/opensil.h> static void soc_init(void *chip_info) { default_dev_ops_root.write_acpi_tables = soc_acpi_write_tables; - setup_opensil(); - opensil_xSIM_timepoint_1(); + amd_opensil_silicon_init(); data_fabric_print_mmio_conf(); diff --git a/src/soc/amd/phoenix/Kconfig b/src/soc/amd/phoenix/Kconfig index 718db8f..b15c12d 100644 --- a/src/soc/amd/phoenix/Kconfig +++ b/src/soc/amd/phoenix/Kconfig @@ -104,6 +104,7 @@ bool select SOC_AMD_PHOENIX_BASE select SOC_AMD_OPENSIL + select OPENSIL_DRIVER if SOC_AMD_PHOENIX_BASE diff --git a/src/soc/amd/phoenix/chip.c b/src/soc/amd/phoenix/chip.c index 68bc408..89de85c 100644 --- a/src/soc/amd/phoenix/chip.c +++ b/src/soc/amd/phoenix/chip.c @@ -1,7 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* TODO: Update for Phoenix */ - #include <acpi/acpigen_pci.h> #include <amdblocks/acpi.h> #include <amdblocks/data_fabric.h> @@ -10,11 +8,12 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> +#include <drivers/amd/opensil/opensil.h> #include <soc/cpu.h> #include <soc/pci_devs.h> #include <soc/southbridge.h> #include <types.h> -#include <vendorcode/amd/opensil/opensil.h> + #include "chip.h" static const char *soc_acpi_name(const struct device *dev) @@ -46,8 +45,7 @@ if (CONFIG(PLATFORM_USES_FSP2_0)) { amd_fsp_silicon_init(); } else { - setup_opensil(); - opensil_xSIM_timepoint_1(); + amd_opensil_silicon_init(); } data_fabric_print_mmio_conf(); -- To view, visit https://review.coreboot.org/c/coreboot/+/85631?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0559fc0ff0ec55e9ef131e5ed20dfb5baa651da Gerrit-Change-Number: 85631 Gerrit-PatchSet: 9 Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Felix Held (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Naresh Solanki. Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) Change subject: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/glinda/Kconfig: https://review.coreboot.org/c/coreboot/+/85627/comment/d52c37a1_f2c59441?us… : PS1, Line 385: default 0x10970 please add an empty line between this option and the endmenu after it -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 14:40:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: payloads/iPXE: Add an option for reproducible building
by Filip Lewiński (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Krystian Hebel, Martin L Roth, Michał Kopeć, Michał Żygowski, Paul Menzel. Filip Lewiński has posted comments on this change by Filip Lewiński. ( https://review.coreboot.org/c/coreboot/+/82039?usp=email ) Change subject: payloads/iPXE: Add an option for reproducible building ...................................................................... Patch Set 14: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/82039/comment/e3eeec6e_d75300bc?us… : PS9, Line 10: Useful for reproducibility. > "Necessary for build reproducibility" […] [Done](https://review.coreboot.org/c/coreboot/+/82039/9..10) -- To view, visit https://review.coreboot.org/c/coreboot/+/82039?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I926b096e77a9d45ba2beecd1fc2b7d0a9b9a7b9c Gerrit-Change-Number: 82039 Gerrit-PatchSet: 14 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Comment-Date: Thu, 09 Jan 2025 14:40:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>

1 0

[S] Change in coreboot[main]: payloads/iPXE: Add an option for reproducible building
by Filip Lewiński (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Filip Lewiński, Krystian Hebel, Martin L Roth, Michał Kopeć, Paul Menzel. Hello Krystian Hebel, Martin L Roth, Michał Kopeć, Michał Żygowski, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82039?usp=email to look at the new patch set (#14). The following approvals got outdated and were removed: Code-Review+1 by Paul Menzel, Verified-1 by build bot (Jenkins) Change subject: payloads/iPXE: Add an option for reproducible building ...................................................................... payloads/iPXE: Add an option for reproducible building Allows to set a custom 32 bit hex build_id option for an iPXE build. Necessary for build reproducibility. Change-Id: I926b096e77a9d45ba2beecd1fc2b7d0a9b9a7b9c Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> --- M payloads/external/Makefile.mk M payloads/external/iPXE/Kconfig M payloads/external/iPXE/Makefile 3 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/82039/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/82039?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I926b096e77a9d45ba2beecd1fc2b7d0a9b9a7b9c Gerrit-Change-Number: 82039 Gerrit-PatchSet: 14 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[L] Change in coreboot[main]: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c
by Yidi Lin (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85861?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/common/dp/dptx_hal.c: https://review.coreboot.org/c/coreboot/+/85861/comment/dbcf701f_ba263c31?us… : PS3, Line 79: vsync Check with MTK, `dptx_hal_set_msa` can be shared with MT8196. The differences on MT8196 are wrong settings. We also found that the setting here is not correct. It should be `hsync` instead of vsync. I will find a Ciri to verify the settings. -- To view, visit https://review.coreboot.org/c/coreboot/+/85861?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9e151bc766c312eaf81b4220782775ef1c9d2297 Gerrit-Change-Number: 85861 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 09 Jan 2025 14:21:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: payloads/iPXE: Add an option for reproducible building
by Filip Lewiński (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Filip Lewiński, Krystian Hebel, Martin L Roth, Michał Kopeć. Hello Krystian Hebel, Martin L Roth, Michał Kopeć, Michał Żygowski, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/82039?usp=email to look at the new patch set (#10). Change subject: payloads/iPXE: Add an option for reproducible building ...................................................................... payloads/iPXE: Add an option for reproducible building Allows to set a custom 32 bit hex build_id option for an iPXE build. Necessary for build reproducibility. Change-Id: I926b096e77a9d45ba2beecd1fc2b7d0a9b9a7b9c Signed-off-by: Krystian Hebel <krystian.hebel(a)3mdeb.com> --- M payloads/external/Makefile.mk M payloads/external/iPXE/Kconfig M payloads/external/iPXE/Makefile 3 files changed, 21 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/82039/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/82039?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I926b096e77a9d45ba2beecd1fc2b7d0a9b9a7b9c Gerrit-Change-Number: 82039 Gerrit-PatchSet: 10 Gerrit-Owner: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Filip Lewiński <filip.lewinski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>

1 0

[XS] Change in coreboot[main]: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat
by Jayvik Desai (Code Review) 09 Jan '25

09 Jan '25

Jayvik Desai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85920?usp=email ) Change subject: mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat ...................................................................... mb/google/fatcat: select DRIVER_INTEL_ISH_HAS_MAIN_FW for fatcat since fatcat uses ISH main firmware enable this setting to avoid storing ISH SHIM firmware version. BUG=none TEST=build and boot fatcat, config exists in coreboot.config Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Signed-off-by: Jayvik Desai <jayvik(a)google.com> --- M src/mainboard/google/fatcat/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/85920/1 diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 37ba330..d762fa7 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -43,6 +43,7 @@ select BOARD_GOOGLE_FATCAT_COMMON select CHROMEOS_WIFI_SAR if CHROMEOS select DRIVERS_INTEL_ISH + select DRIVER_INTEL_ISH_HAS_MAIN_FW select DRIVERS_INTEL_USB4_RETIMER select HAVE_SLP_S0_GATE select MAINBOARD_HAS_CHROMEOS -- To view, visit https://review.coreboot.org/c/coreboot/+/85920?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id24394cb6c6dbaed13c87612da341e47eb69895f Gerrit-Change-Number: 85920 Gerrit-PatchSet: 1 Gerrit-Owner: Jayvik Desai <jayvik(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025