coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XL] Change in coreboot[main]: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85861?usp=email ) Change subject: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c ...................................................................... Patch Set 8: (1 comment) File src/soc/mediatek/common/dp/dptx_hal.c: https://review.coreboot.org/c/coreboot/+/85861/comment/e74f2a36_5eaf7fe4?us… : PS3, Line 79: vsync > Check with MTK, `dptx_hal_set_msa` can be shared with MT8196. […] Done. CB:85930 -- To view, visit https://review.coreboot.org/c/coreboot/+/85861?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9e151bc766c312eaf81b4220782775ef1c9d2297 Gerrit-Change-Number: 85861 Gerrit-PatchSet: 8 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:27:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c
by Yu-Ping Wu (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85861?usp=email ) Change subject: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85861?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9e151bc766c312eaf81b4220782775ef1c9d2297 Gerrit-Change-Number: 85861 Gerrit-PatchSet: 8 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:27:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85930?usp=email ) Change subject: soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa ...................................................................... soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa Correct the settings according to Linux kenrel driver. The related settings can be found in [1]: [1]: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/mediatek/mtk_… TEST=emerge-rauru coreboot; check FW screen on Ciri and Navi Change-Id: I4ba7da74ce6394240513c482b19ec879b1a0a619 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/dp/dptx_hal_common.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/85930/1 diff --git a/src/soc/mediatek/common/dp/dptx_hal_common.c b/src/soc/mediatek/common/dp/dptx_hal_common.c index 3ba95d1..89da19c 100644 --- a/src/soc/mediatek/common/dp/dptx_hal_common.c +++ b/src/soc/mediatek/common/dp/dptx_hal_common.c @@ -137,6 +137,7 @@ htotal = ha + hsync + hbp + hfp; vtotal = va + vsync + vbp + vfp; + /* horizontal */ DP_WRITE2BYTE(mtk_dp, REG_3010_DP_ENCODER0_P0, htotal); DP_WRITE2BYTE(mtk_dp, REG_3018_DP_ENCODER0_P0, hsync + hbp); mtk_dp_mask(mtk_dp, REG_3028_DP_ENCODER0_P0, @@ -146,7 +147,8 @@ 0 << HSP_SW_DP_ENCODER0_P0_FLDMASK_POS, HSP_SW_DP_ENCODER0_P0_FLDMASK); DP_WRITE2BYTE(mtk_dp, REG_3020_DP_ENCODER0_P0, ha); - DP_WRITE2BYTE(mtk_dp, REG_3014_DP_ENCODER0_P0, va); + /* vertical */ + DP_WRITE2BYTE(mtk_dp, REG_3014_DP_ENCODER0_P0, vtotal); DP_WRITE2BYTE(mtk_dp, REG_301C_DP_ENCODER0_P0, vsync + vbp); mtk_dp_mask(mtk_dp, REG_302C_DP_ENCODER0_P0, vsync << VSW_SW_DP_ENCODER0_P0_FLDMASK_POS, @@ -155,14 +157,16 @@ 0 << VSP_SW_DP_ENCODER0_P0_FLDMASK_POS, VSP_SW_DP_ENCODER0_P0_FLDMASK); DP_WRITE2BYTE(mtk_dp, REG_3024_DP_ENCODER0_P0, va); + /* horizontal */ DP_WRITE2BYTE(mtk_dp, REG_3064_DP_ENCODER0_P0, ha); DP_WRITE2BYTE(mtk_dp, REG_3154_DP_ENCODER0_P0, htotal); DP_WRITE2BYTE(mtk_dp, REG_3158_DP_ENCODER0_P0, hfp); - DP_WRITE2BYTE(mtk_dp, REG_315C_DP_ENCODER0_P0, vsync); + DP_WRITE2BYTE(mtk_dp, REG_315C_DP_ENCODER0_P0, hsync); DP_WRITE2BYTE(mtk_dp, REG_3160_DP_ENCODER0_P0, hsync + hbp); DP_WRITE2BYTE(mtk_dp, REG_3164_DP_ENCODER0_P0, ha); + /* vertical */ DP_WRITE2BYTE(mtk_dp, REG_3168_DP_ENCODER0_P0, vtotal); - DP_WRITE2BYTE(mtk_dp, REG_316C_DP_ENCODER0_P0, hfp); + DP_WRITE2BYTE(mtk_dp, REG_316C_DP_ENCODER0_P0, vfp); DP_WRITE2BYTE(mtk_dp, REG_3170_DP_ENCODER0_P0, vsync); DP_WRITE2BYTE(mtk_dp, REG_3174_DP_ENCODER0_P0, vsync + vbp); DP_WRITE2BYTE(mtk_dp, REG_3178_DP_ENCODER0_P0, va); -- To view, visit https://review.coreboot.org/c/coreboot/+/85930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4ba7da74ce6394240513c482b19ec879b1a0a619 Gerrit-Change-Number: 85930 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: src/soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85917?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: src/soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte ...................................................................... src/soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte TEST=emerge-rauru coreboot Change-Id: I2762d6ca024d60663f6dae0db62a959a191adc02 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/dp/dptx_hal_common.c M src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/85917/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85917?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2762d6ca024d60663f6dae0db62a959a191adc02 Gerrit-Change-Number: 85917 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Add read/write APIs for DP Phy register
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85914?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/common/dp: Add read/write APIs for DP Phy register ...................................................................... soc/mediatek/common/dp: Add read/write APIs for DP Phy register MT8196's eDP architecture is different from previous SoCs. DP Phy needs to be configured during the initialization. Add read/write APIs for DP Phy register configuration. Add a mock definition EDP_PHY_BASE for the SoC that do not support DP Phy configuration. BUG=b:382363408 TEST=emerge-geralt coreboot && emerge-rauru coreboot TEST=check FW screen on Navi Change-Id: I5c00d0aa7e35f03cc3c3aef6a58eadd3d334d8ed Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/dp/dptx_common.c M src/soc/mediatek/common/dp/dptx_hal_common.c M src/soc/mediatek/common/dp/include/soc/dptx_common.h M src/soc/mediatek/common/dp/include/soc/dptx_hal_common.h M src/soc/mediatek/mt8188/include/soc/dptx.h M src/soc/mediatek/mt8195/include/soc/dptx.h 6 files changed, 41 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/85914/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c00d0aa7e35f03cc3c3aef6a58eadd3d334d8ed Gerrit-Change-Number: 85914 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85861?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/common/dp: Move common functions to dptx_hal_common.c ...................................................................... soc/mediatek/common/dp: Move common functions to dptx_hal_common.c Move the functions that can be shared with MT8196 to dptx_hal_common.c. BUG=b:382363408 TEST=emerge-geralt coreboot && emerge-cherry coreboot TEST=verify FW screen on Navi Change-Id: I9e151bc766c312eaf81b4220782775ef1c9d2297 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/dp/dptx_hal.c A src/soc/mediatek/common/dp/dptx_hal_common.c M src/soc/mediatek/mt8188/Makefile.mk M src/soc/mediatek/mt8195/Makefile.mk 4 files changed, 541 insertions(+), 559 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/85861/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/85861?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9e151bc766c312eaf81b4220782775ef1c9d2297 Gerrit-Change-Number: 85861 Gerrit-PatchSet: 8 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Paul Menzel. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85917?usp=email ) Change subject: soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85917/comment/19f8d33c_15a1ae88?us… : PS1, Line 8: > Why is u8 the right one? Because we use this API to manipulate one byte value written to the register. And it is quite obvious according to its naming. -- To view, visit https://review.coreboot.org/c/coreboot/+/85917?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2762d6ca024d60663f6dae0db62a959a191adc02 Gerrit-Change-Number: 85917 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:01:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte
by Paul Menzel (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Paul Menzel has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85917?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85917/comment/d2c320ee_4aacbf52?us… : PS1, Line 8: Why is u8 the right one? -- To view, visit https://review.coreboot.org/c/coreboot/+/85917?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2762d6ca024d60663f6dae0db62a959a191adc02 Gerrit-Change-Number: 85917 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 03:08:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: Update Maintainers file
by Paul Menzel (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Martin L Roth. Paul Menzel has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85883?usp=email ) Change subject: Update Maintainers file ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85883/comment/6001b8d1_85abd7e0?us… : PS3, Line 9: - Update AMD maintainers lists to reflect current situation : - Remove Ron Minnich as maintainer (At his request) : - Update the Infrastructure owners to reflect the current situation. : I’d prefer three commits, so it’s clear from the summary, what each does. -- To view, visit https://review.coreboot.org/c/coreboot/+/85883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Gerrit-Change-Number: 85883 Gerrit-PatchSet: 3 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 03:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/common/dp: Use DP_WRITE2BYTE if possible
by Yu-Ping Wu (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85918?usp=email ) Change subject: soc/mediatek/common/dp: Use DP_WRITE2BYTE if possible ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85918?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If8c801173089761db55992279045d053c60dcd86 Gerrit-Change-Number: 85918 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 01:20:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025