coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add srclken_rc drivers
by Jarried Lin (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), ot_song fan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85842?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Add srclken_rc drivers ...................................................................... soc/mediatek/mt8196: Add srclken_rc drivers MT8196 uses new RC mode with clk_buf driver, and needs srclken_rc to send PMRC_EN. PMRC_EN will collect the requirements of all users, such as MD, GPS, PCIE, NFC. TEST=Build pass. BUG=b:317009620 Signed-off-by: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Change-Id: I40f8d2b12027955e6bd57b666e9f04c0116a0a93 --- M src/soc/mediatek/mt8196/Makefile.mk M src/soc/mediatek/mt8196/include/soc/addressmap.h A src/soc/mediatek/mt8196/include/soc/srclken_rc.h A src/soc/mediatek/mt8196/srclken_rc.c 4 files changed, 804 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/85842/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40f8d2b12027955e6bd57b666e9f04c0116a0a93 Gerrit-Change-Number: 85842 Gerrit-PatchSet: 5 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add clk_buf drivers
by Jarried Lin (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), ot_song fan, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85841?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Add clk_buf drivers ...................................................................... soc/mediatek/mt8196: Add clk_buf drivers MT8196 use MT6685 clk_buf, and will use new RC mode with srclken_rc. The clk_buf will provide several 26M clocks, and these clocks can be independently turned on. RC mode will determine which clocks to be turned on based on users' requests, which is collected into PMRC_EN register by srclken_rc. TEST=Build pass. BUG=b:317009620 Signed-off-by: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Change-Id: Ie18bfbb2f3354ba3645799857061dc20de7f6d84 --- M src/soc/mediatek/mt8196/Makefile.mk A src/soc/mediatek/mt8196/clkbuf_ctl.c A src/soc/mediatek/mt8196/include/soc/clkbuf_ctl.h 3 files changed, 874 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/85841/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85841?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie18bfbb2f3354ba3645799857061dc20de7f6d84 Gerrit-Change-Number: 85841 Gerrit-PatchSet: 5 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[S] Change in coreboot[main]: Documentation: Fix wrong link to commit message guidelines
by Werner Zeh (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Martin L Roth, Matt DeVillier. Hello Felix Singer, Martin L Roth, Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85915?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Felix Singer, Code-Review+2 by Matt DeVillier, Verified+1 by build bot (Jenkins) Change subject: Documentation: Fix wrong link to commit message guidelines ...................................................................... Documentation: Fix wrong link to commit message guidelines In the Gerrit guidelines there is an old link pointing to the retired coreboot wiki (https://www.coreboot.org/Git#Commit_messages) when the commit message guidelines are referenced. Indeed this section was never ported over to the new documentation and is missing. This commit rewrites this guidelines and adds them as a new section based on what was in the wiki and updates the link accordingly. Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544 Signed-off-by: Werner Zeh <werner.zeh(a)siemens.com> --- M Documentation/contributing/gerrit_guidelines.md 1 file changed, 48 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85915/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544 Gerrit-Change-Number: 85915 Gerrit-PatchSet: 2 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[S] Change in coreboot[main]: Documentation: Fix wrong link to commit message guidelines
by Werner Zeh (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Felix Singer, Martin L Roth. Werner Zeh has posted comments on this change by Werner Zeh. ( https://review.coreboot.org/c/coreboot/+/85915?usp=email ) Change subject: Documentation: Fix wrong link to commit message guidelines ...................................................................... Patch Set 1: (6 comments) File Documentation/contributing/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/85915/comment/e91b7a4e_881c71e7?us… : PS1, Line 445: - > Please use asterisks for consistency as it's done for all other places in this document. Acknowledged https://review.coreboot.org/c/coreboot/+/85915/comment/f18d6544_83fadb14?us… : PS1, Line 455: gerrit > Uppercase […] Acknowledged https://review.coreboot.org/c/coreboot/+/85915/comment/f36f89fe_87ff5906?us… : PS1, Line 456: signed > Uppercase […] Acknowledged https://review.coreboot.org/c/coreboot/+/85915/comment/191a2258_beb79b12?us… : PS1, Line 459: install the commit-msg hook > Since there is no reference, it's a bit confusing how to get this thing. […] Yes, I stumbled across this, too. We do have Documentation/corebootBuildingGuide.tex where the installation of this hook is kind of described but it seems like .tex-files are not used to render our documentation, right? Still, the easiest way to install the hooks would be ```make gitconfig``` which is not what is described in the .tex-file. That might need an update, too. On the other hand we could simply add this ```make giconfig``` command here as the instruction on how to install these hooks and let it be. I will modify the patch to show how it could look like. What do you think? https://review.coreboot.org/c/coreboot/+/85915/comment/73e8b971_aafe0060?us… : PS1, Line 460: to > Typo […] Acknowledged https://review.coreboot.org/c/coreboot/+/85915/comment/6d7080a1_c4d76d72?us… : PS1, Line 468: she or he > Simplification […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85915?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1cd2b13da6fe59697d677c7350d73eda5d486544 Gerrit-Change-Number: 85915 Gerrit-PatchSet: 1 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 06:20:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Use assert to check read/write API params
by Yidi Lin (Code Review) 09 Jan '25

09 Jan '25

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85931?usp=email ) Change subject: soc/mediatek/common/dp: Use assert to check read/write API params ...................................................................... soc/mediatek/common/dp: Use assert to check read/write API params With CB:85918 and CB:85930, we can clean up the TODO in mtk_dp_mask. Follow DP Phy APIs to use `assert` for the param examination. TEST=verified on Ciri and Navi Change-Id: I94e6ad36d190d773876cbb43eb4ebe17164f3c92 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/dp/dptx_hal_common.c 1 file changed, 9 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/85931/1 diff --git a/src/soc/mediatek/common/dp/dptx_hal_common.c b/src/soc/mediatek/common/dp/dptx_hal_common.c index 89da19c..257a976 100644 --- a/src/soc/mediatek/common/dp/dptx_hal_common.c +++ b/src/soc/mediatek/common/dp/dptx_hal_common.c @@ -16,11 +16,8 @@ { void *addr = mtk_dp->regs + offset; - if (offset % 4 != 0 || offset > REG_OFFSET_LIMIT) { - printk(BIOS_ERR, "[%s] invalid offset %#x for reg %p\n", __func__, offset, - mtk_dp->regs); - return 0; - } + assert(mtk_dp->regs); + assert(offset % 4 == 0 && offset <= REG_OFFSET_LIMIT); return read32(addr); } @@ -28,11 +25,8 @@ { void *addr = mtk_dp->regs + offset; - if (offset % 4 != 0 || offset > REG_OFFSET_LIMIT) { - printk(BIOS_ERR, "[%s] invalid offset %#x for reg %p\n", __func__, offset, - mtk_dp->regs); - return; - } + assert(mtk_dp->regs); + assert(offset % 4 == 0 && offset <= REG_OFFSET_LIMIT); write32(addr, val); } @@ -47,11 +41,11 @@ return; } - /* - * TODO: modify to clrsetbits32(addr, mask, val); - * There is asserion error when testing assert((val & mask) == val). - */ - clrsetbits32(addr, mask, val & mask); + assert(mtk_dp->regs); + assert(offset % 4 == 0 && offset <= REG_OFFSET_LIMIT); + assert((val & mask) == val); + + clrsetbits32(addr, mask, val); } void mtk_dp_write_byte(struct mtk_dp *mtk_dp, u32 addr, u8 val, u8 mask) -- To view, visit https://review.coreboot.org/c/coreboot/+/85931?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I94e6ad36d190d773876cbb43eb4ebe17164f3c92 Gerrit-Change-Number: 85931 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa
by Yu-Ping Wu (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85930?usp=email ) Change subject: soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4ba7da74ce6394240513c482b19ec879b1a0a619 Gerrit-Change-Number: 85930 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:31:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa
by Yidi Lin (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85930?usp=email to look at the new patch set (#2). Change subject: soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa ...................................................................... soc/mediatek/common/dp: Correct the settings in dptx_hal_set_msa Correct the settings according to Linux kernel driver. The related settings can be found in [1]: [1]: https://github.com/torvalds/linux/blob/master/drivers/gpu/drm/mediatek/mtk_… TEST=emerge-rauru coreboot; check FW screen on Ciri and Navi Change-Id: I4ba7da74ce6394240513c482b19ec879b1a0a619 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/dp/dptx_hal_common.c 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/85930/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85930?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4ba7da74ce6394240513c482b19ec879b1a0a619 Gerrit-Change-Number: 85930 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: src/soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte
by Yu-Ping Wu (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85917?usp=email ) Change subject: src/soc/mediatek/common/dp: Fix `mask` data type in mtk_dp_write_byte ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85917?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2762d6ca024d60663f6dae0db62a959a191adc02 Gerrit-Change-Number: 85917 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:29:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Add read/write APIs for DP Phy register
by Yu-Ping Wu (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85914?usp=email ) Change subject: soc/mediatek/common/dp: Add read/write APIs for DP Phy register ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c00d0aa7e35f03cc3c3aef6a58eadd3d334d8ed Gerrit-Change-Number: 85914 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:29:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/common/dp: Add read/write APIs for DP Phy register
by Yidi Lin (Code Review) 09 Jan '25

09 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85914?usp=email ) Change subject: soc/mediatek/common/dp: Add read/write APIs for DP Phy register ...................................................................... Patch Set 2: (3 comments) File src/soc/mediatek/common/dp/dptx_hal_common.c: https://review.coreboot.org/c/coreboot/+/85914/comment/5ee4690e_d91c23ea?us… : PS1, Line 73: if (!mtk_dp->phy_regs) { > Same here. Use an assertion. Done https://review.coreboot.org/c/coreboot/+/85914/comment/2dc1adc2_010a12f7?us… : PS1, Line 78: if (offset % 4 != 0 || offset > REG_OFFSET_LIMIT) { : printk(BIOS_ERR, "[%s] invalid offset %#x for reg %p\n", : __func__, offset, mtk_dp->regs); : return 0; : } > Although existing code is also written this way, I think this should be assertions (instead of run-t […] Done https://review.coreboot.org/c/coreboot/+/85914/comment/a54be643_4e30b495?us… : PS1, Line 120: /* : * TODO: modify to clrsetbits32(addr, mask, val); : * There is asserion error when testing assert((val & mask) == val). : */ > I checked all the `mtk_dp_phy_mask` callers, and think the assertion is always valid. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85914?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5c00d0aa7e35f03cc3c3aef6a58eadd3d334d8ed Gerrit-Change-Number: 85914 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 04:28:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025