coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/rull: eMMC DLL tuning
by Kapil Porwal (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Nick Vaccaro, Rui Zhou. Kapil Porwal has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85933?usp=email ) Change subject: mb/google/nissa/var/rull: eMMC DLL tuning ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdbb96f9623612a8eb5e01818859c4844ca4de13 Gerrit-Change-Number: 85933 Gerrit-PatchSet: 2 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 10:25:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Add mt6363_read8 API
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85892?usp=email ) Change subject: soc/mediatek/mt8196: Add mt6363_read8 API ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3cca4c2e5f6c2537c9661623260b21fb6088eff9 Gerrit-Change-Number: 85892 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 10:18:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek/mt8196: Add mt6363_read8 API
by Jarried Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hope Wang, Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Hello Hope Wang, Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85892?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by Yidi Lin, Code-Review+2 by Yu-Ping Wu, Verified+1 by build bot (Jenkins) The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: soc/mediatek/mt8196: Add mt6363_read8 API ...................................................................... soc/mediatek/mt8196: Add mt6363_read8 API Add mt6363_read8 API for common use. BUG=b:317009620 TEST=Build pass. Change-Id: I3cca4c2e5f6c2537c9661623260b21fb6088eff9 Signed-off-by: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> --- M src/soc/mediatek/common/include/soc/mt6363.h M src/soc/mediatek/common/mt6363.c 2 files changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/85892/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3cca4c2e5f6c2537c9661623260b21fb6088eff9 Gerrit-Change-Number: 85892 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Hope Wang <hope.wang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[XS] Change in coreboot[main]: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Naresh Solanki (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Felix Held. Naresh Solanki has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) Change subject: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/glinda/Kconfig: https://review.coreboot.org/c/coreboot/+/85627/comment/36febf95_d63b9564?us… : PS1, Line 385: default 0x10970 > please add an empty line between this option and the endmenu after it Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 2 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 10 Jan 2025 10:10:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85890?usp=email ) Change subject: mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel ...................................................................... mb/google/corsola/var/wyrdeer: Add STA_2082109QFH040022_50E MIPI panel Add STA_2082109QFH040022_50E MIPI panel for wyrdeer. Datasheet: 2082109QFH040022-50E-XR109IB5T_Full viewing-300-51PIN- V1.0.pdf BUG=b:379810871 TEST=emerge-staryu coreboot chromeos-bootimage BRANCH=corsola Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85890 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yidi Lin <yidilin(a)google.com> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/mainboard/google/corsola/Kconfig M src/mainboard/google/corsola/panel_wyrdeer.c 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Yidi Lin: Looks good to me, approved build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/mainboard/google/corsola/Kconfig b/src/mainboard/google/corsola/Kconfig index 6977bd4..d8643fd 100644 --- a/src/mainboard/google/corsola/Kconfig +++ b/src/mainboard/google/corsola/Kconfig @@ -74,6 +74,7 @@ select MIPI_PANEL_KD_KD101NE3_40TI if BOARD_GOOGLE_WUGTRIO select MIPI_PANEL_KD_KD110N11_51IE if BOARD_GOOGLE_WYRDEER select MIPI_PANEL_LCE_LMFBX101117480 if BOARD_GOOGLE_WUGTRIO + select MIPI_PANEL_STA_2082109QFH040022_50E if BOARD_GOOGLE_WYRDEER select MIPI_PANEL_STA_ER88577 if BOARD_GOOGLE_WUGTRIO select MIPI_PANEL_STA_HIMAX83102_J02 if BOARD_GOOGLE_STARMIE select MIPI_PANEL_STA_ILI9882T if BOARD_GOOGLE_STARMIE diff --git a/src/mainboard/google/corsola/panel_wyrdeer.c b/src/mainboard/google/corsola/panel_wyrdeer.c index 5ae3120..5d6379d 100644 --- a/src/mainboard/google/corsola/panel_wyrdeer.c +++ b/src/mainboard/google/corsola/panel_wyrdeer.c @@ -25,6 +25,14 @@ .disp_path = DISP_PATH_MIPI, .orientation = LB_FB_ORIENTATION_LEFT_UP, }, + /* STA Technology panel */ + [9] = { + .configure_backlight = backlight_control, + .power_on = mipi_panel_power_on, + .name = "STA_2082109QFH040022_50E", + .disp_path = DISP_PATH_MIPI, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + }, }; struct panel_description *get_panel_description(void) -- To view, visit https://review.coreboot.org/c/coreboot/+/85890?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I64b907da8ff4e88b9290132033b9300d0b9488cb Gerrit-Change-Number: 85890 Gerrit-PatchSet: 5 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for STA_2082109QFH040022_50E panel
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85889?usp=email ) Change subject: drivers/mipi: Add support for STA_2082109QFH040022_50E panel ...................................................................... drivers/mipi: Add support for STA_2082109QFH040022_50E panel Add STA panel STA_2082109QFH040022_50E serializable data to CBFS. Datasheet: 2082109QFH040022-50E-XR109IB5T_Full viewing-300-51PIN- V1.0.pdf BUG=b:379810871 TEST=build and check the CBFS include the panel BRANCH=corsola Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85889 Reviewed-by: Yidi Lin <yidilin(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-STA_2082109QFH040022_50E.c 3 files changed, 133 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, approved diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index a7049ba..1edebf9 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -57,6 +57,9 @@ config MIPI_PANEL_STA_2081101QFH032011_53G bool +config MIPI_PANEL_STA_2082109QFH040022_50E + bool + config MIPI_PANEL_STA_ER88577 bool diff --git a/src/drivers/mipi/Makefile.mk b/src/drivers/mipi/Makefile.mk index 0c4a5c9..de566d4 100644 --- a/src/drivers/mipi/Makefile.mk +++ b/src/drivers/mipi/Makefile.mk @@ -29,6 +29,7 @@ panel-params-$(CONFIG_MIPI_PANEL_LCE_LMFBX101117480) += panel-LCE_LMFBX101117480 panel-params-$(CONFIG_MIPI_PANEL_STA_2081101QFH032011_53G) += panel-STA_2081101QFH032011_53G +panel-params-$(CONFIG_MIPI_PANEL_STA_2082109QFH040022_50E) += panel-STA_2082109QFH040022_50E panel-params-$(CONFIG_MIPI_PANEL_STA_ER88577) += panel-STA_ER88577 panel-params-$(CONFIG_MIPI_PANEL_STA_HIMAX83102_J02) += panel-STA_HIMAX83102_J02 panel-params-$(CONFIG_MIPI_PANEL_STA_ILI9882T) += panel-STA_ILI9882T diff --git a/src/drivers/mipi/panel-STA_2082109QFH040022_50E.c b/src/drivers/mipi/panel-STA_2082109QFH040022_50E.c new file mode 100644 index 0000000..6302961 --- /dev/null +++ b/src/drivers/mipi/panel-STA_2082109QFH040022_50E.c @@ -0,0 +1,129 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data STA_QFH040022_50E = { + .edid = { + .ascii_string = "QFH040022_50E", + .manufacturer_name = "STA", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 187097, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 346, .hso = 160, .hspw = 120, + .va = 1920, .vbl = 151, .vso = 115, .vspw = 28, + .phsync = '-', .pvsync = '-', + .x_mm = 147, .y_mm = 235, + }, + }, + + .init = { + PANEL_DCS(0xB9, 0x83, 0x10, 0x21, 0x55, 0x00), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD9, 0xD1), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB1, 0x2C, 0xB5, 0xB5, 0x31, 0xF1, 0x33, 0xC3, 0x57, 0x36, + 0x36, 0x36, 0x36, 0x1A, 0x8B, 0x11, 0x65, 0x00, 0x88, 0xFA, + 0xFF, 0xFF, 0x8F, 0xFF, 0x08, 0x3C, 0x33), + PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x22, 0x70, 0x3C, 0xA1, + 0x22, 0x00, 0x00, 0x00, 0x88, 0xF4), + PANEL_DCS(0xB4, 0x14, 0x16, 0x14, 0x50, 0x14, 0x50, 0x0D, 0x6A, 0x0D, + 0x6A, 0x01, 0x9E), + PANEL_DCS(0xB6, 0x34, 0x34, 0x03), + PANEL_DCS(0xB8, 0x40), + PANEL_DCS(0xE9, 0xCD), + PANEL_DCS(0xBA, 0x84), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBC, 0x1B, 0x04), + PANEL_DCS(0xBE, 0x20), + PANEL_DCS(0xBF, 0xFC, 0xC4), + PANEL_DCS(0xC0, 0x38, 0x38, 0x22, 0x11, 0x33, 0xA0, 0x61, 0x08, 0xF5, + 0x03), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xC7, 0x80), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xC8, 0x97), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xC9, 0x00, 0x1E, 0x30, 0xD4, 0x01), + PANEL_DCS(0xCB, 0x08, 0x13, 0x07, 0x00, 0x0F, 0x16), + PANEL_DCS(0xCC, 0x02, 0x03, 0x44), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD0, 0x03), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD1, 0x37, 0x06, 0x00, 0x02, 0x04, 0x2C, 0xFF), + PANEL_DCS(0xD3, 0x06, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x3B, 0x03, 0x73, 0x3B, 0x21, 0x21, 0x03, 0x03, 0x98, 0x10, + 0x1D, 0x00, 0x1D, 0x32, 0x17, 0xA1, 0x07, 0xA1, 0x43, 0x17, + 0xA6, 0x07, 0xA6, 0x00, 0x00), + PANEL_DCS(0xD5, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x40, 0x40, 0x18, + 0x18, 0x18, 0x18, 0x2A, 0x2B, 0x1F, 0x1F, 0x1E, 0x1E, 0x24, + 0x25, 0x26, 0x27, 0x28, 0x29, 0x2A, 0x2B, 0x00, 0x01, 0x02, + 0x03, 0x04, 0x05, 0x06, 0x07, 0x08, 0x09, 0x0A, 0x0B, 0x20, + 0x21, 0x18, 0x18, 0x18, 0x18), + PANEL_DCS(0xD8, 0x02, 0xAA, 0xEA, 0xAA, 0xAA, 0x00, 0x02, 0xAA, 0xEA, + 0xAA, 0xAA, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xE7, 0x07, 0x10, 0x10, 0x2A, 0x32, 0x9F, 0x01, 0x5A, 0x91, + 0x14, 0x14, 0x00, 0x00, 0x00, 0x00, 0x12, 0x05, 0x02, 0x02, + 0x10, 0x33, 0x02, 0x04, 0x18, 0x01), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xB1, 0x01, 0x7F, 0x11, 0xFD), + PANEL_DCS(0xCB, 0x86), + PANEL_DCS(0xD2, 0x3D), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xD3, 0x00, 0x00, 0x00, 0x80, 0x80, 0x0C, 0xA1), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x03, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x03, 0xFF, 0xFF, + 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xE7, 0x02, 0x00, 0x2D, 0x01, 0x7F, 0x0F, 0x7C, 0x10, 0xA0, + 0x00, 0x00, 0x77, 0x00, 0x00, 0x00), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xBF, 0xF2), + PANEL_DCS(0xCB, 0x02, 0x00, 0x00, 0x10, 0x58), + PANEL_DCS(0xD2, 0x0A, 0x0A, 0x05, 0x03, 0x0A, 0x0A, 0x01, 0x03, 0x01, + 0x01, 0x05, 0x0E), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xD3, 0x03, 0x1F, 0xE0, 0x11, 0x70), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0xAB, 0xFF, 0xFF, 0xFF, 0xFF, 0xA0, 0xAB, 0xFF, 0xFF, + 0xFF, 0xFF, 0xA0), + PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00, 0x00, + 0x03, 0x00, 0x03, 0x81, 0x02, 0x40, 0x00, 0x20, 0x9E, 0x02, + 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0xBD, 0x03), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0xAA, 0xAB, 0xEA, 0xAA, 0xAA, 0xA0, 0xAA, 0xAB, 0xEA, + 0xAA, 0xAA, 0xA0, 0xAA, 0xBF, 0xFF, 0xFF, 0xFE, 0xA0, 0xAA, + 0xBF, 0xFF, 0xFF, 0xFE, 0xA0, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, + 0xA0, 0xAA, 0xAA, 0xAA, 0xAA, 0xAA, 0xA0), + PANEL_DCS(0xE1, 0x00), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xBA, 0x96), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xBA, 0x4F), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xBA, 0x84), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xB9, 0x00, 0x00, 0x00, 0x00), + + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(5), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/85889?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I131e179b7c4420e2038ec4023f9b2f505fc6c088 Gerrit-Change-Number: 85889 Gerrit-PatchSet: 4 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add srclken_rc drivers
by Yidi Lin (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu, ot_song fan. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email ) Change subject: soc/mediatek/mt8196: Add srclken_rc drivers ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Patchset: PS7: @jarried.lin@mediatek.com Please rebase whole chain. -- To view, visit https://review.coreboot.org/c/coreboot/+/85842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40f8d2b12027955e6bd57b666e9f04c0116a0a93 Gerrit-Change-Number: 85842 Gerrit-PatchSet: 7 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 09:49:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/trulo/var/uldrenite: Change ROM size to 32MB
by Subrata Banik (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Shou-Chieh Hsu. Subrata Banik has posted comments on this change by Dtrain Hsu. ( https://review.coreboot.org/c/coreboot/+/85932?usp=email ) Change subject: mb/trulo/var/uldrenite: Change ROM size to 32MB ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85932?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I39f50415e093eb82342462f03cf50e89bce8cd93 Gerrit-Change-Number: 85932 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 09:49:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/nissa/var/rull: eMMC DLL tuning
by Subrata Banik (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou. Subrata Banik has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85933?usp=email ) Change subject: mb/google/nissa/var/rull: eMMC DLL tuning ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85933?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibdbb96f9623612a8eb5e01818859c4844ca4de13 Gerrit-Change-Number: 85933 Gerrit-PatchSet: 2 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Fri, 10 Jan 2025 09:47:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add srclken_rc drivers
by ot_song fan (Code Review) 10 Jan '25

10 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. ot_song fan has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email ) Change subject: soc/mediatek/mt8196: Add srclken_rc drivers ...................................................................... Patch Set 7: (1 comment) File src/soc/mediatek/mt8196/srclken_rc.c: https://review.coreboot.org/c/coreboot/+/85842/comment/508ffe03_be981f88?us… : PS1, Line 265: code flow ASSERT already > Then I don't think we need to keep the comment. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85842?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40f8d2b12027955e6bd57b666e9f04c0116a0a93 Gerrit-Change-Number: 85842 Gerrit-PatchSet: 7 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Fri, 10 Jan 2025 09:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ot_song fan <ot_song.fan(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025