coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[L] Change in coreboot[main]: mb/starlabs/starbook: Put options in CFR cbtable
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Angel Pons, Christian Walter, Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/74743?usp=email ) Change subject: mb/starlabs/starbook: Put options in CFR cbtable ...................................................................... Patch Set 39: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/74743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Gerrit-Change-Number: 74743 Gerrit-PatchSet: 39 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:12:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/starlabs/starfighter: Put options in CFR cbtable
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85709?usp=email ) Change subject: mb/starlabs/starfighter: Put options in CFR cbtable ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85709?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e3b5448282aa81a89356f1d3145381d65e47aaa Gerrit-Change-Number: 85709 Gerrit-PatchSet: 12 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:11:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/starlabs/byte_adl: Put options in CFR cbtable
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85710?usp=email ) Change subject: mb/starlabs/byte_adl: Put options in CFR cbtable ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11349397e41fb2c7a3f26ab172a2c4b30d24bc0a Gerrit-Change-Number: 85710 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:11:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/starlabs/starlite_adl: Put options in CFR cbtable
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85711?usp=email ) Change subject: mb/starlabs/starlite_adl: Put options in CFR cbtable ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85711?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If92f61dece7e67bfd2e29927198c9ebb81c4d363 Gerrit-Change-Number: 85711 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:11:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: mb/starlabs/lite: Put options in CFR cbtable
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/76583?usp=email ) Change subject: mb/starlabs/lite: Put options in CFR cbtable ...................................................................... Patch Set 18: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/76583?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42ae5b35e6b53b5a13ec3f80180f4955db9b6ce2 Gerrit-Change-Number: 76583 Gerrit-PatchSet: 18 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:11:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Organise the Kconfig options
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85972?usp=email ) Change subject: mb/starlabs/starlite_adl: Organise the Kconfig options ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I277249323e8735dda0a6e394e475435ddedf5537 Gerrit-Change-Number: 85972 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:07:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add display driver
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email ) Change subject: soc/mediatek/mt8196: Add display driver ...................................................................... Patch Set 2: (25 comments) File src/soc/mediatek/common/display.c: https://review.coreboot.org/c/coreboot/+/85950/comment/60febca4_8c547fb2?us… : PS2, Line 46: __weak int mtk_edp_enable(void) From another [comment](https://review.coreboot.org/c/coreboot/+/85949/comment/65d79f70_a8…, I think this could be merged into `mtk_edp_init`. File src/soc/mediatek/mt8196/Makefile.mk: https://review.coreboot.org/c/coreboot/+/85950/comment/d1643519_4a7dbda8?us… : PS2, Line 67: ramstage-y += mtcmos.c What's this for? File src/soc/mediatek/mt8196/ddp.c: https://review.coreboot.org/c/coreboot/+/85950/comment/e9715645_dfd7342e?us… : PS2, Line 17: clrbits32(&reg->datapath_con, BIT(4)); : setbits32(&reg->datapath_con, BIT(5)); Single `clrsetbits32` call. Same for other blender types. https://review.coreboot.org/c/coreboot/+/85950/comment/a503b898_bbf03367?us… : PS2, Line 28: break; Add `OTHER_BLENDER:` https://review.coreboot.org/c/coreboot/+/85950/comment/b001aade_e9e46c81?us… : PS2, Line 36: height << 16 | width Define a macro for this ``` #define SIZE(w, h) ((u32)(h) << 16 | (width)) ``` https://review.coreboot.org/c/coreboot/+/85950/comment/a62a43e0_57cb97b2?us… : PS2, Line 38: ff upper case https://review.coreboot.org/c/coreboot/+/85950/comment/70182f7d_8fef3572?us… : PS2, Line 130: 0xff upper case https://review.coreboot.org/c/coreboot/+/85950/comment/079054c4_e90a0058?us… : PS2, Line 196: /* mutex enable*/ wrong style https://review.coreboot.org/c/coreboot/+/85950/comment/27305aa1_bb520e9f?us… : PS2, Line 205: blender_config(0, width, height, FIRST_BLENDER); : blender_config(1, width, height, OTHERS); : blender_config(2, width, height, OTHERS); : blender_config(3, width, height, LAST_BLENDER); : blender_start(0); : blender_start(1); : blender_start(2); : blender_start(3); Use for loops. ``` int i; enum mtk_disp_blender_layer blender_type[ARRAY_SIZE(blenders)] = { FIRST_BLENDER, OTHER_BLENDER, OTHER_BLENDER, LAST_BLENDER }; for (i = 0; i < ARRAY_SIZE(blenders); i++) { struct blender *blender = &blenders[i]; // I assume we can adjust the calling order blender_config(blender, width, height, blender_type[i]); blender_start(blender); } ``` https://review.coreboot.org/c/coreboot/+/85950/comment/c653c170_70990608?us… : PS2, Line 233: /* async config*/ wrong style https://review.coreboot.org/c/coreboot/+/85950/comment/768d27ee_969683e3?us… : PS2, Line 264: /* exdma start*/ wrong style https://review.coreboot.org/c/coreboot/+/85950/comment/7de93dbb_d02cf1f6?us… : PS2, Line 275: 0xffffffff upper case https://review.coreboot.org/c/coreboot/+/85950/comment/8edde20f_893094f0?us… : PS2, Line 308: Check that `width <= XXX && height <= XXX`, and change the type of `width` and `height` to u16 for `main_disp_path_setup`, `ovlsys_layer_config` and other functions in this file (except the local variables here). `XXX` is the maximum supported width/height in this driver. From `BIT(30) | height << 16 | width`, I assume height can be 14 bits, and width can be 16 bits. Please confirm. File src/soc/mediatek/mt8196/include/soc/ddp.h: https://review.coreboot.org/c/coreboot/+/85950/comment/ee733117_2e3eabb4?us… : PS2, Line 10: #define MAIN_PATH_OVL_NR 2 Remove if unused https://review.coreboot.org/c/coreboot/+/85950/comment/6a95b9a3_c8e1f609?us… : PS2, Line 12: 0xffffffff upper case https://review.coreboot.org/c/coreboot/+/85950/comment/e83b2c04_a444fd1b?us… : PS2, Line 15: /* 0x000 */ Remove all of these comments, as we already have `check_member` below. https://review.coreboot.org/c/coreboot/+/85950/comment/f7ed0c73_61f00784?us… : PS2, Line 58: check_member(ovlsys_cfg, rsz_in_cb2, 0xF70); One blank line below. Same for others. https://review.coreboot.org/c/coreboot/+/85950/comment/46333a07_46882866?us… : PS2, Line 110: 0xc30 upper case https://review.coreboot.org/c/coreboot/+/85950/comment/ba8efef6_768439e0?us… : PS2, Line 279: }; blank line below https://review.coreboot.org/c/coreboot/+/85950/comment/90080e8a_2c82c482?us… : PS2, Line 281: (void *)MMSYS_MUTEX_BASE, : (void *)MMSYS1_MUTEX_BASE, : (void *)OVLSYS_MUTEX_BASE, ``` [DISP0] = (void *)MMSYS_MUTEX_BASE, [DISP1] = (void *)MMSYS1_MUTEX_BASE, [OVL0] = (void *)OVLSYS_MUTEX_BASE, ``` https://review.coreboot.org/c/coreboot/+/85950/comment/8db677d8_2c9063f2?us… : PS2, Line 286: OVL_INPUT_FORMAT Remove this unused name. https://review.coreboot.org/c/coreboot/+/85950/comment/78b26653_180eabd9?us… : PS2, Line 317: /* DISPSYS mutex module*/ wrong style https://review.coreboot.org/c/coreboot/+/85950/comment/1e86ef6c_18a75610?us… : PS2, Line 343: /* DISPSYS1 mutex module*/ wrong style https://review.coreboot.org/c/coreboot/+/85950/comment/c3443c85_e509230b?us… : PS2, Line 365: OTHERS Can we rename to `OTHER_BLENDER`? https://review.coreboot.org/c/coreboot/+/85950/comment/0c1cb744_2faeb24b?us… : PS2, Line 366: BLENDER_LAYER_MAX, remove -- To view, visit https://review.coreboot.org/c/coreboot/+/85950?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466 Gerrit-Change-Number: 85950 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:07:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Unset ADD_ITE_BINARY
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85973?usp=email ) Change subject: mb/starlabs/*: Unset ADD_ITE_BINARY ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02a10211d7cec9a2c8a0837f77ca17acdcb06c22 Gerrit-Change-Number: 85973 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:06:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/amd/birman_plus: Kconfig
by Martin Roth (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Ana Carolina Cabral, Felix Held. Martin Roth has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85493?usp=email ) Change subject: mb/amd/birman_plus: Kconfig ...................................................................... Patch Set 8: (3 comments) File src/mainboard/amd/birman_plus/Kconfig: https://review.coreboot.org/c/coreboot/+/85493/comment/cf1b4bcc_bdc2110b?us… : PS8, Line 131: Disable WWAN "Disable both WWAN & GbE"? https://review.coreboot.org/c/coreboot/+/85493/comment/21698062_51d86a8f?us… : PS8, Line 147: Disable WLAN "Disable WLAN & SD Card"? File src/mainboard/amd/birman_plus/port_descriptors_glinda.c: https://review.coreboot.org/c/coreboot/+/85493/comment/eb6aeec8_2915723a?us… : PS8, Line 87: 14 So this is just ignored if it's set to disabled? I'd think we'd just want to the GBE/SD entries if WWAN & WLAN are enabled. To me, this configuration is saying in the WLAN entry that we're using 14, and then here we're saying to disable 14. At the very least maybe add a comment saying that this entry pretty much gets ignored because lane 14 is already allocated above - if that's the case, and I don't know whether it is or not. Obviously this is the same for GBE & for the other port descriptors file. -- To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4 Gerrit-Change-Number: 85493 Gerrit-PatchSet: 8 Gerrit-Owner: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:04:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/{volteer,brya,rex}: Disable 8254 timers by default
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Alicja Michalska, Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun. Matt DeVillier has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/85976?usp=email ) Change subject: mb/google/{volteer,brya,rex}: Disable 8254 timers by default ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: given the Kconfig default for the `USE_LEGACY_8254_TIMER` config, this shouldn't be necessary -- To view, visit https://review.coreboot.org/c/coreboot/+/85976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61f617c65707b7e9113770162885fd13a13a1d67 Gerrit-Change-Number: 85976 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:01:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025