coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: soc/amd/common/block: Remove space after a cast
by Felix Held (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Elyes Haouas, Felix Singer, Fred Reitberger, Jason Glenesk, Matt DeVillier. Felix Held has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77736?usp=email ) Change subject: soc/amd/common/block: Remove space after a cast ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/77736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icccfbc535e005648e45156fc6810210d0ec86a98 Gerrit-Change-Number: 77736 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:23:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Move common variants to respective files
by Sean Rhodes (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Paul Menzel. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85945?usp=email ) Change subject: ec/starlabs/merlin: Move common variants to respective files ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85945/comment/03786021_f7ac1736?us… : PS2, Line 9: EC to > One space. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85945?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Gerrit-Change-Number: 85945 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Move common variants to respective files
by Sean Rhodes (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85945?usp=email to look at the new patch set (#3). Change subject: ec/starlabs/merlin: Move common variants to respective files ...................................................................... ec/starlabs/merlin: Move common variants to respective files Move the Q-Events used by the merlin EC to their respective files, i.e. `Q0B` for Battery Status Update to battery.asl. This means that only revelant events will be included. Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/ec/starlabs/merlin/acpi/ac.asl M src/ec/starlabs/merlin/acpi/battery.asl M src/ec/starlabs/merlin/acpi/ec.asl M src/ec/starlabs/merlin/acpi/hid.asl M src/ec/starlabs/merlin/acpi/lid.asl D src/ec/starlabs/merlin/variants/merlin/events.asl 6 files changed, 36 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/85945/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85945?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Gerrit-Change-Number: 85945 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Alicja Michalska to Erying and Topton mainboards
by Alicja Michalska (Code Review) 14 Jan '25

14 Jan '25

Alicja Michalska has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/85977?usp=email ) Change subject: MAINTAINERS: Add Alicja Michalska to Erying and Topton mainboards ...................................................................... MAINTAINERS: Add Alicja Michalska to Erying and Topton mainboards While I don't have +2 rights, I think it makes sense to add myself as maintainer given I'm a creator of both ports in upstream tree. Change-Id: I2484fc488040c2d86bbf3bf98f39354bf88efae8 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M MAINTAINERS 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/85977/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85977?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2484fc488040c2d86bbf3bf98f39354bf88efae8 Gerrit-Change-Number: 85977 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: soc/amd/common/block: Remove space after a cast
by Ana Carolina Cabral (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Elyes Haouas, Felix Held, Felix Singer, Fred Reitberger, Jason Glenesk, Matt DeVillier. Ana Carolina Cabral has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/77736?usp=email ) Change subject: soc/amd/common/block: Remove space after a cast ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/77736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icccfbc535e005648e45156fc6810210d0ec86a98 Gerrit-Change-Number: 77736 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 13:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Alicja Michalska to Erying and Topton mainboards
by Alicja Michalska (Code Review) 14 Jan '25

14 Jan '25

Alicja Michalska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85977?usp=email ) Change subject: MAINTAINERS: Add Alicja Michalska to Erying and Topton mainboards ...................................................................... MAINTAINERS: Add Alicja Michalska to Erying and Topton mainboards While I don't have +2 rights, I think it makes sense to add myself as maintainer given I'm a creator of both ports in upstream tree. Change-Id: I2484fc488040c2d86bbf3bf98f39354bf88efae8 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M MAINTAINERS 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/85977/1 diff --git a/MAINTAINERS b/MAINTAINERS index 45bcac0..0c2ec70 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -285,7 +285,10 @@ S: Orphan F: src/mainboard/emulation/ - +ERYING MAINBOARDS +M: Alicja Michalska <ahplka19(a)gmail.com> +S: Maintained +F: src/mainboard/erying/ EXAMPLE MAINBOARDS S: Orphan @@ -651,6 +654,12 @@ F: src/mainboard/ti/ +TOPTON MAINBOARDS +M: Alicja Michalska <ahplka19(a)gmail.com> +S: Maintained +F: src/mainboard/topton/ + + UP MAINBOARDS S: Orphan -- To view, visit https://review.coreboot.org/c/coreboot/+/85977?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2484fc488040c2d86bbf3bf98f39354bf88efae8 Gerrit-Change-Number: 85977 Gerrit-PatchSet: 1 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/{volteer,brya,rex}: Disable 8254 timers by default
by Alicja Michalska (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Eric Lai, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85976?usp=email to look at the new patch set (#2). Change subject: mb/google/{volteer,brya,rex}: Disable 8254 timers by default ...................................................................... mb/google/{volteer,brya,rex}: Disable 8254 timers by default Upstream coreboot enables those timers if we're starting config from scratch, which results in builds with broken s0ix state on TGL/ADL/MTL. Disabling 8254 and PM timers is mandatory for functional s0ix. Change-Id: I61f617c65707b7e9113770162885fd13a13a1d67 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/rex/Kconfig M src/mainboard/google/volteer/Kconfig 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85976/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61f617c65707b7e9113770162885fd13a13a1d67 Gerrit-Change-Number: 85976 Gerrit-PatchSet: 2 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/google/{volteer,brya,rex}: Disable 8254 timers by default
by Alicja Michalska (Code Review) 14 Jan '25

14 Jan '25

Alicja Michalska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85976?usp=email ) Change subject: mb/google/{volteer,brya,rex}: Disable 8254 timers by default ...................................................................... mb/google/{volteer,brya,rex}: Disable 8254 timers by default Upstream coreboot enables those times if we're starting config from scratch, which results in builds with broken s0ix state on TGL/ADL/MTL. Disabling 8254 and PM timers is mandatory for functional s0ix. Change-Id: I61f617c65707b7e9113770162885fd13a13a1d67 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/rex/Kconfig M src/mainboard/google/volteer/Kconfig 3 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/85976/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index e4f563e..4c27f9c 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -1053,6 +1053,9 @@ config USE_PM_ACPI_TIMER default n +config USE_LEGACY_8254_TIMER + default n + config DEFAULT_ADL_NEM bool help diff --git a/src/mainboard/google/rex/Kconfig b/src/mainboard/google/rex/Kconfig index 73f28f3..44da8a5 100644 --- a/src/mainboard/google/rex/Kconfig +++ b/src/mainboard/google/rex/Kconfig @@ -273,6 +273,9 @@ config USE_PM_ACPI_TIMER default n +config USE_LEGACY_8254_TIMER + default n + config HAVE_SLP_S0_GATE def_bool n diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig index bc5ee6c..8523e90 100644 --- a/src/mainboard/google/volteer/Kconfig +++ b/src/mainboard/google/volteer/Kconfig @@ -246,4 +246,7 @@ config USE_PM_ACPI_TIMER default n +config USE_LEGACY_8254_TIMER + default n + endif # BOARD_GOOGLE_BASEBOARD_VOLTEER -- To view, visit https://review.coreboot.org/c/coreboot/+/85976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I61f617c65707b7e9113770162885fd13a13a1d67 Gerrit-Change-Number: 85976 Gerrit-PatchSet: 1 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Move common variants to respective files
by Paul Menzel (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Paul Menzel has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85945?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: ec/starlabs/merlin: Move common variants to respective files ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85945/comment/4056d1ba_2bba3c52?us… : PS2, Line 9: EC to One space. -- To view, visit https://review.coreboot.org/c/coreboot/+/85945?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Gerrit-Change-Number: 85945 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:55:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include battery ACPI for systems with a battery
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email ) Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery ...................................................................... Patch Set 10: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082 Gerrit-Change-Number: 85716 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:54:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025