coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: ec/starlabs/merlin: Move common variants to respective files
by Matt DeVillier (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85945?usp=email ) Change subject: ec/starlabs/merlin: Move common variants to respective files ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85945?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Gerrit-Change-Number: 85945 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:54:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: Documentation: Convert AMD-S3.txt to markdown
by Ana Carolina Cabral (Code Review) 14 Jan '25

14 Jan '25

Ana Carolina Cabral has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85543?usp=email ) Change subject: Documentation: Convert AMD-S3.txt to markdown ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I56647c9e2d96c3cdfbe0a870496bb892f6e0c6f7 Gerrit-Change-Number: 85543 Gerrit-PatchSet: 1 Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com> Gerrit-Reviewer: Ana Carolina Cabral Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:52:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Felix Held (Code Review) 14 Jan '25

14 Jan '25

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... soc/amd/glinda: Update PSP MBOX offset in Kconfig Glinda SoC PSP MBOX offset is 0x10970 & hence update the same in Kconfig TEST=Tested with Birman Plus and it solved the issue for psp timeout Before: [DEBUG] PSP: Notify SMM info... error: PSP command timeout After: [DEBUG] PSP: Notify SMM info... OK Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85627 Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/amd/glinda/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved diff --git a/src/soc/amd/glinda/Kconfig b/src/soc/amd/glinda/Kconfig index 68a1b6f..aa8c85e 100644 --- a/src/soc/amd/glinda/Kconfig +++ b/src/soc/amd/glinda/Kconfig @@ -380,6 +380,10 @@ help Add psp_verstage signature token to the build & PSP Directory Table +config PSPV2_MBOX_CMD_OFFSET + hex + default 0x10970 + endmenu config VBOOT -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 6 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Ana Carolina Cabral (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Felix Singer, Naresh Solanki. Ana Carolina Cabral has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) Change subject: soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85627/comment/d7889461_475b8738?us… : PS4, Line 7: src > We don't prefix with "src" for changes done in that area. Please remove. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:45:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Ana Carolina Cabral (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Ana Carolina Cabral, Naresh Solanki. Ana Carolina Cabral has uploaded a new patch set (#5) to the change originally created by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) Change subject: soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... soc/amd/glinda: Update PSP MBOX offset in Kconfig Glinda SoC PSP MBOX offset is 0x10970 & hence update the same in Kconfig TEST=Tested with Birman Plus and it solved the issue for psp timeout Before: [DEBUG] PSP: Notify SMM info... error: PSP command timeout After: [DEBUG] PSP: Notify SMM info... OK Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> --- M src/soc/amd/glinda/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/85627/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 5 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[S] Change in coreboot[main]: mb/*: Drop xhci_overcurrent_map I
by Keith Hui (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Alexander Couzens, Kevin Keijzer, Nicholas Chin, Paul Menzel. Keith Hui has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85923?usp=email ) Change subject: mb/*: Drop xhci_overcurrent_map I ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85923/comment/efc5d07d_dbbe3d3e?us… : PS3, Line 7: I > Depending on the font, it’s unclear if it’s a capital i or an l. Maybe write (part 1). Yes, it's Roman numeral 1. https://review.coreboot.org/c/coreboot/+/85923/comment/892c0ce0_e538fd22?us… : PS3, Line 12: > Was this tested on a board? Not yet. To test it on my p8z77-m later. -- To view, visit https://review.coreboot.org/c/coreboot/+/85923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36944e2f2ed265ee492019b75b7dd8b95ca26dbb Gerrit-Change-Number: 85923 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:39:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XS] Change in coreboot[main]: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Felix Singer (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Ana Carolina Cabral, Naresh Solanki. Felix Singer has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85627/comment/df4d9ec2_ad610e59?us… : PS4, Line 7: src We don't prefix with "src" for changes done in that area. Please remove. -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:39:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/*: Drop xhci_overcurrent_map I
by Paul Menzel (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Alexander Couzens, Keith Hui, Kevin Keijzer, Nicholas Chin. Paul Menzel has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85923?usp=email ) Change subject: mb/*: Drop xhci_overcurrent_map I ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85923/comment/17ed30fc_582d01de?us… : PS3, Line 7: I Depending on the font, it’s unclear if it’s a capital i or an l. Maybe write (part 1). https://review.coreboot.org/c/coreboot/+/85923/comment/51461692_4d018e27?us… : PS3, Line 12: Was this tested on a board? -- To view, visit https://review.coreboot.org/c/coreboot/+/85923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36944e2f2ed265ee492019b75b7dd8b95ca26dbb Gerrit-Change-Number: 85923 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:25:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Ana Carolina Cabral (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Naresh Solanki. Ana Carolina Cabral has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) Change subject: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85627/comment/a57c7d63_8b3c8a03?us… : PS3, Line 10: > since Ana tested this on birman+ with a glinda soc, it would be good to add the test result to this […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ana Carolina Cabral Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 12:23:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig
by Ana Carolina Cabral (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Naresh Solanki. Ana Carolina Cabral has uploaded a new patch set (#4) to the change originally created by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85627?usp=email ) Change subject: src/soc/amd/glinda: Update PSP MBOX offset in Kconfig ...................................................................... src/soc/amd/glinda: Update PSP MBOX offset in Kconfig Glinda SoC PSP MBOX offset is 0x10970 & hence update the same in Kconfig TEST=Tested with Birman Plus and it solved the issue for psp timeout Before: [DEBUG] PSP: Notify SMM info... error: PSP command timeout After: [DEBUG] PSP: Notify SMM info... OK Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Signed-off-by: Naresh Solanki <naresh.solanki(a)9elements.com> --- M src/soc/amd/glinda/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/85627/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I328959513228fe0f9e78070eb6b302ef89857b42 Gerrit-Change-Number: 85627 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025