coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Initialize PMIF for SD Card
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85969?usp=email ) Change subject: soc/mediatek/mt8196: Initialize PMIF for SD Card ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85969/comment/5dea04f4_937d3c2f?us… : PS2, Line 105: mt6373_init_pmif_arb(); > Do you think it'd be cleaner to move the call inside `mtk_msdc_configure_sdcard`? I'm fine either wa […] Calling it inside `mtk_msdc_configure_sdcard` makes sense to me. -- To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Gerrit-Change-Number: 85969 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 11:03:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek: Rename is_pmif_init_done to check_init_done
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85968?usp=email ) Change subject: soc/mediatek: Rename is_pmif_init_done to check_init_done ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85968/comment/2f416da3_fa648a08?us… : PS1, Line 7: pmif_check_init_done > check_init_done Done File src/soc/mediatek/common/include/soc/pmif_common.h: https://review.coreboot.org/c/coreboot/+/85968/comment/11bcb391_7193a0b7?us… : PS1, Line 37: pmif_check_init_done > Just `check_init_done`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Gerrit-Change-Number: 85968 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 11:02:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85967?usp=email ) Change subject: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85967/comment/7d801753_e94f8b75?us… : PS1, Line 7: Mitigatation for the second call to mtXXXX_init_pmif_arb > How about `Skip duplicate pmif_arb->is_pmif_init_done() call` Done File src/soc/mediatek/common/mt6685.c: https://review.coreboot.org/c/coreboot/+/85967/comment/be0c0c5a_40e5cd3b?us… : PS1, Line 86: if (!pmif_arb) { > remove Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Gerrit-Change-Number: 85967 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 11:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Initialize PMIF for SD Card
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85969?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek/mt8196: Initialize PMIF for SD Card ...................................................................... soc/mediatek/mt8196: Initialize PMIF for SD Card mt6373_init_pmif_arb() needs to be initialized for SD card to control the regulator. TEST=emrege-rauru coreboot TEST=The assertion is gone on Rauru during normal boot. Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/mt8196/msdc.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85969/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Gerrit-Change-Number: 85969 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek: Rename is_pmif_init_done to check_init_done
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85968?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek: Rename is_pmif_init_done to check_init_done ...................................................................... soc/mediatek: Rename is_pmif_init_done to check_init_done TEST=emerge-geralt coreboot && emerge-rauru coreboot Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/include/soc/pmif_common.h M src/soc/mediatek/common/mt6315.c M src/soc/mediatek/common/mt6316.c M src/soc/mediatek/common/mt6359p.c M src/soc/mediatek/common/mt6363.c M src/soc/mediatek/common/mt6373.c M src/soc/mediatek/common/mt6685.c M src/soc/mediatek/common/pmif_init.c M src/soc/mediatek/common/pmif_spmi.c M src/soc/mediatek/mt8196/pmif_init.c M src/soc/mediatek/mt8196/pmif_spmi.c 11 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/85968/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Gerrit-Change-Number: 85968 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Hello Hung-Te Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85967?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call ...................................................................... soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call Return to the caller immediately if pmif_arb has been initiailized. In this way, we can skip unnecessary check and reduce the access to the PMIF register. TEST=emerge-geralt coreboot && emerge-rauru coreboot Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/mt6315.c M src/soc/mediatek/common/mt6316.c M src/soc/mediatek/common/mt6359p.c M src/soc/mediatek/common/mt6363.c M src/soc/mediatek/common/mt6373.c M src/soc/mediatek/common/mt6685.c 6 files changed, 31 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/85967/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Gerrit-Change-Number: 85967 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Select more appropriate macros for USB ports
by Sean Rhodes (Code Review) 14 Jan '25

14 Jan '25

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85974?usp=email ) Change subject: mb/starlabs/starlite_adl: Select more appropriate macros for USB ports ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85974?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id193b3ed86c58aedc7d5a1f384f2829a2bf18671 Gerrit-Change-Number: 85974 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 14 Jan 2025 10:45:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Initialize PMIF for SD Card
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85969?usp=email ) Change subject: mb/google/rauru: Initialize PMIF for SD Card ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85969/comment/dc9c2df6_4ebe9e75?us… : PS2, Line 105: mt6373_init_pmif_arb(); Do you think it'd be cleaner to move the call inside `mtk_msdc_configure_sdcard`? I'm fine either way. -- To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Gerrit-Change-Number: 85969 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 09:47:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/mediatek: Rename is_pmif_init_done to pmif_check_init_done
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85968?usp=email ) Change subject: soc/mediatek: Rename is_pmif_init_done to pmif_check_init_done ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85968/comment/d6e49ca1_39e899eb?us… : PS1, Line 7: pmif_check_init_done check_init_done File src/soc/mediatek/common/include/soc/pmif_common.h: https://review.coreboot.org/c/coreboot/+/85968/comment/ed108543_b91f0555?us… : PS1, Line 37: pmif_check_init_done Just `check_init_done`? -- To view, visit https://review.coreboot.org/c/coreboot/+/85968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Gerrit-Change-Number: 85968 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 09:45:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/mediatek: Mitigatation for the second call to mtXXXX_init_pmif_arb
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85967?usp=email ) Change subject: soc/mediatek: Mitigatation for the second call to mtXXXX_init_pmif_arb ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85967/comment/2182c0a9_a8e1c894?us… : PS1, Line 7: Mitigatation for the second call to mtXXXX_init_pmif_arb How about `Skip duplicate pmif_arb->is_pmif_init_done() call` File src/soc/mediatek/common/mt6685.c: https://review.coreboot.org/c/coreboot/+/85967/comment/3008c4d2_cb169594?us… : PS1, Line 86: if (!pmif_arb) { remove -- To view, visit https://review.coreboot.org/c/coreboot/+/85967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Gerrit-Change-Number: 85967 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 09:44:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025