coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: qualcomm/common: Remove dead code
by Felix Singer (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Ariel Otilibili. Felix Singer has uploaded a new patch set (#3) to the change originally created by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85778?usp=email ) Change subject: qualcomm/common: Remove dead code ...................................................................... qualcomm/common: Remove dead code fb_off is set to zero, meaning the else branch is never called. Coverity-ID: 1469336 Fixes: 3b4c45efa2 ("sc7180: Add display hardware pipe line initialization") Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Signed-off-by: Ariel Otilibili <otilibil(a)eurecom.fr> --- M src/soc/qualcomm/common/display/mdss.c 1 file changed, 2 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/85778/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/85778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Gerrit-Change-Number: 85778 Gerrit-PatchSet: 3 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Ariel Otilibili

1 0

[XS] Change in coreboot[main]: qualcomm/common: Remove dead code
by Felix Singer (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Ariel Otilibili. Felix Singer has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85778?usp=email ) Change subject: qualcomm/common: Remove dead code ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85778/comment/8400daae_aa06d28a?us… : PS2, Line 13: Cc: Jonathon Hall <jonathon.hall(a)puri.sm> : Cc: Yidi Lin <yidilin(a)google.com> : Cc: Varshit Pandya <pandyavarshit(a)gmail.com> : Cc: Elyes Haouas <ehaouas(a)noos.fr> We usually don't list people added as CC to the commit message. Please don't add them in future commits. -- To view, visit https://review.coreboot.org/c/coreboot/+/85778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Gerrit-Change-Number: 85778 Gerrit-PatchSet: 2 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Tue, 14 Jan 2025 05:48:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/rauru: Enable firmware display
by Yidi Lin (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) Change subject: mb/google/rauru: Enable firmware display ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85952/comment/40d63862_f7e176e3?us… : PS1, Line 103: mt6373_init_pmif_arb(); > I'd prefer fixing SD card in a separate patch. […] Please review the patch chain CB:85967 -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 05:23:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Initialize PMIF for SD Card
by Yidi Lin (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85969?usp=email to look at the new patch set (#2). Change subject: mb/google/rauru: Initialize PMIF for SD Card ...................................................................... mb/google/rauru: Initialize PMIF for SD Card mt6373_init_pmif_arb() needs to be initialized for SD card to control the regulator. TEST=emrege-rauru coreboot TEST=The assertion is gone on Rauru during normal boot. Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/rauru/mainboard.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85969/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Gerrit-Change-Number: 85969 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/rauru: Initialize PMIF for SD Card
by Yidi Lin (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85969?usp=email ) Change subject: mb/google/rauru: Initialize PMIF for SD Card ...................................................................... mb/google/rauru: Initialize PMIF for SD Card mt6373_init_pmif_arb() needs to be initialized for SD card to control the regulator. TEST=emrege-rauru coreboot TEST=The assertion is gone on Rauru during normal boot. Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/mainboard/google/rauru/mainboard.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85969/1 diff --git a/src/mainboard/google/rauru/mainboard.c b/src/mainboard/google/rauru/mainboard.c index 817bcf2..aae81bc 100644 --- a/src/mainboard/google/rauru/mainboard.c +++ b/src/mainboard/google/rauru/mainboard.c @@ -9,6 +9,7 @@ #include <soc/dpm_v2.h> #include <soc/gpio_common.h> #include <soc/i2c.h> +#include <soc/mt6373.h> #include <soc/msdc.h> #include <soc/pcie.h> #include <soc/spm_common.h> @@ -100,8 +101,10 @@ power_on_fpmcu(); configure_audio(); - if (CONFIG(RAURU_SDCARD_INIT)) + if (CONFIG(RAURU_SDCARD_INIT)) { + mt6373_init_pmif_arb(); mtk_msdc_configure_sdcard(); + } if (dpm_init()) printk(BIOS_ERR, "dpm init failed, DVFS may not work\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Gerrit-Change-Number: 85969 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek: Rename is_pmif_init_done to pmif_check_init_done
by Yidi Lin (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85968?usp=email ) Change subject: soc/mediatek: Rename is_pmif_init_done to pmif_check_init_done ...................................................................... soc/mediatek: Rename is_pmif_init_done to pmif_check_init_done TEST=emerge-geralt coreboot && emerge-rauru coreboot Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/include/soc/pmif_common.h M src/soc/mediatek/common/mt6315.c M src/soc/mediatek/common/mt6316.c M src/soc/mediatek/common/mt6359p.c M src/soc/mediatek/common/mt6363.c M src/soc/mediatek/common/mt6373.c M src/soc/mediatek/common/mt6685.c M src/soc/mediatek/common/pmif_init.c M src/soc/mediatek/common/pmif_spmi.c M src/soc/mediatek/mt8196/pmif_init.c M src/soc/mediatek/mt8196/pmif_spmi.c 11 files changed, 17 insertions(+), 17 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/85968/1 diff --git a/src/soc/mediatek/common/include/soc/pmif_common.h b/src/soc/mediatek/common/include/soc/pmif_common.h index 949b34f..e9b3a21 100644 --- a/src/soc/mediatek/common/include/soc/pmif_common.h +++ b/src/soc/mediatek/common/include/soc/pmif_common.h @@ -34,7 +34,7 @@ void (*write16)(struct pmif *arb, u32 slvid, u32 reg, u16 data); u32 (*read_field)(struct pmif *arb, u32 slvid, u32 reg, u32 mask, u32 shift); void (*write_field)(struct pmif *arb, u32 slvid, u32 reg, u32 val, u32 mask, u32 shift); - int (*is_pmif_init_done)(struct pmif *arb); + int (*pmif_check_init_done)(struct pmif *arb); }; enum { diff --git a/src/soc/mediatek/common/mt6315.c b/src/soc/mediatek/common/mt6315.c index 266fb08..88a681b 100644 --- a/src/soc/mediatek/common/mt6315.c +++ b/src/soc/mediatek/common/mt6315.c @@ -93,7 +93,7 @@ die("ERROR: No spmi device"); } - if (pmif_arb->is_pmif_init_done(pmif_arb)) + if (pmif_arb->pmif_check_init_done(pmif_arb)) die("ERROR - Failed to initialize pmif spmi"); } diff --git a/src/soc/mediatek/common/mt6316.c b/src/soc/mediatek/common/mt6316.c index 5285294..d4aa0a9 100644 --- a/src/soc/mediatek/common/mt6316.c +++ b/src/soc/mediatek/common/mt6316.c @@ -179,7 +179,7 @@ assert(pmif_arb); } - if (pmif_arb->is_pmif_init_done(pmif_arb)) + if (pmif_arb->pmif_check_init_done(pmif_arb)) die("ERROR - Failed to initialize pmif spmi"); for (int i = 0; i < ARRAY_SIZE(mt6316_slave_id); i++) diff --git a/src/soc/mediatek/common/mt6359p.c b/src/soc/mediatek/common/mt6359p.c index 6a96fd3..574d270 100644 --- a/src/soc/mediatek/common/mt6359p.c +++ b/src/soc/mediatek/common/mt6359p.c @@ -340,7 +340,7 @@ die("ERROR: No spi device"); } - if (pmif_arb->is_pmif_init_done(pmif_arb)) + if (pmif_arb->pmif_check_init_done(pmif_arb)) die("ERROR - Failed to initialize pmif spi"); } diff --git a/src/soc/mediatek/common/mt6363.c b/src/soc/mediatek/common/mt6363.c index 608c855..4a92186 100644 --- a/src/soc/mediatek/common/mt6363.c +++ b/src/soc/mediatek/common/mt6363.c @@ -269,7 +269,7 @@ assert(pmif_arb); } - if (pmif_arb->is_pmif_init_done(pmif_arb)) + if (pmif_arb->pmif_check_init_done(pmif_arb)) die("ERROR - Failed to initialize pmif spi"); printk(BIOS_INFO, "[%s][MT6363]CHIP ID = 0x%x\n", __func__, diff --git a/src/soc/mediatek/common/mt6373.c b/src/soc/mediatek/common/mt6373.c index 94c7124..16864b88 100644 --- a/src/soc/mediatek/common/mt6373.c +++ b/src/soc/mediatek/common/mt6373.c @@ -249,7 +249,7 @@ assert(pmif_arb); } - if (pmif_arb->is_pmif_init_done(pmif_arb)) + if (pmif_arb->pmif_check_init_done(pmif_arb)) die("%s: initialization failed", __func__); printk(BIOS_INFO, "[%s][MT6373]CHIP ID = 0x%x\n", diff --git a/src/soc/mediatek/common/mt6685.c b/src/soc/mediatek/common/mt6685.c index abe8c33..8abaf50 100644 --- a/src/soc/mediatek/common/mt6685.c +++ b/src/soc/mediatek/common/mt6685.c @@ -88,7 +88,7 @@ assert(pmif_arb); } - if (pmif_arb->is_pmif_init_done(pmif_arb)) + if (pmif_arb->pmif_check_init_done(pmif_arb)) die("ERROR - Failed to initialize pmif spi"); printk(BIOS_INFO, "[%s]CHIP ID = %#x\n", __func__, mt6685_read_field(0xb, 0xFF, 0)); diff --git a/src/soc/mediatek/common/pmif_init.c b/src/soc/mediatek/common/pmif_init.c index 73b22cf..f335d7e 100644 --- a/src/soc/mediatek/common/pmif_init.c +++ b/src/soc/mediatek/common/pmif_init.c @@ -17,7 +17,7 @@ .read = pmif_spmi_read, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, - .is_pmif_init_done = pmif_check_init_done, + .pmif_check_init_done = pmif_check_init_done, }, }; @@ -32,7 +32,7 @@ .read = pmif_spi_read, .write_field = pmif_spi_write_field, .read_field = pmif_spi_read_field, - .is_pmif_init_done = pmif_check_init_done, + .pmif_check_init_done = pmif_check_init_done, }, }; diff --git a/src/soc/mediatek/common/pmif_spmi.c b/src/soc/mediatek/common/pmif_spmi.c index 7263ff2..939b16d 100644 --- a/src/soc/mediatek/common/pmif_spmi.c +++ b/src/soc/mediatek/common/pmif_spmi.c @@ -152,12 +152,12 @@ int pmif_spmi_init(struct pmif *arb) { - if (arb->is_pmif_init_done(arb) != 0) { + if (arb->pmif_check_init_done(arb) != 0) { pmif_spmi_force_normal_mode(arb); pmif_spmi_enable_swinf(arb); pmif_spmi_enable_cmdIssue(arb, true); pmif_spmi_enable(arb); - if (arb->is_pmif_init_done(arb)) + if (arb->pmif_check_init_done(arb)) return -E_NODEV; } diff --git a/src/soc/mediatek/mt8196/pmif_init.c b/src/soc/mediatek/mt8196/pmif_init.c index 0baf720..a6d83008 100644 --- a/src/soc/mediatek/mt8196/pmif_init.c +++ b/src/soc/mediatek/mt8196/pmif_init.c @@ -24,7 +24,7 @@ .read16 = pmif_spmi_read16, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, - .is_pmif_init_done = pmif_check_init_done, + .pmif_check_init_done = pmif_check_init_done, }, { .mtk_pmif = (struct mtk_pmif_regs *)PMIF_SPMI_BASE, .ch = (struct chan_regs *)PMIF_SPMI_AP_CHAN, @@ -36,7 +36,7 @@ .read16 = pmif_spmi_read16, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, - .is_pmif_init_done = pmif_check_init_done, + .pmif_check_init_done = pmif_check_init_done, }, { .mtk_pmif = (struct mtk_pmif_regs *)PMIF_SPMI_P_BASE, .ch = (struct chan_regs *)PMIF_SPMI_AP_CHAN_P, @@ -48,7 +48,7 @@ .read16 = pmif_spmi_read16, .write_field = pmif_spmi_write_field, .read_field = pmif_spmi_read_field, - .is_pmif_init_done = pmif_check_init_done, + .pmif_check_init_done = pmif_check_init_done, }, }; @@ -63,7 +63,7 @@ .read = pmif_spi_read, .write_field = pmif_spi_write_field, .read_field = pmif_spi_read_field, - .is_pmif_init_done = pmif_check_init_done, + .pmif_check_init_done = pmif_check_init_done, }, }; diff --git a/src/soc/mediatek/mt8196/pmif_spmi.c b/src/soc/mediatek/mt8196/pmif_spmi.c index e646816..6aeecae 100644 --- a/src/soc/mediatek/mt8196/pmif_spmi.c +++ b/src/soc/mediatek/mt8196/pmif_spmi.c @@ -337,12 +337,12 @@ int pmif_spmi_init(struct pmif *arb) { - if (arb->is_pmif_init_done(arb) != 0) { + if (arb->pmif_check_init_done(arb) != 0) { pmif_spmi_force_normal_mode(arb); pmif_spmi_enable_swinf(arb); pmif_spmi_enable_cmd_issue(arb, true); pmif_spmi_enable(arb); - if (arb->is_pmif_init_done(arb)) + if (arb->pmif_check_init_done(arb)) return -E_NODEV; } -- To view, visit https://review.coreboot.org/c/coreboot/+/85968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Gerrit-Change-Number: 85968 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: soc/mediatek: Mitigatation for the second call to mtXXXX_init_pmif_arb
by Yidi Lin (Code Review) 13 Jan '25

13 Jan '25

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85967?usp=email ) Change subject: soc/mediatek: Mitigatation for the second call to mtXXXX_init_pmif_arb ...................................................................... soc/mediatek: Mitigatation for the second call to mtXXXX_init_pmif_arb Return to the caller immediately if pmif_arb has been initiailized. In this way, we can skip unnecessary check and reduce the access to the PMIF register. TEST=emerge-geralt coreboot && emerge-rauru coreboot Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M src/soc/mediatek/common/mt6315.c M src/soc/mediatek/common/mt6316.c M src/soc/mediatek/common/mt6359p.c M src/soc/mediatek/common/mt6363.c M src/soc/mediatek/common/mt6373.c M src/soc/mediatek/common/mt6685.c 6 files changed, 18 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/85967/1 diff --git a/src/soc/mediatek/common/mt6315.c b/src/soc/mediatek/common/mt6315.c index aebbd4c..266fb08 100644 --- a/src/soc/mediatek/common/mt6315.c +++ b/src/soc/mediatek/common/mt6315.c @@ -84,6 +84,9 @@ static void init_pmif_arb(void) { + if (pmif_arb) + return; + if (!pmif_arb) { pmif_arb = get_pmif_controller(PMIF_SPMI, 0); if (!pmif_arb) diff --git a/src/soc/mediatek/common/mt6316.c b/src/soc/mediatek/common/mt6316.c index 797ae3e..5285294 100644 --- a/src/soc/mediatek/common/mt6316.c +++ b/src/soc/mediatek/common/mt6316.c @@ -171,6 +171,9 @@ static void init_pmif_arb(void) { + if (pmif_arb) + return; + if (!pmif_arb) { pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_0); assert(pmif_arb); diff --git a/src/soc/mediatek/common/mt6359p.c b/src/soc/mediatek/common/mt6359p.c index e766479..6a96fd3 100644 --- a/src/soc/mediatek/common/mt6359p.c +++ b/src/soc/mediatek/common/mt6359p.c @@ -331,6 +331,9 @@ void mt6359p_init_pmif_arb(void) { + if (pmif_arb) + return; + if (!pmif_arb) { pmif_arb = get_pmif_controller(PMIF_SPI, 0); if (!pmif_arb) diff --git a/src/soc/mediatek/common/mt6363.c b/src/soc/mediatek/common/mt6363.c index a618b6f..608c855 100644 --- a/src/soc/mediatek/common/mt6363.c +++ b/src/soc/mediatek/common/mt6363.c @@ -261,6 +261,9 @@ void mt6363_init_pmif_arb(void) { + if (pmif_arb) + return; + if (!pmif_arb) { pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); assert(pmif_arb); diff --git a/src/soc/mediatek/common/mt6373.c b/src/soc/mediatek/common/mt6373.c index 1d5e1e2..94c7124 100644 --- a/src/soc/mediatek/common/mt6373.c +++ b/src/soc/mediatek/common/mt6373.c @@ -241,6 +241,9 @@ void mt6373_init_pmif_arb(void) { + if (pmif_arb) + return; + if (!pmif_arb) { pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); assert(pmif_arb); diff --git a/src/soc/mediatek/common/mt6685.c b/src/soc/mediatek/common/mt6685.c index fa434f4..abe8c33 100644 --- a/src/soc/mediatek/common/mt6685.c +++ b/src/soc/mediatek/common/mt6685.c @@ -80,6 +80,9 @@ void mt6685_init_pmif_arb(void) { + if (pmif_arb) + return; + if (!pmif_arb) { pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); assert(pmif_arb); -- To view, visit https://review.coreboot.org/c/coreboot/+/85967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Gerrit-Change-Number: 85967 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/rauru: Enable firmware display
by Yu-Ping Wu (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) Change subject: mb/google/rauru: Enable firmware display ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85952/comment/1c7a9cb1_c07a4d84?us… : PS1, Line 103: mt6373_init_pmif_arb(); > @yupingso@google. […] I'd prefer fixing SD card in a separate patch. And I think it should be fine to call `mt6373_init_pmif_arb()` twice (once here and the other in `if (CONFIG(RAURU_SDCARD_INIT))`), as the extra `pmif_check_init_done` overhead should be pretty small. That said, I think a better approach is to modify all `mtXXXX_init_pmif_arb`, so that a second call to it would be a no-op. For example: ``` void mt6373_init_pmif_arb(void) { if (pmif_arb) return; pmif_arb = get_pmif_controller(PMIF_SPMI, SPMI_MASTER_1); assert(pmif_arb); // BTW we should rename this to pmif_check_init_done if (pmif_arb->is_pmif_init_done(pmif_arb)) ... printk(...); } ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:33:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Modify the felino config for probing TPM...
by Subrata Banik (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Pranava Y N, Tongtong Pan, Weimin Wu. Subrata Banik has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/85965?usp=email ) Change subject: mb/google/fatcat/var/felino: Modify the felino config for probing TPM I2C ...................................................................... Patch Set 1: (4 comments) File src/mainboard/google/fatcat/variants/felino/gpio.c: https://review.coreboot.org/c/coreboot/+/85965/comment/a18f7542_405bb91e?us… : PS1, Line 281: PAD_CFG_GPI_APIC locking make sense for ramstage but I won't lock a PAD with interrupt configuration https://review.coreboot.org/c/coreboot/+/85965/comment/66d1fa9c_783a43b8?us… : PS1, Line 407: PAD_CFG_GPI_APIC_LOCK please don't use lock macro for early GPIO configuration https://review.coreboot.org/c/coreboot/+/85965/comment/b6be1756_fb888357?us… : PS1, Line 422: PAD_CFG_GPI_APIC_LOCK same as above File src/mainboard/google/fatcat/variants/felino/overridetree.cb: https://review.coreboot.org/c/coreboot/+/85965/comment/96123611_660afff1?us… : PS1, Line 50: register "serial_io_i2c_mode" = "{ : [PchSerialIoIndexI2C0] = PchSerialIoPci, : [PchSerialIoIndexI2C1] = PchSerialIoPci, : [PchSerialIoIndexI2C4] = PchSerialIoPci, : }" looking at the below description I2C0 seems unused ? is this required to be enabled for making i2c1 functional or you have any endpoint device at i2c0 as well ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85965?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I093c0bad181f133e601f3270de68c0848f847ccf Gerrit-Change-Number: 85965 Gerrit-PatchSet: 1 Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add eDP driver
by Yu-Ping Wu (Code Review) 13 Jan '25

13 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85949?usp=email ) Change subject: soc/mediatek/mt8196: Add eDP driver ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/mt8196/dptx.c: https://review.coreboot.org/c/coreboot/+/85949/comment/f5dde1f5_7bc31cc7?us… : PS2, Line 348: static void dptx_init_port(struct mtk_dp *mtk_dp) > I will revise it until MTK resolves all the comments. […] Feel free to resolve this comment first. I'm fine with merging this patch with the current `dptx_init_port`. -- To view, visit https://review.coreboot.org/c/coreboot/+/85949?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iccba53f6c6181ca84624c216f9641a2ae9041671 Gerrit-Change-Number: 85949 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025