coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Drop UFC/WFC GPIO programming
by Subrata Banik (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Kapil Porwal, Pranava Y N. Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85955?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Drop UFC/WFC GPIO programming ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85955/comment/ec382a28_07126206?us… : PS1, Line 7: Skip > remove or drop? Drop is more meaningful here -- To view, visit https://review.coreboot.org/c/coreboot/+/85955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae984a2ab6f797af450166c90f4a2c6d3e0e1caa Gerrit-Change-Number: 85955 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:20:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Drop UFC/WFC GPIO programming
by Subrata Banik (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik. Hello Eric Lai, Kapil Porwal, Pranava Y N, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85955?usp=email to look at the new patch set (#2). Change subject: mb/google/fatcat/var/fatcat: Drop UFC/WFC GPIO programming ...................................................................... mb/google/fatcat/var/fatcat: Drop UFC/WFC GPIO programming Skip UFC/WFC GPIO programming for power-on and clock configuration. Clock configuration is now handled by native-function in ramstage, and there is no need to power-on the camera module early in the boot phase. Doing so resulted in the privacy LED being turned on during the entire boot process, which is unnecessary. BUG=b:381044394 TEST=No privacy LED blinking seen while booting google/fatcat. Change-Id: Iae984a2ab6f797af450166c90f4a2c6d3e0e1caa Signed-off-by: Subrata Banik <subratabanik(a)google.com> --- M src/mainboard/google/fatcat/variants/fatcat/fw_config.c M src/mainboard/google/fatcat/variants/fatcat/gpio.c 2 files changed, 0 insertions(+), 60 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/85955/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae984a2ab6f797af450166c90f4a2c6d3e0e1caa Gerrit-Change-Number: 85955 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/rauru: Enable firmware display
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yu-Ping Wu. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) Change subject: mb/google/rauru: Enable firmware display ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85952/comment/fd593e72_290ea7a5?us… : PS1, Line 103: mt6373_init_pmif_arb(); > SD card actually needs `mt6373_init_pmif_arb` for the regulator enablement. […] @yupingso@google.com -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:05:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add eDP driver
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85949?usp=email ) Change subject: soc/mediatek/mt8196: Add eDP driver ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/mt8196/dptx.c: https://review.coreboot.org/c/coreboot/+/85949/comment/9e9fdd62_9f3405f5?us… : PS2, Line 348: static void dptx_init_port(struct mtk_dp *mtk_dp) > @yidilin@google.com […] I will revise it until MTK resolves all the comments. We probably could also move `mtk_edp_init` to `dptx_common.c`. -- To view, visit https://review.coreboot.org/c/coreboot/+/85949?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iccba53f6c6181ca84624c216f9641a2ae9041671 Gerrit-Change-Number: 85949 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 04:05:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: qualcomm/common: Remove dead code
by Yidi Lin (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Ariel Otilibili. Yidi Lin has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85778?usp=email ) Change subject: qualcomm/common: Remove dead code ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85778?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I40cffcf3714decfc54f2bbce9d4a867a9313d72e Gerrit-Change-Number: 85778 Gerrit-PatchSet: 2 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Tue, 14 Jan 2025 04:02:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/lotso: Update gpio setting
by Jian Tong (Code Review) 14 Jan '25

14 Jan '25

Jian Tong has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85966?usp=email ) Change subject: mb/google/brox/var/lotso: Update gpio setting ...................................................................... mb/google/brox/var/lotso: Update gpio setting For edge trigger,the default is "rising edge"(invert=0), and it needs to "invert" (invert=1) for falling edge. BUG=b:359437265 TEST=emerge-brox coreboot chromeos-bootimage oscilloscope measurement interrupt is triggered by falling edge Change-Id: I132b43fd552d2babfbcd497bc6a017f354c69e10 Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/66/85966/1 diff --git a/src/mainboard/google/brox/variants/lotso/gpio.c b/src/mainboard/google/brox/variants/lotso/gpio.c index d5abe8c..ca1eaa8 100644 --- a/src/mainboard/google/brox/variants/lotso/gpio.c +++ b/src/mainboard/google/brox/variants/lotso/gpio.c @@ -57,6 +57,8 @@ /* GPP_F16 : [NF1: GSXCLK NF3: THC1_SPI2_CS# NF4: GSPI1_CS0# * NF6: USB_C_GPP_F16] ==> GSPI1_SOC_TCHSCR_CS_L */ PAD_CFG_NF_LOCK(GPP_F16, NONE, NF4, LOCK_CONFIG), + /* GPP_F18 : [NF3: THC1_SPI2_INT# NF6: USB_C_GPP_F18] ==> TCHSCR_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_F18, NONE, DEEP, EDGE_SINGLE, INVERT), /* GPP_S4 : SNDW2_CLK/DMIC_CLK_B0 ==> MEM_STRAP_0 */ PAD_CFG_GPI(GPP_S4, NONE, PLTRST), /* GPP_S5 : SNDW2_DATA/DMIC_CLK_B1 ==> MEM_STRAP_1 */ @@ -65,8 +67,6 @@ PAD_CFG_GPI(GPP_S6, NONE, PLTRST), /* GPP_S7 : SNDW3_DATA/DMIC_DATA1 ==> MEM_STRAP_3 */ PAD_CFG_GPI(GPP_S7, NONE, PLTRST), - /* GPP_F18 : [NF3: THC1_SPI2_INT# NF6: USB_C_GPP_F18] ==> TCHSCR_INT_ODL */ - PAD_CFG_GPI_APIC(GPP_F18, NONE, DEEP, EDGE_SINGLE, NONE), }; -- To view, visit https://review.coreboot.org/c/coreboot/+/85966?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I132b43fd552d2babfbcd497bc6a017f354c69e10 Gerrit-Change-Number: 85966 Gerrit-PatchSet: 1 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/felino: Modify the felino config for probing TPM...
by Tongtong Pan (Code Review) 14 Jan '25

14 Jan '25

Tongtong Pan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85965?usp=email ) Change subject: mb/google/fatcat/var/felino: Modify the felino config for probing TPM I2C ...................................................................... mb/google/fatcat/var/felino: Modify the felino config for probing TPM I2C Modify the configuration to detect TPM I2C correctly. BUG=b:388982526 TEST=abuild -v -a -x -c max -p none -t google/fatcat -b felino Change-Id: I093c0bad181f133e601f3270de68c0848f847ccf Signed-off-by: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/fatcat/Kconfig M src/mainboard/google/fatcat/variants/felino/gpio.c M src/mainboard/google/fatcat/variants/felino/overridetree.cb 3 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/85965/1 diff --git a/src/mainboard/google/fatcat/Kconfig b/src/mainboard/google/fatcat/Kconfig index 37ba330..c5d235c 100644 --- a/src/mainboard/google/fatcat/Kconfig +++ b/src/mainboard/google/fatcat/Kconfig @@ -116,6 +116,7 @@ hex default 0x03 if BOARD_GOOGLE_MODEL_FATCAT default 0x01 if BOARD_GOOGLE_FRANCKA + default 0x01 if BOARD_GOOGLE_FELINO config FMDFILE default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/chromeos-debug-fsp.fmd" if CHROMEOS && BUILDING_WITH_DEBUG_FSP diff --git a/src/mainboard/google/fatcat/variants/felino/gpio.c b/src/mainboard/google/fatcat/variants/felino/gpio.c index 645746f..b91350f 100644 --- a/src/mainboard/google/fatcat/variants/felino/gpio.c +++ b/src/mainboard/google/fatcat/variants/felino/gpio.c @@ -278,7 +278,7 @@ /* GPP_F14: NC */ PAD_NC(GPP_F14, NONE), /* GPP_F15: GSC_PCH_INT_ODL */ - PAD_CFG_NF(GPP_F15, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC(GPP_F15, NONE, PLTRST, LEVEL, INVERT), /* GPP_F16: NC */ PAD_NC(GPP_F16, NONE), /* GPP_F17: NC */ @@ -399,12 +399,12 @@ /* GPP_H09: UART0_BUF_TXD */ PAD_CFG_NF(GPP_H09, NONE, DEEP, NF1), - /* GPP_H06: I2C3_SDA_PSS */ - PAD_CFG_NF(GPP_H06, NONE, DEEP, NF1), - /* GPP_H07: I2C3_SCL_PSS */ - PAD_CFG_NF(GPP_H07, NONE, DEEP, NF1), - /* GPP_D15: SPI_TPM_INT_N */ - PAD_CFG_GPI_APIC(GPP_D15, NONE, PLTRST, LEVEL, INVERT), + /* GPP_H21: PCH_I2C_GSC_SDA */ + PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1), + /* GPP_H22: PCH_I2C_GSC_SCL */ + PAD_CFG_NF(GPP_H22, NONE, DEEP, NF1), + /* GPP_F15: SPI_TPM_INT_N */ + PAD_CFG_GPI_APIC_LOCK(GPP_F15, NONE, LEVEL, INVERT, LOCK_CONFIG), }; /* Pad configuration in romstage */ @@ -413,6 +413,13 @@ PAD_CFG_NF(GPP_C03, NONE, DEEP, NF1), /* GPP_C04: GPP_C0_SMBDATA */ PAD_CFG_NF(GPP_C04, NONE, DEEP, NF1), + + /* GPP_H21: PCH_I2C_GSC_SDA */ + PAD_CFG_NF(GPP_H21, NONE, DEEP, NF1), + /* GPP_H22: PCH_I2C_GSC_SCL */ + PAD_CFG_NF(GPP_H22, NONE, DEEP, NF1), + /* GPP_F15: SPI_TPM_INT_N */ + PAD_CFG_GPI_APIC_LOCK(GPP_F15, NONE, LEVEL, INVERT, LOCK_CONFIG), }; const struct pad_config *variant_gpio_table(size_t *num) diff --git a/src/mainboard/google/fatcat/variants/felino/overridetree.cb b/src/mainboard/google/fatcat/variants/felino/overridetree.cb index 1f3d07b..28072d5 100644 --- a/src/mainboard/google/fatcat/variants/felino/overridetree.cb +++ b/src/mainboard/google/fatcat/variants/felino/overridetree.cb @@ -47,6 +47,12 @@ [DDI_PORT_A] = DDI_ENABLE_HPD, }" + register "serial_io_i2c_mode" = "{ + [PchSerialIoIndexI2C0] = PchSerialIoPci, + [PchSerialIoIndexI2C1] = PchSerialIoPci, + [PchSerialIoIndexI2C4] = PchSerialIoPci, + }" + # Intel Common SoC Config #+-------------------+---------------------------+ #| Field | Value | -- To view, visit https://review.coreboot.org/c/coreboot/+/85965?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I093c0bad181f133e601f3270de68c0848f847ccf Gerrit-Change-Number: 85965 Gerrit-PatchSet: 1 Gerrit-Owner: Tongtong Pan <pantongtong(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: commonlib/device_tree: Return cells properties of parent node
by Julius Werner (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Douglas Anderson, Yu-Ping Wu. Hello Douglas Anderson, Yu-Ping Wu, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/85964?usp=email to review the following change. Change subject: commonlib/device_tree: Return cells properties of parent node ...................................................................... commonlib/device_tree: Return cells properties of parent node In Flattened Device Trees, there exist special properties called `#address-cells` and `#size-cells` that determine how large addresses and sizes in `reg` properties are. According to the FDT specification, each `reg` node cares about the `...cells` property in the _parent_ of its node. Our current implementation looks for those properties in the node it finds and returns, which would presumably be the node with the `reg` property itself. Therefore, we're returning the wrong `...cells` values. This isn't really a problem in practice because we also allow inheriting these properties from the parent when they don't exist in the child, and nodes that contain `reg` properties usually don't contain `...cells` properties themselves (because those properties would be incorrect and useless there), so we usually just end up falling back to the (correct) value we inherited from the parent. But it's still better to just fix the mistake, and if we ever happen to have a situation where the node containing the `reg` property still has children that require different `...cells` values as well, it could make a difference. (The fact that we're inheriting these properties is also technically incorrect according to the spec, but we're doing that intentionally to match behavior in the Linux kernel.) This issue was already correctly implemented in the recently added fdt_find_node(), and this patch also fixes it in the older dt_find_node(). Change-Id: I323066477a4d4be17225e0915a81ce2ff39c1e40 Signed-off-by: Julius Werner <jwerner(a)chromium.org> --- M src/commonlib/device_tree.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/85964/1 diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c index b2daac9..001633b 100644 --- a/src/commonlib/device_tree.c +++ b/src/commonlib/device_tree.c @@ -1059,12 +1059,13 @@ { struct device_tree_node *node, *found = NULL; - /* Update #address-cells and #size-cells for this level. */ - dt_read_cell_props(parent, addrcp, sizecp); - if (!*path) return parent; + /* Update #address-cells and #size-cells for the parent level (cells + properties always count for the direct children of their node) . */ + dt_read_cell_props(parent, addrcp, sizecp); + /* Find the next node in the path, if it exists. */ list_for_each(node, parent->children, list_node) { if (!strcmp(node->name, *path)) { -- To view, visit https://review.coreboot.org/c/coreboot/+/85964?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I323066477a4d4be17225e0915a81ce2ff39c1e40 Gerrit-Change-Number: 85964 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Douglas Anderson <dianders(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Refactor GPIO programming for UFS support
by Eric Lai (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik. Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85958?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Refactor GPIO programming for UFS support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85958?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I09331d75501977d89592d1a70d5b0dca271f8747 Gerrit-Change-Number: 85958 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 02:09:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/google/fatcat/var/fatcat: Skip UFC/WFC GPIO programming
by Eric Lai (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Kapil Porwal, Pranava Y N, Subrata Banik. Eric Lai has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85955?usp=email ) Change subject: mb/google/fatcat/var/fatcat: Skip UFC/WFC GPIO programming ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85955/comment/4e03df54_473921b0?us… : PS1, Line 7: Skip remove or drop? -- To view, visit https://review.coreboot.org/c/coreboot/+/85955?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iae984a2ab6f797af450166c90f4a2c6d3e0e1caa Gerrit-Change-Number: 85955 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 02:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025