coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: commonlib/device_tree: Return cells properties of parent node
by Douglas Anderson (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Julius Werner, Yu-Ping Wu. Douglas Anderson has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/85964?usp=email ) Change subject: commonlib/device_tree: Return cells properties of parent node ...................................................................... Patch Set 1: (1 comment) File src/commonlib/device_tree.c: https://review.coreboot.org/c/coreboot/+/85964/comment/4738e88e_20346c4f?us… : PS1, Line 1061: It worries me at least slightly that if a caller directly calls the base case (AKA path points to an array that is just [NULL]) that `addrcp` and `sizecp` will never be filled in. Does this ever happen? Is it worth adding a wrapper to ensure that someone directly calls the function with the base case that `addrcp` and `sizecp` are NULL, otherwise we return an error (or at least print a warning?) Even better would be if we could somehow reach into our parent and read the properties from there, but looks like this structure doesn't have pointers back to the parent... ...or maybe this doesn't matter since the caller would need to handle someone forgetting `#address-cells` and `#size-cells` anyway? -- To view, visit https://review.coreboot.org/c/coreboot/+/85964?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I323066477a4d4be17225e0915a81ce2ff39c1e40 Gerrit-Change-Number: 85964 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:12:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8196: Initialize PMIF for SD Card
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85969?usp=email ) Change subject: soc/mediatek/mt8196: Initialize PMIF for SD Card ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85969?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7e3265bb62a6c78d44e2c756be9a020a49a03056 Gerrit-Change-Number: 85969 Gerrit-PatchSet: 3 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:45:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/mediatek: Rename is_pmif_init_done to check_init_done
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85968?usp=email ) Change subject: soc/mediatek: Rename is_pmif_init_done to check_init_done ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85968?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib4b9a7969f5af6e001c5b491ec09a43e1289a6ae Gerrit-Change-Number: 85968 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:44:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/85967?usp=email ) Change subject: soc/mediatek: Skip duplicate pmif_arb->is_pmif_init_done() call ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85967?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id1d11f8b238855edb393d77151159792e7716d22 Gerrit-Change-Number: 85967 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:43:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Initialize MCUPM
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, agogo. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85888?usp=email ) Change subject: soc/mediatek/mt8196: Initialize MCUPM ...................................................................... Patch Set 6: Code-Review+2 (1 comment) File src/soc/mediatek/mt8196/Kconfig: https://review.coreboot.org/c/coreboot/+/85888/comment/f91ac5fe_3de1570d?us… : PS5, Line 64: The file name of the MediaTek MCUPM firmware. > This is not necessary, config just specifies mcupm bin file name Paul, please see the MCUPM README in https://review.coreboot.org/c/blobs/+/84029/5/soc/mediatek/mt8196/README.md. -- To view, visit https://review.coreboot.org/c/coreboot/+/85888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I223f245d384f32d54f6170a28b29573638f77296 Gerrit-Change-Number: 85888 Gerrit-PatchSet: 6 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: agogo <agogo.huang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: agogo <agogo.huang(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: agogo <agogo.huang(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[S] Change in coreboot[main]: mb/google/rauru: Enable firmware display
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

1 0

[S] Change in coreboot[main]: mb/google/rauru: Enable firmware display
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) Change subject: mb/google/rauru: Enable firmware display ...................................................................... Patch Set 3: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85952/comment/1056d57d_0e656a55?us… : PS3, Line 9: mt8196 rauru https://review.coreboot.org/c/coreboot/+/85952/comment/7d518c2a_1565b77f?us… : PS3, Line 9: Enable mt8196 firmware display support. > What needs to be done to enable the display? Please explain what `mt6373_set_vcn33_3_voltage` is for in the commit message. https://review.coreboot.org/c/coreboot/+/85952/comment/5429a4b4_3808be17?us… : PS3, Line 11: TEST=Build pass, the firmware screen displays correctly. > In a normal boot, it’s skipped, and the Linux kernel initializes the display, correct? Correct. File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85952/comment/657c36c5_2c1ed8cd?us… : PS3, Line 107: else Add {} -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:30:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add display driver
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

1 0

[M] Change in coreboot[main]: mb/google/rauru: Add edp driver in mainboard
by Yu-Ping Wu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email ) Change subject: mb/google/rauru: Add edp driver in mainboard ...................................................................... Patch Set 2: (5 comments) File src/mainboard/google/rauru/chromeos.c: https://review.coreboot.org/c/coreboot/+/85951/comment/98991136_feef385b?us… : PS2, Line 60: struct lb_gpio edp_pwm_gpios[] = { : {GPIO_BL_PWM_1V8.id, ACTIVE_HIGH, -1, "PWM control"}, : }; : lb_add_gpios(gpios, edp_pwm_gpios, ARRAY_SIZE(edp_pwm_gpios)); : struct lb_gpio backlight_gpios[] = { : {GPIO_AP_EDP_BKLTEN.id, ACTIVE_HIGH, -1, "backlight enable"}, : }; Use a single array. File src/mainboard/google/rauru/devicetree.cb: https://review.coreboot.org/c/coreboot/+/85951/comment/7f335bde_3aa72ace?us… : PS2, Line 12: Panel PANEL File src/mainboard/google/rauru/panel.c: https://review.coreboot.org/c/coreboot/+/85951/comment/a823755e_c9025367?us… : PS2, Line 39: Panel PANEL File src/mainboard/google/rauru/panel_navi.c: PS2: Rename to panel_oled.c, and rename `get_navi_description` to `get_oled_description`. Alternatively, I'm fine with merging the content into panel.c. @yidilin@google.com? https://review.coreboot.org/c/coreboot/+/85951/comment/bde7c542_f37fc1b7?us… : PS2, Line 15: struct panel_description *get_navi_description(void); Move to panel.h. -- To view, visit https://review.coreboot.org/c/coreboot/+/85951?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea610c97351beb94a49cc1044701a523b7c85a6e Gerrit-Change-Number: 85951 Gerrit-PatchSet: 2 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:23:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/amd/birman_plus: Kconfig
by Martin Roth (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Ana Carolina Cabral, Felix Held. Martin Roth has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85493?usp=email ) Change subject: mb/amd/birman_plus: Kconfig ...................................................................... Patch Set 8: (1 comment) File src/mainboard/amd/birman_plus/port_descriptors_glinda.c: https://review.coreboot.org/c/coreboot/+/85493/comment/476a48be_6c0c395d?us… : PS8, Line 56: true !CONFIG(DISABLE_WWAN_BIRMANPLUS) ? same for wlan... -- To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4 Gerrit-Change-Number: 85493 Gerrit-PatchSet: 8 Gerrit-Owner: Ana Carolina Cabral Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Ana Carolina Cabral Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 14 Jan 2025 16:15:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025