Attention is currently required from: Elyes Haouas, Martin L Roth.
Elyes Haouas has uploaded a new patch set (#10) to the change originally created by Felix Singer. ( https://review.coreboot.org/c/coreboot/+/85169?usp=email )
Change subject: util/crossgcc: Update LLVM from 18.1.8 to 19.1.7
......................................................................
util/crossgcc: Update LLVM from 18.1.8 to 19.1.7
Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M util/crossgcc/buildgcc
R util/crossgcc/patches/clang-19.1.7.src_x86_baremetal.patch
D util/crossgcc/sum/clang-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/clang-19.1.7.src.tar.xz.cksum
D util/crossgcc/sum/clang-tools-extra-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/clang-tools-extra-19.1.7.src.tar.xz.cksum
D util/crossgcc/sum/cmake-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/cmake-19.1.7.src.tar.xz.cksum
D util/crossgcc/sum/compiler-rt-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/compiler-rt-19.1.7.src.tar.xz.cksum
D util/crossgcc/sum/libunwind-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/libunwind-19.1.7.src.tar.xz.cksum
D util/crossgcc/sum/lld-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/lld-19.1.7.src.tar.xz.cksum
D util/crossgcc/sum/llvm-18.1.8.src.tar.xz.cksum
A util/crossgcc/sum/llvm-19.1.7.src.tar.xz.cksum
16 files changed, 8 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/85169/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/85169?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4a392b472b7450685343e1343c7b84c78b0cad3d
Gerrit-Change-Number: 85169
Gerrit-PatchSet: 10
Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Sean Rhodes.
Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85701?usp=email )
Change subject: mb/starlabs/starlite: Add smart battery variant
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85701?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1e04ea26ef597ce542a7348982d056fb55de0d22
Gerrit-Change-Number: 85701
Gerrit-PatchSet: 9
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:26:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Matt DeVillier, Paul Menzel.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85714?usp=email
to look at the new patch set (#22).
Change subject: mb/starlabs/starbook: Add Alder Lake N (N200) variant
......................................................................
mb/starlabs/starbook: Add Alder Lake N (N200) variant
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Ubuntu 24.04
* Manjaro 24
No known issues.
https://starlabs.systems/pages/starbook-specification
Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/starbook_adl_n.md
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/starlabs/starbook/Kconfig.name
A src/mainboard/starlabs/starbook/variants/adl_n/Makefile.mk
A src/mainboard/starlabs/starbook/variants/adl_n/board.fmd
A src/mainboard/starlabs/starbook/variants/adl_n/data.vbt
A src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb
A src/mainboard/starlabs/starbook/variants/adl_n/devtree.c
A src/mainboard/starlabs/starbook/variants/adl_n/gpio.c
A src/mainboard/starlabs/starbook/variants/adl_n/hda_verb.c
A src/mainboard/starlabs/starbook/variants/adl_n/ramstage.c
A src/mainboard/starlabs/starbook/variants/adl_n/romstage.c
A src/mainboard/starlabs/starbook/variants/adl_n/vboot.fmd
14 files changed, 1,119 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/85714/22
--
To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Gerrit-Change-Number: 85714
Gerrit-PatchSet: 22
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85715?usp=email
to look at the new patch set (#19).
Change subject: mb/starlabs/starbook: Add Meteor Lake (165H) variant
......................................................................
mb/starlabs/starbook: Add Meteor Lake (165H) variant
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Ubuntu 24.04
* Manjaro 24
No known issues.
https://starlabs.systems/pages/starbook-specification
Change-Id: I6621585086c58d19574841314796ed9db779036e
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/starbook_mtl.md
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/starlabs/starbook/Kconfig.name
M src/mainboard/starlabs/starbook/dsdt.asl
A src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk
A src/mainboard/starlabs/starbook/variants/mtl/board.fmd
A src/mainboard/starlabs/starbook/variants/mtl/data.vbt
A src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb
A src/mainboard/starlabs/starbook/variants/mtl/devtree.c
A src/mainboard/starlabs/starbook/variants/mtl/gpio.c
A src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c
A src/mainboard/starlabs/starbook/variants/mtl/ramstage.c
A src/mainboard/starlabs/starbook/variants/mtl/romstage.c
14 files changed, 830 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85715/19
--
To view, visit https://review.coreboot.org/c/coreboot/+/85715?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6621585086c58d19574841314796ed9db779036e
Gerrit-Change-Number: 85715
Gerrit-PatchSet: 19
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Attention is currently required from: Matt DeVillier, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email )
Change subject: mb/starlabs/starbook: Add Alder Lake N variant
......................................................................
Patch Set 21:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85714/comment/97ffdeab_d4a58804?us… :
PS20, Line 7: AlderLake
> Alder Lake
Done
https://review.coreboot.org/c/coreboot/+/85714/comment/7c032839_4e3eab30?us… :
PS20, Line 8:
> Where does the VBT come from?
Fsp repo
https://review.coreboot.org/c/coreboot/+/85714/comment/aee9245c_30656533?us… :
PS20, Line 8:
> Please elaborate.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Gerrit-Change-Number: 85714
Gerrit-PatchSet: 21
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Matt DeVillier, Sean Rhodes.
Hello Matt DeVillier, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85714?usp=email
to look at the new patch set (#21).
Change subject: mb/starlabs/starbook: Add Alder Lake N variant
......................................................................
mb/starlabs/starbook: Add Alder Lake N variant
Tested using `edk2` from
`github.com/starlabsltd/edk2/tree/uefipayload_vs`:
* Ubuntu 24.04
* Manjaro 24
No known issues.
https://starlabs.systems/pages/starbook-specification
Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/starbook_adl_n.md
M src/mainboard/starlabs/starbook/Kconfig
M src/mainboard/starlabs/starbook/Kconfig.name
A src/mainboard/starlabs/starbook/variants/adl_n/Makefile.mk
A src/mainboard/starlabs/starbook/variants/adl_n/board.fmd
A src/mainboard/starlabs/starbook/variants/adl_n/data.vbt
A src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb
A src/mainboard/starlabs/starbook/variants/adl_n/devtree.c
A src/mainboard/starlabs/starbook/variants/adl_n/gpio.c
A src/mainboard/starlabs/starbook/variants/adl_n/hda_verb.c
A src/mainboard/starlabs/starbook/variants/adl_n/ramstage.c
A src/mainboard/starlabs/starbook/variants/adl_n/romstage.c
A src/mainboard/starlabs/starbook/variants/adl_n/vboot.fmd
14 files changed, 1,119 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/85714/21
--
To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04
Gerrit-Change-Number: 85714
Gerrit-PatchSet: 21
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Bao Zheng, Julius Werner, Maximilian Brune, Paul Menzel, Zheng Bao.
Felix Held has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email )
Change subject: amdfwtool: Check fletcher of each header
......................................................................
Patch Set 7:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84338/comment/de3e3572_e660a28d?us… :
PS1, Line 571: default: /* ISH */
> Done
hm, i'd add a bool is_ish_dir as second parameter to this function to account for the ISH case and check if that's true and do the ISH table checksum check and return that result in that case before the switch case. sure, if the ISH had a cookie like the other tables this would make things a bit nicer, but introducing that additional parameter seems to be the best solution where we can be sure that nothing might be identified as the wrong table
--
To view, visit https://review.coreboot.org/c/coreboot/+/84338?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7540386027c6449317e9b7c0b4fd22d09d4a3a3
Gerrit-Change-Number: 84338
Gerrit-PatchSet: 7
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Jan Philipp Groß, Máté Kukri, Nicholas Chin.
Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/85756?usp=email )
Change subject: mb/asrock: Add Z87 Pro4 (Haswell)
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85756?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f01f2f25e0a4bcec10b075b574757250a5e5256
Gerrit-Change-Number: 85756
Gerrit-PatchSet: 6
Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:10:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Máté Kukri, Nicholas Chin.
Hello Angel Pons, Máté Kukri, Nicholas Chin, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85756?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/asrock: Add Z87 Pro4 (Haswell)
......................................................................
mb/asrock: Add Z87 Pro4 (Haswell)
This port was done via autoport and subsequent manual tweaking.
Working:
- Haswell MRC.bin
- All four DDR3/DDR3L DIMM slots
- HDMI-Out Port
- DVI-D Port
- D-Sub Port
- RJ-45 Gigabit LAN Port
- All four USB 2.0 Ports
- All four USB 3.1 Gen1 Ports
- Vertical Type A USB 3.1 Gen1 (located next to RAM slots)
- All six SATA3 6.0 Gb/s connectors
- PCI Express 3.0 x16 slot (tested with AMD RX 550 dGPU)
- PCI Express 2.0 x16 slot (tested with AMD RX 550 dGPU)
- Both PCI Express 2.0 x1 slots (tested with TL-WDN4800 WiFi adapter)
- HD Audio Jack (Audio output tested only)
- Front Audio Jack (Audio output tested only)
not working:
- Both USB 3.1 Gen1 headers (also not working on vendor firmware,
possible hardware defect)
not (yet) tested:
- IR header
- COM Port header
- USB 2.0 headers
- PS/2 Mouse/Keyboard Port
- HDMI-In Port
- PCI slots
Change-Id: I2f01f2f25e0a4bcec10b075b574757250a5e5256
Signed-off-by: Jan Philipp Groß <jeangrande(a)mailbox.org>
---
A src/mainboard/asrock/z87_pro4/Kconfig
A src/mainboard/asrock/z87_pro4/Kconfig.name
A src/mainboard/asrock/z87_pro4/Makefile.mk
A src/mainboard/asrock/z87_pro4/acpi/ec.asl
A src/mainboard/asrock/z87_pro4/acpi/platform.asl
A src/mainboard/asrock/z87_pro4/acpi/superio.asl
A src/mainboard/asrock/z87_pro4/board_info.txt
A src/mainboard/asrock/z87_pro4/bootblock.c
A src/mainboard/asrock/z87_pro4/data.vbt
A src/mainboard/asrock/z87_pro4/devicetree.cb
A src/mainboard/asrock/z87_pro4/dsdt.asl
A src/mainboard/asrock/z87_pro4/gma-mainboard.ads
A src/mainboard/asrock/z87_pro4/gpio.c
A src/mainboard/asrock/z87_pro4/hda_verb.c
A src/mainboard/asrock/z87_pro4/romstage.c
15 files changed, 519 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/85756/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/85756?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2f01f2f25e0a4bcec10b075b574757250a5e5256
Gerrit-Change-Number: 85756
Gerrit-PatchSet: 6
Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>