Attention is currently required from: Felix Singer, Jan Philipp Groß, Keith Hui, Máté Kukri, Nicholas Chin.
Angel Pons has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/85926?usp=email )
Change subject: mb/asrock: Add Z87 Extreme3 (Haswell)
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/mainboard/asrock/z87_extreme3/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/85926/comment/120c023e_9af67d50?us… :
PS3, Line 18: device pci 01.0 on # PEG
: end
You should probably enable 01.1 for the lower PCIe x16 slot.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85926?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3c13c068d899588eda80b9957127bcb6ccf8bab0
Gerrit-Change-Number: 85926
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 20:04:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Julius Werner, Yu-Ping Wu.
Douglas Anderson has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/85964?usp=email )
Change subject: commonlib/device_tree: Return cells properties of parent node
......................................................................
Patch Set 1:
(1 comment)
File src/commonlib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/85964/comment/de8c5b01_312b6d12?us… :
PS1, Line 1061:
> path is not allowed to be `NULL`. At the very least it must be `{ NULL }`. […]
Right, by "points to NULL" I meant `path` was `{ NULL }`.
Sure, it's useless for the purpose of finding a child DT node, but what if old code was using this function as a shortcut for finding the `#address-cells` and `#size-cells` of a given node. AKA:
```
u32 sizecells, addrcells;
dt_find_node(np, { NULL }, &addrcells, &sizecells, false);
```
That would have done _something_ prior to this change. Even if it returned the wrong value (because it should have been the parent's value) it was still something. Now it's just leaving uninitialized values.
I'm not saying that I've done any research to see if anyone did that. It is just a change in functionality and, without digging deeply, it's something to point out so people more familiar with the callers can say "yes, we believe this is OK" or "hmmm, maybe we should make a wrapper to catch people doing that". I'm happy to leave it up to others to make the call.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85964?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I323066477a4d4be17225e0915a81ce2ff39c1e40
Gerrit-Change-Number: 85964
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 18:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org>
Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com>
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85493?usp=email
to look at the new patch set (#12).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/amd/birman_plus: Kconfig
......................................................................
mb/amd/birman_plus: Kconfig
Clean up WLAN and WWAN configuration flags based on the schematics Doc. 105-D99700-00C.
Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Signed-off-by: Ana Carolina Cabral <ana.cabral(a)amd.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/ec.c
M src/mainboard/amd/birman_plus/port_descriptors_glinda.c
3 files changed, 38 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/85493/12
--
To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Gerrit-Change-Number: 85493
Gerrit-PatchSet: 12
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Attention is currently required from: Jérémy Compostella, Naresh Solanki.
Felix Held has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85639?usp=email )
Change subject: arch/x86/cpu: Add element id to struct cpu_cache_info
......................................................................
Patch Set 1:
(1 comment)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/85639/comment/5fb577ab_52a7d6c3?us… :
PS1, Line 280: uint8_t
this should probably be a larger int type than uint8_t, since we might have more than 256 cores in the generic case. at least if it does what i think it does from looking at the next patch
--
To view, visit https://review.coreboot.org/c/coreboot/+/85639?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I29002931b559a05756419e0c4ec5c78586d3c3a5
Gerrit-Change-Number: 85639
Gerrit-PatchSet: 1
Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 18:11:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Cliff Huang, Jérémy Compostella, Patrick Georgi, Zhixing Ma.
Pratikkumar V Prajapati has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85982?usp=email )
Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d
Gerrit-Change-Number: 85982
Gerrit-PatchSet: 6
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com>
Gerrit-Reviewer: Name of user not set #1005776
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Comment-Date: Tue, 14 Jan 2025 18:09:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Ana Carolina Cabral, Felix Held.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85493?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/amd/birman_plus: Kconfig
......................................................................
mb/amd/birman_plus: Kconfig
Clean up WLAN and WWAN configuration flags based on the schematics Doc. 105-D99700-00C.
Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Signed-off-by: Ana Carolina Cabral <ana.cabral(a)amd.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/ec.c
M src/mainboard/amd/birman_plus/port_descriptors_glinda.c
3 files changed, 38 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/85493/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Gerrit-Change-Number: 85493
Gerrit-PatchSet: 11
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Ana Carolina Cabral, Felix Held.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85493?usp=email
to look at the new patch set (#10).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: mb/amd/birman_plus: Kconfig
......................................................................
mb/amd/birman_plus: Kconfig
Clean up WLAN and WWAN configuration flags based on the schematics Doc. 105-D99700-00C.
Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Signed-off-by: Ana Carolina Cabral <ana.cabral(a)amd.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/ec.c
M src/mainboard/amd/birman_plus/port_descriptors_glinda.c
3 files changed, 36 insertions(+), 16 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/85493/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Gerrit-Change-Number: 85493
Gerrit-PatchSet: 10
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Ana Carolina Cabral, Felix Held.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85493?usp=email
to look at the new patch set (#9).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: mb/amd/birman_plus: Kconfig
......................................................................
mb/amd/birman_plus: Kconfig
Clean up WLAN and WWAN configuration flags based on the schematics Doc. 105-D99700-00C.
Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Signed-off-by: Ana Carolina Cabral <ana.cabral(a)amd.com>
---
M src/mainboard/amd/birman_plus/Kconfig
M src/mainboard/amd/birman_plus/ec.c
M src/mainboard/amd/birman_plus/port_descriptors_glinda.c
3 files changed, 34 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/85493/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/85493?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia310ea616006479b9a052afb99d08df6a11431f4
Gerrit-Change-Number: 85493
Gerrit-PatchSet: 9
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>