coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Jamie Ryu (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Cliff Huang, Jérémy Compostella, Patrick Georgi, Zhixing Ma. Jamie Ryu has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85982?usp=email ) Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Name of user not set #1005776 Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:58:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: commonlib/device_tree: Return cells properties of parent node
by Maximilian Brune (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Julius Werner, Yu-Ping Wu. Maximilian Brune has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/85964?usp=email ) Change subject: commonlib/device_tree: Return cells properties of parent node ...................................................................... Patch Set 1: (1 comment) File src/commonlib/device_tree.c: https://review.coreboot.org/c/coreboot/+/85964/comment/263ac40a_5fb55477?us… : PS1, Line 1061: > It worries me at least slightly that if a caller directly calls the base case (AKA path points to an […] path is not allowed to be `NULL`. At the very least it must be `{ NULL }`. calling `dt_find_node` with `path` as `NULL` would cause a NULL pointer deference down below. You can call directly call `dt_find_node` with `path = { NULL }` but it is useless because it just returns the node that was supplied to the function (so you are basically asking the function to find the node that you supplied to it as `parent`). In any case `addrcp` and `sizecp` shouldn't be an issue. -- To view, visit https://review.coreboot.org/c/coreboot/+/85964?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I323066477a4d4be17225e0915a81ce2ff39c1e40 Gerrit-Change-Number: 85964 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:51:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Douglas Anderson <dianders(a)chromium.org>

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Bora Guvendik (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Cliff Huang, Jamie Ryu, Jérémy Compostella, Patrick Georgi, Zhixing Ma. Bora Guvendik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85982?usp=email ) Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Name of user not set #1005776 Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:51:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Name of user not set (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Jérémy Compostella, Patrick Georgi, Zhixing Ma. Name of user not set #1005776 has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/85982?usp=email ) Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Name of user not set #1005776 Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:44:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Jérémy Compostella (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma. Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85982?usp=email to look at the new patch set (#6). Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... MAINTAINERS: Add Intel reviewers mailing list to relevant sections Intel reviewers are often unaware of changes affecting the INTEL_SUPPORT section directories. This issue stems from the fact that: 1. Subdirectories assigned to sections override sections assigned to parent directories 2. Individual sections claims ownership of subdirectories without adding Intel reviewers mailing to the notification list even when Intel has been the major code contributor. To ensure that the Intel coreboot reviewers have visibility, this commit adds this mailing list to the relevant sections. Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M MAINTAINERS 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/85982/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 6 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Jérémy Compostella (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma. Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85982?usp=email to look at the new patch set (#5). Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... MAINTAINERS: Add Intel reviewers mailing list to relevant sections Intel reviewers are often unaware of changes affecting the INTEL_SUPPORT section directories. This issue stems from the fact that: 1. Subdirectories assigned to sections override sections assigned to parent directories 2. Individual sections claims ownership of subdirectories without adding Intel reviewers mailing to the notification list even when Intel has been the major code contributor. To ensure that the Intel coreboot reviewers have visibility, this commit adds this mailing list to the following sections: - src/drivers/intel/fsp2_0/ - src/drivers/intel/dptf/ - src/soc/intel/alderlake/ - src/soc/intel/apollolake/ - src/soc/intel/braswell/ - src/soc/intel/denverton_ns/ - src/soc/intel/elkhartlake/ - src/soc/intel/meteorlake/ - src/soc/intel/pantherlake/ - src/soc/intel/tigerlake/ - src/soc/intel/common/block/imc/ - src/soc/intel/common/block/systemagent-server/ - src/soc/intel/xeon_sp/ - src/vendorcode/intel/fsp/fsp2_0/skylake_sp/ Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M MAINTAINERS 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/85982/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Jérémy Compostella (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma. Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85982?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... MAINTAINERS: Add Intel reviewers mailing list to relevant sections Intel reviewers are often unaware of changes affecting the INTEL_SUPPORT section directories. This issue stems from the fact that: 1. Subdirectories assigned to sections override sections assigned to parent directories 2. Individual sections claims ownership of subdirectories without adding Intel reviewers mailing to the notification list even when Intel has been the major code contributor. To ensure that the Intel coreboot reviewers have visibility, this commit adds this mailing list to the following sections: - src/drivers/intel/fsp2_0/ - src/drivers/intel/dptf/ - src/soc/intel/alderlake/ - src/soc/intel/apollolake/ - src/soc/intel/braswell/ - src/soc/intel/denverton_ns/ - src/soc/intel/elkhartlake/ - src/soc/intel/meteorlake/ - src/soc/intel/pantherlake/ - src/soc/intel/tigerlake/ - src/soc/intel/common/block/imc/ - src/soc/intel/common/block/systemagent-server/ - src/soc/intel/xeon_sp/ - src/vendorcode/intel/fsp/fsp2_0/skylake_sp/ Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M MAINTAINERS 1 file changed, 13 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/85982/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 4 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>

1 0

[XL] Change in coreboot[main]: mb/starlabs/starbook: Add AlderLake-N variant
by Paul Menzel (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Matt DeVillier, Sean Rhodes. Paul Menzel has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85714?usp=email ) Change subject: mb/starlabs/starbook: Add AlderLake-N variant ...................................................................... Patch Set 20: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85714/comment/997f24c4_9c6a7e01?us… : PS20, Line 7: AlderLake Alder Lake https://review.coreboot.org/c/coreboot/+/85714/comment/b6f35a40_c7079511?us… : PS20, Line 8: Where does the VBT come from? https://review.coreboot.org/c/coreboot/+/85714/comment/56ac0501_7196fb77?us… : PS20, Line 8: Please elaborate. -- To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Gerrit-Change-Number: 85714 Gerrit-PatchSet: 20 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 14 Jan 2025 17:36:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel reviewers mailing list to relevant sections
by Jérémy Compostella (Code Review) 14 Jan '25

14 Jan '25

Attention is currently required from: Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma. Hello Bora Guvendik, Cliff Huang, Jamie Ryu, Patrick Georgi, Zhixing Ma, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85982?usp=email to look at the new patch set (#2). Change subject: MAINTAINERS: Add Intel reviewers mailing list to relevant sections ...................................................................... MAINTAINERS: Add Intel reviewers mailing list to relevant sections Intel reviewers are often unaware of changes affecting the INTEL_SUPPORT section directories. This issue stems from the fact that: 1. Subdirectories assigned to sections override sections assigned to parent directories 2. Individual sections claims ownership of subdirectories without adding Intel reviewers mailing to the notification list even when Intel has been the major code contributor. To ensure that the Intel coreboot reviewers have visibility, this commit adds this mailing list to the following sections: - src/drivers/intel/fsp2_0/ - src/drivers/intel/dptf/ - src/soc/intel/alderlake/ - src/soc/intel/apollolake/ - src/soc/intel/braswell/ - src/soc/intel/denverton_ns/ - src/soc/intel/elkhartlake/ - src/soc/intel/meteorlake/ - src/soc/intel/pantherlake/ - src/soc/intel/tigerlake/ - src/soc/intel/common/block/imc/ - src/soc/intel/common/block/systemagent-server/ - src/soc/intel/xeon_sp/ - src/vendorcode/intel/fsp/fsp2_0/skylake_sp/ Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M MAINTAINERS 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/85982/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com>

1 0

[S] Change in coreboot[main]: MAINTAINERS: Add Intel_Coreboot_Reviewers to relevant sections
by Jérémy Compostella (Code Review) 14 Jan '25

14 Jan '25

Jérémy Compostella has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/85982?usp=email ) Change subject: MAINTAINERS: Add Intel_Coreboot_Reviewers to relevant sections ...................................................................... MAINTAINERS: Add Intel_Coreboot_Reviewers to relevant sections Intel reviewers are often unaware of changes affecting the INTEL_SUPPORT section directories. This issue stems from the fact that: 1. Subdirectories assigned to sections override sections assigned to parent directories 2. Individual sections claims ownership of subdirectories without adding Intel_Coreboot_Reviewers to the notification list even when Intel has been the major code contributor. To ensure that the Intel Coreboot reviewers have visibility, this commit adds this mailing list to the following sections: - src/drivers/intel/fsp2_0/ - src/drivers/intel/dptf/ - src/soc/intel/alderlake/ - src/soc/intel/apollolake/ - src/soc/intel/braswell/ - src/soc/intel/denverton_ns/ - src/soc/intel/elkhartlake/ - src/soc/intel/meteorlake/ - src/soc/intel/pantherlake/ - src/soc/intel/tigerlake/ - src/soc/intel/common/block/imc/ - src/soc/intel/common/block/systemagent-server/ - src/soc/intel/xeon_sp/ - src/vendorcode/intel/fsp/fsp2_0/skylake_sp/ Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com> --- M MAINTAINERS 1 file changed, 12 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/85982/1 diff --git a/MAINTAINERS b/MAINTAINERS index 45bcac0..0321cc8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -800,11 +800,13 @@ INTEL FSP 2.0 M: Andrey Petrov <andrey.petrov(a)gmail.com> M: Ronak Kanabar <ronak.kanabar(a)intel.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/drivers/intel/fsp2_0/ INTEL DPTF M: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/drivers/intel/dptf/ @@ -881,12 +883,14 @@ M: Kapil Porwal <kapilporwal(a)google.com> M: Dinesh Gehlot <digehlot(a)google.com> M: Jayvik Desai <jayvik(a)google.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/alderlake/ INTEL APOLLOLAKE_SOC M: Sean Rhodes <sean(a)starlabs.systems> S: Odd Fixes +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> F: src/soc/intel/apollolake/ INTEL BRASWELL SOC @@ -894,6 +898,7 @@ M: Michał Żygowski <michal.zygowski(a)3mdeb.com> M: Frans Hendriks <fhendriks(a)eltan.com> S: Maintained +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> F: /src/soc/intel/braswell/ F: /src/vendorcode/intel/fsp/fsp1_1/braswell/ @@ -904,12 +909,14 @@ INTEL DENVERTON-NS SOC M: Jeff Daly <jeffd(a)silicom-usa.com> M: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/denverton_ns/ INTEL ELKHARTLAKE SOC M: Lean Sheng Tan <sheng.tan(a)9elements.com> M: Werner Zeh <werner.zeh(a)siemens.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/elkhartlake/ @@ -920,6 +927,7 @@ M: Jakub Czapiga <czapiga(a)google.com> M: Eran Mitrani <mitrani(a)google.com> M: Dinesh Gehlot <digehlot(a)google.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/meteorlake/ @@ -927,18 +935,21 @@ M: Subrata Banik <subratabanik(a)google.com> M: Kapil Porwal <kapilporwal(a)google.com> M: Pranava Y N <pranavayn(a)google.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/pantherlake/ INTEL TIGERLAKE SOC M: Subrata Banik <subratabanik(a)google.com> M: Nick Vaccaro <nvaccaro(a)chromium.org> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/tigerlake/ INTEL Atom Snow Ridge SoC M: Yuchi Chen <yuchi.chen(a)intel.com> M: Vasiliy Khoruzhick <vasilykh(a)arista.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Maintained F: src/soc/intel/common/block/imc/ F: src/soc/intel/common/block/systemagent-server/ @@ -953,6 +964,7 @@ M: Shuo Liu <shuo.liu(a)intel.com> M: Patrick Rudolph <patrick.rudolph(a)9elements.com> M: Lean Sheng Tan <sheng.tan(a)9elements.com> +R: Intel_Coreboot_Reviewers <intel_coreboot_reviewers(a)intel.com> S: Supported F: src/soc/intel/xeon_sp/ F: src/vendorcode/intel/fsp/fsp2_0/skylake_sp/ -- To view, visit https://review.coreboot.org/c/coreboot/+/85982?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2d90d10902dba30222d213632bd0d6d0226b855d Gerrit-Change-Number: 85982 Gerrit-PatchSet: 1 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025