coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3270 discussions

[M] Change in coreboot[main]: Documentation: Improve x86_64
by Jérémy Compostella (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Arthur Heymans, Benjamin Doron, Felix Held, Jakub Czapiga, Lean Sheng Tan, Martin L Roth, Matt DeVillier, Patrick Rudolph, Paul Menzel, Werner Zeh. Jérémy Compostella has posted comments on this change by Benjamin Doron. ( https://review.coreboot.org/c/coreboot/+/79160?usp=email ) Change subject: Documentation: Improve x86_64 ...................................................................... Patch Set 9: (1 comment) Patchset: PS9: Any reason why it got V-1 ? -- To view, visit https://review.coreboot.org/c/coreboot/+/79160?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia5ba51be629a8c878aad64d3297176457cf8e855 Gerrit-Change-Number: 79160 Gerrit-PatchSet: 9 Gerrit-Owner: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:36:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri
by Felix Held (Code Review) 29 Jan '25

29 Jan '25

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86158?usp=email ) Change subject: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri ...................................................................... mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri Add CSOT_PNA957QT1_1 MIPI panel for Ciri. Datasheet: PNA957QT1-1 Product Spec_CSOT_V02_20250110.pdf BUG=b:391796227 TEST=Boot to firmware screen BRANCH=Geralt Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86158 Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/geralt/Kconfig M src/mainboard/google/geralt/panel_ciri.c 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: David Hendricks: Looks good to me, approved build bot (Jenkins): Verified Xinxiong Xu: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/geralt/Kconfig b/src/mainboard/google/geralt/Kconfig index 42522f5..dbc155c 100644 --- a/src/mainboard/google/geralt/Kconfig +++ b/src/mainboard/google/geralt/Kconfig @@ -39,6 +39,7 @@ select RTC select MIPI_PANEL_BOE_TV110C9M_LL0 if BOARD_GOOGLE_GERALT select MIPI_PANEL_BOE_NV110WUM_L60 if BOARD_GOOGLE_CIRI + select MIPI_PANEL_CSOT_PNA957QT1_1 if BOARD_GOOGLE_CIRI select MIPI_PANEL_IVO_T109NW41 if BOARD_GOOGLE_CIRI select FW_CONFIG select FW_CONFIG_SOURCE_CHROMEEC_CBI diff --git a/src/mainboard/google/geralt/panel_ciri.c b/src/mainboard/google/geralt/panel_ciri.c index 15c8859..4c21e90 100644 --- a/src/mainboard/google/geralt/panel_ciri.c +++ b/src/mainboard/google/geralt/panel_ciri.c @@ -44,6 +44,15 @@ .orientation = LB_FB_ORIENTATION_LEFT_UP, .disp_path = DISP_PATH_MIPI, .pwm_ctrl_gpio = true, + }, + + [51] = { + .name = "CSOT_PNA957QT1_1", + .power_on = power_on_mipi_himax_83102j, + .configure_backlight = configure_mipi_pwm_backlight, + .orientation = LB_FB_ORIENTATION_LEFT_UP, + .disp_path = DISP_PATH_MIPI, + .pwm_ctrl_gpio = true, } }; -- To view, visit https://review.coreboot.org/c/coreboot/+/86158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Gerrit-Change-Number: 86158 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for CSOT_PNA957QT1_1 panel
by Felix Held (Code Review) 29 Jan '25

29 Jan '25

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86157?usp=email ) Change subject: drivers/mipi: Add support for CSOT_PNA957QT1_1 panel ...................................................................... drivers/mipi: Add support for CSOT_PNA957QT1_1 panel Add CSOT panel PNA957QT1-1 serializable data to CBFS. Datasheet: HX83102-J Initial code_CSOT 10p95_USI_60Hz_DPHY_20250123_V2 BUG=b:391796227 TEST=build and check the CBFS include the panel BRANCH=Geralt Change-Id: Ibd092fa8f2e33f2692c61a7f302224c01678db05 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86157 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Reviewed-by: David Hendricks <david.hendricks(a)gmail.com> --- M src/drivers/mipi/Kconfig M src/drivers/mipi/Makefile.mk A src/drivers/mipi/panel-CSOT_PNA957QT1_1.c 3 files changed, 113 insertions(+), 0 deletions(-) Approvals: Xinxiong Xu: Looks good to me, but someone else must approve build bot (Jenkins): Verified David Hendricks: Looks good to me, approved diff --git a/src/drivers/mipi/Kconfig b/src/drivers/mipi/Kconfig index 1edebf9..1d271c7 100644 --- a/src/drivers/mipi/Kconfig +++ b/src/drivers/mipi/Kconfig @@ -36,6 +36,9 @@ config MIPI_PANEL_CMN_P097PFG_SSD2858 bool +config MIPI_PANEL_CSOT_PNA957QT1_1 + bool + config MIPI_PANEL_INX_HJ110IZ_01A_B2 bool diff --git a/src/drivers/mipi/Makefile.mk b/src/drivers/mipi/Makefile.mk index de566d4..9464421 100644 --- a/src/drivers/mipi/Makefile.mk +++ b/src/drivers/mipi/Makefile.mk @@ -18,6 +18,8 @@ panel-params-$(CONFIG_MIPI_PANEL_CMN_P097PFG_SSD2858) += panel-CMN_P097PFG_SSD2858 +panel-params-$(CONFIG_MIPI_PANEL_CSOT_PNA957QT1_1) += panel-CSOT_PNA957QT1_1 + panel-params-$(CONFIG_MIPI_PANEL_INX_HJ110IZ_01A_B2) += panel-INX_HJ110IZ_01A_B2 panel-params-$(CONFIG_MIPI_PANEL_INX_OTA7290D10P) += panel-INX_OTA7290D10P diff --git a/src/drivers/mipi/panel-CSOT_PNA957QT1_1.c b/src/drivers/mipi/panel-CSOT_PNA957QT1_1.c new file mode 100644 index 0000000..6882db6 --- /dev/null +++ b/src/drivers/mipi/panel-CSOT_PNA957QT1_1.c @@ -0,0 +1,108 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <mipi/panel.h> + +struct panel_serializable_data CSOT_PNA957QT1_1 = { + .edid = { + .ascii_string = "PNA957QT1_1", + .manufacturer_name = "CSOT", + .panel_bits_per_color = 8, + .panel_bits_per_pixel = 24, + .mode = { + .pixel_clock = 177958, + .lvds_dual_channel = 0, + .refresh = 60, + .ha = 1200, .hbl = 244, .hso = 124, .hspw = 80, + .va = 1920, .vbl = 134, .vso = 88, .vspw = 8, + .phsync = '-', .pvsync = '-', + .x_mm = 147, .y_mm = 235, + }, + }, + .init = { + PANEL_DELAY(60), + PANEL_DCS(0xB9, 0x83, 0x10, 0x21, 0x55, 0x00), + PANEL_DCS(0xE9, 0xC4), + PANEL_DCS(0xD9, 0xD2), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB1, 0x2C, 0xB3, 0xB3, 0x31, 0xF1, 0x33, 0xE0, 0x54, 0x36, + 0x36, 0x3A, 0x3A, 0x32, 0x8B, 0x11, 0xE5, 0x98), + PANEL_DCS(0xE9, 0xD9), + PANEL_DCS(0xB1, 0x8B, 0x33), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xB2, 0x00, 0x47, 0xB0, 0x80, 0x00, 0x2C, 0x80, 0x3C, 0x9F, + 0x22, 0x20, 0x00, 0x00, 0x98, 0x51), + PANEL_DCS(0xB4, 0x41, 0x41, 0x41, 0x41, 0x64, 0x64, 0x40, 0x84, 0x64, + 0x84, 0x01, 0x9D, 0x01, 0x02, 0x01, 0x00, 0x00), + PANEL_DCS(0xBC, 0x1B, 0x04), + PANEL_DCS(0xBE, 0x20), + PANEL_DCS(0xBF, 0xFC, 0xC4, 0x80, 0x9C, 0x36, 0x00, 0x0D, 0x04), + PANEL_DCS(0xC0, 0x32, 0x32, 0x22, 0x11, 0x22, 0xA0, 0x31, 0x08, 0xF5, + 0x03), + PANEL_DCS(0xE9, 0xCC), + PANEL_DCS(0xC7, 0x80), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xC8, 0x97), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xC9, 0x00, 0x1E, 0x13, 0x88, 0x01), + PANEL_DCS(0xCB, 0x08, 0x13, 0x07, 0x00, 0x0F, 0x36), + PANEL_DCS(0xCC, 0x02, 0x03, 0x44), + PANEL_DCS(0xD1, 0x07, 0x06, 0x00, 0x02, 0x04, 0x2C, 0xFF), + PANEL_DCS(0xD3, 0x06, 0x00, 0x00, 0x00, 0x40, 0x04, 0x08, 0x04, 0x08, + 0x37, 0x07, 0x44, 0x37, 0x2B, 0x2B, 0x03, 0x03, 0x32, 0x10, 0x22, + 0x00, 0x25, 0x32, 0x10, 0x29, 0x00, 0x29, 0x32, 0x10, 0x08, 0x00, + 0x08, 0x00, 0x00), + PANEL_DCS(0xD5, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, + 0x18, 0x07, 0x06, 0x07, 0x06, 0x05, 0x04, 0x05, 0x04, 0x03, 0x02, + 0x03, 0x02, 0x01, 0x00, 0x01, 0x00, 0x18, 0x18, 0x25, 0x24, 0x25, + 0x24, 0x1F, 0x1F, 0x1F, 0x1F, 0x1E, 0x1E, 0x1E, 0x1E, 0x20, 0x20, + 0x20, 0x20), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, + 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xE0, 0x0A, 0x0E, 0x1A, 0x21, 0x28, 0x46, 0x5C, 0x61, 0x63, + 0x5E, 0x78, 0x7D, 0x80, 0x8E, 0x89, 0x90, 0x98, 0xAA, 0xA8, 0x52, + 0x59, 0x60, 0x6F, 0x06, 0x0A, 0x16, 0x1D, 0x24, 0x46, 0x5C, 0x61, + 0x6B, 0x66, 0x7C, 0x7D, 0x80, 0x8E, 0x89, 0x90, 0x98, 0xAA, 0xA8, + 0x52, 0x59, 0x60, 0x6F), + PANEL_DCS(0xE7, 0xE0, 0x10, 0x10, 0x0D, 0x1E, 0x9D, 0x02, 0x52, 0x9D, + 0x14, 0x14), + PANEL_DCS(0xBD, 0x01), + PANEL_DCS(0xB1, 0x01, 0x7F, 0x11, 0xFD), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xBA, 0x4F), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xCB, 0x86), + PANEL_DCS(0xD2, 0x64), + PANEL_DCS(0xE9, 0xC5), + PANEL_DCS(0xD3, 0x00), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, + 0x8A, 0xAA, 0xA0, 0x05, 0x15, 0x55, 0x45, 0x55, 0x50, 0x05, 0x15, + 0x55, 0x45, 0x55, 0x50), + PANEL_DCS(0xE7, 0x02, 0x00, 0x24, 0x01, 0x7E, 0x0F, 0x7C, 0x10, 0xA0, + 0x00, 0x00), + PANEL_DCS(0xBD, 0x02), + PANEL_DCS(0xCB, 0x03, 0x07, 0x00, 0x10, 0x7B), + PANEL_DCS(0xD8, 0x0F, 0x3F, 0xFF, 0xCF, 0xFF, 0xF0, 0x0F, 0x3F, 0xFF, + 0xCF, 0xFF, 0xF0), + PANEL_DCS(0xE7, 0xFE, 0x01, 0xFE, 0x01, 0xFE, 0x01, 0x00, 0x00, 0x00, + 0x23, 0x00, 0x23, 0x81, 0x02, 0x40, 0x00, 0x20, 0x9D, 0x02, 0x01, + 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00), + PANEL_DCS(0xBD, 0x03), + PANEL_DCS(0xB2, 0x66, 0x81), + PANEL_DCS(0xE9, 0xC6), + PANEL_DCS(0xB4, 0x03, 0xFF, 0xF8), + PANEL_DCS(0xE9, 0x3F), + PANEL_DCS(0xD8, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, 0x2A, 0xAA, + 0x8A, 0xAA, 0xA0, 0x0F, 0x2A, 0xAA, 0x8A, 0xAA, 0xF0, 0x0F, 0x2A, + 0xAA, 0x8A, 0xAA, 0xF0, 0x0A, 0x2A, 0xAA, 0x8A, 0xAA, 0xA0, 0x0A, + 0x2A, 0xAA, 0x8A, 0xAA, 0xA0), + PANEL_DCS(0xBD, 0x00), + PANEL_DCS(0xB9, 0x00, 0x00, 0x00, 0x00), + PANEL_DCS(0x11), + PANEL_DELAY(120), + PANEL_DCS(0x29), + PANEL_DELAY(20), + PANEL_END, + }, +}; -- To view, visit https://review.coreboot.org/c/coreboot/+/86157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd092fa8f2e33f2692c61a7f302224c01678db05 Gerrit-Change-Number: 86157 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: drivers/mipi: Add support for CSOT_PNA957QT1_1 panel
by David Hendricks (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Hung-Te Lin, Yang Wu, Yidi Lin, Yu-Ping Wu. David Hendricks has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/86157?usp=email ) Change subject: drivers/mipi: Add support for CSOT_PNA957QT1_1 panel ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86157?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibd092fa8f2e33f2692c61a7f302224c01678db05 Gerrit-Change-Number: 86157 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:26:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri
by David Hendricks (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Hung-Te Lin, Yang Wu, Yidi Lin, Yu-Ping Wu. David Hendricks has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/86158?usp=email ) Change subject: mb/google/geralt: Enable CSOT_PNA957QT1_1 panel for Ciri ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86158?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I306298c6eb172e4dd199e45a50e197fa87905e8c Gerrit-Change-Number: 86158 Gerrit-PatchSet: 2 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: nb/intel/i440bx: Drop self-specific debugging macros
by Jérémy Compostella (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Felix Singer, Keith Hui. Jérémy Compostella has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/78786?usp=email ) Change subject: nb/intel/i440bx: Drop self-specific debugging macros ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I685a2f1f38c1afab6a08ff9de4bf82c9061aebec Gerrit-Change-Number: 78786 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:25:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig
by Felix Held (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Alicja Michalska, Angel Pons, Arthur Heymans. Felix Held has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig ...................................................................... Patch Set 4: (2 comments) File src/device/Kconfig: https://review.coreboot.org/c/coreboot/+/86131/comment/5a25bb0a_5ec09c34?us… : PS4, Line 1015: default y is it intended that the default is changed for all non-x86 arcitectures? https://review.coreboot.org/c/coreboot/+/86131/comment/3893cd8e_e161efaa?us… : PS4, Line 1013: bool "Extend resource window for PCIe devices" i;d change the prompt text to be more descriptive of what it does; at least to me the name of the option is more descriptive than then prompt test -- To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Gerrit-Change-Number: 86131 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:24:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: device/Kconfig: Make option to allocate above 4G appear in Kconfig
by David Hendricks (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Alicja Michalska, Angel Pons, Arthur Heymans. David Hendricks has posted comments on this change by Alicja Michalska. ( https://review.coreboot.org/c/coreboot/+/86131?usp=email ) Change subject: device/Kconfig: Make option to allocate above 4G appear in Kconfig ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86131?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia17b3312016409d8fd6bcce4321481a7b7e35ce5 Gerrit-Change-Number: 86131 Gerrit-PatchSet: 4 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 29 Jan 2025 18:19:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/bostentech/gbyt4: Increase default CBFS size to cover BIOS region
by Felix Singer (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Máté Kukri. Felix Singer has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/86219?usp=email ) Change subject: mb/bostentech/gbyt4: Increase default CBFS size to cover BIOS region ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86219?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I65a8b161c522a2da58420397aae6c7ff2b5cf30d Gerrit-Change-Number: 86219 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Comment-Date: Wed, 29 Jan 2025 17:22:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/bostentech/gbyt4: Add VBT
by Felix Singer (Code Review) 29 Jan '25

29 Jan '25

Attention is currently required from: Máté Kukri. Felix Singer has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/86218?usp=email ) Change subject: mb/bostentech/gbyt4: Add VBT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I73d54c73a12430074f4f3880caf842b3491b5170 Gerrit-Change-Number: 86218 Gerrit-PatchSet: 1 Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz> Gerrit-Comment-Date: Wed, 29 Jan 2025 17:22:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025