coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: ec/starlabs/merlin: Only include battery ACPI for systems with a battery
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85716?usp=email ) Change subject: ec/starlabs/merlin: Only include battery ACPI for systems with a battery ...................................................................... ec/starlabs/merlin: Only include battery ACPI for systems with a battery Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85716 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/ec/starlabs/merlin/acpi/ec.asl 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl index 2fc1248..8fa16c5 100644 --- a/src/ec/starlabs/merlin/acpi/ec.asl +++ b/src/ec/starlabs/merlin/acpi/ec.asl @@ -134,7 +134,9 @@ } #include "ac.asl" +#if CONFIG(SYSTEM_TYPE_LAPTOP) || CONFIG(SYSTEM_TYPE_DETACHABLE) #include "battery.asl" +#endif #if !CONFIG(EC_STARLABS_MERLIN) #include "events.asl" #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/85716?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I381714887f4319d8e1a25c1e493ba03631cbf082 Gerrit-Change-Number: 85716 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Move common variants to respective files
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85945?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ec/starlabs/merlin: Move common variants to respective files ...................................................................... ec/starlabs/merlin: Move common variants to respective files Move the Q-Events used by the merlin EC to their respective files, i.e. `Q0B` for Battery Status Update to battery.asl. This means that only revelant events will be included. Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85945 Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/starlabs/merlin/acpi/ac.asl M src/ec/starlabs/merlin/acpi/battery.asl M src/ec/starlabs/merlin/acpi/ec.asl M src/ec/starlabs/merlin/acpi/hid.asl M src/ec/starlabs/merlin/acpi/lid.asl D src/ec/starlabs/merlin/variants/merlin/events.asl 6 files changed, 36 insertions(+), 27 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Matt DeVillier: Looks good to me, approved diff --git a/src/ec/starlabs/merlin/acpi/ac.asl b/src/ec/starlabs/merlin/acpi/ac.asl index 01dcca9..b689dd5 100644 --- a/src/ec/starlabs/merlin/acpi/ac.asl +++ b/src/ec/starlabs/merlin/acpi/ac.asl @@ -1,5 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#if CONFIG(EC_STARLABS_MERLIN) +Method (_Q0A, 0, NotSerialized) // Event: Charger Status Update +{ + Notify (ADP1, 0x80) +} +#endif + Device (ADP1) { Name (_HID, "ACPI0003") diff --git a/src/ec/starlabs/merlin/acpi/battery.asl b/src/ec/starlabs/merlin/acpi/battery.asl index 10fea6a..5f00c88 100644 --- a/src/ec/starlabs/merlin/acpi/battery.asl +++ b/src/ec/starlabs/merlin/acpi/battery.asl @@ -1,5 +1,12 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#if CONFIG(EC_STARLABS_MERLIN) +Method (_Q0B, 0, NotSerialized) // Event: Battery Information Update +{ + Notify (BAT0, 0x80) +} +#endif + Device (BAT0) { Name (_HID, EisaId("PNP0C0A")) diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl index 1219b82..2fc1248 100644 --- a/src/ec/starlabs/merlin/acpi/ec.asl +++ b/src/ec/starlabs/merlin/acpi/ec.asl @@ -135,7 +135,9 @@ #include "ac.asl" #include "battery.asl" +#if !CONFIG(EC_STARLABS_MERLIN) #include "events.asl" +#endif #include "lid.asl" #include "dock.asl" diff --git a/src/ec/starlabs/merlin/acpi/hid.asl b/src/ec/starlabs/merlin/acpi/hid.asl index 15f02fc..4a85f04 100644 --- a/src/ec/starlabs/merlin/acpi/hid.asl +++ b/src/ec/starlabs/merlin/acpi/hid.asl @@ -1,5 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#if CONFIG(EC_STARLABS_MERLIN) +Method (_Q05, 0, NotSerialized) // Event: Backlight Brightness Down +{ + ^HIDD.HPEM (20) +} + +Method (_Q06, 0, NotSerialized) // Event: Backlight Brightness Up +{ + ^HIDD.HPEM (19) +} +#endif + Device (HIDD) // HID Device { Name (_HID, "INTC1051") // Intel Ultrabook HID Platform Event Driver. diff --git a/src/ec/starlabs/merlin/acpi/lid.asl b/src/ec/starlabs/merlin/acpi/lid.asl index 0eaa2c5..83d28a0 100644 --- a/src/ec/starlabs/merlin/acpi/lid.asl +++ b/src/ec/starlabs/merlin/acpi/lid.asl @@ -1,5 +1,13 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#if CONFIG(EC_STARLABS_MERLIN) +Method (_Q0C, 0, NotSerialized) // Event: Lid Opened or Closed +{ + \LIDS = ECRD(RefOf(LSTE)) + Notify (LID0, 0x80) +} +#endif + Device (LID0) { Name (_HID, EisaId ("PNP0C0D")) diff --git a/src/ec/starlabs/merlin/variants/merlin/events.asl b/src/ec/starlabs/merlin/variants/merlin/events.asl deleted file mode 100644 index 64bb0d0..0000000 --- a/src/ec/starlabs/merlin/variants/merlin/events.asl +++ /dev/null @@ -1,27 +0,0 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ - -Method (_Q05, 0, NotSerialized) // Event: Backlight Brightness Down -{ - ^^^^HIDD.HPEM (20) -} - -Method (_Q06, 0, NotSerialized) // Event: Backlight Brightness Up -{ - ^^^^HIDD.HPEM (19) -} - -Method (_Q0A, 0, NotSerialized) // Event: Charger Status Update -{ - Notify (ADP1, 0x80) -} - -Method (_Q0B, 0, NotSerialized) // Event: Battery Information Update -{ - Notify (BAT0, 0x80) -} - -Method (_Q0C, 0, NotSerialized) // Event: Lid Opened or Closed -{ - \LIDS = ECRD(RefOf(LSTE)) - Notify (LID0, 0x80) -} -- To view, visit https://review.coreboot.org/c/coreboot/+/85945?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib41fbafd79b999409a520361a4d372902d878794 Gerrit-Change-Number: 85945 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: soc/intel/common/cnvi: Add _PRW for CNVi device
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84993?usp=email ) Change subject: soc/intel/common/cnvi: Add _PRW for CNVi device ...................................................................... Abandoned Not needed (can use the one in wifi generic) -- To view, visit https://review.coreboot.org/c/coreboot/+/84993?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8b3dcdf7b6cdc32fb910e7a4783029076717beff Gerrit-Change-Number: 84993 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: commonlib/device_tree: Return cells properties of parent node
by Maximilian Brune (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Doug Anderson, Julius Werner, Paul Menzel, Yu-Ping Wu. Maximilian Brune has posted comments on this change by Julius Werner. ( https://review.coreboot.org/c/coreboot/+/85964?usp=email ) Change subject: commonlib/device_tree: Return cells properties of parent node ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85964?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I323066477a4d4be17225e0915a81ce2ff39c1e40 Gerrit-Change-Number: 85964 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Doug Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Doug Anderson <dianders(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:10:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/rauru: Configure firmware display for eDP panel
by Nancy Lin (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yu-Ping Wu. Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) Change subject: mb/google/rauru: Configure firmware display for eDP panel ...................................................................... Patch Set 4: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85952/comment/2ff3065b_bc4ec47e?us… : PS3, Line 9: mt8196 > rauru Done https://review.coreboot.org/c/coreboot/+/85952/comment/77c00a1f_ce143df0?us… : PS3, Line 12: BUG=b:343351631 > OK, I will add it. Done File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85952/comment/f1c22893_c12e7142?us… : PS3, Line 107: else > OK, I will fix it. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 09:58:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/rauru: Configure firmware display for eDP panel
by Nancy Lin (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Nancy Lin, Paul Menzel. Nancy Lin has uploaded a new patch set (#4) to the change originally created by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/google/rauru: Configure firmware display for eDP panel ...................................................................... mb/google/rauru: Configure firmware display for eDP panel Add eDP panel power-on sequences and initialize the display in the ramstage. TEST=Build pass, the firmware screen displays correctly. BUG=b:343351631, b:353464237 Signed-off-by: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 --- M src/mainboard/google/rauru/Kconfig M src/mainboard/google/rauru/mainboard.c 2 files changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/85952/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 4 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com>

1 0

[S] Change in coreboot[main]: soc/intel/alderlake: Add IRQ mapping for PEG PCI-E ports
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Michał Żygowski, Nick Vaccaro, Subrata Banik. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84620?usp=email ) Change subject: soc/intel/alderlake: Add IRQ mapping for PEG PCI-E ports ...................................................................... Patch Set 6: (1 comment) Patchset: PS4: > Could you please share the warning message? and also the output of […] Error: `[ 0.852250] pcieport 0000:00:06.0: can't derive routing for PCI INT A` Without patch: ``` 122: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 IR-PCI-MSI-0000:00:06.0 0-edge PCIe PME, aerdrv 00:06.0 PCI bridge: Intel Corporation Raptor Lake PCIe 4.0 Graphics Port (prog-if 00 [Normal decode]) Interrupt: pin D routed to IRQ 122 ``` With patch: ``` 122: 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 IR-PCI-MSI-0000:00:06.0 0-edge PCIe PME, aerdrv 00:06.0 PCI bridge: Intel Corporation Raptor Lake PCIe 4.0 Graphics Port (prog-if 00 [Normal decode]) Interrupt: pin D routed to IRQ 122 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/84620?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2e36cee37716d3b003b9ce250f28fdf5581a15bc Gerrit-Change-Number: 84620 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 15 Jan 2025 09:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com>

1 0

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add RTC driver
by Yu-Ping Wu (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email ) Change subject: soc/mediatek/mt8196: Add RTC driver ...................................................................... Patch Set 1: (9 comments) Patchset: PS1: Partial review. src/soc/mediatek/mt8196/mt6685_rtc.c is not reviewed yet. Commit Message: https://review.coreboot.org/c/coreboot/+/85978/comment/c8c97fd7_f06354c1?us… : PS1, Line 9: rtc RTC File src/soc/mediatek/common/include/soc/rtc_common.h: https://review.coreboot.org/c/coreboot/+/85978/comment/1b6ed322_2db3abb1?us… : PS1, Line 107: /* The return result of the clock calibration : * The result is relationship coefficient between 26M and 32K, : * which is non-unit. : */ Okay, I think this explains nothing. If the return value is NOT a unit, let's remove this comment (and remove the blank line above). File src/soc/mediatek/common/rtc_osc_init.c: https://review.coreboot.org/c/coreboot/+/85978/comment/45087dce_6dfaca48?us… : PS1, Line 7: u16 > Why limit the length? Because the data width for rtc_read/rtc_write API is u16. File src/soc/mediatek/mt8196/include/soc/mt6685_rtc_hw.h: https://review.coreboot.org/c/coreboot/+/85978/comment/62237abf_d3792be8?us… : PS1, Line 24: Remove this extra space. Same for other values below. https://review.coreboot.org/c/coreboot/+/85978/comment/ef6b5e9c_a3936cab?us… : PS1, Line 89: mask masks File src/soc/mediatek/mt8196/include/soc/rtc.h: https://review.coreboot.org/c/coreboot/+/85978/comment/40e3cf96_1ec03b60?us… : PS1, Line 58: WATCH_INIT_EXPIRED_TIME Can we have a more descriptive name? `XXX_US` https://review.coreboot.org/c/coreboot/+/85978/comment/e4f94527_7eb065a7?us… : PS1, Line 59: WAIT_TIME_US Same here. Wait for what? Also change these two to enum for consistency. File src/soc/mediatek/mt8196/mt6685_rtc.c: https://review.coreboot.org/c/coreboot/+/85978/comment/c2e0d743_9748dc5e?us… : PS1, Line 43: freq Can we name these 3 fields instead of using an array? -- To view, visit https://review.coreboot.org/c/coreboot/+/85978?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3dd337eaa3eed3012ddea300f7e04f2b63fb2daa Gerrit-Change-Number: 85978 Gerrit-PatchSet: 1 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 09:40:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/google/rauru: Enable firmware display
by Nancy Lin (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel. Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85952?usp=email ) Change subject: mb/google/rauru: Enable firmware display ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85952/comment/1890e9a1_0993e119?us… : PS3, Line 9: Enable mt8196 firmware display support. > Please explain what `mt6373_set_vcn33_3_voltage` is for in the commit message. OK, I will explain more detail in commit message. https://review.coreboot.org/c/coreboot/+/85952/comment/95491d94_8f6ff528?us… : PS3, Line 12: BUG=b:343351631 > Also add b:353464237 OK, I will add it. File src/mainboard/google/rauru/mainboard.c: https://review.coreboot.org/c/coreboot/+/85952/comment/5dee104b_a45fab02?us… : PS3, Line 107: else > Add {} OK, I will fix it. -- To view, visit https://review.coreboot.org/c/coreboot/+/85952?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic928b2478c41ccd03223fd2b73d9e81d303a2036 Gerrit-Change-Number: 85952 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 09:40:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[L] Change in coreboot[main]: soc/mediatek/mt8196: Add DDP driver
by Nancy Lin (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu. Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email ) Change subject: soc/mediatek/mt8196: Add DDP driver ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/85950/comment/3eae30c2_896e6a7e?us… : PS2, Line 7: soc/mediatek/mt8196: Add display driver : : Add mt8196 firmware display support. : : TEST=build pass. : BUG=b:343351631 > Please revise the commit message Done File src/soc/mediatek/mt8196/include/soc/ddp.h: https://review.coreboot.org/c/coreboot/+/85950/comment/41b78f6c_58d57eb1?us… : PS2, Line 12: 0xffffffff > upper case Done -- To view, visit https://review.coreboot.org/c/coreboot/+/85950?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I006911e83d940c1eec7135a6a0c36fbfa2aad466 Gerrit-Change-Number: 85950 Gerrit-PatchSet: 3 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Nancy Lin <nancy.lin(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 09:23:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025