coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: soc/amd/glinda/cpu: Update cache info
by Angel Pons (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Jérémy Compostella, Naresh Solanki. Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email ) Change subject: soc/amd/glinda/cpu: Update cache info ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/glinda/cpu.c: https://review.coreboot.org/c/coreboot/+/85640/comment/d907b37d_3c0293b6?us… : PS3, Line 66: memcpy(info, &info_list[0], sizeof(*info)); > This part may need some optimisation. The caller expect data for as part of struct info. […] Oh, wait. This is only copying one element of the array. ```suggestion *info = info_list[0]; ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/85640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6 Gerrit-Change-Number: 85640 Gerrit-PatchSet: 3 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:42:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Naresh Solanki <naresh.solanki(a)9elements.com>

1 0

[M] Change in coreboot[main]: CFR: add dependencies based on specific option values
by Angel Pons (Code Review) 15 Jan '25

15 Jan '25

Attention is currently required from: Filip Brozovic, Matt DeVillier. Angel Pons has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/85987?usp=email ) Change subject: CFR: add dependencies based on specific option values ...................................................................... Patch Set 1: (2 comments) File src/drivers/option/cfr_frontend.h: https://review.coreboot.org/c/coreboot/+/85987/comment/33ac5d07_4a4c3a6e?us… : PS1, Line 115: .dep_values = ((const uint32_t[]) { __VA_ARGS__ }), \ Does this work? I'm not sure where the array will be stored. https://review.coreboot.org/c/coreboot/+/85987/comment/dca9ecae_ff3667b5?us… : PS1, Line 116: .num_dep_values = sizeof((uint32_t[]) { __VA_ARGS__ }) / sizeof(uint32_t) ARRAY_SIZE macro exists -- To view, visit https://review.coreboot.org/c/coreboot/+/85987?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iaf7965551490969052eb27c207fa524470d4dd6a Gerrit-Change-Number: 85987 Gerrit-PatchSet: 1 Gerrit-Owner: Filip Brozovic <fbrozovic(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Filip Brozovic <fbrozovic(a)gmail.com> Gerrit-Comment-Date: Wed, 15 Jan 2025 10:39:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Unset ADD_ITE_BINARY
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85973?usp=email ) Change subject: mb/starlabs/*: Unset ADD_ITE_BINARY ...................................................................... mb/starlabs/*: Unset ADD_ITE_BINARY This has always been set in downstream defconfig's; remove it here to avoid build issues with Jenkin's being unable to find a suitable EC binary. Change-Id: I02a10211d7cec9a2c8a0837f77ca17acdcb06c22 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85973 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/Kconfig M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starfighter/Kconfig M src/mainboard/starlabs/starlite_adl/Kconfig 4 files changed, 0 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/Kconfig b/src/mainboard/starlabs/byte_adl/Kconfig index 1bd2fe0..77a4ea4 100644 --- a/src/mainboard/starlabs/byte_adl/Kconfig +++ b/src/mainboard/starlabs/byte_adl/Kconfig @@ -44,9 +44,6 @@ config EC_GPE_SCI default 0x6e -config EC_STARLABS_ADD_ITE_BIN - default n - config EC_STARLABS_ITE_BIN_PATH string depends on EC_STARLABS_NEED_ITE_BIN diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 4a781e6..dfae2af 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -121,9 +121,6 @@ default 0x50 if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML default 0x6e -config EC_STARLABS_ADD_ITE_BIN - default y if !BOARD_STARLABS_STARBOOK_RPL - config EC_STARLABS_BATTERY_MODEL default "AEC3987118-2S1P" if BOARD_STARLABS_LABTOP_KBL || BOARD_STARLABS_LABTOP_CML default "597077-3S" diff --git a/src/mainboard/starlabs/starfighter/Kconfig b/src/mainboard/starlabs/starfighter/Kconfig index 05d677e..e9c3b63 100644 --- a/src/mainboard/starlabs/starfighter/Kconfig +++ b/src/mainboard/starlabs/starfighter/Kconfig @@ -65,9 +65,6 @@ config EC_GPE_SCI default 0x6e -config EC_STARLABS_ADD_ITE_BIN - default n - config EC_STARLABS_BATTERY_MODEL default "AEC617573-4S1P" diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 1a0b15a..55a66be 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -58,9 +58,6 @@ config EC_GPE_SCI default 0x6e -config EC_STARLABS_ADD_ITE_BIN - default n - config EC_STARLABS_BATTERY_MODEL default "AEC3756153-2S1P-N" -- To view, visit https://review.coreboot.org/c/coreboot/+/85973?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I02a10211d7cec9a2c8a0837f77ca17acdcb06c22 Gerrit-Change-Number: 85973 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starlite: Add smart battery variant
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85701?usp=email ) Change subject: mb/starlabs/starlite: Add smart battery variant ...................................................................... mb/starlabs/starlite: Add smart battery variant Add Kconfig options for `_SB`, the smart battery variant which is identical apart from a different EC which supports a Smart Battery instead of the CW2015. Change-Id: I1e04ea26ef597ce542a7348982d056fb55de0d22 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85701 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starlite_adl/Kconfig M src/mainboard/starlabs/starlite_adl/Kconfig.name 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 7791a50..1a0b15a 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -34,6 +34,9 @@ config BOARD_STARLABS_LITE_ADL select BOARD_STARLABS_STARLITE_SERIES +config BOARD_STARLABS_LITE_ADL_SB + select BOARD_STARLABS_STARLITE_SERIES + if BOARD_STARLABS_STARLITE_SERIES config CCD_PORT @@ -70,6 +73,7 @@ config EC_STARLABS_ITE_BIN_PATH string depends on EC_STARLABS_NEED_ITE_BIN + default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/mk_v_sb/ec.bin" if BOARD_STARLABS_LITE_ADL_SB default "3rdparty/blobs/mainboard/\$(MAINBOARDDIR)/\$(CONFIG_VARIANT_DIR)/ec.bin" config EC_VARIANT_DIR @@ -88,6 +92,7 @@ config MAINBOARD_FAMILY string + default "I5-SB" if BOARD_STARLABS_LITE_ADL_SB default "I5" config MAINBOARD_PART_NUMBER diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig.name b/src/mainboard/starlabs/starlite_adl/Kconfig.name index 4be49f9..5d66e61 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig.name +++ b/src/mainboard/starlabs/starlite_adl/Kconfig.name @@ -2,3 +2,6 @@ config BOARD_STARLABS_LITE_ADL bool "Star Labs Lite Mk V (N200)" + +config BOARD_STARLABS_LITE_ADL_SB + bool "Star Labs Lite Mk V Smart Battery (N200)" -- To view, visit https://review.coreboot.org/c/coreboot/+/85701?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e04ea26ef597ce542a7348982d056fb55de0d22 Gerrit-Change-Number: 85701 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Organise the Kconfig options
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85972?usp=email ) Change subject: mb/starlabs/starlite_adl: Organise the Kconfig options ...................................................................... mb/starlabs/starlite_adl: Organise the Kconfig options The selected options were a bit illogical, so but them all under the common board Kconfig, alphabetise and dedpulicate them. Change-Id: I277249323e8735dda0a6e394e475435ddedf5537 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85972 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starlite_adl/Kconfig 1 file changed, 11 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 0dda164..7791a50 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -1,39 +1,38 @@ config BOARD_STARLABS_STARLITE_SERIES def_bool n select BOARD_ROMSIZE_KB_16384 + select CRB_TPM select DRIVERS_EFI_VARIABLE_STORE - select DRIVERS_OPTION_CFR select DRIVERS_I2C_HID + select DRIVERS_INTEL_PMC + select DRIVERS_OPTION_CFR select EC_STARLABS_CHARGING_SPEED - select EC_STARLABS_LID_SWITCH select EC_STARLABS_ITE + select EC_STARLABS_LID_SWITCH select EC_STARLABS_MAX_CHARGE select EC_STARLABS_MERLIN select EC_STARLABS_NEED_ITE_BIN select EC_STARLABS_POWER_LED select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES + select HAVE_INTEL_PTT select HAVE_OPTION_TABLE select HAVE_SPD_IN_CBFS select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE select NO_UART_ON_SUPERIO - select SOC_INTEL_COMMON_BLOCK_HDA_VERB - select SYSTEM_TYPE_DETACHABLE - select VALIDATE_INTEL_DESCRIPTOR - -config BOARD_STARLABS_LITE_ADL - select BOARD_ROMSIZE_KB_16384 - select BOARD_STARLABS_STARLITE_SERIES - select CRB_TPM - select DRIVERS_INTEL_PMC - select HAVE_INTEL_PTT select SOC_INTEL_ALDERLAKE select SOC_INTEL_ALDERLAKE_PCH_N + select SOC_INTEL_COMMON_BLOCK_HDA_VERB select SOC_INTEL_COMMON_BLOCK_TCSS select SOC_INTEL_CRASHLOG select SPI_FLASH_WINBOND + select SYSTEM_TYPE_DETACHABLE select TPM2 + select VALIDATE_INTEL_DESCRIPTOR + +config BOARD_STARLABS_LITE_ADL + select BOARD_STARLABS_STARLITE_SERIES if BOARD_STARLABS_STARLITE_SERIES -- To view, visit https://review.coreboot.org/c/coreboot/+/85972?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I277249323e8735dda0a6e394e475435ddedf5537 Gerrit-Change-Number: 85972 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/starlabs/lite: Put options in CFR cbtable
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/76583?usp=email ) Change subject: mb/starlabs/lite: Put options in CFR cbtable ...................................................................... mb/starlabs/lite: Put options in CFR cbtable Change-Id: I42ae5b35e6b53b5a13ec3f80180f4955db9b6ce2 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/76583 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/lite/Kconfig M src/mainboard/starlabs/lite/Makefile.mk A src/mainboard/starlabs/lite/cfr.c M src/mainboard/starlabs/lite/cmos.default M src/mainboard/starlabs/lite/cmos.layout D src/mainboard/starlabs/lite/variants/glkr/cmos.default D src/mainboard/starlabs/lite/variants/glkr/cmos.layout 7 files changed, 224 insertions(+), 201 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/lite/Kconfig b/src/mainboard/starlabs/lite/Kconfig index 4e0deb2..1f5c766 100644 --- a/src/mainboard/starlabs/lite/Kconfig +++ b/src/mainboard/starlabs/lite/Kconfig @@ -3,6 +3,8 @@ config BOARD_STARLABS_LITE_SERIES def_bool n select BOARD_ROMSIZE_KB_8192 + select DRIVERS_EFI_VARIABLE_STORE + select DRIVERS_OPTION_CFR select DRIVERS_I2C_HID select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES @@ -35,12 +37,6 @@ if BOARD_STARLABS_LITE_SERIES -config CMOS_DEFAULT_FILE - default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.default" if BOARD_STARLABS_LITE_GLKR - -config CMOS_LAYOUT_FILE - default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.layout" if BOARD_STARLABS_LITE_GLKR - config CONSOLE_SERIAL default n if !EDK2_DEBUG diff --git a/src/mainboard/starlabs/lite/Makefile.mk b/src/mainboard/starlabs/lite/Makefile.mk index 5cfed35..65a5241 100644 --- a/src/mainboard/starlabs/lite/Makefile.mk +++ b/src/mainboard/starlabs/lite/Makefile.mk @@ -9,6 +9,7 @@ romstage-$(CONFIG_VBOOT) += vboot.c +ramstage-$(CONFIG_DRIVERS_OPTION_CFR) += cfr.c ramstage-y += devtree.c ramstage-y += mainboard.c ramstage-y += smbios.c diff --git a/src/mainboard/starlabs/lite/cfr.c b/src/mainboard/starlabs/lite/cfr.c new file mode 100644 index 0000000..e0d22e6 --- /dev/null +++ b/src/mainboard/starlabs/lite/cfr.c @@ -0,0 +1,216 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <boot/coreboot_tables.h> +#include <commonlib/coreboot_tables.h> +#include <drivers/option/cfr_frontend.h> +#include <inttypes.h> +#include <intelblocks/pcie_rp.h> +#include <string.h> +#include <types.h> +#include <variants.h> + +static const struct sm_object boot_option = SM_DECLARE_ENUM({ + .opt_name = "boot_option", + .ui_name = "Boot Option", + .ui_helptext = "Change the boot device in the event of a failed boot", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Fallback", 0 }, + { "Normal", 1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object card_reader = SM_DECLARE_BOOL({ + .opt_name = "card_reader", + .ui_name = "Card Reader", + .ui_helptext = "Enable or disable the built-in card reader", + .default_value = true, +}); + +static const struct sm_object debug_level = SM_DECLARE_ENUM({ + .opt_name = "debug_level", + .ui_name = "Debug Level", + .ui_helptext = "Set the verbosity of the debug output.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Emergency", 0 }, + { "Alert", 1 }, + { "Critical", 2 }, + { "Error", 3 }, + { "Warning", 4 }, + { "Notice", 5 }, + { "Info", 6 }, + { "Debug", 7 }, + { "Spew", 8 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(EC_STARLABS_FAST_CHARGE) +static const struct sm_object fast_charge = SM_DECLARE_BOOL({ + .opt_name = "fast_charge", + .ui_name = "Fast Charge", + .ui_helptext = "Charge the battery faster at the cost of heat and battery wear.", + .default_value = false, +}); +#endif + +static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ + .opt_name = "fn_ctrl_swap", + .ui_name = "Fn Ctrl Reverse", + .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", + .default_value = false, +}); + +static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ + .opt_name = "kbl_timeout", + .ui_name = "Keyboard Backlight Timeout", + .ui_helptext = "Set the amount of time before the keyboard backlight turns off" + " when un-used", + .default_value = 0, + .values = (struct sm_enum_value[]) { + { "30 seconds", 0 }, + { "1 minute", 1 }, + { "3 minutes", 2 }, + { "5 minutes", 3 }, + { "Never", 4 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object power_on_after_fail = SM_DECLARE_BOOL({ + .opt_name = "power_on_after_fail", + .ui_name = "Power on after failure", + .ui_helptext = "Automatically turn on after a power failure", + .default_value = false, +}); + +static const struct sm_object power_profile = SM_DECLARE_ENUM({ + .opt_name = "power_profile", + .ui_name = "Power Profile", + .ui_helptext = "Select whether to maximize performance, battery life or both.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Power Saver", PP_POWER_SAVER }, + { "Balanced", PP_BALANCED }, + { "Performance", PP_PERFORMANCE }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object microphone = SM_DECLARE_BOOL({ + .opt_name = "microphone", + .ui_name = "Microphone", + .ui_helptext = "Enable or disable the built-in microphone", + .default_value = true, +}); + +static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ + .opt_name = "reboot_counter", + .ui_name = "Reboot Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object webcam = SM_DECLARE_BOOL({ + .opt_name = "webcam", + .ui_name = "Webcam", + .ui_helptext = "Enable or disable the built-in webcam", + .default_value = true, +}); + +static const struct sm_object wireless = SM_DECLARE_BOOL({ + .opt_name = "wireless", + .ui_name = "Wireless", + .ui_helptext = "Enable or disable the built-in wireless card", + .default_value = true, +}); + +static const struct sm_object vtd = SM_DECLARE_BOOL({ + .opt_name = "vtd", + .ui_name = "VT-d", + .ui_helptext = "Enable or disable Intel VT-d (virtualization)", + .default_value = true, +}); + +static struct sm_obj_form performance = { + .ui_name = "Performance", + .obj_list = (const struct sm_object *[]) { + &power_profile, + NULL + }, +}; + +static struct sm_obj_form processor = { + .ui_name = "Processor", + .obj_list = (const struct sm_object *[]) { + &vtd, + NULL + }, +}; + +static struct sm_obj_form power = { + .ui_name = "Power", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(EC_STARLABS_FAST_CHARGE) + &fast_charge, + #endif + &power_on_after_fail, + NULL + }, +}; + +static struct sm_obj_form keyboard = { + .ui_name = "Keyboard", + .obj_list = (const struct sm_object *[]) { + &kbl_timeout, + &fn_ctrl_swap, + NULL + }, +}; + +static struct sm_obj_form devices = { + .ui_name = "Devices", + .obj_list = (const struct sm_object *[]) { + &card_reader, + &microphone, + &webcam, + &wireless, + NULL + }, +}; + +static struct sm_obj_form pci = { + .ui_name = "PCI", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(SOC_INTEL_ALDERLAKE) + &pciexp_clk_pm, + &pciexp_aspm, + &pciexp_l1ss, + #endif + NULL + }, +}; + +static struct sm_obj_form coreboot = { + .ui_name = "coreboot", + .obj_list = (const struct sm_object *[]) { + &boot_option, + &debug_level, + &reboot_counter, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &performance, + &processor, + &power, + &keyboard, + &devices, + &pci, + &coreboot, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +} diff --git a/src/mainboard/starlabs/lite/cmos.default b/src/mainboard/starlabs/lite/cmos.default index 7bf045b..49faae3 100644 --- a/src/mainboard/starlabs/lite/cmos.default +++ b/src/mainboard/starlabs/lite/cmos.default @@ -1,19 +1,4 @@ ## SPDX-License-Identifier: GPL-2.0-only - -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -vtd=Enable -power_profile=Balanced -# Devices -wireless=Enable -webcam=Enable -legacy_8254_timer=Disable -# EC -kbl_timeout=30 seconds -fn_ctrl_swap=Disable # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/lite/cmos.layout b/src/mainboard/starlabs/lite/cmos.layout index ca77291..3057eff 100644 --- a/src/mainboard/starlabs/lite/cmos.layout +++ b/src/mainboard/starlabs/lite/cmos.layout @@ -9,25 +9,10 @@ # ----------------------------------------------------------------- # RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option 388 4 h 0 reboot_counter -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level # coreboot config options: cpu #400 8 r 0 reserved for century byte -416 1 e 1 vtd -424 2 e 7 power_profile - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 webcam -528 1 e 1 legacy_8254_timer - -# coreboot config options: EC -600 3 e 4 kbl_timeout -608 1 e 1 fn_ctrl_swap # coreboot config options: check sums 984 16 h 0 check_sum @@ -36,7 +21,7 @@ # embedded controller settings (outside the checksummed area) 1024 8 h 1 fn_lock_state 1032 8 h 1 trackpad_state -1040 8 h 10 kbl_brightness +1040 8 h 2 kbl_brightness 1048 8 h 1 kbl_state # ----------------------------------------------------------------- @@ -47,48 +32,10 @@ 1 0 Disable 1 1 Enable -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 30 seconds -4 1 1 minute -4 2 3 minutes -4 3 5 minutes -4 4 Never - -5 0 Enable -5 1 Disable - -6 0 Disable -6 1 Enable -6 2 Keep - -7 0 Power Saver -7 1 Balanced -7 2 Performance - -8 0 100% -8 1 80% -8 2 60% - -9 0 Normal -9 1 Aggressive -9 2 Quiet - -10 0 Off -10 1 Low -10 2 High -10 3 On +2 0 Off +2 1 Low +2 2 High +2 3 On # ----------------------------------------------------------------- checksums diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.default b/src/mainboard/starlabs/lite/variants/glkr/cmos.default deleted file mode 100644 index 6bf32d0..0000000 --- a/src/mainboard/starlabs/lite/variants/glkr/cmos.default +++ /dev/null @@ -1,22 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -vtd=Enable -power_profile=Balanced -# Devices -wireless=Enable -webcam=Enable -legacy_8254_timer=Disable -# EC -kbl_timeout=30 seconds -fn_ctrl_swap=Disable -fast_charge=Normal -# Functions -fn_lock_state=0x1 -trackpad_state=0x1 -kbl_brightness=0x0 -kbl_state=0x1 diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout deleted file mode 100644 index edca818..0000000 --- a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout +++ /dev/null @@ -1,100 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only - -# ----------------------------------------------------------------- -entries - -# Bank: 1 -# ----------------------------------------------------------------- -0 120 r 0 reserved_memory - -# ----------------------------------------------------------------- -# RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option -388 4 h 0 reboot_counter - -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level -# coreboot config options: cpu -#400 8 r 0 reserved for century byte -416 1 e 1 vtd -424 2 e 7 power_profile - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 webcam -528 1 e 1 legacy_8254_timer - -# coreboot config options: EC -600 3 e 4 kbl_timeout -608 1 e 1 fn_ctrl_swap -616 1 e 11 fast_charge - -# coreboot config options: check sums -984 16 h 0 check_sum - -# Bank: 2 -# embedded controller settings (outside the checksummed area) -1024 8 h 1 fn_lock_state -1032 8 h 1 trackpad_state -1040 8 h 10 kbl_brightness -1048 8 h 1 kbl_state - -# ----------------------------------------------------------------- - -enumerations - -#ID value text -1 0 Disable -1 1 Enable - -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 30 seconds -4 1 1 minute -4 2 3 minutes -4 3 5 minutes -4 4 Never - -5 0 Enable -5 1 Disable - -6 0 Disable -6 1 Enable -6 2 Keep - -7 0 Power Saver -7 1 Balanced -7 2 Performance - -8 0 100% -8 1 80% -8 2 60% - -9 0 Normal -9 1 Aggressive -9 2 Quiet - -10 0 Off -10 1 Low -10 2 High -10 3 On - -11 0 Normal -11 1 Fast - -# ----------------------------------------------------------------- -checksums - -checksum 392 983 984 -- To view, visit https://review.coreboot.org/c/coreboot/+/76583?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I42ae5b35e6b53b5a13ec3f80180f4955db9b6ce2 Gerrit-Change-Number: 76583 Gerrit-PatchSet: 19 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/starlabs/starlite_adl: Put options in CFR cbtable
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85711?usp=email ) Change subject: mb/starlabs/starlite_adl: Put options in CFR cbtable ...................................................................... mb/starlabs/starlite_adl: Put options in CFR cbtable Change-Id: If92f61dece7e67bfd2e29927198c9ebb81c4d363 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85711 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starlite_adl/Kconfig A src/mainboard/starlabs/starlite_adl/cfr.c D src/mainboard/starlabs/starlite_adl/cmos.default M src/mainboard/starlabs/starlite_adl/cmos.layout 4 files changed, 326 insertions(+), 80 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starlite_adl/Kconfig b/src/mainboard/starlabs/starlite_adl/Kconfig index 41d6c23..0dda164 100644 --- a/src/mainboard/starlabs/starlite_adl/Kconfig +++ b/src/mainboard/starlabs/starlite_adl/Kconfig @@ -1,5 +1,8 @@ config BOARD_STARLABS_STARLITE_SERIES def_bool n + select BOARD_ROMSIZE_KB_16384 + select DRIVERS_EFI_VARIABLE_STORE + select DRIVERS_OPTION_CFR select DRIVERS_I2C_HID select EC_STARLABS_CHARGING_SPEED select EC_STARLABS_LID_SWITCH @@ -10,7 +13,6 @@ select EC_STARLABS_POWER_LED select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select HAVE_SPD_IN_CBFS select INTEL_GMA_HAVE_VBT diff --git a/src/mainboard/starlabs/starlite_adl/cfr.c b/src/mainboard/starlabs/starlite_adl/cfr.c new file mode 100644 index 0000000..4cd31d9 --- /dev/null +++ b/src/mainboard/starlabs/starlite_adl/cfr.c @@ -0,0 +1,323 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <boot/coreboot_tables.h> +#include <commonlib/coreboot_tables.h> +#include <drivers/option/cfr_frontend.h> +#include <inttypes.h> +#include <intelblocks/pcie_rp.h> +#include <string.h> +#include <types.h> +#include <variants.h> + +static const struct sm_object accelerometer = SM_DECLARE_BOOL({ + .opt_name = "accelerometer", + .ui_name = "Accelerometer", + .ui_helptext = "Enable or disable the built-in accelerometer", + .default_value = true, +}); + +static const struct sm_object boot_option = SM_DECLARE_ENUM({ + .opt_name = "boot_option", + .ui_name = "Boot Option", + .ui_helptext = "Change the boot device in the event of a failed boot", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Fallback", 0 }, + { "Normal", 1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object camera = SM_DECLARE_BOOL({ + .opt_name = "camera", + .ui_name = "Camera", + .ui_helptext = "Enable or disable the built-in camera", + .default_value = true, +}); + +#if CONFIG(EC_STARLABS_CHARGING_SPEED) +static const struct sm_object charging_speed = SM_DECLARE_ENUM({ + .opt_name = "charging_speed", + .ui_name = "Charging Speed", + .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" + " will increase heat and battery wear.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "1.0C", 0 }, + { "0.5C", 1 }, + { "0.2C", 2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object debug_level = SM_DECLARE_ENUM({ + .opt_name = "debug_level", + .ui_name = "Debug Level", + .ui_helptext = "Set the verbosity of the debug output.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Emergency", 0 }, + { "Alert", 1 }, + { "Critical", 2 }, + { "Error", 3 }, + { "Warning", 4 }, + { "Notice", 5 }, + { "Info", 6 }, + { "Debug", 7 }, + { "Spew", 8 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) +static const struct sm_object gna = SM_DECLARE_BOOL({ + .opt_name = "gna", + .ui_name = "Gaussian & Neural Accelerator", + .ui_helptext = "Enable or Disable the Gaussian & Neural Accelerator", + .default_value = false, +}); +#endif + +#if CONFIG(EC_STARLABS_LID_SWITCH) +static const struct sm_object lid_switch = SM_DECLARE_ENUM({ + .opt_name = "lid_switch", + .ui_name = "Lid Switch", + .ui_helptext = "Enable or disable the lid switch.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Enabled", 0 }, + { "Disabled", 1 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object max_charge = SM_DECLARE_ENUM({ + .opt_name = "max_charge", + .ui_name = "Maximum Charge Level", + .ui_helptext = "Set the maximum level the battery will charge to.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "100%", 0 }, + { "80%", 1 }, + { "60%", 2 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state = SM_DECLARE_ENUM({ + .opt_name = "me_state", + .ui_name = "Intel Management Engine", + .ui_helptext = "Enable or disable the Intel Management Engine", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Disabled", 1 }, + { "Enabled", 0 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state_counter = SM_DECLARE_NUMBER({ + .opt_name = "me_state_counter", + .ui_name = "ME State Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object memory_speed = SM_DECLARE_ENUM({ + .opt_name = "memory_speed", + .ui_name = "Memory Speed", + .ui_helptext = "Configure the speed that the memory will run at. Higher speeds produce more heat and consume more power but provide higher performance.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "5500MT/s", 0 }, + { "6400MT/s", 1 }, + { "7500MT/s", 2 }, + SM_ENUM_VALUE_END, + } +}); + +static const struct sm_object power_on_after_fail = SM_DECLARE_BOOL({ + .opt_name = "power_on_after_fail", + .ui_name = "Power on after failure", + .ui_helptext = "Automatically turn on after a power failure", + .default_value = false, +}); + +static const struct sm_object power_profile = SM_DECLARE_ENUM({ + .opt_name = "power_profile", + .ui_name = "Power Profile", + .ui_helptext = "Select whether to maximize performance, battery life or both.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Power Saver", PP_POWER_SAVER }, + { "Balanced", PP_BALANCED }, + { "Performance", PP_PERFORMANCE }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object microphone = SM_DECLARE_BOOL({ + .opt_name = "microphone", + .ui_name = "Microphone", + .ui_helptext = "Enable or disable the built-in microphone", + .default_value = true, +}); + +#if CONFIG(SOC_INTEL_ALDERLAKE) +static const struct sm_object pciexp_aspm = SM_DECLARE_ENUM({ + .opt_name = "pciexp_aspm", + .ui_name = "PCI ASPM", + .ui_helptext = "Controls the Active State Power Management for PCI devices." + " Enabling this feature can reduce power consumption of" + " PCI-connected devices during idle times.", + .default_value = ASPM_L0S_L1, + .values = (const struct sm_enum_value[]) { + { "Disabled", ASPM_DISABLE }, + { "L0s", ASPM_L0S }, + { "L1", ASPM_L1 }, + { "L0sL1", ASPM_L0S_L1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object pciexp_clk_pm = SM_DECLARE_BOOL({ + .opt_name = "pciexp_clk_pm", + .ui_name = "PCI Clock Power Management", + .ui_helptext = "Enables or disables power management for the PCI clock. When" + " enabled, it reduces power consumption during idle states." + " This can help lower overall energy use but may impact" + " performance in power-sensitive tasks.", + .default_value = true, +}); + +static const struct sm_object pciexp_l1ss = SM_DECLARE_ENUM({ + .opt_name = "pciexp_l1ss", + .ui_name = "PCI L1 Substates", + .ui_helptext = "Controls deeper power-saving states for PCI devices." + " Enabling this feature allows supported devices to achieve" + " lower power states at the cost of slightly increased" + " latency when exiting these states.", + .default_value = L1_SS_L1_2, + .values = (const struct sm_enum_value[]) { + { "Disabled", L1_SS_DISABLED }, + { "L1.1", L1_SS_L1_1 }, + { "L1.2", L1_SS_L1_2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ + .opt_name = "reboot_counter", + .ui_name = "Reboot Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object touchscreen = SM_DECLARE_BOOL({ + .opt_name = "touchscreen", + .ui_name = "Touchscreen", + .ui_helptext = "Enable or disable the built-in touch-screen", + .default_value = true, +}); + +static const struct sm_object webcam = SM_DECLARE_BOOL({ + .opt_name = "webcam", + .ui_name = "Webcam", + .ui_helptext = "Enable or disable the built-in webcam", + .default_value = true, +}); + +static const struct sm_object wireless = SM_DECLARE_BOOL({ + .opt_name = "wireless", + .ui_name = "Wireless", + .ui_helptext = "Enable or disable the built-in wireless card", + .default_value = true, +}); + +static const struct sm_object vtd = SM_DECLARE_BOOL({ + .opt_name = "vtd", + .ui_name = "VT-d", + .ui_helptext = "Enable or disable Intel VT-d (virtualization)", + .default_value = true, +}); + +static struct sm_obj_form performance = { + .ui_name = "Performance", + .obj_list = (const struct sm_object *[]) { + &memory_speed, + &power_profile, + NULL + }, +}; + +static struct sm_obj_form processor = { + .ui_name = "Processor", + .obj_list = (const struct sm_object *[]) { + &me_state, + &me_state_counter, + &vtd, + NULL + }, +}; + +static struct sm_obj_form power = { + .ui_name = "Power", + .obj_list = (const struct sm_object *[]) { + &max_charge, + #if CONFIG(EC_STARLABS_CHARGING_SPEED) + &charging_speed, + #endif + &power_on_after_fail, + NULL + }, +}; + +static struct sm_obj_form devices = { + .ui_name = "Devices", + .obj_list = (const struct sm_object *[]) { + &accelerometer, + &camera, + #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) + &gna, + #endif + #if CONFIG(EC_STARLABS_LID_SWITCH) + &lid_switch, + #endif + &microphone, + &touchscreen, + &webcam, + &wireless, + NULL + }, +}; + +static struct sm_obj_form pci = { + .ui_name = "PCI", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(SOC_INTEL_ALDERLAKE) + &pciexp_clk_pm, + &pciexp_aspm, + &pciexp_l1ss, + #endif + NULL + }, +}; + +static struct sm_obj_form coreboot = { + .ui_name = "coreboot", + .obj_list = (const struct sm_object *[]) { + &boot_option, + &debug_level, + &reboot_counter, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &performance, + &processor, + &power, + &devices, + &pci, + &coreboot, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +} diff --git a/src/mainboard/starlabs/starlite_adl/cmos.default b/src/mainboard/starlabs/starlite_adl/cmos.default deleted file mode 100644 index 2a772fc..0000000 --- a/src/mainboard/starlabs/starlite_adl/cmos.default +++ /dev/null @@ -1,21 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -vtd=Enable -power_profile=Balanced -me_state=Disable -memory_speed=5500 -# Devices -wireless=Enable -webcam=Enable -camera=Enable -microphone=Enable -lid_switch=Disable -power_led=Normal -gna=Disable -# EC -charging_speed=0.5C diff --git a/src/mainboard/starlabs/starlite_adl/cmos.layout b/src/mainboard/starlabs/starlite_adl/cmos.layout index 60441e0..f78701f 100644 --- a/src/mainboard/starlabs/starlite_adl/cmos.layout +++ b/src/mainboard/starlabs/starlite_adl/cmos.layout @@ -12,39 +12,16 @@ 304 80 h 0 ramtop # RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option 388 4 h 0 reboot_counter -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level # coreboot config options: cpu #400 8 r 0 reserved for century byte -408 1 e 1 vtd -416 2 e 5 power_profile -424 1 e 4 me_state -432 4 h 0 me_state_counter -440 2 e 8 memory_speed - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 webcam -520 1 e 1 camera -528 1 e 1 microphone -536 1 e 1 lid_switch -542 1 e 9 power_led -550 1 e 1 gna - -# coreboot config options: EC -600 2 e 6 max_charge -608 2 e 11 charging_speed # coreboot config options: check sums 984 16 h 0 check_sum # Bank: 2 # embedded controller settings (outside the checksummed area) - # ----------------------------------------------------------------- enumerations @@ -53,41 +30,6 @@ 1 0 Disable 1 1 Enable -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 Enable -4 1 Disable - -5 0 Power Saver -5 1 Balanced -5 2 Performance - -6 0 100% -6 1 80% -6 2 60% - -7 0 1.0C -7 1 0.5C -7 2 0.2C - -8 0 5500MT/s -8 1 6400MT/s -8 2 7500MT/s - -9 0 Normal -9 1 Reduced - # ----------------------------------------------------------------- checksums -- To view, visit https://review.coreboot.org/c/coreboot/+/85711?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If92f61dece7e67bfd2e29927198c9ebb81c4d363 Gerrit-Change-Number: 85711 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/starlabs/byte_adl: Put options in CFR cbtable
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85710?usp=email ) Change subject: mb/starlabs/byte_adl: Put options in CFR cbtable ...................................................................... mb/starlabs/byte_adl: Put options in CFR cbtable Change-Id: I11349397e41fb2c7a3f26ab172a2c4b30d24bc0a Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85710 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/byte_adl/Kconfig A src/mainboard/starlabs/byte_adl/cfr.c D src/mainboard/starlabs/byte_adl/cmos.default M src/mainboard/starlabs/byte_adl/cmos.layout 4 files changed, 216 insertions(+), 47 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/Kconfig b/src/mainboard/starlabs/byte_adl/Kconfig index 7a28093..1bd2fe0 100644 --- a/src/mainboard/starlabs/byte_adl/Kconfig +++ b/src/mainboard/starlabs/byte_adl/Kconfig @@ -1,9 +1,10 @@ config BOARD_STARLABS_BYTE_SERIES def_bool n + select DRIVERS_EFI_VARIABLE_STORE + select DRIVERS_OPTION_CFR select EC_STARLABS_ITE select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select HAVE_CMOS_DEFAULT select HAVE_OPTION_TABLE select INTEL_GMA_HAVE_VBT select INTEL_LPSS_UART_FOR_CONSOLE diff --git a/src/mainboard/starlabs/byte_adl/cfr.c b/src/mainboard/starlabs/byte_adl/cfr.c new file mode 100644 index 0000000..81d74b9 --- /dev/null +++ b/src/mainboard/starlabs/byte_adl/cfr.c @@ -0,0 +1,214 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <boot/coreboot_tables.h> +#include <commonlib/coreboot_tables.h> +#include <drivers/option/cfr_frontend.h> +#include <inttypes.h> +#include <intelblocks/pcie_rp.h> +#include <string.h> +#include <types.h> +#include <variants.h> + +static const struct sm_object boot_option = SM_DECLARE_ENUM({ + .opt_name = "boot_option", + .ui_name = "Boot Option", + .ui_helptext = "Change the boot device in the event of a failed boot", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Fallback", 0 }, + { "Normal", 1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object debug_level = SM_DECLARE_ENUM({ + .opt_name = "debug_level", + .ui_name = "Debug Level", + .ui_helptext = "Set the verbosity of the debug output.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Emergency", 0 }, + { "Alert", 1 }, + { "Critical", 2 }, + { "Error", 3 }, + { "Warning", 4 }, + { "Notice", 5 }, + { "Info", 6 }, + { "Debug", 7 }, + { "Spew", 8 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) +static const struct sm_object gna = SM_DECLARE_BOOL({ + .opt_name = "gna", + .ui_name = "Gaussian & Neural Accelerator", + .ui_helptext = "Enable or Disable the Gaussian & Neural Accelerator", + .default_value = false, +}); +#endif + +static const struct sm_object me_state = SM_DECLARE_ENUM({ + .opt_name = "me_state", + .ui_name = "Intel Management Engine", + .ui_helptext = "Enable or disable the Intel Management Engine", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Disabled", 1 }, + { "Enabled", 0 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state_counter = SM_DECLARE_NUMBER({ + .opt_name = "me_state_counter", + .ui_name = "ME State Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object power_on_after_fail = SM_DECLARE_BOOL({ + .opt_name = "power_on_after_fail", + .ui_name = "Power on after failure", + .ui_helptext = "Automatically turn on after a power failure", + .default_value = false, +}); + +static const struct sm_object power_profile = SM_DECLARE_ENUM({ + .opt_name = "power_profile", + .ui_name = "Power Profile", + .ui_helptext = "Select whether to maximize performance, battery life or both.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Power Saver", PP_POWER_SAVER }, + { "Balanced", PP_BALANCED }, + { "Performance", PP_PERFORMANCE }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(SOC_INTEL_ALDERLAKE) +static const struct sm_object pciexp_aspm = SM_DECLARE_ENUM({ + .opt_name = "pciexp_aspm", + .ui_name = "PCI ASPM", + .ui_helptext = "Controls the Active State Power Management for PCI devices." + " Enabling this feature can reduce power consumption of" + " PCI-connected devices during idle times.", + .default_value = ASPM_L0S_L1, + .values = (const struct sm_enum_value[]) { + { "Disabled", ASPM_DISABLE }, + { "L0s", ASPM_L0S }, + { "L1", ASPM_L1 }, + { "L0sL1", ASPM_L0S_L1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object pciexp_clk_pm = SM_DECLARE_BOOL({ + .opt_name = "pciexp_clk_pm", + .ui_name = "PCI Clock Power Management", + .ui_helptext = "Enables or disables power management for the PCI clock. When" + " enabled, it reduces power consumption during idle states." + " This can help lower overall energy use but may impact" + " performance in power-sensitive tasks.", + .default_value = true, +}); + +static const struct sm_object pciexp_l1ss = SM_DECLARE_ENUM({ + .opt_name = "pciexp_l1ss", + .ui_name = "PCI L1 Substates", + .ui_helptext = "Controls deeper power-saving states for PCI devices." + " Enabling this feature allows supported devices to achieve" + " lower power states at the cost of slightly increased" + " latency when exiting these states.", + .default_value = L1_SS_L1_2, + .values = (const struct sm_enum_value[]) { + { "Disabled", L1_SS_DISABLED }, + { "L1.1", L1_SS_L1_1 }, + { "L1.2", L1_SS_L1_2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ + .opt_name = "reboot_counter", + .ui_name = "Reboot Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object vtd = SM_DECLARE_BOOL({ + .opt_name = "vtd", + .ui_name = "VT-d", + .ui_helptext = "Enable or disable Intel VT-d (virtualization)", + .default_value = true, +}); + +static struct sm_obj_form performance = { + .ui_name = "Performance", + .obj_list = (const struct sm_object *[]) { + &power_profile, + NULL + }, +}; + +static struct sm_obj_form processor = { + .ui_name = "Processor", + .obj_list = (const struct sm_object *[]) { + &me_state, + &me_state_counter, + &vtd, + NULL + }, +}; + +static struct sm_obj_form power = { + .ui_name = "Power", + .obj_list = (const struct sm_object *[]) { + &power_on_after_fail, + NULL + }, +}; + +static struct sm_obj_form devices = { + .ui_name = "Devices", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) + &gna, + #endif + NULL + }, +}; + +static struct sm_obj_form pci = { + .ui_name = "PCI", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(SOC_INTEL_ALDERLAKE) + &pciexp_clk_pm, + &pciexp_aspm, + &pciexp_l1ss, + #endif + NULL + }, +}; + +static struct sm_obj_form coreboot = { + .ui_name = "coreboot", + .obj_list = (const struct sm_object *[]) { + &boot_option, + &debug_level, + &reboot_counter, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &performance, + &processor, + &power, + &devices, + &pci, + &coreboot, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +} diff --git a/src/mainboard/starlabs/byte_adl/cmos.default b/src/mainboard/starlabs/byte_adl/cmos.default deleted file mode 100644 index 619729f..0000000 --- a/src/mainboard/starlabs/byte_adl/cmos.default +++ /dev/null @@ -1,14 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -vtd=Enable -power_profile=Balanced -me_state=Disable -# Devices -wireless=Enable -webcam=Enable -gna=Disable diff --git a/src/mainboard/starlabs/byte_adl/cmos.layout b/src/mainboard/starlabs/byte_adl/cmos.layout index d780f6a..f78701f 100644 --- a/src/mainboard/starlabs/byte_adl/cmos.layout +++ b/src/mainboard/starlabs/byte_adl/cmos.layout @@ -12,22 +12,10 @@ 304 80 h 0 ramtop # RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option 388 4 h 0 reboot_counter -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level # coreboot config options: cpu #400 8 r 0 reserved for century byte -408 1 e 1 vtd -416 2 e 5 power_profile -424 1 e 4 me_state -432 4 h 0 me_state_counter - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 gna # coreboot config options: check sums 984 16 h 0 check_sum @@ -42,26 +30,6 @@ 1 0 Disable 1 1 Enable -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 Enable -4 1 Disable - -5 0 Power Saver -5 1 Balanced -5 2 Performance - # ----------------------------------------------------------------- checksums -- To view, visit https://review.coreboot.org/c/coreboot/+/85710?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I11349397e41fb2c7a3f26ab172a2c4b30d24bc0a Gerrit-Change-Number: 85710 Gerrit-PatchSet: 11 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/starlabs/starfighter: Put options in CFR cbtable
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85709?usp=email ) Change subject: mb/starlabs/starfighter: Put options in CFR cbtable ...................................................................... mb/starlabs/starfighter: Put options in CFR cbtable Change-Id: I3e3b5448282aa81a89356f1d3145381d65e47aaa Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85709 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starfighter/Kconfig M src/mainboard/starlabs/starfighter/Makefile.mk A src/mainboard/starlabs/starfighter/cfr.c M src/mainboard/starlabs/starfighter/cmos.default M src/mainboard/starlabs/starfighter/cmos.layout 5 files changed, 334 insertions(+), 95 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starfighter/Kconfig b/src/mainboard/starlabs/starfighter/Kconfig index 42c7ab6..05d677e 100644 --- a/src/mainboard/starlabs/starfighter/Kconfig +++ b/src/mainboard/starlabs/starfighter/Kconfig @@ -3,6 +3,8 @@ config BOARD_STARLABS_STARFIGHTER_SERIES def_bool n select BOARD_ROMSIZE_KB_32768 + select DRIVERS_EFI_VARIABLE_STORE + select DRIVERS_OPTION_CFR select DRIVERS_INTEL_PMC select DRIVERS_INTEL_USB4_RETIMER select DRIVERS_I2C_HID diff --git a/src/mainboard/starlabs/starfighter/Makefile.mk b/src/mainboard/starlabs/starfighter/Makefile.mk index dc26be0..f35c14f 100644 --- a/src/mainboard/starlabs/starfighter/Makefile.mk +++ b/src/mainboard/starlabs/starfighter/Makefile.mk @@ -6,6 +6,7 @@ bootblock-y += bootblock.c +ramstage-$(CONFIG_DRIVERS_OPTION_CFR) += cfr.c ramstage-y += hda_verb.c ramstage-y += mainboard.c ramstage-y += smbios.c diff --git a/src/mainboard/starlabs/starfighter/cfr.c b/src/mainboard/starlabs/starfighter/cfr.c new file mode 100644 index 0000000..6802b75 --- /dev/null +++ b/src/mainboard/starlabs/starfighter/cfr.c @@ -0,0 +1,326 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <boot/coreboot_tables.h> +#include <commonlib/coreboot_tables.h> +#include <drivers/option/cfr_frontend.h> +#include <inttypes.h> +#include <intelblocks/pcie_rp.h> +#include <string.h> +#include <types.h> +#include <variants.h> + +static const struct sm_object boot_option = SM_DECLARE_ENUM({ + .opt_name = "boot_option", + .ui_name = "Boot Option", + .ui_helptext = "Change the boot device in the event of a failed boot", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Fallback", 0 }, + { "Normal", 1 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(EC_STARLABS_CHARGING_SPEED) +static const struct sm_object charging_speed = SM_DECLARE_ENUM({ + .opt_name = "charging_speed", + .ui_name = "Charging Speed", + .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" + " will increase heat and battery wear.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "1.0C", 0 }, + { "0.5C", 1 }, + { "0.2C", 2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object debug_level = SM_DECLARE_ENUM({ + .opt_name = "debug_level", + .ui_name = "Debug Level", + .ui_helptext = "Set the verbosity of the debug output.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Emergency", 0 }, + { "Alert", 1 }, + { "Critical", 2 }, + { "Error", 3 }, + { "Warning", 4 }, + { "Notice", 5 }, + { "Info", 6 }, + { "Debug", 7 }, + { "Spew", 8 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object fan_mode = SM_DECLARE_ENUM({ + .opt_name = "fan_mode", + .ui_name = "Fan Mode", + .ui_helptext = "Adjust the fan curve to prioritize performance or noise levels.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Normal", 0 }, + { "Aggressive", 1 }, + { "Quiet", 2 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ + .opt_name = "fn_ctrl_swap", + .ui_name = "Fn Ctrl Reverse", + .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", + .default_value = false, +}); + +#if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) +static const struct sm_object gna = SM_DECLARE_BOOL({ + .opt_name = "gna", + .ui_name = "Gaussian & Neural Accelerator", + .ui_helptext = "Enable or Disable the Gaussian & Neural Accelerator", + .default_value = false, +}); +#endif + +static const struct sm_object hyper_threading = SM_DECLARE_BOOL({ + .opt_name = "hyper_threading", + .ui_name = "Hyper-Threading", + .ui_helptext = "Enable or disable Hyper-Threading", + .default_value = true, +}); + +static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ + .opt_name = "kbl_timeout", + .ui_name = "Keyboard Backlight Timeout", + .ui_helptext = "Set the amount of time before the keyboard backlight turns off" + " when un-used", + .default_value = 0, + .values = (struct sm_enum_value[]) { + { "30 seconds", 0 }, + { "1 minute", 1 }, + { "3 minutes", 2 }, + { "5 minutes", 3 }, + { "Never", 4 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(EC_STARLABS_LID_SWITCH) +static const struct sm_object lid_switch = SM_DECLARE_ENUM({ + .opt_name = "lid_switch", + .ui_name = "Lid Switch", + .ui_helptext = "Enable or disable the lid switch.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Enabled", 0 }, + { "Disabled", 1 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object max_charge = SM_DECLARE_ENUM({ + .opt_name = "max_charge", + .ui_name = "Maximum Charge Level", + .ui_helptext = "Set the maximum level the battery will charge to.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "100%", 0 }, + { "80%", 1 }, + { "60%", 2 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state = SM_DECLARE_ENUM({ + .opt_name = "me_state", + .ui_name = "Intel Management Engine", + .ui_helptext = "Enable or disable the Intel Management Engine", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Disabled", 1 }, + { "Enabled", 0 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state_counter = SM_DECLARE_NUMBER({ + .opt_name = "me_state_counter", + .ui_name = "ME State Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object power_on_after_fail = SM_DECLARE_BOOL({ + .opt_name = "power_on_after_fail", + .ui_name = "Power on after failure", + .ui_helptext = "Automatically turn on after a power failure", + .default_value = false, +}); + +static const struct sm_object power_profile = SM_DECLARE_ENUM({ + .opt_name = "power_profile", + .ui_name = "Power Profile", + .ui_helptext = "Select whether to maximize performance, battery life or both.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Power Saver", PP_POWER_SAVER }, + { "Balanced", PP_BALANCED }, + { "Performance", PP_PERFORMANCE }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(SOC_INTEL_ALDERLAKE) +static const struct sm_object pciexp_aspm = SM_DECLARE_ENUM({ + .opt_name = "pciexp_aspm", + .ui_name = "PCI ASPM", + .ui_helptext = "Controls the Active State Power Management for PCI devices." + " Enabling this feature can reduce power consumption of" + " PCI-connected devices during idle times.", + .default_value = ASPM_L0S_L1, + .values = (const struct sm_enum_value[]) { + { "Disabled", ASPM_DISABLE }, + { "L0s", ASPM_L0S }, + { "L1", ASPM_L1 }, + { "L0sL1", ASPM_L0S_L1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object pciexp_clk_pm = SM_DECLARE_BOOL({ + .opt_name = "pciexp_clk_pm", + .ui_name = "PCI Clock Power Management", + .ui_helptext = "Enables or disables power management for the PCI clock. When" + " enabled, it reduces power consumption during idle states." + " This can help lower overall energy use but may impact" + " performance in power-sensitive tasks.", + .default_value = true, +}); + +static const struct sm_object pciexp_l1ss = SM_DECLARE_ENUM({ + .opt_name = "pciexp_l1ss", + .ui_name = "PCI L1 Substates", + .ui_helptext = "Controls deeper power-saving states for PCI devices." + " Enabling this feature allows supported devices to achieve" + " lower power states at the cost of slightly increased" + " latency when exiting these states.", + .default_value = L1_SS_L1_2, + .values = (const struct sm_enum_value[]) { + { "Disabled", L1_SS_DISABLED }, + { "L1.1", L1_SS_L1_1 }, + { "L1.2", L1_SS_L1_2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ + .opt_name = "reboot_counter", + .ui_name = "Reboot Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +#if CONFIG(DRIVERS_INTEL_USB4_RETIMER) +static const struct sm_object thunderbolt = SM_DECLARE_BOOL({ + .opt_name = "thunderbolt", + .ui_name = "Thunderbolt", + .ui_helptext = "Enable or disable Thunderbolt support", + .default_value = true, +}); +#endif + +static const struct sm_object vtd = SM_DECLARE_BOOL({ + .opt_name = "vtd", + .ui_name = "VT-d", + .ui_helptext = "Enable or disable Intel VT-d (virtualization)", + .default_value = true, +}); + +static struct sm_obj_form performance = { + .ui_name = "Performance", + .obj_list = (const struct sm_object *[]) { + &fan_mode, + &power_profile, + NULL + }, +}; + +static struct sm_obj_form processor = { + .ui_name = "Processor", + .obj_list = (const struct sm_object *[]) { + &me_state, + &me_state_counter, + &hyper_threading, + &vtd, + NULL + }, +}; + +static struct sm_obj_form power = { + .ui_name = "Power", + .obj_list = (const struct sm_object *[]) { + &max_charge, + #if CONFIG(EC_STARLABS_CHARGING_SPEED) + &charging_speed, + #endif + &power_on_after_fail, + NULL + }, +}; + +static struct sm_obj_form keyboard = { + .ui_name = "Keyboard", + .obj_list = (const struct sm_object *[]) { + &kbl_timeout, + &fn_ctrl_swap, + NULL + }, +}; + +static struct sm_obj_form devices = { + .ui_name = "Devices", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) + &gna, + #endif + #if CONFIG(EC_STARLABS_LID_SWITCH) + &lid_switch, + #endif + #if CONFIG(DRIVERS_INTEL_USB4_RETIMER) + &thunderbolt, + #endif + NULL + }, +}; + +static struct sm_obj_form pci = { + .ui_name = "PCI", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(SOC_INTEL_ALDERLAKE) + &pciexp_clk_pm, + &pciexp_aspm, + &pciexp_l1ss, + #endif + NULL + }, +}; + +static struct sm_obj_form coreboot = { + .ui_name = "coreboot", + .obj_list = (const struct sm_object *[]) { + &boot_option, + &debug_level, + &reboot_counter, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &performance, + &processor, + &power, + &keyboard, + &devices, + &pci, + &coreboot, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +} diff --git a/src/mainboard/starlabs/starfighter/cmos.default b/src/mainboard/starlabs/starfighter/cmos.default index b2f49a5..49faae3 100644 --- a/src/mainboard/starlabs/starfighter/cmos.default +++ b/src/mainboard/starlabs/starfighter/cmos.default @@ -1,26 +1,4 @@ ## SPDX-License-Identifier: GPL-2.0-only -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -hyper_threading=Enable -vtd=Enable -power_profile=Balanced -me_state=Disable -# Devices -wireless=Enable -webcam=Enable -microphone=Enable -pci_hot_plug=Disable -lid_switch=Enable -gna=Disable -# EC -kbl_timeout=30 seconds -fn_ctrl_swap=Disable -charging_speed=0.5C -# southbridge -power_on_after_fail=Disable # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/starfighter/cmos.layout b/src/mainboard/starlabs/starfighter/cmos.layout index b161fed..ebba7fb 100644 --- a/src/mainboard/starlabs/starfighter/cmos.layout +++ b/src/mainboard/starlabs/starfighter/cmos.layout @@ -12,36 +12,10 @@ 304 80 h 0 ramtop # RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option 388 4 h 0 reboot_counter -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level # coreboot config options: cpu #400 8 r 0 reserved for century byte -408 1 e 1 hyper_threading -416 1 e 1 vtd -424 2 e 7 power_profile -432 1 e 5 me_state -440 4 h 0 me_state_counter - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 webcam -520 1 e 1 microphone -528 1 e 1 lid_switch -536 1 e 1 gna - -# coreboot config options: EC -600 3 e 4 kbl_timeout -608 1 e 1 fn_ctrl_swap -616 2 e 8 max_charge -624 2 e 9 fan_mode -632 2 e 11 charging_speed - -# coreboot config options: southbridge -800 2 e 6 power_on_after_fail # coreboot config options: check sums 984 16 h 0 check_sum @@ -50,7 +24,7 @@ # embedded controller settings (outside the checksummed area) 1024 8 h 1 fn_lock_state 1032 8 h 1 trackpad_state -1040 8 h 10 kbl_brightness +1040 8 h 2 kbl_brightness 1048 8 h 1 kbl_state # ----------------------------------------------------------------- @@ -61,52 +35,10 @@ 1 0 Disable 1 1 Enable -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 30 seconds -4 1 1 minute -4 2 3 minutes -4 3 5 minutes -4 4 Never - -5 0 Enable -5 1 Disable - -6 0 Disable -6 1 Enable -6 2 Keep - -7 0 Power Saver -7 1 Balanced -7 2 Performance - -8 0 100% -8 1 80% -8 2 60% - -9 0 Normal -9 1 Aggressive -9 2 Quiet - -10 0 Off -10 1 Low -10 2 High -10 3 On - -11 0 1.0C -11 1 0.5C -11 2 0.2C +2 0 Off +2 1 Low +2 2 High +2 3 On # ----------------------------------------------------------------- checksums -- To view, visit https://review.coreboot.org/c/coreboot/+/85709?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3e3b5448282aa81a89356f1d3145381d65e47aaa Gerrit-Change-Number: 85709 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[L] Change in coreboot[main]: mb/starlabs/starbook: Put options in CFR cbtable
by Sean Rhodes (Code Review) 15 Jan '25

15 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74743?usp=email ) Change subject: mb/starlabs/starbook: Put options in CFR cbtable ...................................................................... mb/starlabs/starbook: Put options in CFR cbtable Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74743 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/Makefile.mk A src/mainboard/starlabs/starbook/cfr.c M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout D src/mainboard/starlabs/starbook/variants/tgl/cmos.default D src/mainboard/starlabs/starbook/variants/tgl/cmos.layout 7 files changed, 391 insertions(+), 235 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/Kconfig b/src/mainboard/starlabs/starbook/Kconfig index 1837e19..4a781e6 100644 --- a/src/mainboard/starlabs/starbook/Kconfig +++ b/src/mainboard/starlabs/starbook/Kconfig @@ -2,6 +2,8 @@ config BOARD_STARLABS_STARBOOK_SERIES def_bool n + select DRIVERS_EFI_VARIABLE_STORE + select DRIVERS_OPTION_CFR select DRIVERS_I2C_HID select EC_STARLABS_ITE select EC_STARLABS_FAN @@ -100,12 +102,6 @@ default 4 if BOARD_STARLABS_STARBOOK_ADL || BOARD_STARLABS_STARBOOK_RPL default 3 -config CMOS_DEFAULT_FILE - default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.default" if BOARD_STARLABS_STARBOOK_TGL - -config CMOS_LAYOUT_FILE - default "src/mainboard/\$(CONFIG_MAINBOARD_DIR)/variants/\$(CONFIG_VARIANT_DIR)/cmos.layout" if BOARD_STARLABS_STARBOOK_TGL - config CONSOLE_SERIAL default n if !EDK2_DEBUG diff --git a/src/mainboard/starlabs/starbook/Makefile.mk b/src/mainboard/starlabs/starbook/Makefile.mk index c6d94c8..581c861 100644 --- a/src/mainboard/starlabs/starbook/Makefile.mk +++ b/src/mainboard/starlabs/starbook/Makefile.mk @@ -10,6 +10,7 @@ romstage-$(CONFIG_VBOOT) += vboot.c +ramstage-$(CONFIG_DRIVERS_OPTION_CFR) += cfr.c ramstage-y += hda_verb.c ramstage-y += mainboard.c ramstage-y += smbios.c diff --git a/src/mainboard/starlabs/starbook/cfr.c b/src/mainboard/starlabs/starbook/cfr.c new file mode 100644 index 0000000..9efe924 --- /dev/null +++ b/src/mainboard/starlabs/starbook/cfr.c @@ -0,0 +1,383 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <boot/coreboot_tables.h> +#include <commonlib/coreboot_tables.h> +#include <drivers/option/cfr_frontend.h> +#include <inttypes.h> +#include <intelblocks/pcie_rp.h> +#include <string.h> +#include <types.h> +#include <variants.h> + +static const struct sm_object boot_option = SM_DECLARE_ENUM({ + .opt_name = "boot_option", + .ui_name = "Boot Option", + .ui_helptext = "Change the boot device in the event of a failed boot", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Fallback", 0 }, + { "Normal", 1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object card_reader = SM_DECLARE_BOOL({ + .opt_name = "card_reader", + .ui_name = "Card Reader", + .ui_helptext = "Enable or disable the built-in card reader", + .default_value = true, +}); + +#if CONFIG(EC_STARLABS_CHARGING_SPEED) +static const struct sm_object charging_speed = SM_DECLARE_ENUM({ + .opt_name = "charging_speed", + .ui_name = "Charging Speed", + .ui_helptext = "Set the maximum speed to charge the battery. Charging faster" + " will increase heat and battery wear.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "1.0C", 0 }, + { "0.5C", 1 }, + { "0.2C", 2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object debug_level = SM_DECLARE_ENUM({ + .opt_name = "debug_level", + .ui_name = "Debug Level", + .ui_helptext = "Set the verbosity of the debug output.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Emergency", 0 }, + { "Alert", 1 }, + { "Critical", 2 }, + { "Error", 3 }, + { "Warning", 4 }, + { "Notice", 5 }, + { "Info", 6 }, + { "Debug", 7 }, + { "Spew", 8 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object fan_mode = SM_DECLARE_ENUM({ + .opt_name = "fan_mode", + .ui_name = "Fan Mode", + .ui_helptext = "Adjust the fan curve to prioritize performance or noise levels.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Normal", 0 }, + { "Aggressive", 1 }, + { "Quiet", 2 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(BOARD_STARLABS_STARBOOK_ADL) || CONFIG(BOARD_STARLABS_STARBOOK_RPL) +static const struct sm_object fingerprint_reader = SM_DECLARE_BOOL({ + .opt_name = "fingerprint_reader", + .ui_name = "Fingerprint Reader", + .ui_helptext = "Enable or disable the built-in fingerprint reader", + .default_value = true, +}); +#endif + +static const struct sm_object fn_ctrl_swap = SM_DECLARE_BOOL({ + .opt_name = "fn_ctrl_swap", + .ui_name = "Fn Ctrl Reverse", + .ui_helptext = "Swap the functions of the [Fn] and [Ctrl] keys", + .default_value = false, +}); + +#if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) +static const struct sm_object gna = SM_DECLARE_BOOL({ + .opt_name = "gna", + .ui_name = "Gaussian & Neural Accelerator", + .ui_helptext = "Enable or Disable the Gaussian & Neural Accelerator", + .default_value = false, +}); +#endif + +static const struct sm_object hyper_threading = SM_DECLARE_BOOL({ + .opt_name = "hyper_threading", + .ui_name = "Hyper-Threading", + .ui_helptext = "Enable or disable Hyper-Threading", + .default_value = true, +}); + +static const struct sm_object kbl_timeout = SM_DECLARE_ENUM({ + .opt_name = "kbl_timeout", + .ui_name = "Keyboard Backlight Timeout", + .ui_helptext = "Set the amount of time before the keyboard backlight turns off" + " when un-used", + .default_value = 0, + .values = (struct sm_enum_value[]) { + { "30 seconds", 0 }, + { "1 minute", 1 }, + { "3 minutes", 2 }, + { "5 minutes", 3 }, + { "Never", 4 }, + SM_ENUM_VALUE_END }, +}); + +#if CONFIG(EC_STARLABS_LID_SWITCH) +static const struct sm_object lid_switch = SM_DECLARE_ENUM({ + .opt_name = "lid_switch", + .ui_name = "Lid Switch", + .ui_helptext = "Enable or disable the lid switch.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "Enabled", 0 }, + { "Disabled", 1 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object max_charge = SM_DECLARE_ENUM({ + .opt_name = "max_charge", + .ui_name = "Maximum Charge Level", + .ui_helptext = "Set the maximum level the battery will charge to.", + .default_value = 0, + .values = (const struct sm_enum_value[]) { + { "100%", 0 }, + { "80%", 1 }, + { "60%", 2 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state = SM_DECLARE_ENUM({ + .opt_name = "me_state", + .ui_name = "Intel Management Engine", + .ui_helptext = "Enable or disable the Intel Management Engine", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Disabled", 1 }, + { "Enabled", 0 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object me_state_counter = SM_DECLARE_NUMBER({ + .opt_name = "me_state_counter", + .ui_name = "ME State Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +static const struct sm_object power_on_after_fail = SM_DECLARE_BOOL({ + .opt_name = "power_on_after_fail", + .ui_name = "Power on after failure", + .ui_helptext = "Automatically turn on after a power failure", + .default_value = false, +}); + +static const struct sm_object power_profile = SM_DECLARE_ENUM({ + .opt_name = "power_profile", + .ui_name = "Power Profile", + .ui_helptext = "Select whether to maximize performance, battery life or both.", + .default_value = 1, + .values = (const struct sm_enum_value[]) { + { "Power Saver", PP_POWER_SAVER }, + { "Balanced", PP_BALANCED }, + { "Performance", PP_PERFORMANCE }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object microphone = SM_DECLARE_BOOL({ + .opt_name = "microphone", + .ui_name = "Microphone", + .ui_helptext = "Enable or disable the built-in microphone", + .default_value = true, +}); + +#if CONFIG(BOARD_STARLABS_STARBOOK_ADL) +static const struct sm_object pci_hot_plug = SM_DECLARE_BOOL({ + .opt_name = "pci_hot_plug", + .ui_name = "Third-Party SSD Support", + .ui_helptext = "Enables PCI Hot Plug, which slows down the SSD initialization. It" + " is required for certain third-party SSDs to be detected.", + .default_value = false, +}); +#endif + +#if CONFIG(SOC_INTEL_ALDERLAKE) +static const struct sm_object pciexp_aspm = SM_DECLARE_ENUM({ + .opt_name = "pciexp_aspm", + .ui_name = "PCI ASPM", + .ui_helptext = "Controls the Active State Power Management for PCI devices." + " Enabling this feature can reduce power consumption of" + " PCI-connected devices during idle times.", + .default_value = ASPM_L0S_L1, + .values = (const struct sm_enum_value[]) { + { "Disabled", ASPM_DISABLE }, + { "L0s", ASPM_L0S }, + { "L1", ASPM_L1 }, + { "L0sL1", ASPM_L0S_L1 }, + SM_ENUM_VALUE_END }, +}); + +static const struct sm_object pciexp_clk_pm = SM_DECLARE_BOOL({ + .opt_name = "pciexp_clk_pm", + .ui_name = "PCI Clock Power Management", + .ui_helptext = "Enables or disables power management for the PCI clock. When" + " enabled, it reduces power consumption during idle states." + " This can help lower overall energy use but may impact" + " performance in power-sensitive tasks.", + .default_value = true, +}); + +static const struct sm_object pciexp_l1ss = SM_DECLARE_ENUM({ + .opt_name = "pciexp_l1ss", + .ui_name = "PCI L1 Substates", + .ui_helptext = "Controls deeper power-saving states for PCI devices." + " Enabling this feature allows supported devices to achieve" + " lower power states at the cost of slightly increased" + " latency when exiting these states.", + .default_value = L1_SS_L1_2, + .values = (const struct sm_enum_value[]) { + { "Disabled", L1_SS_DISABLED }, + { "L1.1", L1_SS_L1_1 }, + { "L1.2", L1_SS_L1_2 }, + SM_ENUM_VALUE_END }, +}); +#endif + +static const struct sm_object reboot_counter = SM_DECLARE_NUMBER({ + .opt_name = "reboot_counter", + .ui_name = "Reboot Counter", + .flags = CFR_OPTFLAG_SUPPRESS, + .default_value = 0, +}); + +#if CONFIG(DRIVERS_INTEL_USB4_RETIMER) +static const struct sm_object thunderbolt = SM_DECLARE_BOOL({ + .opt_name = "thunderbolt", + .ui_name = "Thunderbolt", + .ui_helptext = "Enable or disable Thunderbolt support", + .default_value = true, +}); +#endif + +static const struct sm_object webcam = SM_DECLARE_BOOL({ + .opt_name = "webcam", + .ui_name = "Webcam", + .ui_helptext = "Enable or disable the built-in webcam", + .default_value = true, +}); + +static const struct sm_object wireless = SM_DECLARE_BOOL({ + .opt_name = "wireless", + .ui_name = "Wireless", + .ui_helptext = "Enable or disable the built-in wireless card", + .default_value = true, +}); + +static const struct sm_object vtd = SM_DECLARE_BOOL({ + .opt_name = "vtd", + .ui_name = "VT-d", + .ui_helptext = "Enable or disable Intel VT-d (virtualization)", + .default_value = true, +}); + +static struct sm_obj_form performance = { + .ui_name = "Performance", + .obj_list = (const struct sm_object *[]) { + &fan_mode, + &power_profile, + NULL + }, +}; + +static struct sm_obj_form processor = { + .ui_name = "Processor", + .obj_list = (const struct sm_object *[]) { + &me_state, + &me_state_counter, + &hyper_threading, + &vtd, + NULL + }, +}; + +static struct sm_obj_form power = { + .ui_name = "Power", + .obj_list = (const struct sm_object *[]) { + &max_charge, + #if CONFIG(EC_STARLABS_CHARGING_SPEED) + &charging_speed, + #endif + &power_on_after_fail, + NULL + }, +}; + +static struct sm_obj_form keyboard = { + .ui_name = "Keyboard", + .obj_list = (const struct sm_object *[]) { + &kbl_timeout, + &fn_ctrl_swap, + NULL + }, +}; + +static struct sm_obj_form devices = { + .ui_name = "Devices", + .obj_list = (const struct sm_object *[]) { + &card_reader, + #if CONFIG(BOARD_STARLABS_STARBOOK_ADL) || CONFIG(BOARD_STARLABS_STARBOOK_RPL) + &fingerprint_reader, + #endif + #if CONFIG(SOC_INTEL_TIGERLAKE) || CONFIG(SOC_INTEL_ALDERLAKE) || CONFIG(SOC_INTEL_RAPTORLAKE) + &gna, + #endif + #if CONFIG(EC_STARLABS_LID_SWITCH) + &lid_switch, + #endif + &microphone, + #if CONFIG(DRIVERS_INTEL_USB4_RETIMER) + &thunderbolt, + #endif + &webcam, + &wireless, + NULL + }, +}; + +static struct sm_obj_form pci = { + .ui_name = "PCI", + .obj_list = (const struct sm_object *[]) { + #if CONFIG(BOARD_STARLABS_STARBOOK_ADL) + &pci_hot_plug, + #endif + #if CONFIG(SOC_INTEL_ALDERLAKE) + &pciexp_clk_pm, + &pciexp_aspm, + &pciexp_l1ss, + #endif + NULL + }, +}; + +static struct sm_obj_form coreboot = { + .ui_name = "coreboot", + .obj_list = (const struct sm_object *[]) { + &boot_option, + &debug_level, + &reboot_counter, + NULL + }, +}; + +static struct sm_obj_form *sm_root[] = { + &performance, + &processor, + &power, + &keyboard, + &devices, + &pci, + &coreboot, + NULL +}; + +void mb_cfr_setup_menu(struct lb_cfr *cfr_root) +{ + cfr_write_setup_menu(cfr_root, sm_root); +} diff --git a/src/mainboard/starlabs/starbook/cmos.default b/src/mainboard/starlabs/starbook/cmos.default index 5959948..49faae3 100644 --- a/src/mainboard/starlabs/starbook/cmos.default +++ b/src/mainboard/starlabs/starbook/cmos.default @@ -1,28 +1,4 @@ ## SPDX-License-Identifier: GPL-2.0-only - -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -hyper_threading=Enable -vtd=Enable -power_profile=Balanced -me_state=Disable -# Devices -wireless=Enable -webcam=Enable -microphone=Enable -legacy_8254_timer=Disable -pci_hot_plug=Disable -fingerprint_reader=Enable -card_reader=Enable -lid_switch=Enable -gna=Disable -# EC -kbl_timeout=30 seconds -fn_ctrl_swap=Disable -charging_speed=0.5C # Functions fn_lock_state=0x1 trackpad_state=0x1 diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout index 1f8f247..ebba7fb 100644 --- a/src/mainboard/starlabs/starbook/cmos.layout +++ b/src/mainboard/starlabs/starbook/cmos.layout @@ -12,37 +12,10 @@ 304 80 h 0 ramtop # RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option 388 4 h 0 reboot_counter -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level # coreboot config options: cpu #400 8 r 0 reserved for century byte -408 1 e 1 hyper_threading -416 1 e 1 vtd -424 2 e 7 power_profile -432 1 e 5 me_state -440 4 h 0 me_state_counter - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 webcam -520 1 e 1 microphone -528 1 e 1 legacy_8254_timer -536 1 e 1 pci_hot_plug -542 1 e 1 fingerprint_reader -550 1 e 1 card_reader -558 1 e 1 lid_switch -566 1 e 1 gna - -# coreboot config options: EC -600 3 e 4 kbl_timeout -608 1 e 1 fn_ctrl_swap -616 2 e 8 max_charge -624 2 e 9 fan_mode -632 2 e 11 charging_speed # coreboot config options: check sums 984 16 h 0 check_sum @@ -51,7 +24,7 @@ # embedded controller settings (outside the checksummed area) 1024 8 h 1 fn_lock_state 1032 8 h 1 trackpad_state -1040 8 h 10 kbl_brightness +1040 8 h 2 kbl_brightness 1048 8 h 1 kbl_state # ----------------------------------------------------------------- @@ -62,52 +35,10 @@ 1 0 Disable 1 1 Enable -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 30 seconds -4 1 1 minute -4 2 3 minutes -4 3 5 minutes -4 4 Never - -5 0 Enable -5 1 Disable - -6 0 Disable -6 1 Enable -6 2 Keep - -7 0 Power Saver -7 1 Balanced -7 2 Performance - -8 0 100% -8 1 80% -8 2 60% - -9 0 Normal -9 1 Aggressive -9 2 Quiet - -10 0 Off -10 1 Low -10 2 High -10 3 On - -11 0 1.0C -11 1 0.5C -11 2 0.2C +2 0 Off +2 1 Low +2 2 High +2 3 On # ----------------------------------------------------------------- checksums diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default deleted file mode 100644 index fada05c..0000000 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default +++ /dev/null @@ -1,25 +0,0 @@ -## SPDX-License-Identifier: GPL-2.0-only - -# hardcoded -boot_option=Fallback -# console -debug_level=Debug -# cpu -hyper_threading=Enable -vtd=Enable -power_profile=Balanced -me_state=Disable -# Devices -wireless=Enable -webcam=Enable -microphone=Enable -legacy_8254_timer=Disable -thunderbolt=Disable -# EC -kbl_timeout=30 seconds -fn_ctrl_swap=Disable -# Functions -fn_lock_state=0x1 -trackpad_state=0x1 -kbl_brightness=0x0 -kbl_state=0x1 diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout deleted file mode 100644 index 51e6c15..0000000 --- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout +++ /dev/null @@ -1,106 +0,0 @@ -# SPDX-License-Identifier: GPL-2.0-only - -# ----------------------------------------------------------------- -entries - -# Bank: 1 -# ----------------------------------------------------------------- -0 120 r 0 reserved_memory - -# ----------------------------------------------------------------- -# coreboot config options: ramtop -304 80 h 0 ramtop - -# RTC_BOOT_BYTE (coreboot hardcoded) -384 1 e 2 boot_option -388 4 h 0 reboot_counter - -# ----------------------------------------------------------------- -# coreboot config options: console -395 4 e 3 debug_level -# coreboot config options: cpu -#400 8 r 0 reserved for century byte -408 1 e 1 hyper_threading -416 1 e 1 vtd -424 2 e 7 power_profile -432 1 e 5 me_state -440 4 h 0 me_state_counter - -# coreboot config options: Devices -504 1 e 1 wireless -512 1 e 1 webcam -520 1 e 1 microphone -528 1 e 1 legacy_8254_timer -536 1 e 1 thunderbolt - -# coreboot config options: EC -600 3 e 4 kbl_timeout -608 1 e 1 fn_ctrl_swap -616 2 e 8 max_charge -624 2 e 9 fan_mode - -# coreboot config options: check sums -984 16 h 0 check_sum - -# Bank: 2 -# embedded controller settings (outside the checksummed area) -1024 8 h 1 fn_lock_state -1032 8 h 1 trackpad_state -1040 8 h 10 kbl_brightness -1048 8 h 1 kbl_state - -# ----------------------------------------------------------------- - -enumerations - -#ID value text -1 0 Disable -1 1 Enable - -2 0 Fallback -2 1 Normal - -3 0 Emergency -3 1 Alert -3 2 Critical -3 3 Error -3 4 Warning -3 5 Notice -3 6 Info -3 7 Debug -3 8 Spew - -4 0 30 seconds -4 1 1 minute -4 2 3 minutes -4 3 5 minutes -4 4 Never - -5 0 Enable -5 1 Disable - -6 0 Disable -6 1 Enable -6 2 Keep - -7 0 Power Saver -7 1 Balanced -7 2 Performance - -8 0 100% -8 1 80% -8 2 60% - -9 0 Normal -9 1 Aggressive -9 2 Quiet - -10 0 Off -10 1 Low -10 2 High -10 3 On - -# ----------------------------------------------------------------- -checksums - -checksum 392 983 984 -- To view, visit https://review.coreboot.org/c/coreboot/+/74743?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I816893e5c2663ed55ae9fa5dd662489b27332aa6 Gerrit-Change-Number: 74743 Gerrit-PatchSet: 40 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Lean Sheng Tan <tanleansheng(a)outlook.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025