coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
467 discussions

[XS] Change in coreboot[main]: mb/google/nissa/var/rull: Configure Acoustic noise mitigation
by Kun Liu (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou, Subrata Banik. Kun Liu has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85863?usp=email ) Change subject: mb/google/nissa/var/rull: Configure Acoustic noise mitigation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/85863?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I54c8412410cca33ffb19a2b21d678b6263ead297 Gerrit-Change-Number: 85863 Gerrit-PatchSet: 1 Gerrit-Owner: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rui Zhou <zhourui(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Mon, 06 Jan 2025 12:10:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: mb/amd/birman_plus/devicetree_glinda.cb: Update USB
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Maximilian Brune. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84436?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/amd/birman_plus/devicetree_glinda.cb: Update USB ...................................................................... mb/amd/birman_plus/devicetree_glinda.cb: Update USB Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: Iacf9ab43c337a8b6a7aa5a37eb8a59644fcaeac6 Original-signed-off-by: Satya SreenivasL <satya.sreenivasl(a)amd.com> Original-reviewed-by: Anand Vaikar <a.vaikar2021(a)gmail.com> Original-reviewed-by: Ritul Guru <ritul.bits(a)gmail.com> Original-tested-by: Satya Sreenivas L <Satya.SreenivasL(a)amd.com> --- M src/mainboard/amd/birman_plus/devicetree_glinda.cb 1 file changed, 58 insertions(+), 29 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/84436/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/84436?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iacf9ab43c337a8b6a7aa5a37eb8a59644fcaeac6 Gerrit-Change-Number: 84436 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>

1 0

[S] Change in coreboot[main]: vendorcode/amd/fsp/glinda: Update usb_phy_config structure
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, Paul Menzel, ritul guru. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84435?usp=email ) Change subject: vendorcode/amd/fsp/glinda: Update usb_phy_config structure ...................................................................... Patch Set 8: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84435/comment/3368e14d_1d3999d4?us… : PS7, Line 7: vendorcode/amd/fsp/glinda: port usb_phy_config structure > Please make it a statement. Done https://review.coreboot.org/c/coreboot/+/84435/comment/a771b948_c64bfb65?us… : PS7, Line 8: > Please add a commit message body. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84435?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Gerrit-Change-Number: 84435 Gerrit-PatchSet: 8 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 06 Jan 2025 12:03:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: vendorcode/amd/fsp/glinda: Update usb_phy_config structure
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, Maximilian Brune, ritul guru. Hello Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, build bot (Jenkins), ritul guru, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84435?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Code-Review+2 by Marshall Dawson, Verified+1 by build bot (Jenkins) Change subject: vendorcode/amd/fsp/glinda: Update usb_phy_config structure ...................................................................... vendorcode/amd/fsp/glinda: Update usb_phy_config structure Updates the structures to match the ones in the FSP. Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Original-signed-off-by: Satya SreenivasL <satya.sreenivasl(a)amd.com> Original-reviewed-by: Anand Vaikar <a.vaikar2021(a)gmail.com> Original-reviewed-by: Ritul Guru <ritul.bits(a)gmail.com> Original-tested-by: Satya Sreenivas L <Satya.SreenivasL(a)amd.com> --- M src/mainboard/amd/birman/devicetree_glinda.cb M src/mainboard/amd/birman_plus/devicetree_glinda.cb M src/vendorcode/amd/fsp/glinda/FspUsb.h 3 files changed, 5 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/84435/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/84435?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Gerrit-Change-Number: 84435 Gerrit-PatchSet: 8 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: tests: Replace 'unsigned long int' by 'unsigned long'
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Ariel Otilibili. Maximilian Brune has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85788?usp=email ) Change subject: tests: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: building with BUILD_TIMELESS shows there is no difference in the binaries. -- To view, visit https://review.coreboot.org/c/coreboot/+/85788?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia41f0674f4abab285d89ed5101b3805975f3f381 Gerrit-Change-Number: 85788 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Mon, 06 Jan 2025 11:44:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: lib: Replace 'unsigned long int' by 'unsigned long'
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Ariel Otilibili. Maximilian Brune has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85787?usp=email ) Change subject: lib: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: building with BUILD_TIMELESS shows there is no difference in the binaries. -- To view, visit https://review.coreboot.org/c/coreboot/+/85787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I93d951eac69150b6cd73c9e56cb02a73c5118340 Gerrit-Change-Number: 85787 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Mon, 06 Jan 2025 11:44:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: util/cbfstool: Replace 'unsigned long int' by 'unsigned long'
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Ariel Otilibili. Maximilian Brune has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85786?usp=email ) Change subject: util/cbfstool: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: building with BUILD_TIMELESS shows there is no difference in the binaries. -- To view, visit https://review.coreboot.org/c/coreboot/+/85786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If94e70778d0302552f151c31d3073524162faf9e Gerrit-Change-Number: 85786 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-CC: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Mon, 06 Jan 2025 11:43:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: samsung/exynos5250: Replace 'unsigned long int' by 'unsigned long'
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Ariel Otilibili. Maximilian Brune has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85785?usp=email ) Change subject: samsung/exynos5250: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: building with BUILD_TIMELESS shows there is no difference in the binaries. -- To view, visit https://review.coreboot.org/c/coreboot/+/85785?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7eddb0934ccd24c9994a60d7058a1e518c6c9c9f Gerrit-Change-Number: 85785 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Mon, 06 Jan 2025 11:43:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: drivers/uart: Replace 'unsigned long int' by 'unsigned long'
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Ariel Otilibili. Maximilian Brune has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85784?usp=email ) Change subject: drivers/uart: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: building with BUILD_TIMELESS shows there is no difference in the binaries. -- To view, visit https://review.coreboot.org/c/coreboot/+/85784?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1416a2f7d75a888dcaf0775894aced981800866f Gerrit-Change-Number: 85784 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Mon, 06 Jan 2025 11:43:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long'
by Maximilian Brune (Code Review) 06 Jan '25

06 Jan '25

Attention is currently required from: Ariel Otilibili. Maximilian Brune has posted comments on this change by Ariel Otilibili. ( https://review.coreboot.org/c/coreboot/+/85783?usp=email ) Change subject: intel/fsp1_1: Replace 'unsigned long int' by 'unsigned long' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: building with BUILD_TIMELESS shows there is no difference in the binaries. -- To view, visit https://review.coreboot.org/c/coreboot/+/85783?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I940528dc4f8cb9b2d441d0f0d181cccebd315255 Gerrit-Change-Number: 85783 Gerrit-PatchSet: 1 Gerrit-Owner: Ariel Otilibili Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ariel Otilibili Gerrit-Comment-Date: Mon, 06 Jan 2025 11:43:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

← Newer
1
...
11
12
13
14
15
16
17
...
47
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025