Attention is currently required from: Angel Pons, Christian Walter, Elyes Haouas, Frans Hendriks, Jeremy Soller, Jonathon Hall, Michael Niewöhner, Michał Żygowski, Nick Vaccaro, Patrick Rudolph, Piotr Król, Subrata Banik, Tim Crawford.
Maxim Polyakov has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86192?usp=email )
Change subject: tree: Use true false for PcieRpEnable[]
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/86192?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8e67a33f82b7dfa1864016ccd5cd1b7ec119c528
Gerrit-Change-Number: 86192
Gerrit-PatchSet: 1
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Thu, 30 Jan 2025 14:29:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Angel Pons, Keith Hui.
Nicholas Chin has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85413?usp=email )
Change subject: mb/asus/p8z77-v: Attempt to correctly route PCIe lanes
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/asus/p8x7x-series/variants/p8z77-v/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85413/comment/ab2ee065_792e1cee?us… :
PS5, Line 76: drq 0xe6 = 0x7f # GP7 PP
Was this removal intentional? I haven't checked what GPIO bank 7 is used for.
--
To view, visit https://review.coreboot.org/c/coreboot/+/85413?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If41197a1f817a48c209d25fc1ae461ec97ccf16c
Gerrit-Change-Number: 85413
Gerrit-PatchSet: 6
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Comment-Date: Thu, 30 Jan 2025 14:01:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya.
Nick Kochlowski has posted comments on this change by Nick Kochlowski. ( https://review.coreboot.org/c/coreboot/+/85634?usp=email )
Change subject: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver
......................................................................
Patch Set 16:
(2 comments)
File src/drivers/amd/opensil/memmap.c:
https://review.coreboot.org/c/coreboot/+/85634/comment/e33d4914_bf314d3e?us… :
PS15, Line 16: } HOLE_INFO;
> please add a comment to this struct that it matches and needs to match openSIL's MEMORY_HOLE_TYPES s […]
Done
https://review.coreboot.org/c/coreboot/+/85634/comment/9d950176_ee6cb005?us… :
PS15, Line 18: // This assumes holes are allocated
> since this code is moved from vendorcode into the regular coreboot code base, it would be better to […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/85634?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80b9bdd7fd633c7b12d695ced5d4b9b518570d80
Gerrit-Change-Number: 85634
Gerrit-PatchSet: 16
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 30 Jan 2025 13:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Nick Kochlowski, Varshit Pandya.
Hello Felix Held, Fred Reitberger, Jason Glenesk, Martin L Roth, Matt DeVillier, Varshit Pandya, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/85634?usp=email
to look at the new patch set (#16).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: drivers/amd/opensil/memmap.c: Factor out common memmap code to driver
......................................................................
drivers/amd/opensil/memmap.c: Factor out common memmap code to driver
Refactor the vendercode openSIL memory map code and move all common
calls that do not require any openSIL headers to the driver.
Change-Id: I80b9bdd7fd633c7b12d695ced5d4b9b518570d80
Signed-off-by: Nicolas Kochlowski <nickkochlowski(a)gmail.com>
---
M src/drivers/amd/opensil/Makefile.mk
A src/drivers/amd/opensil/memmap.c
M src/drivers/amd/opensil/opensil.h
M src/soc/amd/genoa_poc/domain.c
M src/soc/amd/phoenix/memmap.c
M src/vendorcode/amd/opensil/genoa_poc/memmap.c
M src/vendorcode/amd/opensil/opensil.h
M src/vendorcode/amd/opensil/stub/ramstage.c
8 files changed, 115 insertions(+), 86 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/85634/16
--
To view, visit https://review.coreboot.org/c/coreboot/+/85634?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I80b9bdd7fd633c7b12d695ced5d4b9b518570d80
Gerrit-Change-Number: 85634
Gerrit-PatchSet: 16
Gerrit-Owner: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Nick Kochlowski <nickkochlowski(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Attention is currently required from: Máté Kukri.
Paul Menzel has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/86219?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/bostentech/gbyt4: Increase default CBFS size to cover BIOS region
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86219/comment/ecad9f8d_7a09703a?us… :
PS1, Line 7: mb/bostentech/gbyt4: Increase default CBFS size to cover BIOS region
Mention 5 MB here too, if possible. Otherwise ignore.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86219?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I65a8b161c522a2da58420397aae6c7ff2b5cf30d
Gerrit-Change-Number: 86219
Gerrit-PatchSet: 1
Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Comment-Date: Thu, 30 Jan 2025 12:55:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Máté Kukri.
Paul Menzel has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/86218?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/bostentech/gbyt4: Add VBT
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86218/comment/858df450_ce52473d?us… :
PS1, Line 9: This is useful when booted with the (not yet mainline) libgfxinit for
: Bay Trail.
Please mention the vendor firmware version you extracted it from.
--
To view, visit https://review.coreboot.org/c/coreboot/+/86218?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I73d54c73a12430074f4f3880caf842b3491b5170
Gerrit-Change-Number: 86218
Gerrit-PatchSet: 1
Gerrit-Owner: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Máté Kukri <km(a)mkukri.xyz>
Gerrit-Comment-Date: Thu, 30 Jan 2025 12:55:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Jayvik Desai, Kapil Porwal, Naveen M, Pranava Y N, Subrata Banik.
Uday Bhat has posted comments on this change by Uday Bhat. ( https://review.coreboot.org/c/coreboot/+/86121?usp=email )
Change subject: mb/google/fatcat/variants/fatcat: Enable BT audio offload
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86121/comment/6ec9c7de_1c1730df?us… :
PS1, Line 12: I2S and soundwire
> BT offload is not enabled for HDA till now (not even in previous platforms). […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/86121?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id68667d674386cf9e6abc066a4637ee055a967f3
Gerrit-Change-Number: 86121
Gerrit-PatchSet: 2
Gerrit-Owner: Uday Bhat <uday.m.bhat(a)intel.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Naveen M <naveen.m(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Naveen M <naveen.m(a)intel.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 30 Jan 2025 12:52:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Uday Bhat <uday.m.bhat(a)intel.com>
Comment-In-Reply-To: Pranava Y N <pranavayn(a)google.com>