coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
643 discussions

[S] Change in coreboot[main]: soc/intel/pantherlake: Refactor FSP-M params for debug message control
by Jérémy Compostella (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Subrata Banik. Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85827?usp=email ) Change subject: soc/intel/pantherlake: Refactor FSP-M params for debug message control ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > I am just wondering: Why ? And why isn't looped in a patch review like this ? I am just wondering: Why ? And why isn't Intel looped in a patch review like this ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2916ce82133058464d20eed327de7c7288e78a4 Gerrit-Change-Number: 85827 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:30:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Add SSDT entry for volume keys
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85695?usp=email ) Change subject: mb/starlabs/starlite_adl: Add SSDT entry for volume keys ...................................................................... mb/starlabs/starlite_adl: Add SSDT entry for volume keys Add entries to the SSDT so that the volume keys, which use the PS2 keyboard interface, are correctly registered. Change-Id: Ie80491559de50d72bf1ff97fd30c1a74e6b0f7a6 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85695 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starlite_adl/mainboard.c 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starlite_adl/mainboard.c b/src/mainboard/starlabs/starlite_adl/mainboard.c index d394f25..99b59253 100644 --- a/src/mainboard/starlabs/starlite_adl/mainboard.c +++ b/src/mainboard/starlabs/starlite_adl/mainboard.c @@ -1,5 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */ +#include <acpi/acpigen_ps2_keybd.h> #include <device/device.h> #include <soc/ramstage.h> #include <option.h> @@ -22,6 +23,23 @@ devtree_update(); } +static void mainboard_fill_ssdt(const struct device *dev) +{ + enum ps2_action_key ps2_action_keys[2] = { + PS2_KEY_VOL_DOWN, + PS2_KEY_VOL_UP + }; + acpigen_ps2_keyboard_dsd("_SB.PCI0.PS2K", ARRAY_SIZE(ps2_action_keys), + ps2_action_keys, false, false, false, false, false); +} + +static void enable_mainboard(struct device *dev) +{ + dev->ops->acpi_fill_ssdt = mainboard_fill_ssdt; +} + + struct chip_operations mainboard_ops = { .init = init_mainboard, + .enable_dev = enable_mainboard, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/85695?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie80491559de50d72bf1ff97fd30c1a74e6b0f7a6 Gerrit-Change-Number: 85695 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/*: Tweak the performance profiles
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85694?usp=email ) Change subject: mb/starlabs/*: Tweak the performance profiles ...................................................................... mb/starlabs/*: Tweak the performance profiles Adjust these so they simply adjust the Intel detaults, rather than having hardcoded values. Change-Id: I8375428e9ace8e505e8cb53b2e4912592715b79a Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85694 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c M src/mainboard/starlabs/lite/devtree.c M src/mainboard/starlabs/starbook/variants/adl/devtree.c M src/mainboard/starlabs/starbook/variants/cml/devtree.c M src/mainboard/starlabs/starbook/variants/kbl/devtree.c M src/mainboard/starlabs/starbook/variants/rpl/devtree.c M src/mainboard/starlabs/starbook/variants/tgl/devtree.c M src/mainboard/starlabs/starfighter/variants/rpl/devtree.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c 9 files changed, 99 insertions(+), 68 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c index ae87d6a..88e8f3a 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c @@ -23,18 +23,24 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf_4core->tdp_pl4 = 36; + + /* Set PL1 to 50% of PL2 */ + soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; common_config->pch_thermal_trip = 30; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; common_config->pch_thermal_trip = 25; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ common_config->pch_thermal_trip = 20; break; } @@ -42,9 +48,6 @@ soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl1_override * performance_scale) / 100; soc_conf_4core->tdp_pl2_override = (soc_conf_4core->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf_4core->tdp_pl4 = 36; - /* Enable/Disable Bluetooth based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) { cfg->usb2_ports[9].enable = 0; diff --git a/src/mainboard/starlabs/lite/devtree.c b/src/mainboard/starlabs/lite/devtree.c index 2e192e3..f25628b 100644 --- a/src/mainboard/starlabs/lite/devtree.c +++ b/src/mainboard/starlabs/lite/devtree.c @@ -27,7 +27,13 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf->tdp_pl4 = 31; + + /* Set PL1 to 50% of PL2 */ + soc_conf->tdp_pl1_override = (soc_conf->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: performance_scale -= 25; @@ -46,9 +52,6 @@ soc_conf->tdp_pl1_override = (soc_conf->tdp_pl1_override * performance_scale) / 100; soc_conf->tdp_pl2_override = (soc_conf->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf->tdp_pl4 = 31; - /* Enable/Disable Wireless based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) nic_dev->enabled = 0; diff --git a/src/mainboard/starlabs/starbook/variants/adl/devtree.c b/src/mainboard/starlabs/starbook/variants/adl/devtree.c index e7fc786..b83f6ad 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/adl/devtree.c @@ -24,32 +24,36 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf_10core->tdp_pl4 = 65; + soc_conf_12core->tdp_pl4 = 65; + + /* Set PL1 to 50% of PL2 */ + soc_conf_10core->tdp_pl1_override = (soc_conf_10core->tdp_pl2_override / 2) & ~1; + soc_conf_12core->tdp_pl1_override = (soc_conf_12core->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; common_config->pch_thermal_trip = 20; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; common_config->pch_thermal_trip = 15; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ common_config->pch_thermal_trip = 10; break; } soc_conf_10core->tdp_pl1_override = (soc_conf_10core->tdp_pl1_override * performance_scale) / 100; - soc_conf_12core->tdp_pl1_override = (soc_conf_12core->tdp_pl2_override * performance_scale) / 100; + soc_conf_10core->tdp_pl2_override = (soc_conf_10core->tdp_pl2_override * performance_scale) / 100; - soc_conf_10core->tdp_pl2_override = (soc_conf_10core->tdp_pl1_override * performance_scale) / 100; + soc_conf_12core->tdp_pl1_override = (soc_conf_12core->tdp_pl1_override * performance_scale) / 100; soc_conf_12core->tdp_pl2_override = (soc_conf_12core->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf_10core->tdp_pl4 = 65; - soc_conf_12core->tdp_pl4 = 65; - /* Enable/Disable Bluetooth based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) cfg->usb2_ports[9].enable = 0; diff --git a/src/mainboard/starlabs/starbook/variants/cml/devtree.c b/src/mainboard/starlabs/starbook/variants/cml/devtree.c index 1496754..b28c9f6 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/cml/devtree.c @@ -19,18 +19,24 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf->tdp_pl4 = 45; + + /* Set PL1 to 50% of PL2 */ + soc_conf->tdp_pl1_override = (soc_conf->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; cfg->tcc_offset = 20; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; cfg->tcc_offset = 15; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ cfg->tcc_offset = 10; break; } @@ -38,9 +44,6 @@ soc_conf->tdp_pl1_override = (soc_conf->tdp_pl1_override * performance_scale) / 100; soc_conf->tdp_pl2_override = (soc_conf->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf->tdp_pl4 = 45; - /* Enable/Disable Wireless based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) nic_dev->enabled = 0; diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devtree.c b/src/mainboard/starlabs/starbook/variants/kbl/devtree.c index a5b13b8..2599db8 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/devtree.c @@ -19,18 +19,24 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf->tdp_pl4 = 45; + + /* Set PL1 to 50% of PL2 */ + soc_conf->tdp_pl1_override = (soc_conf->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; cfg->tcc_offset = 20; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; cfg->tcc_offset = 15; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ cfg->tcc_offset = 10; break; } @@ -38,9 +44,6 @@ soc_conf->tdp_pl1_override = (soc_conf->tdp_pl1_override * performance_scale) / 100; soc_conf->tdp_pl2_override = (soc_conf->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf->tdp_pl4 = 45; - /* Enable/Disable Wireless based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) nic_dev->enabled = 0; diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devtree.c b/src/mainboard/starlabs/starbook/variants/rpl/devtree.c index 5eea89f..279f4cf 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/devtree.c @@ -27,18 +27,26 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf_6core->tdp_pl4 = 65; + soc_conf_12core->tdp_pl4 = 65; + + /* Set PL1 to 50% of PL2 */ + soc_conf_6core->tdp_pl1_override = (soc_conf_6core->tdp_pl2_override / 2) & ~1; + soc_conf_12core->tdp_pl1_override = (soc_conf_12core->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; common_config->pch_thermal_trip = 30; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; common_config->pch_thermal_trip = 25; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ common_config->pch_thermal_trip = 20; break; } @@ -49,10 +57,6 @@ soc_conf_12core->tdp_pl1_override = (soc_conf_12core->tdp_pl1_override * performance_scale) / 100; soc_conf_12core->tdp_pl2_override = (soc_conf_12core->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf_6core->tdp_pl4 = 65; - soc_conf_12core->tdp_pl4 = 65; - /* Enable/Disable Bluetooth based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) cfg->usb2_ports[9].enable = 0; diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devtree.c b/src/mainboard/starlabs/starbook/variants/tgl/devtree.c index b6422f5..6df6900 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/devtree.c @@ -25,32 +25,36 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf_2core->tdp_pl4 = 65; + soc_conf_4core->tdp_pl4 = 65; + + /* Set PL1 to 50% of PL2 */ + soc_conf_2core->tdp_pl1_override = (soc_conf_2core->tdp_pl2_override / 2) & ~1; + soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; cfg->tcc_offset = 30; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; cfg->tcc_offset = 25; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ cfg->tcc_offset = 20; break; } soc_conf_2core->tdp_pl1_override = (soc_conf_2core->tdp_pl1_override * performance_scale) / 100; - soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl2_override * performance_scale) / 100; + soc_conf_2core->tdp_pl2_override = (soc_conf_2core->tdp_pl2_override * performance_scale) / 100; - soc_conf_2core->tdp_pl2_override = (soc_conf_2core->tdp_pl1_override * performance_scale) / 100; + soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl1_override * performance_scale) / 100; soc_conf_4core->tdp_pl2_override = (soc_conf_4core->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf_2core->tdp_pl4 = 65; - soc_conf_4core->tdp_pl4 = 65; - /* Enable/Disable Wireless based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) nic_dev->enabled = 0; diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c b/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c index 9d4bb69..d4abe940 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devtree.c @@ -28,18 +28,26 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf_6core->tdp_pl4 = 65; + soc_conf_14core->tdp_pl4 = 65; + + /* Set PL1 to 50% of PL2 */ + soc_conf_6core->tdp_pl1_override = (soc_conf_6core->tdp_pl2_override / 2) & ~1; + soc_conf_14core->tdp_pl1_override = (soc_conf_14core->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; common_config->pch_thermal_trip = 30; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; common_config->pch_thermal_trip = 25; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ common_config->pch_thermal_trip = 20; break; } @@ -50,10 +58,6 @@ soc_conf_14core->tdp_pl1_override = (soc_conf_14core->tdp_pl1_override * performance_scale) / 100; soc_conf_14core->tdp_pl2_override = (soc_conf_14core->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf_6core->tdp_pl4 = 65; - soc_conf_14core->tdp_pl4 = 65; - /* Enable/Disable Bluetooth based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) cfg->usb2_ports[9].enable = 0; diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c index 6067a46..dca182c 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c @@ -25,18 +25,24 @@ uint8_t performance_scale = 100; - /* Update PL1 & PL2 based on CMOS settings */ + /* Set PL4 to 1.0C */ + soc_conf_4core->tdp_pl4 = 37; + + /* Set PL1 to 50% of PL2 */ + soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl2_override / 2) & ~1; + + /* Scale PL1 & PL2 based on CMOS settings */ switch (get_power_profile(PP_POWER_SAVER)) { case PP_POWER_SAVER: - performance_scale -= 25; + performance_scale -= 50; common_config->pch_thermal_trip = 30; break; case PP_BALANCED: - /* Use the Intel defaults */ + performance_scale -= 25; common_config->pch_thermal_trip = 25; break; case PP_PERFORMANCE: - performance_scale += 25; + /* Use the Intel defaults */ common_config->pch_thermal_trip = 20; break; } @@ -44,9 +50,6 @@ soc_conf_4core->tdp_pl1_override = (soc_conf_4core->tdp_pl1_override * performance_scale) / 100; soc_conf_4core->tdp_pl2_override = (soc_conf_4core->tdp_pl2_override * performance_scale) / 100; - /* Set PL4 to 1.0C */ - soc_conf_4core->tdp_pl4 = 37; - /* Enable/Disable Bluetooth based on CMOS settings */ if (get_uint_option("wireless", 1) == 0) { cfg->usb2_ports[9].enable = 0; -- To view, visit https://review.coreboot.org/c/coreboot/+/85694?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8375428e9ace8e505e8cb53b2e4912592715b79a Gerrit-Change-Number: 85694 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Declare all DDI interfaces
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85693?usp=email ) Change subject: mb/starlabs/*: Declare all DDI interfaces ...................................................................... mb/starlabs/*: Declare all DDI interfaces This seems to make no noticeable difference, but configure these interfaces according to the schematics. Enable HPD for all DisplayPort links and DDC for HDMI links. Change-Id: I0f736761bcc177afebb98eb2f612b089bc6f13a4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85693 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb 5 files changed, 12 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb index 5236ba5..620b3f5 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb @@ -19,10 +19,9 @@ device domain 0 on device ref igpu on register "ddi_ports_config" = "{ - [DDI_PORT_A] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_1] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, - [DDI_PORT_2] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref tcss_xhci on diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 3d17a19..e525d47 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -30,8 +30,9 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" register "ddi_portA_config" = "1" register "ddi_ports_config" = "{ - [DDI_PORT_A] = DDI_ENABLE_HPD, - [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_A] = DDI_ENABLE_HPD, + [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref gna on end diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index c54a9b4..d84474b 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -34,6 +34,7 @@ register "ddi_ports_config" = "{ [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref pcie4_0 on # SSD x4 diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index 1f5bf5e..8ac7e8f 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -32,8 +32,9 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" register "ddi_portA_config" = "1" register "ddi_ports_config" = "{ - [DDI_PORT_A] = DDI_ENABLE_HPD, - [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_A] = DDI_ENABLE_HPD, + [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD, }" end device ref pcie4_0 on # SSD x4 diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 43e5bc9..64d7405 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -40,7 +40,10 @@ register "gfx" = "GMA_DEFAULT_PANEL(0)" register "ddi_portA_config" = "1" register "ddi_ports_config" = "{ + [DDI_PORT_A] = DDI_ENABLE_HPD, [DDI_PORT_B] = DDI_ENABLE_HPD | DDI_ENABLE_DDC, + [DDI_PORT_1] = DDI_ENABLE_HPD, + [DDI_PORT_2] = DDI_ENABLE_HPD, }" end device ref gna on end -- To view, visit https://review.coreboot.org/c/coreboot/+/85693?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0f736761bcc177afebb98eb2f612b089bc6f13a4 Gerrit-Change-Number: 85693 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Unify WiFi driver settings
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85692?usp=email ) Change subject: mb/starlabs/*: Unify WiFi driver settings ...................................................................... mb/starlabs/*: Unify WiFi driver settings Adjust ACPI so they are consistant across all boards. Change-Id: If0fd6b3dd67583842e4520679b7a9c3ab9f433c4 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85692 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb M src/mainboard/starlabs/lite/variants/glk/devicetree.cb M src/mainboard/starlabs/lite/variants/glkr/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb 10 files changed, 23 insertions(+), 13 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb index 3753b46..5236ba5 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb @@ -132,7 +132,13 @@ end end device ref shared_sram on end - device ref cnvi_wifi on end + device ref cnvi_wifi on + chip drivers/wifi/generic + register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" + device generic 0 on end + end + end device ref sata on register "sata_salp_support" = "1" register "sata_ports_enable[0]" = "1" diff --git a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb index b93d566..629668e 100644 --- a/src/mainboard/starlabs/lite/variants/glk/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glk/devicetree.cb @@ -60,7 +60,8 @@ end device ref cnvi on chip drivers/wifi/generic - register "wake" = "GPE0A_CNVI_PME_STS" + register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end end diff --git a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb index 65ac609..549c022 100644 --- a/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb +++ b/src/mainboard/starlabs/lite/variants/glkr/devicetree.cb @@ -60,7 +60,8 @@ end device ref cnvi on chip drivers/wifi/generic - register "wake" = "GPE0A_CNVI_PME_STS" + register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end end diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 330e440..3d17a19 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -145,7 +145,7 @@ end device ref pcie_rp5 on # WiFi chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -163,7 +163,7 @@ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" - register "add_acpi_dma_property" = "1" + register "add_acpi_dma_property" = "true" register "skip_on_off_support" = "1" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "use_rp_mutex" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 6569b04..d390a88 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -132,7 +132,8 @@ device ref shared_sram on end device ref cnvi_wifi on chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" + register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end end diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index a594f7a..f50e35d 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -90,6 +90,8 @@ register "PcieRpClkSrcNumber[5]" = "4" register "PcieRpLtrEnable[5]" = "1" chip drivers/wifi/generic + register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end end diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index dc27e4e..c54a9b4 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -182,7 +182,7 @@ device ref shared_sram on end device ref pcie_rp5 on # WiFi chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -200,8 +200,8 @@ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" - register "add_acpi_dma_property" = "1" register "skip_on_off_support" = "1" + register "add_acpi_dma_property" = "true" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "use_rp_mutex" = "1" device generic 0 on end diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index b7b93d5..8dfece7 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -164,7 +164,8 @@ device ref shared_ram on end device ref cnvi_wifi on chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" + register "add_acpi_dma_property" = "true" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end end diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index c3b9792..1f5bf5e 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -189,7 +189,7 @@ end device ref pcie_rp5 on # WiFi chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" + register "enable_cnvi_ddr_rfim" = "true" device generic 0 on end end register "pch_pcie_rp[PCH_RP(5)]" = "{ @@ -207,7 +207,7 @@ register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_H2)" register "srcclk_pin" = "2" - register "add_acpi_dma_property" = "1" + register "add_acpi_dma_property" = "true" register "skip_on_off_support" = "1" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "use_rp_mutex" = "1" diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index b127716..43e5bc9 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -125,10 +125,8 @@ device ref shared_sram on end device ref cnvi_wifi on chip drivers/wifi/generic - register "wake" = "GPE0_PME_B0" register "add_acpi_dma_property" = "true" register "enable_cnvi_ddr_rfim" = "true" - use usb2_port10 as bluetooth_companion device generic 0 on end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/85692?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0fd6b3dd67583842e4520679b7a9c3ab9f433c4 Gerrit-Change-Number: 85692 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[M] Change in coreboot[main]: mb/starlabs/*: Configure GPIO UPDs for eSPI
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85691?usp=email ) Change subject: mb/starlabs/*: Configure GPIO UPDs for eSPI ...................................................................... mb/starlabs/*: Configure GPIO UPDs for eSPI FSP defaults to using pins that are used for LPC; given that coreboot and these boards only supports eSPI, set these pins accordingly. If this is not done, FSP will assert and not boot. Change-Id: Ide4d92211fa7ab496c38ce1c4e895337c269d247 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85691 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk A src/mainboard/starlabs/byte_adl/variants/mk_ii/ramstage.c M src/mainboard/starlabs/starbook/variants/adl/ramstage.c M src/mainboard/starlabs/starbook/variants/rpl/ramstage.c M src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk A src/mainboard/starlabs/starlite_adl/variants/mk_v/ramstage.c 7 files changed, 53 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk b/src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk index 2a505c3..9abc069 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/Makefile.mk @@ -7,3 +7,4 @@ ramstage-y += devtree.c ramstage-y += gpio.c ramstage-y += hda_verb.c +ramstage-y += ramstage.c diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/ramstage.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/ramstage.c new file mode 100644 index 0000000..80f186e --- /dev/null +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/ramstage.c @@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/ramstage.h> + +void mainboard_silicon_init_params(FSP_S_CONFIG *supd) +{ + /* + * FSP defaults to pins that are used for LPC; given that + * coreboot only supports eSPI, set these pins accordingly. + */ + supd->CnviRfResetPinMux = 0x194ce404; // GPP_F4 + supd->CnviClkreqPinMux = 0x294ce605; // GPP_F5 + supd->SataPortDevSlpPinMux[1] = 0x5967400d; // GPP_H13 +} diff --git a/src/mainboard/starlabs/starbook/variants/adl/ramstage.c b/src/mainboard/starlabs/starbook/variants/adl/ramstage.c index a2c3926..9e678de 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/ramstage.c +++ b/src/mainboard/starlabs/starbook/variants/adl/ramstage.c @@ -3,10 +3,17 @@ #include <option.h> #include <soc/ramstage.h> - void mainboard_silicon_init_params(FSP_S_CONFIG *supd) { /* + * FSP defaults to pins that are used for LPC; given that + * coreboot only supports eSPI, set these pins accordingly. + */ + supd->PchSerialIoI2cSdaPinMux[0] = 0x1947c404; // GPP_H4 + supd->PchSerialIoI2cSclPinMux[0] = 0x1947a405; // GPP_H5 + supd->SataPortDevSlpPinMux[1] = 0x5967400d; // GPP_H13 + + /* * Enable Hot Plug on RP5 to slow down coreboot so that * third-party drives are detected. */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c b/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c index bd3d7ed..f62c069 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c @@ -3,9 +3,15 @@ #include <option.h> #include <soc/ramstage.h> - void mainboard_silicon_init_params(FSP_S_CONFIG *supd) { + /* + * FSP defaults to pins that are used for LPC; given that + * coreboot only supports eSPI, set these pins accordingly. + */ + supd->PchSerialIoI2cSdaPinMux[0] = 0x1947c404; // GPP_H4 + supd->PchSerialIoI2cSclPinMux[0] = 0x1947a405; // GPP_H5 + if (get_uint_option("thunderbolt", 1) == 0) supd->UsbTcPortEn = 0; } diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c b/src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c index bd3d7ed..f62c069 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c @@ -3,9 +3,15 @@ #include <option.h> #include <soc/ramstage.h> - void mainboard_silicon_init_params(FSP_S_CONFIG *supd) { + /* + * FSP defaults to pins that are used for LPC; given that + * coreboot only supports eSPI, set these pins accordingly. + */ + supd->PchSerialIoI2cSdaPinMux[0] = 0x1947c404; // GPP_H4 + supd->PchSerialIoI2cSclPinMux[0] = 0x1947a405; // GPP_H5 + if (get_uint_option("thunderbolt", 1) == 0) supd->UsbTcPortEn = 0; } diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk b/src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk index 2a505c3..9abc069 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/Makefile.mk @@ -7,3 +7,4 @@ ramstage-y += devtree.c ramstage-y += gpio.c ramstage-y += hda_verb.c +ramstage-y += ramstage.c diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/ramstage.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/ramstage.c new file mode 100644 index 0000000..c6c16c0 --- /dev/null +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/ramstage.c @@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <soc/ramstage.h> + +void mainboard_silicon_init_params(FSP_S_CONFIG *supd) +{ + /* + * FSP defaults to pins that are used for LPC; given that + * coreboot only supports eSPI, set these pins accordingly. + */ + supd->CnviRfResetPinMux = 0x194ce404; // GPP_F4 + supd->CnviClkreqPinMux = 0x294ce605; // GPP_F5 + supd->PchSerialIoI2cSdaPinMux[0] = 0x1947c404; // GPP_H4 + supd->PchSerialIoI2cSclPinMux[0] = 0x1947a405; // GPP_H5 +} -- To view, visit https://review.coreboot.org/c/coreboot/+/85691?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ide4d92211fa7ab496c38ce1c4e895337c269d247 Gerrit-Change-Number: 85691 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Use the new Intel Bluetooth driver
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84636?usp=email ) Change subject: mb/starlabs/*: Use the new Intel Bluetooth driver ...................................................................... mb/starlabs/*: Use the new Intel Bluetooth driver Use the newly created Intel Bluetooth ACPI driver. Change-Id: I6438a21a73e8ddab21fb5b9021fb4d5e2f8c1c22 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84636 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-by: Alicja Michalska <ahplka19(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb M src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/adl/gpio.c M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/gpio.c M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/gpio.c M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb M src/mainboard/starlabs/starfighter/variants/rpl/gpio.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c 13 files changed, 33 insertions(+), 12 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Alicja Michalska: Looks good to me, but someone else must approve diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb index 87cab71..3753b46 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devicetree.cb @@ -122,6 +122,10 @@ register "desc" = ""Internal Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(0, 5)" + register "is_intel_bluetooth" = "1" + register "cnvi_bt_audio_offload" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_VGPIO_0)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device ref usb2_port10 on end end end diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c index 497ba75..6353d64 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), /* A14: Type C VBUS OverCurrent */ PAD_CFG_NF(GPP_A14, NONE, DEEP, NF1), /* A15: Test Point 3 */ @@ -244,7 +244,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Test Point 7 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index ce5bda4..330e440 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -120,6 +120,9 @@ register "desc" = ""Internal Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(0, 6)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device ref usb2_port10 on end end end diff --git a/src/mainboard/starlabs/starbook/variants/adl/gpio.c b/src/mainboard/starlabs/starbook/variants/adl/gpio.c index dd1c7a7..00a4a08 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/adl/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -244,7 +244,7 @@ /* E2: Not Connected */ PAD_CFG_GPO(GPP_E2, 1, PLTRST), /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Test Point 14 */ PAD_NC(GPP_E4, NONE), /* E5: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index 6769ac9..6569b04 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -121,6 +121,9 @@ register "desc" = ""Internal Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(0, 5)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(CNV_BTEN)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B4)" device ref usb2_port10 on end end end diff --git a/src/mainboard/starlabs/starbook/variants/cml/gpio.c b/src/mainboard/starlabs/starbook/variants/cml/gpio.c index e29cd81..2baac30 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/cml/gpio.c @@ -116,7 +116,7 @@ /* B3: CLICK_PAD_INT_R_N */ PAD_CFG_GPI_APIC_LOW(GPP_B3, NONE, PLTRST), /* B4: BT_RF_KILL_N */ - PAD_CFG_GPO(GPP_B4, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_B4, 1, DEEP, NONE), /* B5: WLAN_CLKREQ# */ PAD_CFG_NF(GPP_B5, NONE, DEEP, NF1), /* B6: CLKREQ1_SSD_N */ @@ -161,7 +161,7 @@ /* C1: SMB_DATA */ PAD_CFG_NF(GPP_C1, NONE, DEEP, NF1), /* C2: WIFI_RF_KILL_N */ - PAD_CFG_GPO(GPP_C2, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_C2, 1, DEEP, NONE), /* C3: Not Connected */ PAD_NC(GPP_C3, NONE), /* C4: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 7faf157..dc27e4e 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -161,6 +161,9 @@ register "desc" = ""Internal Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(0, 6)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" + register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" device ref usb2_port10 on end end end diff --git a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c index 99b8604..9b7b25c 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_NC(GPP_A12, NONE), /* A13: BlueTooth RF Kill */ - PAD_NC(GPP_A13, NONE), + PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -244,7 +244,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_NC(GPP_E3, NONE), + PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Retimer Force Power */ PAD_CFG_GPO(GPP_E4, 0, PLTRST), /* E5: Not Connected */ diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index c221285..b7b93d5 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -153,6 +153,9 @@ register "desc" = ""Internal Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(0, 5)" + register "is_intel_bluetooth" = "1" + register "cnvi_bt_audio_offload" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(CNV_BTEN)" device ref usb2_port10 on end end end diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb index e8ccf90..c3b9792 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb @@ -165,6 +165,8 @@ register "desc" = ""Internal Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" register "group" = "ACPI_PLD_GROUP(0, 5)" + register "is_intel_bluetooth" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_A13)" device ref usb2_port10 on end end end diff --git a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c index 604e1b4..c28592e 100644 --- a/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c +++ b/src/mainboard/starlabs/starfighter/variants/rpl/gpio.c @@ -72,7 +72,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), /* A14: Test Point 45 */ PAD_NC(GPP_A14, NONE), /* A15: Test Point 52 */ @@ -249,7 +249,7 @@ /* E2: Not Connected */ PAD_CFG_GPO(GPP_E2, 1, PLTRST), /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: Retimer Force Power */ PAD_CFG_GPO(GPP_E4, 0, PLTRST), /* E5: Not Connected */ diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index e1cb6bd..b127716 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -112,6 +112,9 @@ chip drivers/usb/acpi register "desc" = ""CNVi Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" + register "is_intel_bluetooth" = "1" + register "cnvi_bt_audio_offload" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_VGPIO_0)" register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A13)" register "group" = "ACPI_PLD_GROUP(0, 5)" device ref usb2_port10 on end diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c index d026769..c60c369 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/gpio.c @@ -63,7 +63,7 @@ /* A12: PCH M.2 SSD PEDET */ PAD_CFG_NF(GPP_A12, NONE, DEEP, NF1), /* A13: BlueTooth RF Kill */ - PAD_CFG_GPO(GPP_A13, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_A13, 1, DEEP, NONE), /* A14: Camera Power Enable */ PAD_NC(GPP_A14, NONE), /* A15: Camera Reset */ @@ -242,7 +242,7 @@ /* E2: Not Connected */ PAD_NC(GPP_E2, NONE), /* E3: WiFi RF Kill */ - PAD_CFG_GPO(GPP_E3, 1, DEEP), + PAD_CFG_GPO_GPIO_DRIVER(GPP_E3, 1, DEEP, NONE), /* E4: P Offset */ PAD_NC(GPP_E4, NONE), /* E5: P Out */ -- To view, visit https://review.coreboot.org/c/coreboot/+/84636?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6438a21a73e8ddab21fb5b9021fb4d5e2f8c1c22 Gerrit-Change-Number: 84636 Gerrit-PatchSet: 27 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/intel/pantherlake: Refactor FSP-M params for debug message control
by Jérémy Compostella (Code Review) 07 Jan '25

07 Jan '25

Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/85827?usp=email ) Change subject: soc/intel/pantherlake: Refactor FSP-M params for debug message control ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I am just wondering: Why ? And why isn't looped in a patch review like this ? -- To view, visit https://review.coreboot.org/c/coreboot/+/85827?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2916ce82133058464d20eed327de7c7288e78a4 Gerrit-Change-Number: 85827 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:29:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Set all I2C speeds to fast
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84736?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/starlabs/*: Set all I2C speeds to fast ...................................................................... mb/starlabs/*: Set all I2C speeds to fast The default i2c speed is I2C_SPEED_STANDARD, but the coreboot driver defaults to I2C_SPEED_FAST. The difference in performance and power consumption is negligible, so set the buses to fast and remove the superfluous option. Change-Id: Ic722e971e6f94965d28fd158a46d144a19490199 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84736 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/cml/devicetree.cb M src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb M src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb M src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c 7 files changed, 39 insertions(+), 6 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index 8b4daf6..ce5bda4 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -8,6 +8,12 @@ [PchSerialIoIndexI2C0] = PchSerialIoPci, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb index db646e3..6769ac9 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/cml/devicetree.cb @@ -21,6 +21,12 @@ [PchSerialIoIndexUART2] = PchSerialIoSkipInit, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + # Power register "PchPmSlpS3MinAssert" = "2" # 50ms register "PchPmSlpS4MinAssert" = "3" # 1s diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb index 21c475e..a594f7a 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/kbl/devicetree.cb @@ -20,6 +20,12 @@ [PchSerialIoIndexUart2] = PchSerialIoSkipInit, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + # Power register "PmConfigSlpS3MinAssert" = "2" # 50ms register "PmConfigSlpS4MinAssert" = "3" # 1s diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 8889cf6..7faf157 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -10,6 +10,12 @@ [PchSerialIoIndexI2C0] = PchSerialIoPci, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb index 9f208b9..c221285 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb @@ -22,6 +22,12 @@ [PchSerialIoIndexI2C4] = PchSerialIoSkipInit, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + }" + register "SerialIoUartMode" = "{ [PchSerialIoIndexUART2] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb index 3d49cc1..e1cb6bd 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb @@ -11,6 +11,15 @@ [PchSerialIoIndexI2C2] = PchSerialIoPci, }" + register "common_soc_config" = "{ + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + } + }" + register "serial_io_uart_mode" = "{ [PchSerialIoIndexUART0] = PchSerialIoSkipInit, }" diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c index 8c35c5c..6067a46 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c @@ -68,10 +68,4 @@ /* Enable/Disable Accelerometer based on CMOS settings */ if (get_uint_option("accelerometer", 1) == 0) accelerometer_dev->enabled = 0; - - /* Set I2C devices speed to fast based on CMOS settings */ - if (get_uint_option("i2c_speed_fast", 0) == 1) { - common_config->i2c[0].speed = I2C_SPEED_FAST; - common_config->i2c[2].speed = I2C_SPEED_FAST; - } } -- To view, visit https://review.coreboot.org/c/coreboot/+/84736?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic722e971e6f94965d28fd158a46d144a19490199 Gerrit-Change-Number: 84736 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Sean Rhodes has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84734?usp=email ) ( 6 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory ...................................................................... ec/starlabs/merlin: Always use ECRD and ECWR when accessing EC memory Ensure any reads or writes to the EC memory, are performed with ECRD (Read) and ECWR (Write) as these methods use a mutex. Also, use local variables to cache reads of the same variable within a given ACPI method. This solves: Initialized Arguments for Method [ECRD]: (1 arguments defined for method invocation) Arg0: 00000000967261a4 [RefOf] <Node> Name ECPS RegionField 000000007d4b8073 ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.ECRD due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529) ACPI Error: Aborting method \_SB.PCI0.LPCB.EC.ADP1._PSR due to previous error (AE_BAD_PARAMETER) (20230628/psparse-529) Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84734 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/ec/starlabs/merlin/acpi/battery.asl M src/ec/starlabs/merlin/acpi/ec.asl M src/ec/starlabs/merlin/acpi/suspend.asl M src/ec/starlabs/merlin/variants/apl/events.asl M src/ec/starlabs/merlin/variants/cezanne/events.asl M src/ec/starlabs/merlin/variants/glk/events.asl M src/ec/starlabs/merlin/variants/glkr/events.asl M src/ec/starlabs/merlin/variants/kbl/events.asl M src/ec/starlabs/merlin/variants/merlin/events.asl 9 files changed, 46 insertions(+), 41 deletions(-) Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/ec/starlabs/merlin/acpi/battery.asl b/src/ec/starlabs/merlin/acpi/battery.asl index ee800ed..10fea6a 100644 --- a/src/ec/starlabs/merlin/acpi/battery.asl +++ b/src/ec/starlabs/merlin/acpi/battery.asl @@ -9,7 +9,7 @@ // Battery Status // 0x80 BIT1 0x01 = Present // 0x80 BIT1 0x00 = Not Present - If (ECPS & 0x02) + If (ECRD (RefOf(ECPS)) & 0x02) { Return (0x1F) } @@ -34,20 +34,22 @@ CONFIG_EC_STARLABS_BATTERY_TYPE, // 11: Battery Type CONFIG_EC_STARLABS_BATTERY_OEM // 12: OEM Information }) + Method (_BIF, 0, NotSerialized) { - If (B1DC) { - SBIF [1] = B1DC + Local0 = ECRD(RefOf(B1DC)) + If (Local0) { + SBIF [1] = Local0 If (B1FC != 0xffff) { - SBIF [2] = B1FC + SBIF [2] = ECRD(RefOf(B1FC)) } Else { - SBIF [2] = B1DC + SBIF [2] = Local0 } - SBIF [4] = B1DV - SBIF [5] = B1DC / 5 // 20% - SBIF [6] = B1DC / 20 // 5% - SBIF [7] = B1DC / 500 // 0.2% - SBIF [8] = B1DC / 500 // 0.2% + SBIF [4] = ECRD(RefOf(B1DV)) + SBIF [5] = Local0 / 5 // 20% + SBIF [6] = Local0 / 20 // 5% + SBIF [7] = Local0 / 500 // 0.2% + SBIF [8] = Local0 / 500 // 0.2% } Return (SBIF) } @@ -83,21 +85,22 @@ }) Method (_BIX, 0, NotSerialized) { - If (B1DC) { - XBIF [2] = B1DC + Local0 = ECRD(RefOf(B1DC)) + If (Local0) { + XBIF [2] = Local0 If (B1FC != 0xffff) { - XBIF [3] = B1FC + XBIF [3] = ECRD(RefOf(B1FC)) } Else { - XBIF [3] = B1DC + XBIF [3] = Local0 } - XBIF [5] = B1DV - XBIF [6] = B1DC / 5 // 20% - XBIF [7] = B1DC / 20 // 5% + XBIF [5] = ECRD(RefOf(B1DV)) + XBIF [6] = Local0 / 5 // 20% + XBIF [7] = Local0 / 20 // 5% If (B1CC != 0xffff) { - XBIF [8] = B1CC + XBIF [8] = ECRD(RefOf(B1CC)) } - XBIF [14] = B1DC / 500 // 0.2% - XBIF [15] = B1DC / 500 // 0.2% + XBIF [14] = Local0 / 500 // 0.2% + XBIF [15] = Local0 / 500 // 0.2% } Return (XBIF) } @@ -111,14 +114,16 @@ }) Method (_BST, 0, NotSerialized) { - PKG1[0] = (B1ST & 0x07) - PKG1[1] = B1PR - If (B1RC != 0xffff) { - PKG1[2] = B1RC + PKG1[0] = (ECRD(RefOf(B1ST)) & 0x07) + PKG1[1] = ECRD(RefOf(B1PR)) + + Local0 = ECRD(RefOf(B1RC)) + If (Local0 != 0xffff) { + PKG1[2] = Local0 } Else { - PKG1[2] = (B1RP * B1DC) / 100 + PKG1[2] = (ECRD(RefOf(B1RP)) * ECRD(RefOf(B1DC))) / 100 } - PKG1[3] = B1PV + PKG1[3] = ECRD(RefOf(B1PV)) Return (PKG1) } Method (_PCL, 0, NotSerialized) diff --git a/src/ec/starlabs/merlin/acpi/ec.asl b/src/ec/starlabs/merlin/acpi/ec.asl index 7eec057..1219b82 100644 --- a/src/ec/starlabs/merlin/acpi/ec.asl +++ b/src/ec/starlabs/merlin/acpi/ec.asl @@ -147,10 +147,10 @@ ECAV = 0x01 // Initialise the Lid State - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) // Initialise the OS State - OSFG = 0x01 + ECWR(0x01, RefOf(OSFG)) // Initialise the Power State PWRS = (ECRD (RefOf(ECPS)) & 0x01) diff --git a/src/ec/starlabs/merlin/acpi/suspend.asl b/src/ec/starlabs/merlin/acpi/suspend.asl index e0e89a3..2039b34 100644 --- a/src/ec/starlabs/merlin/acpi/suspend.asl +++ b/src/ec/starlabs/merlin/acpi/suspend.asl @@ -68,7 +68,7 @@ * Disable ACPI support. * This should always be the last action before entering S4 or S5. */ - \_SB.PCI0.LPCB.EC.OSFG = 0x00 + \_SB.PCI0.LPCB.EC.ECWR(0x00, RefOf(\_SB.PCI0.LPCB.EC.OSFG)) } Method (RWAK, 1, Serialized) @@ -77,7 +77,7 @@ * Enable ACPI support. * This should always be the first action when exiting S4 or S5. */ - \_SB.PCI0.LPCB.EC.OSFG = 0x01 + \_SB.PCI0.LPCB.EC.ECWR(0x01, RefOf(\_SB.PCI0.LPCB.EC.OSFG)) /* Restore EC settings from CMOS */ Switch (ToInteger (\_SB.PCI0.LPCB.TPLC)) diff --git a/src/ec/starlabs/merlin/variants/apl/events.asl b/src/ec/starlabs/merlin/variants/apl/events.asl index 57da405..85ce767 100644 --- a/src/ec/starlabs/merlin/variants/apl/events.asl +++ b/src/ec/starlabs/merlin/variants/apl/events.asl @@ -2,13 +2,13 @@ Method (_Q0D, 0, NotSerialized) // Event: Lid Opened { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } Method (_Q0C, 0, NotSerialized) // Event: Lid Closed { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } diff --git a/src/ec/starlabs/merlin/variants/cezanne/events.asl b/src/ec/starlabs/merlin/variants/cezanne/events.asl index 37b84b7..4c9608c 100644 --- a/src/ec/starlabs/merlin/variants/cezanne/events.asl +++ b/src/ec/starlabs/merlin/variants/cezanne/events.asl @@ -74,13 +74,13 @@ Method (_Q0C, 0, NotSerialized) // Event: Lid Closed { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } Method (_Q0D, 0, NotSerialized) // Event: Lid Opened { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } diff --git a/src/ec/starlabs/merlin/variants/glk/events.asl b/src/ec/starlabs/merlin/variants/glk/events.asl index 46aebe4..f43dc36 100644 --- a/src/ec/starlabs/merlin/variants/glk/events.asl +++ b/src/ec/starlabs/merlin/variants/glk/events.asl @@ -2,13 +2,13 @@ Method (_Q0D, 0, NotSerialized) // Event: Lid Opened { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } Method (_Q0C, 0, NotSerialized) // Event: Lid Closed { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } diff --git a/src/ec/starlabs/merlin/variants/glkr/events.asl b/src/ec/starlabs/merlin/variants/glkr/events.asl index 556da66..68f5614 100644 --- a/src/ec/starlabs/merlin/variants/glkr/events.asl +++ b/src/ec/starlabs/merlin/variants/glkr/events.asl @@ -2,13 +2,13 @@ Method (_Q0D, 0, NotSerialized) // Event: Lid Opened { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } Method (_Q0C, 0, NotSerialized) // Event: Lid Closed { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } diff --git a/src/ec/starlabs/merlin/variants/kbl/events.asl b/src/ec/starlabs/merlin/variants/kbl/events.asl index 5e80fd0..c792d9a 100644 --- a/src/ec/starlabs/merlin/variants/kbl/events.asl +++ b/src/ec/starlabs/merlin/variants/kbl/events.asl @@ -2,13 +2,13 @@ Method (_Q0D, 0, NotSerialized) // Event: Lid Opened { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } Method (_Q0C, 0, NotSerialized) // Event: Lid Closed { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } diff --git a/src/ec/starlabs/merlin/variants/merlin/events.asl b/src/ec/starlabs/merlin/variants/merlin/events.asl index 38a4971..64bb0d0 100644 --- a/src/ec/starlabs/merlin/variants/merlin/events.asl +++ b/src/ec/starlabs/merlin/variants/merlin/events.asl @@ -22,6 +22,6 @@ Method (_Q0C, 0, NotSerialized) // Event: Lid Opened or Closed { - \LIDS = LSTE + \LIDS = ECRD(RefOf(LSTE)) Notify (LID0, 0x80) } -- To view, visit https://review.coreboot.org/c/coreboot/+/84734?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bbb538017cc004bff1989a8017ccfcd1ba9ab5c Gerrit-Change-Number: 84734 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
65
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025