coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
650 discussions

[S] Change in coreboot[main]: mb/starlabs/*: Add a CMOS option to disable the GNA
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Sean Rhodes. Hello Matt DeVillier, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85703?usp=email to look at the new patch set (#10). Change subject: mb/starlabs/*: Add a CMOS option to disable the GNA ...................................................................... mb/starlabs/*: Add a CMOS option to disable the GNA Add an option, the defaults to disabled, to control whether the GNA (Gaussian Neural Accelerator) is enabled. This is a device that designed to handle AI tasks. Change-Id: I99f015cf1b5e21e8b524c4aa9bd3e94f86908ca1 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/byte_adl/cmos.default M src/mainboard/starlabs/byte_adl/cmos.layout M src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c M src/mainboard/starlabs/starbook/cmos.default M src/mainboard/starlabs/starbook/cmos.layout M src/mainboard/starlabs/starbook/variants/adl/devtree.c M src/mainboard/starlabs/starbook/variants/rpl/devtree.c M src/mainboard/starlabs/starbook/variants/tgl/devtree.c M src/mainboard/starlabs/starfighter/cmos.default M src/mainboard/starlabs/starfighter/cmos.layout M src/mainboard/starlabs/starfighter/variants/rpl/devtree.c M src/mainboard/starlabs/starlite_adl/cmos.default M src/mainboard/starlabs/starlite_adl/cmos.layout M src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c 14 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/85703/10 -- To view, visit https://review.coreboot.org/c/coreboot/+/85703?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I99f015cf1b5e21e8b524c4aa9bd3e94f86908ca1 Gerrit-Change-Number: 85703 Gerrit-PatchSet: 10 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Adjust the EC code to read values from CMOS
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/76582?usp=email ) Change subject: ec/starlabs/merlin: Adjust the EC code to read values from CMOS ...................................................................... Patch Set 14: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/76582/comment/79e50b26_dd294d61?us… : PS13, Line 9: rather : that option. > can you clarify? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/76582?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb094456543c75b59a8ddd80b58eb4fa1e10144f Gerrit-Change-Number: 76582 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 20:20:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Adjust the EC code to read values from CMOS
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/76582?usp=email to look at the new patch set (#14). Change subject: ec/starlabs/merlin: Adjust the EC code to read values from CMOS ...................................................................... ec/starlabs/merlin: Adjust the EC code to read values from CMOS This is in preparation to store options in EFI variable store, rather that CMOS. However, some still need to stay in CMOS, so that they can be accessed via ACPI. Change-Id: Idb094456543c75b59a8ddd80b58eb4fa1e10144f Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/ec/starlabs/merlin/ite.c M src/ec/starlabs/merlin/nuvoton.c 2 files changed, 141 insertions(+), 52 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/76582/14 -- To view, visit https://review.coreboot.org/c/coreboot/+/76582?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb094456543c75b59a8ddd80b58eb4fa1e10144f Gerrit-Change-Number: 76582 Gerrit-PatchSet: 14 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[L] Change in coreboot[main]: mb/starlabs/starbook: Add Meteor Lake (165H) variant
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85715?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/starlabs/starbook: Add Meteor Lake (165H) variant ...................................................................... mb/starlabs/starbook: Add Meteor Lake (165H) variant Change-Id: I6621585086c58d19574841314796ed9db779036e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/starbook_mtl.md M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/Kconfig.name M src/mainboard/starlabs/starbook/dsdt.asl A src/mainboard/starlabs/starbook/variants/mtl/Makefile.mk A src/mainboard/starlabs/starbook/variants/mtl/board.fmd A src/mainboard/starlabs/starbook/variants/mtl/data.vbt A src/mainboard/starlabs/starbook/variants/mtl/devicetree.cb A src/mainboard/starlabs/starbook/variants/mtl/devtree.c A src/mainboard/starlabs/starbook/variants/mtl/gpio.c A src/mainboard/starlabs/starbook/variants/mtl/hda_verb.c A src/mainboard/starlabs/starbook/variants/mtl/ramstage.c A src/mainboard/starlabs/starbook/variants/mtl/romstage.c 14 files changed, 837 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/85715/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/85715?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6621585086c58d19574841314796ed9db779036e Gerrit-Change-Number: 85715 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XL] Change in coreboot[main]: mb/starlabs/starbook: Add AlderLake-N variant
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/85714?usp=email to look at the new patch set (#7). Change subject: mb/starlabs/starbook: Add AlderLake-N variant ...................................................................... mb/starlabs/starbook: Add AlderLake-N variant Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/starbook_adl_n.md M src/mainboard/starlabs/starbook/Kconfig M src/mainboard/starlabs/starbook/Kconfig.name A src/mainboard/starlabs/starbook/variants/adl_n/Makefile.mk A src/mainboard/starlabs/starbook/variants/adl_n/board.fmd A src/mainboard/starlabs/starbook/variants/adl_n/data.vbt A src/mainboard/starlabs/starbook/variants/adl_n/devicetree.cb A src/mainboard/starlabs/starbook/variants/adl_n/devtree.c A src/mainboard/starlabs/starbook/variants/adl_n/gpio.c A src/mainboard/starlabs/starbook/variants/adl_n/hda_verb.c A src/mainboard/starlabs/starbook/variants/adl_n/ramstage.c A src/mainboard/starlabs/starbook/variants/adl_n/romstage.c A src/mainboard/starlabs/starbook/variants/adl_n/vboot.fmd 14 files changed, 1,127 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/85714/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/85714?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id45e31b61046748a57c8104081f689057621bb04 Gerrit-Change-Number: 85714 Gerrit-PatchSet: 7 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: soc/intel/common/cnvi: Fix path for CFLR method
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85885?usp=email ) Change subject: soc/intel/common/cnvi: Fix path for CFLR method ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/85885?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1158cf1ccf50d9095fdab8d2d663041ef1985513 Gerrit-Change-Number: 85885 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:44:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/asrock: Add Z87 Extreme4 (Haswell)
by Jan Philipp Groß (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Angel Pons, Nicholas Chin. Jan Philipp Groß has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/84672?usp=email ) Change subject: mb/asrock: Add Z87 Extreme4 (Haswell) ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84672/comment/1242ff63_8130c55d?us… : PS1, Line 35: - both SATA3 6.0 Gb/s connectors by ASMedia ASM1061 > Okay, so the device shows up but doesn't work at all. […] Fixed in CB:85816. -- To view, visit https://review.coreboot.org/c/coreboot/+/84672?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I78791aa9877a3ad79bf8b896c583fedf37e96d9a Gerrit-Change-Number: 84672 Gerrit-PatchSet: 7 Gerrit-Owner: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:43:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jan Philipp Groß <jeangrande(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin/nuvoton: Remove the call to initialise the keyboard
by Matt DeVillier (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85794?usp=email ) Change subject: ec/starlabs/merlin/nuvoton: Remove the call to initialise the keyboard ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85794/comment/6da06a07_f3885486?us… : PS3, Line 9: This is done by edk2, so there isn't any need for coreboot to do it. > Haven't used another others in a long time, so for now (probably not for long), we do not care Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/85794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I947d5d2f7512cc910963054dfbe6b5dc0f00462a Gerrit-Change-Number: 85794 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:39:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sean Rhodes <sean(a)starlabs.systems> Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[M] Change in coreboot[main]: MAINTAINERS: Update file
by Felix Held (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Martin L Roth, Martin Roth. Felix Held has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/85883?usp=email ) Change subject: MAINTAINERS: Update file ...................................................................... Patch Set 2: (1 comment) File MAINTAINERS: https://review.coreboot.org/c/coreboot/+/85883/comment/11ff63ac_48a1158e?us… : PS2, Line 775: Maintained this should be kept as odd fixes, since that's the old pre-soc/amd code. i did do some cleanups on the non-soc code and probably still have some additional cleanup patches that need some work, but that's not a priority for me. maybe call the category OLD AMD SUPPORT, PRE-SOC AMD SUPPORT, or something like that -- To view, visit https://review.coreboot.org/c/coreboot/+/85883?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2feac94595081fcea9becd9d8067ddd99a50123c Gerrit-Change-Number: 85883 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:36:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: ec/starlabs/merlin/nuvoton: Remove the call to initialise the keyboard
by Sean Rhodes (Code Review) 07 Jan '25

07 Jan '25

Attention is currently required from: Matt DeVillier. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/85794?usp=email ) Change subject: ec/starlabs/merlin/nuvoton: Remove the call to initialise the keyboard ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/85794/comment/ee96c30a_536dd439?us… : PS3, Line 9: This is done by edk2, so there isn't any need for coreboot to do it. > any issue with other payloads (SeaBIOS, Linuxboot/HEADS)? or do we care? Haven't used another others in a long time, so for now (probably not for long), we do not care -- To view, visit https://review.coreboot.org/c/coreboot/+/85794?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I947d5d2f7512cc910963054dfbe6b5dc0f00462a Gerrit-Change-Number: 85794 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 07 Jan 2025 19:32:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
65
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025