coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XS] Change in coreboot[main]: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas, Nicholas Chin. Hello Angel Pons, Angel Pons, Elyes Haouas, Jan Philipp Groß, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86056?usp=email to look at the new patch set (#3). Change subject: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 Commit fee8bcbcfb55 ("drivers/asmedia: Add code to enable AHCI for ASM1061") renamed the ASMEDIA_ASPM_BLACKLIST Kconfig to ASMEDIA_ASM_1061 since the former was only ever used for that card. However, commit fb2462053497 ("mb/asrock: Add Z87 Extreme4 (Haswell)") was merged first and used the old Kconfig, so the tree broke when the AHCH patch was merged. Change the Kconfig to fix the tree. Change-Id: If16455c43e583e7edbf7914db87346385d811190 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/mainboard/asrock/z87_extreme4/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/86056/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/z87_extreme4: Select correct Kconfig for ASM1061
by Angel Pons (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas, Nicholas Chin. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86056/comment/32e9f884_80135cad?us… : PS2, Line 7: mb/z87_extreme4: Select correct Kconfig for ASM1061 nit: mb/asrock/z87_extreme4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:14:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061"
by Angel Pons (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Elyes Haouas, Jan Philipp Groß, Riku Viitanen. Angel Pons has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86055?usp=email ) Change subject: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061" ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS1: > Can you fix this error and be more careful before submitting in the future? […] CB:86056 got pushed before I could get to a computer and make the one-line change myself. -- To view, visit https://review.coreboot.org/c/coreboot/+/86055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbf895ff08bbb309cbb5236c1e5ff1f65f6e299e Gerrit-Change-Number: 86055 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:03:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/z87_extreme4: Select correct Kconfig for ASM1061
by Jan Philipp Groß (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas, Nicholas Chin. Jan Philipp Groß has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:02:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/z87_extreme4: Select correct Kconfig for ASM1061
by Angel Pons (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas, Nicholas Chin. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/*: Drop xhci_overcurrent_map for the easy ones
by Patrick Rudolph (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Alexander Couzens, Keith Hui, Kevin Keijzer, Nicholas Chin, Paul Menzel. Patrick Rudolph has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85923?usp=email ) Change subject: mb/*: Drop xhci_overcurrent_map for the easy ones ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36944e2f2ed265ee492019b75b7dd8b95ca26dbb Gerrit-Change-Number: 85923 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:00:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061"
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas, Jan Philipp Groß, Riku Viitanen. Nicholas Chin has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86055?usp=email ) Change subject: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Can you fix this error and be more careful before submitting in the future? […] I pushed a fix: CB:86056 -- To view, visit https://review.coreboot.org/c/coreboot/+/86055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbf895ff08bbb309cbb5236c1e5ff1f65f6e299e Gerrit-Change-Number: 86055 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 14:58:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/z87_extreme4: Select correct Kconfig for ASM1061
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas. Hello Angel Pons, Elyes Haouas, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86056?usp=email to look at the new patch set (#2). Change subject: mb/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... mb/z87_extreme4: Select correct Kconfig for ASM1061 Commit fee8bcbcfb55 ("drivers/asmedia: Add code to enable AHCI for ASM1061") renamed the ASMEDIA_ASPM_BLACKLIST Kconfig to ASMEDIA_ASM_1061 since the former was only ever used for that card. However, commit fb2462053497 ("mb/asrock: Add Z87 Extreme4 (Haswell)") was merged first and used the old Kconfig, so the tree broke when the AHCH patch was merged. Change the Kconfig to fix the tree. Change-Id: If16455c43e583e7edbf7914db87346385d811190 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/mainboard/asrock/z87_extreme4/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/86056/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 2 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>

1 0

[XS] Change in coreboot[main]: mb/z87_extreme4: Select correct Kconfig for ASM1061
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... mb/z87_extreme4: Select correct Kconfig for ASM1061 Commit fee8bcbcfb55 ("drivers/asmedia: Add code to enable AHCI for ASM1061") renamed the ASMEDIA_ASPM_BLACKLIST Kconfig to ASMEDIA_ASM_1061 since the former was only ever used for that card. However, commit fb2462053497 ("mb/asrock: Add Z87 Extreme4 (Haswell)") was merged first and used the old Kconfig, so the tree broke when the AHCH patch was merged. Change the Kconfig to fix the tree. Change-Id: If16455c43e583e7edbf7914db87346385d811190 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M src/mainboard/asrock/z87_extreme4/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/86056/1 diff --git a/src/mainboard/asrock/z87_extreme4/Kconfig b/src/mainboard/asrock/z87_extreme4/Kconfig index 3ef4afa..f2a2e7c 100644 --- a/src/mainboard/asrock/z87_extreme4/Kconfig +++ b/src/mainboard/asrock/z87_extreme4/Kconfig @@ -5,7 +5,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 - select DRIVERS_ASMEDIA_ASPM_BLACKLIST + select DRIVERS_ASMEDIA_ASM1061 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_GMA_HAVE_VBT -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061"
by Elyes Haouas (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Jan Philipp Groß, Nicholas Chin, Riku Viitanen. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/86055?usp=email ) Change subject: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061" ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > `#!!!!! Error: Undefined Symbol 'DRIVERS_ASMEDIA_ASPM_BLACKLIST' used at src/mainboard/asrock/z87_ex […] Can you fix this error and be more careful before submitting in the future? Thx -- To view, visit https://review.coreboot.org/c/coreboot/+/86055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbf895ff08bbb309cbb5236c1e5ff1f65f6e299e Gerrit-Change-Number: 86055 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Attention: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Sun, 19 Jan 2025 14:49:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025