coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[M] Change in coreboot[main]: docs/getting-started: Update guide for writing docs
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85857?usp=email ) Change subject: docs/getting-started: Update guide for writing docs ...................................................................... Patch Set 4: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I569862e30fb88a421ad2338aafabeaf3ea76836a Gerrit-Change-Number: 85857 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Jan 2025 00:53:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: docs/getting-started: Update guide for writing docs
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/85857?usp=email ) Change subject: docs/getting-started: Update guide for writing docs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85857?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I569862e30fb88a421ad2338aafabeaf3ea76836a Gerrit-Change-Number: 85857 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 20 Jan 2025 00:53:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: util/chromeos/crosfirmware: Improve parsing of manifest.json
by Matt DeVillier (Code Review) 19 Jan '25

19 Jan '25

Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86057?usp=email ) Change subject: util/chromeos/crosfirmware: Improve parsing of manifest.json ...................................................................... util/chromeos/crosfirmware: Improve parsing of manifest.json Some newer boards (like google/skyrim) use a separate line for each field, so adjust parsing to accommodate that. TEST=run `bash crosfirmware.sh` for frostflow, grunt, careena. Change-Id: I3af38d3577f1390c999ad5e6df0fa2c4c4382245 Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> --- M util/chromeos/crosfirmware.sh 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/86057/1 diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index cfb1fcc..22fd611 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -114,8 +114,10 @@ _bios_image=$(grep -m1 "image" "$_unpacked/manifest.json" | cut -f4 -d'"') fi elif [ -f "$_unpacked/manifest.json" ]; then - _version=$(grep -m1 -A1 "$BOARD\":" "$_unpacked/manifest.json" | grep "host" | cut -f12 -d'"') - _bios_image=$(grep -m1 -A3 "$BOARD\":" "$_unpacked/manifest.json" | grep "image" | cut -f4 -d'"') + _version=$(grep -m1 -A4 "$BOARD\":" "$_unpacked/manifest.json" | grep -m1 "rw" | + sed 's/.*$rw.*$/\1/' | sed 's/.*$"Google.*$/\1/' | cut -f2 -d'"') + _bios_image=$(grep -m1 -A7 "$BOARD\":" "$_unpacked/manifest.json" | grep -m1 "image" | + sed 's/.*"image": //' | cut -f2 -d'"') else _version=$(cat $_unpacked/VERSION | grep BIOS\ version: | cut -f2 -d: | tr -d \ ) -- To view, visit https://review.coreboot.org/c/coreboot/+/86057?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3af38d3577f1390c999ad5e6df0fa2c4c4382245 Gerrit-Change-Number: 86057 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[XS] Change in coreboot[main]: util/chromeos/crosfirmware: Improve matching when scanning manifest file
by Matt DeVillier (Code Review) 19 Jan '25

19 Jan '25

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85935?usp=email ) Change subject: util/chromeos/crosfirmware: Improve matching when scanning manifest file ...................................................................... util/chromeos/crosfirmware: Improve matching when scanning manifest file To ensure we find the correct firmware image, match against `$BOARD":` rather than just `$BOARD`. This fixes an issue where another board (b1) using the same firmware build or name as the one we are searching for, causes the grep matching to return empty strings. TEST=successfully extract the firmware image for CAREENA, which previously failed. Change-Id: I2f2a71f0b033938aafc1fd27e2996fe319614b3c Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85935 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M util/chromeos/crosfirmware.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Felix Singer: Looks good to me, approved build bot (Jenkins): Verified diff --git a/util/chromeos/crosfirmware.sh b/util/chromeos/crosfirmware.sh index 1972aec..cfb1fcc 100755 --- a/util/chromeos/crosfirmware.sh +++ b/util/chromeos/crosfirmware.sh @@ -114,8 +114,8 @@ _bios_image=$(grep -m1 "image" "$_unpacked/manifest.json" | cut -f4 -d'"') fi elif [ -f "$_unpacked/manifest.json" ]; then - _version=$(grep -m1 -A1 "$BOARD" "$_unpacked/manifest.json" | grep "host" | cut -f12 -d'"') - _bios_image=$(grep -m1 -A3 "$BOARD" "$_unpacked/manifest.json" | grep "image" | cut -f4 -d'"') + _version=$(grep -m1 -A1 "$BOARD\":" "$_unpacked/manifest.json" | grep "host" | cut -f12 -d'"') + _bios_image=$(grep -m1 -A3 "$BOARD\":" "$_unpacked/manifest.json" | grep "image" | cut -f4 -d'"') else _version=$(cat $_unpacked/VERSION | grep BIOS\ version: | cut -f2 -d: | tr -d \ ) -- To view, visit https://review.coreboot.org/c/coreboot/+/85935?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2f2a71f0b033938aafc1fd27e2996fe319614b3c Gerrit-Change-Number: 85935 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061
by Elyes Haouas (Code Review) 19 Jan '25

19 Jan '25

Elyes Haouas has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 Commit fee8bcbcfb55 ("drivers/asmedia: Add code to enable AHCI for ASM1061") renamed the ASMEDIA_ASPM_BLACKLIST Kconfig to ASMEDIA_ASM_1061 since the former was only ever used for that card. However, commit fb2462053497 ("mb/asrock: Add Z87 Extreme4 (Haswell)") was merged first and used the old Kconfig, so the tree broke when the AHCH patch was merged. Change the Kconfig to fix the tree. Change-Id: If16455c43e583e7edbf7914db87346385d811190 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86056 Reviewed-by: Jan Philipp Groß <jeangrande(a)mailbox.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Elyes Haouas <ehaouas(a)noos.fr> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/asrock/z87_extreme4/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Jan Philipp Groß: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved Elyes Haouas: Looks good to me, approved diff --git a/src/mainboard/asrock/z87_extreme4/Kconfig b/src/mainboard/asrock/z87_extreme4/Kconfig index 3ef4afa..f2a2e7c 100644 --- a/src/mainboard/asrock/z87_extreme4/Kconfig +++ b/src/mainboard/asrock/z87_extreme4/Kconfig @@ -5,7 +5,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y select BOARD_ROMSIZE_KB_8192 - select DRIVERS_ASMEDIA_ASPM_BLACKLIST + select DRIVERS_ASMEDIA_ASM1061 select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select INTEL_GMA_HAVE_VBT -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 4 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061
by Elyes Haouas (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Matt DeVillier, Nicholas Chin. Elyes Haouas has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:53:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: util/nvramtool: Fix spacing issues reported by linter
by Name of user not set (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Nicholas Chin. Hello Nicholas Chin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/86052?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: util/nvramtool: Fix spacing issues reported by linter ...................................................................... util/nvramtool: Fix spacing issues reported by linter Fix for several ERROR:POINTER_LOCATION and many other errors reported by linter. Change-Id: I5a18a571300c6175ea6c8123e79807afa7a6f084 Signed-off-by: libreandre <openrc(a)posteo.de> --- M util/nvramtool/accessors/cmos-hw-unix.c M util/nvramtool/accessors/cmos-mem.c M util/nvramtool/accessors/layout-bin.c M util/nvramtool/accessors/layout-text.c M util/nvramtool/accessors/layout-text.h M util/nvramtool/cbfs.c M util/nvramtool/cbfs.h M util/nvramtool/cli/nvramtool.c M util/nvramtool/cmos_lowlevel.c M util/nvramtool/cmos_lowlevel.h M util/nvramtool/cmos_ops.c M util/nvramtool/cmos_ops.h M util/nvramtool/common.c M util/nvramtool/common.h M util/nvramtool/hexdump.c M util/nvramtool/hexdump.h M util/nvramtool/input_file.c M util/nvramtool/input_file.h M util/nvramtool/layout.c M util/nvramtool/layout.h M util/nvramtool/lbtable.c 21 files changed, 120 insertions(+), 120 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/86052/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/86052?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5a18a571300c6175ea6c8123e79807afa7a6f084 Gerrit-Change-Number: 86052 Gerrit-PatchSet: 4 Gerrit-Owner: openrc(a)posteo.de Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[XS] Change in coreboot[main]: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061
by Angel Pons (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas, Nicholas Chin. Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:31:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061
by Nicholas Chin (Code Review) 19 Jan '25

19 Jan '25

Attention is currently required from: Angel Pons, Elyes Haouas. Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/86056?usp=email ) Change subject: mb/asrock/z87_extreme4: Select correct Kconfig for ASM1061 ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/86056/comment/ad2be5cd_992cc98e?us… : PS2, Line 7: mb/z87_extreme4: Select correct Kconfig for ASM1061 > nit: mb/asrock/z87_extreme4 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/86056?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If16455c43e583e7edbf7914db87346385d811190 Gerrit-Change-Number: 86056 Gerrit-PatchSet: 3 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Sun, 19 Jan 2025 15:14:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[M] Change in coreboot[main]: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061"
by Elyes Haouas (Code Review) 19 Jan '25

19 Jan '25

Elyes Haouas has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/86055?usp=email ) Change subject: Revert "drivers/asmedia: Add code to enable AHCI for ASM1061" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/86055?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifbf895ff08bbb309cbb5236c1e5ff1f65f6e299e Gerrit-Change-Number: 86055 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jan Philipp Groß <jeangrande(a)mailbox.org> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Riku Viitanen <riku.viitanen(a)protonmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025