coreboot-gerrit January 2025

coreboot-gerrit@coreboot.org

1 participants
3269 discussions

[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add RTC driver
by Yidi Lin (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel. Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8196: Add RTC driver ...................................................................... Patch Set 8: (1 comment) File src/soc/mediatek/common/rtc_osc_init.c: https://review.coreboot.org/c/coreboot/+/85978/comment/8ce6e0af_7bdeff29?us… : PS8, Line 15: PMIC_RG_FQMTR_CKSEL `PMIC_RG_FQMTR_CKSEL` is defined as `0x0118` in `include/soc/rtc.h`. There is a similar define `RG_FQMTR_CKSEL` in `include/soc/mt6685_rtc.h` and the value is `0x111`. Just want to confirm the correctness of this value. -- To view, visit https://review.coreboot.org/c/coreboot/+/85978?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3dd337eaa3eed3012ddea300f7e04f2b63fb2daa Gerrit-Change-Number: 85978 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Shunxi Zhang <ot_shunxi.zhang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 02:13:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/brya/var/uldrenite: Remove location setting in HDA verb tables
by Eric Lai (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Jayvik Desai, John Su, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik. Eric Lai has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86079?usp=email ) Change subject: mb/brya/var/uldrenite: Remove location setting in HDA verb tables ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/86079?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I05767ac80c2e3d609f944d0f669fcb343c1991ef Gerrit-Change-Number: 86079 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 22 Jan 2025 01:56:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: commonlib: Add new "ESE completed AUnit loading" TS
by Bora Guvendik (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Jamie Ryu, Wonkyu Kim. Bora Guvendik has posted comments on this change by Bora Guvendik. ( https://review.coreboot.org/c/coreboot/+/85830?usp=email ) Change subject: commonlib: Add new "ESE completed AUnit loading" TS ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/85830?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7a7fa4d8b6f360d6d688051455e8afc992fc7343 Gerrit-Change-Number: 85830 Gerrit-PatchSet: 1 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 01:06:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/brox/var/lotso: Update gpio setting
by Karthik Ramasubramanian (Code Review) 22 Jan '25

22 Jan '25

Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/85966?usp=email ) Change subject: mb/google/brox/var/lotso: Update gpio setting ...................................................................... mb/google/brox/var/lotso: Update gpio setting For edge trigger,the default is "rising edge"(invert=0), and it needs to "invert" (invert=1) for falling edge. BUG=b:359437265 TEST=emerge-brox coreboot chromeos-bootimage oscilloscope measurement interrupt is triggered by falling edge Change-Id: I132b43fd552d2babfbcd497bc6a017f354c69e10 Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/85966 Reviewed-by: Bob Moragues <moragues(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Marx Wang <marx.wang(a)intel.corp-partner.google.com> --- M src/mainboard/google/brox/variants/lotso/gpio.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Bob Moragues: Looks good to me, but someone else must approve Marx Wang: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/google/brox/variants/lotso/gpio.c b/src/mainboard/google/brox/variants/lotso/gpio.c index d5abe8c..ca1eaa8 100644 --- a/src/mainboard/google/brox/variants/lotso/gpio.c +++ b/src/mainboard/google/brox/variants/lotso/gpio.c @@ -57,6 +57,8 @@ /* GPP_F16 : [NF1: GSXCLK NF3: THC1_SPI2_CS# NF4: GSPI1_CS0# * NF6: USB_C_GPP_F16] ==> GSPI1_SOC_TCHSCR_CS_L */ PAD_CFG_NF_LOCK(GPP_F16, NONE, NF4, LOCK_CONFIG), + /* GPP_F18 : [NF3: THC1_SPI2_INT# NF6: USB_C_GPP_F18] ==> TCHSCR_INT_ODL */ + PAD_CFG_GPI_APIC(GPP_F18, NONE, DEEP, EDGE_SINGLE, INVERT), /* GPP_S4 : SNDW2_CLK/DMIC_CLK_B0 ==> MEM_STRAP_0 */ PAD_CFG_GPI(GPP_S4, NONE, PLTRST), /* GPP_S5 : SNDW2_DATA/DMIC_CLK_B1 ==> MEM_STRAP_1 */ @@ -65,8 +67,6 @@ PAD_CFG_GPI(GPP_S6, NONE, PLTRST), /* GPP_S7 : SNDW3_DATA/DMIC_DATA1 ==> MEM_STRAP_3 */ PAD_CFG_GPI(GPP_S7, NONE, PLTRST), - /* GPP_F18 : [NF3: THC1_SPI2_INT# NF6: USB_C_GPP_F18] ==> TCHSCR_INT_ODL */ - PAD_CFG_GPI_APIC(GPP_F18, NONE, DEEP, EDGE_SINGLE, NONE), }; -- To view, visit https://review.coreboot.org/c/coreboot/+/85966?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I132b43fd552d2babfbcd497bc6a017f354c69e10 Gerrit-Change-Number: 85966 Gerrit-PatchSet: 2 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Marx Wang <marx.wang(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>

1 0

[XS] Change in coreboot[main]: commonlib/dt: Fix incorrect cell properties
by Julius Werner (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Kapil Porwal. Julius Werner has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86030?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: commonlib/dt: Fix incorrect cell properties ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Sorry, can you please explain why you want to do this? This reverts exactly the part that CB:85964 was intended to fix. What's the exact situation where you're seeing incorrect behavior after that patch? If a test is failing, it's possible that the test was specifically written to account for the previous (incorrect) way this behaved and it would be better to update the test instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/86030?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1d360a4cc0a02462a53866bf375e5d4c85177a05 Gerrit-Change-Number: 86030 Gerrit-PatchSet: 1 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 00:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: commonlib/dt: Fix recursive call for _dt_find_node
by Julius Werner (Code Review) 22 Jan '25

22 Jan '25

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86029?usp=email ) Change subject: commonlib/dt: Fix recursive call for _dt_find_node ...................................................................... commonlib/dt: Fix recursive call for _dt_find_node Correctly call _dt_find_node recursively to avoid incorrect re-initialization of addrcp and sizecp. BUG=none TEST=Test coverage can pass. Change-Id: Icad075485f0a8a22138f1a0e1885405749ae5253 Signed-off-by: Kapil Porwal <kapilporwal(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/86029 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Subrata Banik <subratabanik(a)google.com> --- M src/commonlib/device_tree.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Julius Werner: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/commonlib/device_tree.c b/src/commonlib/device_tree.c index a7007d9..4d72fb0 100644 --- a/src/commonlib/device_tree.c +++ b/src/commonlib/device_tree.c @@ -1074,7 +1074,7 @@ list_insert_after(&found->list_node, &parent->children); } - return dt_find_node(found, path + 1, addrcp, sizecp, create); + return _dt_find_node(found, path + 1, addrcp, sizecp, create); } /* -- To view, visit https://review.coreboot.org/c/coreboot/+/86029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icad075485f0a8a22138f1a0e1885405749ae5253 Gerrit-Change-Number: 86029 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[XS] Change in coreboot[main]: commonlib/dt: Fix recursive call for _dt_find_node
by Julius Werner (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Kapil Porwal. Julius Werner has posted comments on this change by Kapil Porwal. ( https://review.coreboot.org/c/coreboot/+/86029?usp=email ) Change subject: commonlib/dt: Fix recursive call for _dt_find_node ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Whoops, yeah, this was bad, sorry. -- To view, visit https://review.coreboot.org/c/coreboot/+/86029?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Icad075485f0a8a22138f1a0e1885405749ae5253 Gerrit-Change-Number: 86029 Gerrit-PatchSet: 2 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 00:34:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/erying/tgl: Drop specifying which timers to use
by Alicja Michalska (Code Review) 22 Jan '25

22 Jan '25

Alicja Michalska has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86093?usp=email ) Change subject: mb/erying/tgl: Drop specifying which timers to use ...................................................................... mb/erying/tgl: Drop specifying which timers to use Change-Id: If6e0ac1d289447c292a49111251d321c951078e2 Signed-off-by: Alicja Michalska <alicja.michalska(a)9elements.com> --- M src/mainboard/erying/tgl/Kconfig 1 file changed, 0 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/86093/1 diff --git a/src/mainboard/erying/tgl/Kconfig b/src/mainboard/erying/tgl/Kconfig index 01e5dd98..e8a2a1f 100644 --- a/src/mainboard/erying/tgl/Kconfig +++ b/src/mainboard/erying/tgl/Kconfig @@ -30,12 +30,6 @@ config CBFS_SIZE default 0xA00000 -config USE_PM_ACPI_TIMER - default n - -config USE_LEGACY_8254_TIMER - default y - config PCIEXP_ASPM default n -- To view, visit https://review.coreboot.org/c/coreboot/+/86093?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If6e0ac1d289447c292a49111251d321c951078e2 Gerrit-Change-Number: 86093 Gerrit-PatchSet: 1 Gerrit-Owner: Alicja Michalska <ahplka19(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/*: Drop xhci_overcurrent_mapping for the easy ones
by Elyes Haouas (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Alexander Couzens, Keith Hui, Kevin Keijzer, Nicholas Chin, Patrick Rudolph, Paul Menzel. Elyes Haouas has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/85923?usp=email ) Change subject: mb/*: Drop xhci_overcurrent_mapping for the easy ones ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/85923?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I36944e2f2ed265ee492019b75b7dd8b95ca26dbb Gerrit-Change-Number: 85923 Gerrit-PatchSet: 5 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Jan 2025 22:33:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/cmn/cnvi: Fix scope of CFLR ACPI method
by Jérémy Compostella (Code Review) 22 Jan '25

22 Jan '25

Attention is currently required from: Intel coreboot Reviewers, Matt DeVillier, Sean Rhodes. Jérémy Compostella has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86092?usp=email ) Change subject: soc/intel/cmn/cnvi: Fix scope of CFLR ACPI method ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/86092?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7065e24626b2f763868909b8f85a8f18b4cc229b Gerrit-Change-Number: 86092 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Intel coreboot Reviewers <intel_coreboot_reviewers(a)intel.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Jan 2025 22:13:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2025