coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
2374 discussions

[XS] Change in coreboot[main]: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
by Yang Wu (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Xinxiong Xu, Yidi Lin, Yu-Ping Wu. Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email ) Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186 ...................................................................... Patch Set 3: (7 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84342/comment/a119e67e_6a154a66?us… : PS2, Line 7: Make compatible with MT8186T by modifing skuid > Distinguish MT8186T's SKU ID from MT8186 Done https://review.coreboot.org/c/coreboot/+/84342/comment/81a41919_077c218d?us… : PS2, Line 9: skuid > SKU ID Done https://review.coreboot.org/c/coreboot/+/84342/comment/63ff905d_12e0c0f5?us… : PS2, Line 10: corresponded > corresponding Done https://review.coreboot.org/c/coreboot/+/84342/comment/51e6a038_735a9f53?us… : PS2, Line 11: coreboot will pass skuid to kernel by 0x7ffffffe, : so kernel can get the corresponded dts file for system boot. > change the SKU ID to 0x7ffffffe, so that the correct dts file will be selected by the payload. Done https://review.coreboot.org/c/coreboot/+/84342/comment/f65b33c4_8cd1f608?us… : PS2, Line 15: 1.Pre-flashed 0x7fffffff and boot OS. : 2.Check OS boot normally by 0x7ffffffe. > It’d be great if you put a space after the “bullet”. Done File src/mainboard/google/corsola/boardid.c: https://review.coreboot.org/c/coreboot/+/84342/comment/d6ed142d_8b2b4372?us… : PS2, Line 16: /* Define compatible sku_id value */ > remove Done https://review.coreboot.org/c/coreboot/+/84342/comment/8720ae74_d7922cf2?us… : PS2, Line 17: CROS_SKU_COM > CROS_SKU_UNPROVISIONED_MT8186T Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036 Gerrit-Change-Number: 84342 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Sat, 14 Sep 2024 09:52:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
by Yang Wu (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Hung-Te Lin, Knox Chiou, Xinxiong Xu, Yang Wu, Yidi Lin, Yu-Ping Wu. Hello Hung-Te Lin, Knox Chiou, Xinxiong Xu, Yidi Lin, Yu-Ping Wu, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84342?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by Xinxiong Xu, Verified+1 by build bot (Jenkins) Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186 ...................................................................... mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186 For MT8186, factory pre-flashed 0x7fffffff as default SKUD ID and kernel can load the corresponding dts file. To make MT8186T functional on 0x7fffffff devices, change the SKU ID to 0x7ffffffe, so that the correct dts file will be selected by the payload. BUG=b:365730137 TEST=1. Pre-flashed 0x7fffffff and boot OS. 2. Check OS boot normally by 0x7ffffffe. BRANCH=corsola Change-Id: I91306d3abd508e104851916882fb36a4fd302036 Signed-off-by: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/corsola/boardid.c 1 file changed, 9 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/84342/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036 Gerrit-Change-Number: 84342 Gerrit-PatchSet: 3 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com> Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com> Gerrit-Attention: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: Documentation/soc/intel/xeon_sp: Update Xeon 6 test config
by Lean Sheng Tan (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Arthur Heymans, David Hendricks, Jincheng Li, Johnny Lin, Patrick Rudolph, Paul Menzel, Shuo Liu. Lean Sheng Tan has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84331?usp=email ) Change subject: Documentation/soc/intel/xeon_sp: Update Xeon 6 test config ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84331?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia54af1495a0146be3e5c3e74a0dcfef6785d6371 Gerrit-Change-Number: 84331 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Comment-Date: Sat, 14 Sep 2024 09:42:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: Documentation/soc/intel/xeon_sp: Update community preview guide
by Lean Sheng Tan (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Arthur Heymans, David Hendricks, Jincheng Li, Johnny Lin, Patrick Rudolph, Paul Menzel, Shuo Liu. Lean Sheng Tan has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/84330?usp=email ) Change subject: Documentation/soc/intel/xeon_sp: Update community preview guide ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/84330?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0eb6d889e9c1c2ba162a94daeee260d51f48b83 Gerrit-Change-Number: 84330 Gerrit-PatchSet: 3 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Comment-Date: Sat, 14 Sep 2024 09:42:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mainboard/intel/avenuecity_crb: Update full IIO configuration
by Lean Sheng Tan (Code Review) 14 Sep '24

14 Sep '24

Lean Sheng Tan has submitted this change. ( https://review.coreboot.org/c/coreboot/+/84318?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mainboard/intel/avenuecity_crb: Update full IIO configuration ...................................................................... mainboard/intel/avenuecity_crb: Update full IIO configuration Change-Id: I88baa159475ac57ec6a2a638ab84f76a6af4fe82 Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/84318 Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/intel/avenuecity_crb/config/iio.c M src/soc/intel/xeon_sp/gnr/include/soc/iio.h 2 files changed, 33 insertions(+), 0 deletions(-) Approvals: Arthur Heymans: Looks good to me, approved build bot (Jenkins): Verified diff --git a/src/mainboard/intel/avenuecity_crb/config/iio.c b/src/mainboard/intel/avenuecity_crb/config/iio.c index 117d604..5406034 100644 --- a/src/mainboard/intel/avenuecity_crb/config/iio.c +++ b/src/mainboard/intel/avenuecity_crb/config/iio.c @@ -20,6 +20,38 @@ _IIO_PORT_CFG_STRUCT_BASIC_X2(0x0, 0x4B, 0x4), _IIO_PORT_CFG_STRUCT_BASIC_X2(0x0, 0x4B, 0x5), }}, + + {_IIO_PE_CFG_STRUCT(0x0, PE1, CB_IIO_BIFURCATE_x16xxxxx, PE_TYPE_PCIE) { + /* _IIO_PORT_CFG_STRUCT_BASIC(sltpls, sltplv, psn) */ + _IIO_PORT_CFG_STRUCT_BASIC_X16(0x0, 0x4B, 0x6), + _IIO_PORT_CFG_STRUCT_DISABLED, + _IIO_PORT_CFG_STRUCT_DISABLED, + _IIO_PORT_CFG_STRUCT_DISABLED, + _IIO_PORT_CFG_STRUCT_DISABLED, + _IIO_PORT_CFG_STRUCT_DISABLED, + _IIO_PORT_CFG_STRUCT_DISABLED, + _IIO_PORT_CFG_STRUCT_DISABLED, + }}, + + _IIO_PE_CFG_DISABLED(0x0, PE2), + _IIO_PE_CFG_DISABLED(0x0, PE3), + _IIO_PE_CFG_DISABLED(0x0, PE4), + _IIO_PE_CFG_DISABLED(0x0, PE5), + _IIO_PE_CFG_DISABLED(0x0, PEa), + _IIO_PE_CFG_DISABLED(0x0, PEb), + _IIO_PE_CFG_DISABLED(0x0, PEc), + _IIO_PE_CFG_DISABLED(0x0, PEd), + + _IIO_PE_CFG_DISABLED(0x1, PE0), + _IIO_PE_CFG_DISABLED(0x1, PE1), + _IIO_PE_CFG_DISABLED(0x1, PE2), + _IIO_PE_CFG_DISABLED(0x1, PE3), + _IIO_PE_CFG_DISABLED(0x1, PE4), + _IIO_PE_CFG_DISABLED(0x1, PE5), + _IIO_PE_CFG_DISABLED(0x1, PEa), + _IIO_PE_CFG_DISABLED(0x1, PEb), + _IIO_PE_CFG_DISABLED(0x1, PEc), + _IIO_PE_CFG_DISABLED(0x1, PEd), }; const struct iio_pe_config *get_iio_config_table(int *size) diff --git a/src/soc/intel/xeon_sp/gnr/include/soc/iio.h b/src/soc/intel/xeon_sp/gnr/include/soc/iio.h index 16095d1..d106941 100644 --- a/src/soc/intel/xeon_sp/gnr/include/soc/iio.h +++ b/src/soc/intel/xeon_sp/gnr/include/soc/iio.h @@ -163,6 +163,7 @@ 0x0, 0x0, 0x1, 0x0,\ 0x0, 0x0, 0x0, 0x0, 0x0) +#define _IIO_PORT_CFG_STRUCT_BASIC_X16 _IIO_PORT_CFG_STRUCT_BASIC #define _IIO_PORT_CFG_STRUCT_BASIC_X8 _IIO_PORT_CFG_STRUCT_BASIC #define _IIO_PORT_CFG_STRUCT_BASIC_X4 _IIO_PORT_CFG_STRUCT_BASIC #define _IIO_PORT_CFG_STRUCT_BASIC_X2 _IIO_PORT_CFG_STRUCT_BASIC -- To view, visit https://review.coreboot.org/c/coreboot/+/84318?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I88baa159475ac57ec6a2a638ab84f76a6af4fe82 Gerrit-Change-Number: 84318 Gerrit-PatchSet: 5 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: drivers/intel/fsp2_0: Define 64-bit FSP_STATUS_GLOBAL_RESET
by Subrata Banik (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ronak Kanabar, Tarun. Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84356?usp=email ) Change subject: drivers/intel/fsp2_0: Define 64-bit FSP_STATUS_GLOBAL_RESET ...................................................................... Patch Set 2: (4 comments) File src/drivers/intel/fsp2_0/Kconfig: https://review.coreboot.org/c/coreboot/+/84356/comment/188a11b7_ed627a77?us… : PS2, Line 378: 0x4000000000000003 can you please point me to the FSP spec that defines 64-bit FSP return value. Ideally they should be used below logic to covert into 64-bit if required ``` #define CONVERT_TO_64BIT(value) (CONFIG_PLATFORM_USES_FSP2_X86_32 \ ? value : \ ((uint64_t)(value & 0xf0000000) << 32) | (value & 0xff)) #define FSP_STATUS_WRAPPER(x) CONVERT_TO_64BIT(x) ``` File src/include/efi/efi_datatype.h: https://review.coreboot.org/c/coreboot/+/84356/comment/6e3a1164_dd65ee06?us… : PS2, Line 16: #if CONFIG(PLATFORM_USES_FSP1_1) || CONFIG(PLATFORM_USES_FSP2_X86_32) can u please submit a separate CL to add FSP1.1 if required File src/soc/intel/meteorlake/chip.c: https://review.coreboot.org/c/coreboot/+/84356/comment/fb75d43b_08ba28cc?us… : PS2, Line 276: fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE, : "Failed to handle the FSP reset request"); please submit a separate CL for this as well File src/soc/intel/pantherlake/chip.c: https://review.coreboot.org/c/coreboot/+/84356/comment/02ce52d6_f9f5a5ae?us… : PS2, Line 274: fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE, : "Failed to handle the FSP reset request"); same as previous file -- To view, visit https://review.coreboot.org/c/coreboot/+/84356?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f Gerrit-Change-Number: 84356 Gerrit-PatchSet: 2 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Pranava Y N <pranavayn(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Sep 2024 06:46:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: mb/google/brox/var/lotso: Update cpu power limits
by Jian Tong (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Dengwu Yu, Karthik Ramasubramanian, Paul Menzel, Subrata Banik, wen zhang. Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84202?usp=email ) Change subject: mb/google/brox/var/lotso: Update cpu power limits ...................................................................... Patch Set 9: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84202/comment/397ddac5_a15b37e8?us… : PS8, Line 10: form > from Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84202?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928 Gerrit-Change-Number: 84202 Gerrit-PatchSet: 9 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Sat, 14 Sep 2024 06:30:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: mb/google/brox/var/lotso: Update cpu power limits
by Jian Tong (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Dengwu Yu, Jian Tong, Karthik Ramasubramanian, Subrata Banik, wen zhang. Hello Dengwu Yu, Karthik Ramasubramanian, Kun Liu, Subrata Banik, build bot (Jenkins), wen zhang, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84202?usp=email to look at the new patch set (#9). Change subject: mb/google/brox/var/lotso: Update cpu power limits ...................................................................... mb/google/brox/var/lotso: Update cpu power limits When battery not present, increase PL4 limit from 9 to 40. Get PL setting from internal thermal and power team. AC+DC/DC: PL1=15W PL2=25W PL4=114W AC ONLY: PL1=15W PL2=25W PL4=40W BUG=b:355094551 TEST=emerge-brox sys-boot/coreboot sys-boot/chromeos-bootimage Confirm on lotso EVT board, as expected. Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928 Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/brox/Kconfig M src/mainboard/google/brox/variants/lotso/Makefile.mk M src/mainboard/google/brox/variants/lotso/overridetree.cb A src/mainboard/google/brox/variants/lotso/ramstage.c 4 files changed, 47 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/84202/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/84202?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928 Gerrit-Change-Number: 84202 Gerrit-PatchSet: 9 Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com> Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>

1 0

[M] Change in coreboot[main]: OpenSBI: Get rid of a burden
by Elyes Haouas (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84346?usp=email ) Change subject: OpenSBI: Get rid of a burden ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84346/comment/a77accae_a7e78c5d?us… : PS4, Line 9: we can neither update OpenSBI nor take advantage of the new GCC's : features since OpenSBI only compiles with its version from two years ago! : So get rid of the burden! > What do you mean by this? Why can OpenSBI not be updated? What do you mean by not compiling? Is ther […] Please see https://review.coreboot.org/c/coreboot/+/84358 -- To view, visit https://review.coreboot.org/c/coreboot/+/84346?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id22f3d4ef9c6e1c90a2d25c06c982bbf289b1268 Gerrit-Change-Number: 84346 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Sat, 14 Sep 2024 06:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>

1 0

[XS] Change in coreboot[main]: Update opensbi submodule to upstream master
by Elyes Haouas (Code Review) 14 Sep '24

14 Sep '24

Attention is currently required from: Arthur Heymans, Maximilian Brune. Elyes Haouas has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/84358?usp=email ) Change subject: Update opensbi submodule to upstream master ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Please feel free to fix OpenSBI -- To view, visit https://review.coreboot.org/c/coreboot/+/84358?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0bc93a425040f1dab7cf1a4afe31e3caa5257775 Gerrit-Change-Number: 84358 Gerrit-PatchSet: 1 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Sat, 14 Sep 2024 06:29:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024