Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich.
Hello Arthur Heymans, Maximilian Brune, Philipp Hug, build bot (Jenkins), ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84346?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: OpenSBI: Get rid of a burden
......................................................................
OpenSBI: Get rid of a burden
we can neither update OpenSBI nor take advantage of the new GCC's
features since OpenSBI only compiles with its version from two years ago!
So get rid of the burden!
Change-Id: Id22f3d4ef9c6e1c90a2d25c06c982bbf289b1268
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M .gitmodules
D 3rdparty/opensbi
M Documentation/arch/riscv/index.md
M configs/config.emulation_qemu_riscv_rv64
D configs/config.sifive_hifive-unleashed.opensbi
D src/arch/riscv/Kconfig
D src/arch/riscv/Makefile.mk
D src/arch/riscv/arch_timer.c
D src/arch/riscv/boot.c
D src/arch/riscv/bootblock.S
D src/arch/riscv/fit_payload.c
D src/arch/riscv/fp_asm.S
D src/arch/riscv/include/arch/barrier.h
D src/arch/riscv/include/arch/boot.h
D src/arch/riscv/include/arch/byteorder.h
D src/arch/riscv/include/arch/cache.h
D src/arch/riscv/include/arch/cbconfig.h
D src/arch/riscv/include/arch/cpu.h
D src/arch/riscv/include/arch/encoding.h
D src/arch/riscv/include/arch/errno.h
D src/arch/riscv/include/arch/exception.h
D src/arch/riscv/include/arch/header.ld
D src/arch/riscv/include/arch/hlt.h
D src/arch/riscv/include/arch/io.h
D src/arch/riscv/include/arch/memlayout.h
D src/arch/riscv/include/arch/mmio.h
D src/arch/riscv/include/arch/pmp.h
D src/arch/riscv/include/arch/smp/atomic.h
D src/arch/riscv/include/arch/smp/smp.h
D src/arch/riscv/include/arch/smp/spinlock.h
D src/arch/riscv/include/bits.h
D src/arch/riscv/include/mcall.h
D src/arch/riscv/include/sbi.h
D src/arch/riscv/include/vm.h
D src/arch/riscv/mcall.c
D src/arch/riscv/misc.c
D src/arch/riscv/opensbi.c
D src/arch/riscv/payload.c
D src/arch/riscv/pmp.c
D src/arch/riscv/ramstage.S
D src/arch/riscv/romstage.S
D src/arch/riscv/sbi.c
D src/arch/riscv/smp.c
D src/arch/riscv/tables.c
D src/arch/riscv/trap_handler.c
D src/arch/riscv/trap_util.S
D src/arch/riscv/virtual_memory.c
M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
M src/commonlib/bsd/lz4_wrapper.c
M src/include/acpi/acpi.h
M src/include/bootmem.h
M src/include/program_loading.h
M src/include/rules.h
M src/include/symbols.h
M src/lib/bootmem.c
M src/lib/libgcc.c
M src/mainboard/emulation/Kconfig
D src/mainboard/emulation/qemu-riscv/Kconfig
D src/mainboard/emulation/qemu-riscv/Kconfig.name
D src/mainboard/emulation/qemu-riscv/Makefile.mk
D src/mainboard/emulation/qemu-riscv/board_info.txt
D src/mainboard/emulation/qemu-riscv/cbmem.c
D src/mainboard/emulation/qemu-riscv/chip.c
D src/mainboard/emulation/qemu-riscv/clint.c
D src/mainboard/emulation/qemu-riscv/devicetree.cb
D src/mainboard/emulation/qemu-riscv/include/mainboard/addressmap.h
D src/mainboard/emulation/qemu-riscv/mainboard.c
D src/mainboard/emulation/qemu-riscv/memlayout.ld
D src/mainboard/emulation/qemu-riscv/rom_media.c
D src/mainboard/emulation/qemu-riscv/romstage.c
D src/mainboard/emulation/qemu-riscv/uart.c
D src/mainboard/emulation/spike-riscv/Kconfig
D src/mainboard/emulation/spike-riscv/Kconfig.name
D src/mainboard/emulation/spike-riscv/Makefile.mk
D src/mainboard/emulation/spike-riscv/board_info.txt
D src/mainboard/emulation/spike-riscv/clint.c
D src/mainboard/emulation/spike-riscv/devicetree.cb
D src/mainboard/emulation/spike-riscv/mainboard.c
D src/mainboard/emulation/spike-riscv/memlayout.ld
D src/mainboard/emulation/spike-riscv/rom_media.c
D src/mainboard/emulation/spike-riscv/romstage.c
D src/mainboard/emulation/spike-riscv/uart.c
D src/mainboard/sifive/Kconfig
D src/mainboard/sifive/Kconfig.name
D src/mainboard/sifive/hifive-unleashed/Kconfig
D src/mainboard/sifive/hifive-unleashed/Kconfig.name
D src/mainboard/sifive/hifive-unleashed/Makefile.mk
D src/mainboard/sifive/hifive-unleashed/board_info.txt
D src/mainboard/sifive/hifive-unleashed/devicetree.cb
D src/mainboard/sifive/hifive-unleashed/fixup_fdt.c
D src/mainboard/sifive/hifive-unleashed/fu540-c000.dtsi
D src/mainboard/sifive/hifive-unleashed/hifive-unleashed-a00.dts
D src/mainboard/sifive/hifive-unleashed/mainboard.c
D src/mainboard/sifive/hifive-unleashed/media.c
D src/mainboard/sifive/hifive-unleashed/romstage.c
D src/mainboard/sifive/hifive-unmatched/Kconfig
D src/mainboard/sifive/hifive-unmatched/Kconfig.name
D src/mainboard/sifive/hifive-unmatched/Makefile.mk
D src/mainboard/sifive/hifive-unmatched/board_info.txt
D src/mainboard/sifive/hifive-unmatched/cbfs_spi.c
D src/mainboard/sifive/hifive-unmatched/devicetree.cb
D src/mainboard/sifive/hifive-unmatched/fixup_fdt.c
D src/mainboard/sifive/hifive-unmatched/fu740-c000.dtsi
D src/mainboard/sifive/hifive-unmatched/hifive-unmatched-a00-mod.dts
D src/mainboard/sifive/hifive-unmatched/hifive-unmatched-a00.dts
D src/mainboard/sifive/hifive-unmatched/mainboard.c
D src/mainboard/sifive/hifive-unmatched/romstage.c
D src/soc/sifive/fu540/Kconfig
D src/soc/sifive/fu540/Makefile.mk
D src/soc/sifive/fu540/bootblock.c
D src/soc/sifive/fu540/cbmem.c
D src/soc/sifive/fu540/chip.c
D src/soc/sifive/fu540/clint.c
D src/soc/sifive/fu540/clock.c
D src/soc/sifive/fu540/ddrregs.h
D src/soc/sifive/fu540/include/soc/addressmap.h
D src/soc/sifive/fu540/include/soc/clock.h
D src/soc/sifive/fu540/include/soc/otp.h
D src/soc/sifive/fu540/include/soc/sdram.h
D src/soc/sifive/fu540/include/soc/spi.h
D src/soc/sifive/fu540/memlayout.ld
D src/soc/sifive/fu540/otp.c
D src/soc/sifive/fu540/regconfig-ctl.h
D src/soc/sifive/fu540/regconfig-phy.h
D src/soc/sifive/fu540/sdram.c
D src/soc/sifive/fu540/spi.c
D src/soc/sifive/fu540/spi_internal.h
D src/soc/sifive/fu540/uart.c
D src/soc/sifive/fu540/ux00ddr.h
D src/soc/sifive/fu740/Kconfig
D src/soc/sifive/fu740/Makefile.mk
D src/soc/sifive/fu740/TODO
D src/soc/sifive/fu740/cbmem.c
D src/soc/sifive/fu740/chip.c
D src/soc/sifive/fu740/clint.c
D src/soc/sifive/fu740/clock.c
D src/soc/sifive/fu740/ddrregs.c
D src/soc/sifive/fu740/gpio.c
D src/soc/sifive/fu740/include/soc/addressmap.h
D src/soc/sifive/fu740/include/soc/clock.h
D src/soc/sifive/fu740/include/soc/gpio.h
D src/soc/sifive/fu740/include/soc/otp.h
D src/soc/sifive/fu740/include/soc/sdram.h
D src/soc/sifive/fu740/include/soc/spi.h
D src/soc/sifive/fu740/memlayout.ld
D src/soc/sifive/fu740/otp.c
D src/soc/sifive/fu740/sdram.c
D src/soc/sifive/fu740/spi.c
D src/soc/sifive/fu740/spi_internal.h
D src/soc/sifive/fu740/uart.c
D src/soc/ucb/riscv/Kconfig
D src/soc/ucb/riscv/Makefile.mk
D src/soc/ucb/riscv/cbmem.c
D src/soc/ucb/riscv/chip.c
M util/crossgcc/Makefile
M util/crossgcc/Makefile.mk
M util/crossgcc/buildgcc
D util/crossgcc/patches/clang-18.1.8.src_x86_baremetal.patch
D util/crossgcc/patches/gcc-14.2.0_rv32iafc.patch
M util/lint/check_lint_tests
M util/qemu/Makefile.mk
D util/riscv/description.md
D util/riscv/make-spike-elf.sh
D util/riscv/sifive-gpt.py
D util/riscv/spike-elf.ld
M util/xcompile/xcompile
166 files changed, 9 insertions(+), 13,364 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/84346/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84346?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id22f3d4ef9c6e1c90a2d25c06c982bbf289b1268
Gerrit-Change-Number: 84346
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: ron minnich <rminnich(a)gmail.com>
Attention is currently required from: Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Varun Upadhyay.
Paul Menzel has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/84351?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya/var/trulo: Update ISH GPIO config for tablet mode switch
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84351/comment/0be51156_48e71150?us… :
PS2, Line 13: TEST=Builds successfully for google/trulo.
Do you have access to the board, and could you verify that it works?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84351?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id22e397e46b522428ffdabe34a445ed7e4fb6fc5
Gerrit-Change-Number: 84351
Gerrit-PatchSet: 2
Gerrit-Owner: Varun Upadhyay <varun.upadhyay(a)intel.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jayvik Desai <jayvik(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Varun Upadhyay <varun.upadhyay(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Sun, 15 Sep 2024 07:14:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier.
Paul Menzel has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84359/comment/adbc5334_3a6638d4?us… :
PS1, Line 9: significantly impacts
: boot time negatively
> I'm not sitting here with a stopwatch, but it's an order of magnitude (ie, 10s vs 1s)
Thank you. That is good enough for me.
https://review.coreboot.org/c/coreboot/+/84359/comment/d75d70c5_04ebd3df?us… :
PS1, Line 10: breaks USB detection in edk2 payload
> the device was effectively unusable as it didn't have an OS installed on internal storage
Understood.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Sun, 15 Sep 2024 06:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier, Paul Menzel.
Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/84359/comment/f59d1115_f3682589?us… :
PS1, Line 39: select SOC_INTEL_CRASHLOG
> that doesn't help, since `MAINBOARD_HAS_CHROMEOS` is already selected above -- it would enable it even for non-ChromeOS builds, just like it already is.
ummm, can you move the below code into JSL SoC Kconfig in that way, it might help you ?
```
select SOC_INTEL_CRASHLOG if MAINBOARD_HAS_CHROMEOS
```
```
src/soc/intel/pantherlake/Kconfig:87: select SOC_INTEL_CRASHLOG
src/soc/intel/meteorlake/Kconfig:93: select SOC_INTEL_CRASHLOG
```
I will cleanup for Alder lake and Raptor Lake device today (moving crashlog from mainboard to SOC Kconfig). If you want, you can move the same for Jasper Lake or you want me to do that (to cover dedede) ?
```
src/mainboard/google/brya/Kconfig:47: select SOC_INTEL_CRASHLOG
src/mainboard/google/brya/Kconfig:178: select SOC_INTEL_CRASHLOG
src/mainboard/google/brya/Kconfig:188: select SOC_INTEL_CRASHLOG
src/mainboard/google/dedede/Kconfig:39: select SOC_INTEL_CRASHLOG
src/mainboard/google/brox/Kconfig:40: select SOC_INTEL_CRASHLOG
src/mainboard/google/brox/Kconfig:52: select SOC_INTEL_CRASHLOG
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 15 Sep 2024 05:53:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Paul Menzel, Subrata Banik.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84359/comment/9f039c96_dd9cebce?us… :
PS1, Line 12: verify boot time normal
> Please note the normal boot time.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 15 Sep 2024 04:05:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Paul Menzel, Subrata Banik.
Hello Jakub Czapiga, Jędrzej Ciupis, Paul Menzel, Subrata Banik, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84359?usp=email
to look at the new patch set (#2).
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
Selecting this option for non-ChromeOS builds significantly impacts
boot time negatively by an order of magnitude (~10s vs ~1s) and breaks
USB detection in edk2 payload; inability to properly enumerate USB
devices is almost certainly the cause of the increased boot time.
TEST=build/boot google/maglia, verify boot time normal (~1s) and USB
detection working as expected with multiple USB devices connected.
Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/dedede/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/84359/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Paul Menzel, Subrata Banik.
Matt DeVillier has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84359/comment/1e7ab28d_9f445450?us… :
PS1, Line 9: significantly impacts
: boot time negatively
> It’d be great to have numbers in the commit message.
I'm not sitting here with a stopwatch, but it's an order of magnitude (ie, 10s vs 1s)
https://review.coreboot.org/c/coreboot/+/84359/comment/f5e25250_64c52a76?us… :
PS1, Line 10: breaks USB detection in edk2 payload
> Does Linux detect it? Any logs for the record?
the device was effectively unusable as it didn't have an OS installed on internal storage
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/84359/comment/7f4cffd9_af186f9e?us… :
PS1, Line 39: select SOC_INTEL_CRASHLOG
> ``` […]
that doesn't help, since `MAINBOARD_HAS_CHROMEOS` is already selected above -- it would enable it even for non-ChromeOS builds, just like it already is.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Sun, 15 Sep 2024 04:04:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Jakub Czapiga, Jędrzej Ciupis, Matt DeVillier.
Subrata Banik has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/84359?usp=email )
Change subject: mb/google/dedede: Select INTEL_CRASHLOG only for ChromeOS builds
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/Kconfig:
https://review.coreboot.org/c/coreboot/+/84359/comment/95a2124c_73de6d50?us… :
PS1, Line 39: select SOC_INTEL_CRASHLOG
```
select SOC_INTEL_CRASHLOG if MAINBOARD_HAS_CHROMEOS
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/84359?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I53be4befe9a04bdaece21f40f93af6599baa7e0b
Gerrit-Change-Number: 84359
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jędrzej Ciupis <jciupis(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Sun, 15 Sep 2024 03:03:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Alexander Couzens, Angel Pons, Christian Walter, Dinesh Gehlot, Eric Lai, Erik van den Bogaert, Evgeny Zinoviev, Felix Held, Frans Hendriks, Fred Reitberger, Jason Glenesk, Jayvik Desai, Jeremy Soller, Jonathon Hall, Kapil Porwal, Kevin Keijzer, Michael Niewöhner, Michał Kopeć, Michał Żygowski, Nicholas Chin, Nick Vaccaro, Nico Huber, Patrick Rudolph, Piotr Król, Rishika Raj, Sean Rhodes, Stefan Ott, Subrata Banik, Tim Crawford.
Nicholas Sudsgaard has posted comments on this change by Nicholas Sudsgaard. ( https://review.coreboot.org/c/coreboot/+/80333?usp=email )
Change subject: device/azalia: Rework azalia verb tables
......................................................................
Patch Set 22:
(1 comment)
Patchset:
PS21:
> I've done some serious refactoring in Sandy/Ivy Bridge native raminit in the past. […]
That's very interesting, thanks for the advice. I'll try to use some macro magic and reproducible builds to minimize as much overhead as I can.
--
To view, visit https://review.coreboot.org/c/coreboot/+/80333?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If8b672e4fd800b34e5ba39fad174fcf1154b0a54
Gerrit-Change-Number: 80333
Gerrit-PatchSet: 22
Gerrit-Owner: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Keith Hui <buurin(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Kevin Keijzer <kevin(a)quietlife.nl>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Comment-Date: Sun, 15 Sep 2024 02:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>