Maximilian Brune has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/84379?usp=email )
Change subject: Update UPD for system configuration, Fast and Slow PPT to set 45W TDP
......................................................................
Update UPD for system configuration, Fast and Slow PPT to set 45W TDP
Signed-off-by: Anand Vaikar <Anand.Vaikar(a)amd.com>
Change-Id: Ib73c3a1270c7b1d490fd14c4e60f7aa9be93429b
Reviewed-by: Avinash Munduru <Avinash.Munduru(a)amd.com>
---
M src/soc/amd/glinda/fsp_m_params.c
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/84379/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84379?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib73c3a1270c7b1d490fd14c4e60f7aa9be93429b
Gerrit-Change-Number: 84379
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk.
Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84378?usp=email )
Change subject: soc/amd/glinda: Update gpp bridge naming scheme
......................................................................
soc/amd/glinda: Update gpp bridge naming scheme
This patch updates the naming scheme used for the GPP bridges.
The naming scheme now matches what we also have on phoenix.
Change-Id: I9f740d75a3561dba2ed65acb16bb4259f632307d
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/mainboard/amd/birman/devicetree_glinda.cb
M src/mainboard/amd/birman_plus/devicetree_glinda.cb
M src/soc/amd/glinda/chipset.cb
3 files changed, 16 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/84378/1
diff --git a/src/mainboard/amd/birman/devicetree_glinda.cb b/src/mainboard/amd/birman/devicetree_glinda.cb
index dfcd176..9fa1918 100644
--- a/src/mainboard/amd/birman/devicetree_glinda.cb
+++ b/src/mainboard/amd/birman/devicetree_glinda.cb
@@ -158,9 +158,11 @@
device domain 0 on
device ref iommu on end
- device ref gpp_bridge_0 on end # GBE
- device ref gpp_bridge_1 on end # WIFI
- device ref gpp_bridge_2 on end # NVMe SSD
+ device ref gpp_bridge_2_1 on end # NVME SSD0
+ device ref gpp_bridge_2_2 on end # SD
+ device ref gpp_bridge_2_3 on end # WLAN
+ device ref gpp_bridge_2_4 on end # GBE
+
device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A
device ref gfx on end # Internal GPU (GFX)
device ref gfx_hda on end # Display HD Audio Controller (GFXAZ)
diff --git a/src/mainboard/amd/birman_plus/devicetree_glinda.cb b/src/mainboard/amd/birman_plus/devicetree_glinda.cb
index 025680e..c134915 100644
--- a/src/mainboard/amd/birman_plus/devicetree_glinda.cb
+++ b/src/mainboard/amd/birman_plus/devicetree_glinda.cb
@@ -158,9 +158,9 @@
device domain 0 on
device ref iommu on end
- device ref gpp_bridge_0 on end # GBE
- device ref gpp_bridge_1 on end # WIFI
- device ref gpp_bridge_2 on end # NVMe SSD
+ device ref gpp_bridge_2_1 on end # GBE
+ device ref gpp_bridge_2_2 on end # WIFI
+ device ref gpp_bridge_2_3 on end # NVMe SSD
device ref gpp_bridge_a on # Internal GPP Bridge 0 to Bus A
device ref gfx on end # Internal GPU (GFX)
device ref gfx_hda on end # Display HD Audio Controller (GFXAZ)
diff --git a/src/soc/amd/glinda/chipset.cb b/src/soc/amd/glinda/chipset.cb
index 6e23c2d..f328797 100644
--- a/src/soc/amd/glinda/chipset.cb
+++ b/src/soc/amd/glinda/chipset.cb
@@ -14,13 +14,15 @@
device pci 01.2 alias usb4_pcie_bridge_1 off end
device pci 01.3 alias usb4_pcie_bridge_2 off end
+ # The PCIe GPP aliases in this SoC match the device and function numbers
device pci 02.0 on end # Dummy device function, do not disable
- device pci 02.1 alias gpp_bridge_0 off ops amd_external_pcie_gpp_ops end
- device pci 02.2 alias gpp_bridge_1 off ops amd_external_pcie_gpp_ops end
- device pci 02.3 alias gpp_bridge_2 off ops amd_external_pcie_gpp_ops end
- device pci 02.4 alias gpp_bridge_3 off ops amd_external_pcie_gpp_ops end
- device pci 02.5 alias gpp_bridge_4 off ops amd_external_pcie_gpp_ops end
- device pci 02.6 alias gpp_bridge_5 off ops amd_external_pcie_gpp_ops end
+ device pci 02.1 alias gpp_bridge_2_1 off ops amd_external_pcie_gpp_ops end
+ device pci 02.2 alias gpp_bridge_2_2 off ops amd_external_pcie_gpp_ops end
+ device pci 02.3 alias gpp_bridge_2_3 off ops amd_external_pcie_gpp_ops end
+ device pci 02.4 alias gpp_bridge_2_4 off ops amd_external_pcie_gpp_ops end
+ device pci 02.5 alias gpp_bridge_2_5 off ops amd_external_pcie_gpp_ops end
+ device pci 02.6 alias gpp_bridge_2_6 off ops amd_external_pcie_gpp_ops end
+
device pci 03.0 on end # Dummy device function, do not disable
device pci 03.1 alias gpp_bridge_3_1 off ops amd_external_pcie_gpp_ops end
device pci 03.2 alias gpp_bridge_3_2 off ops amd_external_pcie_gpp_ops end
--
To view, visit https://review.coreboot.org/c/coreboot/+/84378?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9f740d75a3561dba2ed65acb16bb4259f632307d
Gerrit-Change-Number: 84378
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84377?usp=email )
Change subject: soc/amd/glinda/chipset.cb: Add missing devices
......................................................................
soc/amd/glinda/chipset.cb: Add missing devices
Source: Document 57254
Change-Id: I9675d45eba257e52d9a870a4cc153b925267f840
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/soc/amd/glinda/chipset.cb
1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/84377/1
diff --git a/src/soc/amd/glinda/chipset.cb b/src/soc/amd/glinda/chipset.cb
index 5a6541fe..6e23c2d 100644
--- a/src/soc/amd/glinda/chipset.cb
+++ b/src/soc/amd/glinda/chipset.cb
@@ -10,6 +10,9 @@
device pci 00.2 alias iommu off ops amd_iommu_ops end
device pci 01.0 on end # Dummy device function
+ device pci 01.1 alias usb4_pcie_bridge_0 off end
+ device pci 01.2 alias usb4_pcie_bridge_1 off end
+ device pci 01.3 alias usb4_pcie_bridge_2 off end
device pci 02.0 on end # Dummy device function, do not disable
device pci 02.1 alias gpp_bridge_0 off ops amd_external_pcie_gpp_ops end
@@ -18,6 +21,13 @@
device pci 02.4 alias gpp_bridge_3 off ops amd_external_pcie_gpp_ops end
device pci 02.5 alias gpp_bridge_4 off ops amd_external_pcie_gpp_ops end
device pci 02.6 alias gpp_bridge_5 off ops amd_external_pcie_gpp_ops end
+ device pci 03.0 on end # Dummy device function, do not disable
+ device pci 03.1 alias gpp_bridge_3_1 off ops amd_external_pcie_gpp_ops end
+ device pci 03.2 alias gpp_bridge_3_2 off ops amd_external_pcie_gpp_ops end
+ device pci 03.3 alias gpp_bridge_3_3 off ops amd_external_pcie_gpp_ops end
+ device pci 03.4 alias gpp_bridge_3_4 off ops amd_external_pcie_gpp_ops end
+ device pci 03.5 alias gpp_bridge_3_5 off ops amd_external_pcie_gpp_ops end
+ device pci 03.6 alias gpp_bridge_3_6 off ops amd_external_pcie_gpp_ops end
device pci 08.0 on end # Dummy device function, do not disable
device pci 08.1 alias gpp_bridge_a off # Internal GPP Bridge 0 to Bus A
@@ -47,6 +57,7 @@
device pci 08.2 alias gpp_bridge_b off # Internal GPP Bridge 1 to Bus B
ops amd_internal_pcie_gpp_ops
device pci 0.0 on end # dummy, do not disable
+ device pci 0.1 alias npu off end # Neural Processing Unit (NPU)
end
device pci 08.3 alias gpp_bridge_c off # Internal GPP Bridge 2 to Bus C
@@ -109,6 +120,8 @@
end
end
end
+ device pci 0.5 alias usb4_router_0 off end
+ device pci 0.6 alias usb4_router_1 off end
end
device pci 14.0 alias smbus on ops amd_smbus_ops end # primary FCH function
--
To view, visit https://review.coreboot.org/c/coreboot/+/84377?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9675d45eba257e52d9a870a4cc153b925267f840
Gerrit-Change-Number: 84377
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Maximilian Brune has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84376?usp=email )
Change subject: soc/amd/glinda/chipset.cb: Update for glinda
......................................................................
soc/amd/glinda/chipset.cb: Update for glinda
Change-Id: I1138f27bfd47f6fa70a0c2afcc65a5553a609d57
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M src/soc/amd/glinda/chipset.cb
1 file changed, 61 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/84376/1
diff --git a/src/soc/amd/glinda/chipset.cb b/src/soc/amd/glinda/chipset.cb
index 3d0e119..5a6541fe 100644
--- a/src/soc/amd/glinda/chipset.cb
+++ b/src/soc/amd/glinda/chipset.cb
@@ -25,29 +25,39 @@
device pci 0.0 alias gfx off ops amd_graphics_ops end # Internal GPU (GFX)
device pci 0.1 alias gfx_hda off end # Display HD Audio Controller (GFXAZ)
device pci 0.2 alias crypto off end # Crypto Coprocessor
- device pci 0.3 alias xhci_0 off
- ops xhci_pci_ops
- chip drivers/usb/acpi
- register "type" = "UPC_TYPE_HUB"
- device usb 0.0 alias xhci_0_root_hub off
- chip drivers/usb/acpi
- device usb 3.0 alias usb3_port0 off end
- end
- chip drivers/usb/acpi
- device usb 2.0 alias usb2_port0 off end
- end
- chip drivers/usb/acpi
- device usb 2.1 alias usb2_port1 off end
- end
- end
- end
- end
device pci 0.4 alias xhci_1 off
ops xhci_pci_ops
chip drivers/usb/acpi
register "type" = "UPC_TYPE_HUB"
device usb 0.0 alias xhci_1_root_hub off
chip drivers/usb/acpi
+ device usb 3.0 alias usb3_port7 off end
+ end
+ chip drivers/usb/acpi
+ device usb 2.0 alias usb2_port7 off end
+ end
+ end
+ end
+ end
+ device pci 0.5 alias acp off ops amd_acp_ops end # Audio Processor (ACP)
+ device pci 0.6 alias hda off end # Audio Processor HD Audio Controller (main AZ)
+ device pci 0.7 alias mp2 off end # Sensor Fusion Hub (MP2)
+ end
+
+ device pci 08.2 alias gpp_bridge_b off # Internal GPP Bridge 1 to Bus B
+ ops amd_internal_pcie_gpp_ops
+ device pci 0.0 on end # dummy, do not disable
+ end
+
+ device pci 08.3 alias gpp_bridge_c off # Internal GPP Bridge 2 to Bus C
+ ops amd_internal_pcie_gpp_ops
+
+ device pci 0.0 alias xhci_0 off
+ ops xhci_pci_ops
+ chip drivers/usb/acpi
+ register "type" = "UPC_TYPE_HUB"
+ device usb 0.3 alias xhci_0_root_hub off
+ chip drivers/usb/acpi
device usb 3.0 alias usb3_port2 off end
end
chip drivers/usb/acpi
@@ -62,18 +72,43 @@
chip drivers/usb/acpi
device usb 2.2 alias usb2_port4 off end
end
+ chip drivers/usb/acpi
+ device usb 2.3 alias usb2_port5 off end
+ end
+ chip drivers/usb/acpi
+ device usb 2.4 alias usb2_port6 off end
+ end
end
end
end
- device pci 0.5 alias acp off ops amd_acp_ops end # Audio Processor (ACP)
- device pci 0.6 alias hda off end # Audio Processor HD Audio Controller (main AZ)
- device pci 0.7 alias mp2 off end # Sensor Fusion Hub (MP2)
- end
- device pci 08.2 alias gpp_bridge_b off ops amd_internal_pcie_gpp_ops end # Internal GPP Bridge 1 to Bus B
- device pci 08.3 alias gpp_bridge_c off # Internal GPP Bridge 2 to Bus C
- ops amd_internal_pcie_gpp_ops
- device pci 0.0 alias xhci_2 off end # Might also be a dummy device with different PCI DID
- # When using this as XHCI2, the mainboard devicetree needs to add ops xhci_pci_ops
+ device pci 0.3 alias usb4_xhci_0 off
+ ops xhci_pci_ops
+ chip drivers/usb/acpi
+ register "type" = "UPC_TYPE_HUB"
+ device usb 0.0 alias usb4_xhci_0_root_hub off
+ chip drivers/usb/acpi
+ device usb 3.0 alias usb3_port0 off end
+ end
+ chip drivers/usb/acpi
+ device usb 2.0 alias usb2_port0 off end
+ end
+ end
+ end
+ end
+ device pci 0.4 alias usb4_xhci_1 off
+ ops xhci_pci_ops
+ chip drivers/usb/acpi
+ register "type" = "UPC_TYPE_HUB"
+ device usb 0.0 alias usb4_xhci_1_root_hub off
+ chip drivers/usb/acpi
+ device usb 3.0 alias usb3_port1 off end
+ end
+ chip drivers/usb/acpi
+ device usb 2.0 alias usb2_port1 off end
+ end
+ end
+ end
+ end
end
device pci 14.0 alias smbus on ops amd_smbus_ops end # primary FCH function
--
To view, visit https://review.coreboot.org/c/coreboot/+/84376?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1138f27bfd47f6fa70a0c2afcc65a5553a609d57
Gerrit-Change-Number: 84376
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Attention is currently required from: Felix Held, Maximilian Brune.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84373?usp=email
to look at the new patch set (#4).
Change subject: util/amdfwtool: Add binaries
......................................................................
util/amdfwtool: Add binaries
Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
M util/amdfwtool/data_parse.c
3 files changed, 132 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84373/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Gerrit-Change-Number: 84373
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Felix Held, Maximilian Brune.
Hello Felix Held, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84373?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: util/amdfwtool: Add binaries
......................................................................
util/amdfwtool: Add binaries
Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
M util/amdfwtool/data_parse.c
3 files changed, 131 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84373/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Gerrit-Change-Number: 84373
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Maximilian Brune has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )
Change subject: util/amdfwtool: Add binaries
......................................................................
util/amdfwtool: Add binaries
Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com>
---
M util/amdfwtool/amdfwtool.c
M util/amdfwtool/amdfwtool.h
M util/amdfwtool/data_parse.c
3 files changed, 132 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/84373/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Gerrit-Change-Number: 84373
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>