Attention is currently required from: Hung-Te Lin, Knox Chiou, Yidi Lin, Yu-Ping Wu.
Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/96fcf8af_e9e864d2?us… :
PS2, Line 132: BOARD_GOOGLE_STEELIX
> Are there Voltorb and Squirtle still being manufactured in the factory? If not, I'd like to change t […]
Yes, Voltorb is still being manufactured, and Squirtle has received FSI sign-off and is now entering manufacturing.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 03:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Comment-In-Reply-To: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Attention is currently required from: Hung-Te Lin, Knox Chiou, Yang Wu, Yidi Lin.
Yu-Ping Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Make compatible with MT8186T by modifing skuid
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/62c06539_6cf7cf22?us… :
PS2, Line 132: BOARD_GOOGLE_STEELIX
> Yes,that is.
Are there Voltorb and Squirtle still being manufactured in the factory? If not, I'd like to change their unprovisioned SKU ID to 0xfffffffe, so that this ID could be shared for all mt8186t devices.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84342?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I91306d3abd508e104851916882fb36a4fd302036
Gerrit-Change-Number: 84342
Gerrit-PatchSet: 2
Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Reviewer: Xinxiong Xu <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Knox Chiou <knoxchiou(a)google.com>
Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 03:35:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Nico Huber.
Nigel Tao has posted comments on this change by Nigel Tao. ( https://review.coreboot.org/c/coreboot/+/84341?usp=email )
Change subject: lib/jpeg: return string (not int) error messages
......................................................................
Patch Set 6:
(2 comments)
File src/lib/bootsplash.c:
https://review.coreboot.org/c/coreboot/+/84341/comment/2fe3d040_c6ff075e?us… :
PS5, Line 26: bootsplash.jpg
> May look odd, but it actually carries information, i.e. that we are looking […]
Done
File src/lib/jpeg.h:
https://review.coreboot.org/c/coreboot/+/84341/comment/ed9b5bf7_1322b924?us… :
PS5, Line 7:
> Should have a comment that `!= NULL` is an error.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84341?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I465a6eebc2a41ca9a618b1e86dee015cea40800b
Gerrit-Change-Number: 84341
Gerrit-PatchSet: 6
Gerrit-Owner: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sat, 14 Sep 2024 02:49:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Nico Huber.
Nigel Tao has posted comments on this change by Nigel Tao. ( https://review.coreboot.org/c/coreboot/+/84340?usp=email )
Change subject: lib/jpeg: enable dst-pixel-format allowlist
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
> Technically, it's undefined. Some people run VGA option roms in coreboot, and […]
Fair enough on going through Kconfig.
I don't actually run coreboot myself. I'm just a src/vendorcode/wuffs developer. TBH, exploring how coreboot's Kconfig works is low on my never-ending priority list of things to do.
Thanks anyway for the suggestion. I'll abandon the gerrit review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84340?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie29592f74f245cb890d18b68060640e9bab192b2
Gerrit-Change-Number: 84340
Gerrit-PatchSet: 3
Gerrit-Owner: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sat, 14 Sep 2024 02:48:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Nigel Tao <nigeltao(a)golang.org>
Attention is currently required from: Nico Huber, Nigel Tao.
Hello Nico Huber, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84341?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+2 by Nico Huber, Verified+1 by build bot (Jenkins)
Change subject: lib/jpeg: return string (not int) error messages
......................................................................
lib/jpeg: return string (not int) error messages
Change-Id: I465a6eebc2a41ca9a618b1e86dee015cea40800b
Signed-off-by: Nigel Tao <nigeltao(a)golang.org>
---
M src/lib/bootsplash.c
M src/lib/jpeg.c
M src/lib/jpeg.h
3 files changed, 30 insertions(+), 33 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/84341/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/84341?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I465a6eebc2a41ca9a618b1e86dee015cea40800b
Gerrit-Change-Number: 84341
Gerrit-PatchSet: 6
Gerrit-Owner: Nigel Tao <nigeltao(a)golang.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nigel Tao <nigeltao(a)golang.org>
Attention is currently required from: Jian Tong, Kun Liu.
Hello Kun Liu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84254?usp=email
to look at the new patch set (#3).
Change subject: mb/google/brox/var/lotso: Add RTS522A vdd ctrl by gpio
......................................................................
mb/google/brox/var/lotso: Add RTS522A vdd ctrl by gpio
For next DVT build, hw will add this power ctrl.
BUG=b:359409425
TEST=emerge-brox sys-boot/coreboot sys-boot/chromeos-bootimage
Change-Id: Id256b3a94d3c8ed6f6832d63ecc74c2438c7d15a
Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/variants/lotso/gpio.c
M src/mainboard/google/brox/variants/lotso/overridetree.cb
2 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/84254/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84254?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id256b3a94d3c8ed6f6832d63ecc74c2438c7d15a
Gerrit-Change-Number: 84254
Gerrit-PatchSet: 3
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Attention is currently required from: Dengwu Yu, Karthik Ramasubramanian, Paul Menzel, Subrata Banik, wen zhang.
Jian Tong has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/84202?usp=email )
Change subject: mb/google/brox/var/lotso: Update cpu power limits
......................................................................
Patch Set 8:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84202/comment/6ef6f1ef_1748450a?us… :
PS6, Line 9: persent
> present
Done
https://review.coreboot.org/c/coreboot/+/84202/comment/f3fc94f0_52ac8688?us… :
PS6, Line 9: limit PL4 to 40
> … increase limit from 9 to 40
Done
https://review.coreboot.org/c/coreboot/+/84202/comment/5c79f591_b16a17cc?us… :
PS6, Line 10: Base on: https://review.coreboot.org/c/coreboot/+/83752
> Please summarize the change-set, and once it’s commit, also add the git commit hash and summary.
Done
https://review.coreboot.org/c/coreboot/+/84202/comment/d92412cd_321b2e4a?us… :
PS6, Line 10: Base
> Base*d*
Done
https://review.coreboot.org/c/coreboot/+/84202/comment/4c2ec7bb_11e9e9c8?us… :
PS6, Line 21:
> What is the source for this data?
Done
https://review.coreboot.org/c/coreboot/+/84202/comment/bf49ac5a_b3d24111?us… :
PS6, Line 23: TEST=emerge-brox sys-boot/coreboot sys-boot/chromeos-bootimage
> Should runtime tests be done?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/84202?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928
Gerrit-Change-Number: 84202
Gerrit-PatchSet: 8
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Sat, 14 Sep 2024 01:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Dengwu Yu, Jian Tong, Karthik Ramasubramanian, Subrata Banik, wen zhang.
Hello Dengwu Yu, Karthik Ramasubramanian, Kun Liu, Subrata Banik, build bot (Jenkins), wen zhang,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84202?usp=email
to look at the new patch set (#8).
Change subject: mb/google/brox/var/lotso: Update cpu power limits
......................................................................
mb/google/brox/var/lotso: Update cpu power limits
When battery not present, increase PL4 limit from 9 to 40.
Get PL setting form internal thermal and power team.
AC+DC/DC:
PL1=15W
PL2=25W
PL4=114W
AC ONLY:
PL1=15W
PL2=25W
PL4=40W
BUG=b:355094551
TEST=emerge-brox sys-boot/coreboot sys-boot/chromeos-bootimage
Confirm on lotso EVT board, as expected.
Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928
Signed-off-by: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/brox/Kconfig
M src/mainboard/google/brox/variants/lotso/Makefile.mk
M src/mainboard/google/brox/variants/lotso/overridetree.cb
A src/mainboard/google/brox/variants/lotso/ramstage.c
4 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/84202/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/84202?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5848c776399a1bdc455db604bb3b22d16f6b2928
Gerrit-Change-Number: 84202
Gerrit-PatchSet: 8
Gerrit-Owner: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Kun Liu <liukun11(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: wen zhang <zhangwen6(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Dengwu Yu <yudengwu(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Jian Tong <tongjian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>