Attention is currently required from: Caveh Jalali, Karthik Ramasubramanian.
Jameson Thies has posted comments on this change by Jameson Thies. ( https://review.coreboot.org/c/coreboot/+/84403?usp=email )
Change subject: mb/google/brox: Switch USB-C port locations
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hey Karthik and Caveh, the USB-C port PLDs defined for Brox are incorrect. Can you take a look at this update to swap them? Let me know if you have any questions.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84403?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I98e3042c64aba885b602c99916734c2dbb9d66bd
Gerrit-Change-Number: 84403
Gerrit-PatchSet: 1
Gerrit-Owner: Jameson Thies <jthies(a)google.com>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Abhishek Pandit-Subedi <abhishekpandit(a)chromium.org>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Tue, 17 Sep 2024 21:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Mario Scheithauer.
Paul Menzel has posted comments on this change by Mario Scheithauer. ( https://review.coreboot.org/c/coreboot/+/84391?usp=email )
Change subject: mb/siemens/{mc_ehl2,mc_ehl3,mc_ehl5}: Enable real-time tuning in FSP
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84391/comment/266e9476_ec1bc876?us… :
PS1, Line 11: improves performance in the real-time environment for these mainboards.
> I set this comment to resolved so that this easy patch can go in.
I know, nobody else than you is going to use the board, still it’d be great to have a generic way to test, if the UPD(?) was effective. From an earlier commit I remember, that power management features are so are disabled. So `lspci -vv` might differ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/84391?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04859b2f32bc11344b0620925f2414e7a6df625e
Gerrit-Change-Number: 84391
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Uwe Poeche <uwe.poeche(a)siemens.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Gerrit-Comment-Date: Tue, 17 Sep 2024 20:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com>
Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com>
Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Paul Menzel, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh.
Hello Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84356?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................
drivers/intel/fsp2_0: Simplify FSP global reset definition
This commit simplifies the definition of the FSP global reset return
status:
1. According to the FSP 2.x specification, FSP reset status are a
suite of integers starting from FSP_STATUS_RESET_REQUIRED_COLD,
hence we can define the FSP Global reset as a simple index.
2. Since all the platforms defining
SOC_INTEL_COMMON_FSP_RESET (tigerlake, alderlake, jasperlake,
meteorlake, pantherlake, elkhartlake, skylake, cannonlake and
apollolake) pick a global reset value, we can default the most
common (3).
FSP 2.x status code uses the UEFI EFI_STATUS type (aka.
efi_return_status_t) type whose size varies with the
architecture (32-bit vs 64-bit). As a result of the code
simplification introduced by this commit, FSP_STATUS_GLOBAL_RESET is
appropriately defined for 64-bit FSP. Therefore, functions handling
this reset status such fsp_get_pch_reset_status() must use
efi_return_status_t type. It waterfalls into a few extra changes due
to dependencies.
BUG=b:348678529
TEST=FSP-s Global reset request is handled properly on pantherlake
fatcat
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/drivers/intel/fsp2_0/Kconfig
M src/soc/intel/alderlake/Kconfig
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/common/fsp_reset.c
M src/soc/intel/common/reset.h
M src/soc/intel/elkhartlake/Kconfig
M src/soc/intel/jasperlake/Kconfig
M src/soc/intel/meteorlake/Kconfig
M src/soc/intel/meteorlake/chip.c
M src/soc/intel/pantherlake/Kconfig
M src/soc/intel/pantherlake/chip.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/tigerlake/Kconfig
14 files changed, 23 insertions(+), 62 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/84356/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/84356?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Gerrit-Change-Number: 84356
Gerrit-PatchSet: 5
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Paul Menzel, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh.
Hello Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84356?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified-1 by build bot (Jenkins)
Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................
drivers/intel/fsp2_0: Simplify FSP global reset definition
This commit simplifies the definition of the FSP global reset return
status:
1. According to the FSP 2.x specification, FSP reset status are a
suite of integers starting from FSP_STATUS_RESET_REQUIRED_COLD,
hence we can define the FSP Global reset as a simple index.
2. Since all the platforms defining
SOC_INTEL_COMMON_FSP_RESET (tigerlake, alderlake, jasperlake,
meteorlake, pantherlake, elkhartlake, skylake, cannonlake and
apollolake) pick a global reset value, we can default the most
common (3).
FSP 2.x status code uses the UEFI EFI_STATUS type (aka.
efi_return_status_t) type whose size varies with the
architecture (32-bit vs 64-bit). As a result of the code
simplification introduced by this commit, FSP_STATUS_GLOBAL_RESET is
appropriately defined for 64-bit FSP. Therefore, functions handling
this reset status such fsp_get_pch_reset_status() must use
efi_return_status_t type. It waterfalls into a few extra changes due
to dependencies.
BUG=b:348678529
TEST=FSP-s Global reset request is handled properly on pantherlake
fatcat
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/drivers/intel/fsp2_0/Kconfig
M src/soc/intel/alderlake/Kconfig
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/common/fsp_reset.c
M src/soc/intel/common/reset.h
M src/soc/intel/elkhartlake/Kconfig
M src/soc/intel/jasperlake/Kconfig
M src/soc/intel/meteorlake/Kconfig
M src/soc/intel/meteorlake/chip.c
M src/soc/intel/pantherlake/Kconfig
M src/soc/intel/pantherlake/chip.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/tigerlake/Kconfig
14 files changed, 22 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/84356/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/84356?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Gerrit-Change-Number: 84356
Gerrit-PatchSet: 4
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Lean Sheng Tan, Nick Vaccaro, Paul Menzel, Pranava Y N, Rishika Raj, Ronak Kanabar, Sean Rhodes, Subrata Banik, Tarun, Werner Zeh.
Jérémy Compostella has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/84356?usp=email )
Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84356/comment/81153ea4_776abc92?us… :
PS2, Line 9: which
> whose?
Done
https://review.coreboot.org/c/coreboot/+/84356/comment/269d2241_b570e647?us… :
PS2, Line 13: take
> takes
Done
https://review.coreboot.org/c/coreboot/+/84356/comment/4f59700b_63f219bb?us… :
PS2, Line 17: TEST=Verified with fatcat mainboard on pantherlake reference board
> Before it did not boot or build?
Done
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/84356/comment/f5d420c8_be638668?us… :
PS2, Line 378: 0x4000000000000003
> can you please point me to the FSP spec that defines 64-bit FSP return value. […]
FSP 2.4 OEM Status Code https://cdrdv2.intel.com/v1/dl/getContent/736809?explicitVersion=true.
But technically speaking this return status always has been an EFI_STATUS which per definition varies with the architecture but since FSP < 2.3 was limited to 32-bit it was not an issue.
File src/include/efi/efi_datatype.h:
https://review.coreboot.org/c/coreboot/+/84356/comment/825c0df9_3649a31b?us… :
PS2, Line 16: #if CONFIG(PLATFORM_USES_FSP1_1) || CONFIG(PLATFORM_USES_FSP2_X86_32)
> can u please submit a separate CL to add FSP1. […]
Done
File src/soc/intel/meteorlake/chip.c:
https://review.coreboot.org/c/coreboot/+/84356/comment/903f4703_4cbcbf82?us… :
PS2, Line 276: fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE,
: "Failed to handle the FSP reset request");
> please submit a separate CL for this as well
Done
File src/soc/intel/pantherlake/chip.c:
https://review.coreboot.org/c/coreboot/+/84356/comment/376179bc_7e8a02f3?us… :
PS2, Line 274: fsp_die_with_post_code(reset_status, POSTCODE_HW_INIT_FAILURE,
: "Failed to handle the FSP reset request");
> same as previous file
I cannot, if I split, I hit the following error:
```
src/soc/intel/pantherlake/chip.c:275:74: note: format string is defined here
275 | "Failed to handle the FSP reset request with error 0x%08x\n", reset_status);
| ~~~^
| |
| unsigned int
| %08llx
cc1: all warnings being treated as errors
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/84356?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Gerrit-Change-Number: 84356
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Jayvik Desai <jayvik(a)google.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 17 Sep 2024 18:24:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jérémy Compostella, Kapil Porwal, Pranava Y N, Ronak Kanabar, Tarun.
Hello Andrey Petrov, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/84356?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by build bot (Jenkins)
Change subject: drivers/intel/fsp2_0: Simplify FSP global reset definition
......................................................................
drivers/intel/fsp2_0: Simplify FSP global reset definition
This commit simplifies the definition of the FSP global reset return
status:
1. According to the FSP 2.x specification, FSP reset status are a
suite of integers starting from FSP_STATUS_RESET_REQUIRED_COLD,
hence we can define the FSP Global reset as a simple index.
2. Since all the platforms defining
SOC_INTEL_COMMON_FSP_RESET (tigerlake, alderlake, jasperlake,
meteorlake, pantherlake, elkhartlake, skylake, cannonlake and
apollolake) pick a global reset value, we can default the most
common (3).
FSP 2.x status code uses the UEFI EFI_STATUS type (aka.
efi_return_status_t) type whose size varies with the
architecture (32-bit vs 64-bit). As a result of the code
simplification introduced by this commit, FSP_STATUS_GLOBAL_RESET is
appropriately defined for 64-bit FSP. Therefore, functions handling
this reset status such fsp_get_pch_reset_status() must use
efi_return_status_t type. It waterfalls into a few extra changes due
to dependencies.
BUG=b:348678529
TEST=FSP-s Global reset request is handled properly on pantherlake
fatcat
Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
---
M src/drivers/intel/fsp2_0/Kconfig
M src/soc/intel/alderlake/Kconfig
M src/soc/intel/apollolake/Kconfig
M src/soc/intel/cannonlake/Kconfig
M src/soc/intel/common/fsp_reset.c
M src/soc/intel/common/reset.h
M src/soc/intel/elkhartlake/Kconfig
M src/soc/intel/jasperlake/Kconfig
M src/soc/intel/meteorlake/Kconfig
M src/soc/intel/meteorlake/chip.c
M src/soc/intel/pantherlake/Kconfig
M src/soc/intel/pantherlake/chip.c
M src/soc/intel/skylake/Kconfig
M src/soc/intel/tigerlake/Kconfig
14 files changed, 21 insertions(+), 60 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/84356/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/84356?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I914f73ff06bfb801fc319b45b23d7ce4cb7a6d5f
Gerrit-Change-Number: 84356
Gerrit-PatchSet: 3
Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>