coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3342 discussions

[M] Change in coreboot[main]: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Paul Menzel. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83879?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode ...................................................................... ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode This patch adds support for the Intel Virtual Button driver, which reports whether a tablet is docked or undocked. The GPIO used for detection is hardcoded to GPP_F15 for now, specific to the `mb/starlite_adl` board. The GPIO value is returned to the HID driver via the `_STA` and `VGBS` methods. These methods ensure proper notification to the OS, allowing it to show or hide the virtual keyboard depending on the docking status. Tested on `starlite_adl` with Ubuntu 24.04, confirming the virtual keyboard appears when the tablet is undocked and hides when docked. This was verified with ACPI debug enabled, as dmesg does not report the state of the GPIO. Change-Id: I574a1b2d3907b2341a0dfdc412151d574ba4848e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- A src/ec/starlabs/merlin/acpi/dock.asl M src/ec/starlabs/merlin/acpi/hid.asl 2 files changed, 56 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83879/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/83879?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574a1b2d3907b2341a0dfdc412151d574ba4848e Gerrit-Change-Number: 83879 Gerrit-PatchSet: 5 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XL] Change in coreboot[main]: mainboard/hardkernel: Add ODROID H4+ initial support
by Michał Żygowski (Code Review) 30 Sep '24

30 Sep '24

Michał Żygowski has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84213?usp=email ) Change subject: mainboard/hardkernel: Add ODROID H4+ initial support ...................................................................... Abandoned https://review.coreboot.org/c/coreboot/+/83979 got merged -- To view, visit https://review.coreboot.org/c/coreboot/+/84213?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iee066cb0da27e3bf7ce52fc199396185912893aa Gerrit-Change-Number: 84213 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Alicja Michalska <ahplka19(a)gmail.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com>

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Make I2C speed configurable
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Sean Rhodes. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83882?usp=email ) Change subject: mb/starlabs/starlite_adl: Make I2C speed configurable ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/83882?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia1b08d7ec6212418bb95d0a52077f01c930f8830 Gerrit-Change-Number: 83882 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:35:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/starlite_adl: Alphabetize and group FSP UPDs
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83881?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/starlabs/starlite_adl: Alphabetize and group FSP UPDs ...................................................................... mb/starlabs/starlite_adl: Alphabetize and group FSP UPDs Change-Id: Ibe47f242ce12fc4906baeee89393a34a56eaca76 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/mainboard/starlabs/starlite_adl/variants/mk_v/devicetree.cb 1 file changed, 5 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/83881/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83881?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibe47f242ce12fc4906baeee89393a34a56eaca76 Gerrit-Change-Number: 83881 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/starlabs/*: Remove the CMOS option to set the 8254 timer
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Paul Menzel. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83634?usp=email ) Change subject: mb/starlabs/*: Remove the CMOS option to set the 8254 timer ...................................................................... Patch Set 6: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83634/comment/2dee1b9a_79c8bb66?us… : PS1, Line 9: This setting is no longer used. > Please elaborate. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83634?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifde16e95bce048b70e11aa6459bf6d86c834eed6 Gerrit-Change-Number: 83634 Gerrit-PatchSet: 6 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:32:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Paul Menzel. Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83879?usp=email ) Change subject: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode ...................................................................... Patch Set 4: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83879/comment/4ea8c006_a6a8cb3b?us… : PS3, Line 15: Ubuntu > Which version? Done https://review.coreboot.org/c/coreboot/+/83879/comment/facdcb7a_c463788a?us… : PS3, Line 16: show > show*n* Done https://review.coreboot.org/c/coreboot/+/83879/comment/68f04483_6251a816?us… : PS3, Line 15: Tested on `starlite_adl` with Ubuntu, by checking the : virtual keyboard is show when the tablet is undocked : and hidden when docked. > Can it be tested by looking at some logs? Done https://review.coreboot.org/c/coreboot/+/83879/comment/4c83b997_f9557ea6?us… : PS3, Line 9: Add Intel Virtual Button driver which is used to report : to the OS whether a tablet is docked or undocked. : : This is currently only used on `mb/starlite_adl` so the : GPIO is hardcoded to GPP_F15 for now. : : Tested on `starlite_adl` with Ubuntu, by checking the : virtual keyboard is show when the tablet is undocked : and hidden when docked. > Please try to use 72 characters per line. Done File src/ec/starlabs/merlin/acpi/battery.asl: PS3: > This is from a different commit, isn’t it? Done File src/ec/starlabs/merlin/acpi/dock.asl: PS3: > There is already: […] Not any way that I can see that wouldn't overconplicate it. File src/ec/starlabs/merlin/acpi/ec.asl: https://review.coreboot.org/c/coreboot/+/83879/comment/fe308e5a_9aabd4fb?us… : PS3, Line 53: #if CONFIG(SOC_INTEL_COMMON) : \LIDS = 0x03 : #endif > Please comment in the commit message why this is done, or add a comment? Done File src/ec/starlabs/merlin/acpi/hid.asl: https://review.coreboot.org/c/coreboot/+/83879/comment/f023f8e0_32f02d9b?us… : PS3, Line 352: Case (0x08) : { : Return (\_SB.PCI0.LPCB.EC.VBTN.VGBS()) : } > Please mention this in the commit message? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/83879?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574a1b2d3907b2341a0dfdc412151d574ba4848e Gerrit-Change-Number: 83879 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:30:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83879?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode ...................................................................... ec/starlabs/merlin: Add Intel Virtual Button Driver for Tablet Mode This patch adds support for the Intel Virtual Button driver, which reports whether a tablet is docked or undocked. The GPIO used for detection is hardcoded to GPP_F15 for now, specific to the `mb/starlite_adl` board. The GPIO value is returned to the HID driver via the `_STA` and `VGBS` methods. These methods ensure proper notification to the OS, allowing it to show or hide the virtual keyboard depending on the docking status. Tested on `starlite_adl` with Ubuntu 24.04, confirming the virtual keyboard appears when the tablet is undocked and hides when docked. This was verified with ACPI debug enabled, as dmesg does not report the state of the GPIO. Change-Id: I574a1b2d3907b2341a0dfdc412151d574ba4848e Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- A src/ec/starlabs/merlin/acpi/dock.asl M src/ec/starlabs/merlin/acpi/hid.asl 2 files changed, 57 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83879/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/83879?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I574a1b2d3907b2341a0dfdc412151d574ba4848e Gerrit-Change-Number: 83879 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/kbl: Disable DPTF
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84276?usp=email ) Change subject: mb/starlabs/starbook/kbl: Disable DPTF ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84276?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I68b285ff098127b7becf4aa8736e66fd6b2c4a32 Gerrit-Change-Number: 84276 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:17:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/kbl: Remove PMC GPIO routing
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84275?usp=email ) Change subject: mb/starlabs/starbook/kbl: Remove PMC GPIO routing ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ibb92d76f15be71ecb1e2187c7e235235585f8793 Gerrit-Change-Number: 84275 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:17:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/kbl: Alphabetize and group FSP UPDs
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84274?usp=email ) Change subject: mb/starlabs/starbook/kbl: Alphabetize and group FSP UPDs ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84274?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5beda22208fe17338d4136f9d38fd50e55054b01 Gerrit-Change-Number: 84274 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 30 Sep 2024 08:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024