coreboot-gerrit September 2024

coreboot-gerrit@coreboot.org

1 participants
3344 discussions

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Felix Singer (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Sean Rhodes. Felix Singer has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84597?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Patch Set 1: (1 comment) File 3rdparty/fsp: https://review.coreboot.org/c/coreboot/+/84597/comment/1b491bf0_1dfb5e06?us… : PS1, Line 1: Subproject commit bb12f17b07700a40c0033da345eae0c1cd487b73 The latest commit has a different ID 02b30da989444aa988ebb00c00c414bb662babd3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib414495bd2b7e6fe363277bad1031e06ab8d503c Gerrit-Change-Number: 84597 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 30 Sep 2024 10:03:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream main
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84597?usp=email ) Change subject: Update fsp submodule to upstream main ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84597?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib414495bd2b7e6fe363277bad1031e06ab8d503c Gerrit-Change-Number: 84597 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 30 Sep 2024 09:55:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: vendorcode/amd/fsp/glinda: port usb_phy_config structure
by Maximilian Brune (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Marshall Dawson, ritul guru. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84435?usp=email ) Change subject: vendorcode/amd/fsp/glinda: port usb_phy_config structure ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84435/comment/40cd8428_f02ff288?us… : PS3, Line 7: Porting glinda specific usb_phy_config structure > nit, please change this to simply "port usb_phy_config structure" Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84435?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Gerrit-Change-Number: 84435 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 09:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Marshall Dawson <marshalldawson3rd(a)gmail.com>

1 0

[S] Change in coreboot[main]: vendorcode/amd/fsp/glinda: port usb_phy_config structure
by Maximilian Brune (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, Maximilian Brune, ritul guru. Hello Anand Vaikar, Felix Held, Fred Reitberger, Jason Glenesk, build bot (Jenkins), ritul guru, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84435?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: vendorcode/amd/fsp/glinda: port usb_phy_config structure ...................................................................... vendorcode/amd/fsp/glinda: port usb_phy_config structure Signed-off-by: Satya SreenivasL <satya.sreenivasl(a)amd.com> Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Reviewed-by: Anand Vaikar <a.vaikar2021(a)gmail.com> Reviewed-by: Ritul Guru <ritul.bits(a)gmail.com> Tested-by: Satya Sreenivas L <Satya.SreenivasL(a)amd.com> --- M src/mainboard/amd/birman/devicetree_glinda.cb M src/mainboard/amd/birman_plus/devicetree_glinda.cb M src/vendorcode/amd/fsp/glinda/FspUsb.h 3 files changed, 5 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/84435/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/84435?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0603f5da689b6738ea54305a665b150121bc520c Gerrit-Change-Number: 84435 Gerrit-PatchSet: 4 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: soc/amd/glinda/.../iomap.h: Update for glinda
by Maximilian Brune (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Paul Menzel. Maximilian Brune has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84380?usp=email ) Change subject: soc/amd/glinda/.../iomap.h: Update for glinda ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/84380/comment/1d3d92d9_0b0a66ad?us… : PS2, Line 8: > Please elaborate. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/84380?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If282ce5687b8a2bdae03ebfc5a37fe5b8b17647a Gerrit-Change-Number: 84380 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 30 Sep 2024 09:49:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XL] Change in coreboot[main]: mb/starlabs/starfighter: Add Raptor Lake StarFighter Mk I variant
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74445?usp=email to look at the new patch set (#8). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: mb/starlabs/starfighter: Add Raptor Lake StarFighter Mk I variant ...................................................................... mb/starlabs/starfighter: Add Raptor Lake StarFighter Mk I variant Tested using `edk2` from `github.com/starlabsltd/edk2/tree/uefipayload_202209`: * Windows 10 * Ubuntu 20.04 * MX Linux 19.4 * Manjaro 21 No known issues. https://starlabs.systems/pages/starfighter-specification Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I046e70845a5201d6f6ab062aee91fa8be9728737 --- M Documentation/mainboard/index.md A Documentation/mainboard/starlabs/starfighter_rpl.md A src/mainboard/starlabs/starfighter/Kconfig A src/mainboard/starlabs/starfighter/Kconfig.name A src/mainboard/starlabs/starfighter/Makefile.mk A src/mainboard/starlabs/starfighter/acpi/ec.asl A src/mainboard/starlabs/starfighter/acpi/mainboard.asl A src/mainboard/starlabs/starfighter/acpi/sleep.asl A src/mainboard/starlabs/starfighter/acpi/superio.asl A src/mainboard/starlabs/starfighter/board_info.txt A src/mainboard/starlabs/starfighter/bootblock.c A src/mainboard/starlabs/starfighter/cmos.default A src/mainboard/starlabs/starfighter/cmos.layout A src/mainboard/starlabs/starfighter/dsdt.asl A src/mainboard/starlabs/starfighter/hda_verb.c A src/mainboard/starlabs/starfighter/include/variants.h A src/mainboard/starlabs/starfighter/mainboard.c A src/mainboard/starlabs/starfighter/smbios.c A src/mainboard/starlabs/starfighter/spd/16gb.spd.hex A src/mainboard/starlabs/starfighter/spd/32gb.spd.hex A src/mainboard/starlabs/starfighter/spd/64gb.spd.hex A src/mainboard/starlabs/starfighter/spd/Makefile.mk A src/mainboard/starlabs/starfighter/variants/rpl/Makefile.mk A src/mainboard/starlabs/starfighter/variants/rpl/board.fmd A src/mainboard/starlabs/starfighter/variants/rpl/data.vbt A src/mainboard/starlabs/starfighter/variants/rpl/devicetree.cb A src/mainboard/starlabs/starfighter/variants/rpl/devtree.c A src/mainboard/starlabs/starfighter/variants/rpl/gpio.c A src/mainboard/starlabs/starfighter/variants/rpl/hda_verb.c A src/mainboard/starlabs/starfighter/variants/rpl/ramstage.c A src/mainboard/starlabs/starfighter/variants/rpl/romstage.c A src/mainboard/starlabs/starfighter/vboot.c 32 files changed, 1,775 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/74445/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/74445?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I046e70845a5201d6f6ab062aee91fa8be9728737 Gerrit-Change-Number: 74445 Gerrit-PatchSet: 8 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>

1 0

[XS] Change in coreboot[main]: soc/amd/glinda/.../iomap.h: Update for glinda
by Maximilian Brune (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Felix Held, Maximilian Brune. Hello Marshall Dawson, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84380?usp=email to look at the new patch set (#3). Change subject: soc/amd/glinda/.../iomap.h: Update for glinda ...................................................................... soc/amd/glinda/.../iomap.h: Update for glinda Remove TODO after checking the contents are still valid. DMA4 apparently doesn't exist anymore so remove it. source: PPR 57254 Rev 1.59 Table 147 Change-Id: If282ce5687b8a2bdae03ebfc5a37fe5b8b17647a Signed-off-by: Maximilian Brune <maximilian.brune(a)9elements.com> --- M src/soc/amd/glinda/include/soc/iomap.h 1 file changed, 0 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/84380/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84380?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If282ce5687b8a2bdae03ebfc5a37fe5b8b17647a Gerrit-Change-Number: 84380 Gerrit-PatchSet: 3 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[S] Change in coreboot[main]: mb/starlabs/starbook/kbl: Add USB ACPI to devicetree
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Sean Rhodes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/84273?usp=email ) Change subject: mb/starlabs/starbook/kbl: Add USB ACPI to devicetree ...................................................................... Abandoned Wrong -- To view, visit https://review.coreboot.org/c/coreboot/+/84273?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id844397059cce8aa40dcf9a22482409f242828ba Gerrit-Change-Number: 84273 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: soc/intel/cannonlake: Hook up CNVi Bluetooth UPDs to devicetree
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84596?usp=email ) Change subject: soc/intel/cannonlake: Hook up CNVi Bluetooth UPDs to devicetree ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/84596?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic5640c23af3ce30498be814a6d7ce56988653b25 Gerrit-Change-Number: 84596 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Mon, 30 Sep 2024 09:41:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: drivers/usb/acpi: Add AOLD Method for Intel Bluetooth
by Sean Rhodes (Code Review) 30 Sep '24

30 Sep '24

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik, Tarun. Hello Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jayvik Desai, Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84134?usp=email to look at the new patch set (#13). Change subject: drivers/usb/acpi: Add AOLD Method for Intel Bluetooth ...................................................................... drivers/usb/acpi: Add AOLD Method for Intel Bluetooth Add AOLD Method, which simply returns an integer based on whether Audio Offload is enabled. Leave the existing control of Audio Offload in `soc/soc_chip.h`, and add second control in the USB ACPI `chip.h` which takes precedence if used. Change-Id: Idb804fb1cf0edef4a98479a6261ca68255dbf075 Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> --- M src/drivers/usb/acpi/chip.h M src/drivers/usb/acpi/usb_acpi.c M src/soc/intel/alderlake/fsp_params.c M src/soc/intel/meteorlake/fsp_params.c M src/soc/intel/tigerlake/fsp_params.c 5 files changed, 84 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/84134/13 -- To view, visit https://review.coreboot.org/c/coreboot/+/84134?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb804fb1cf0edef4a98479a6261ca68255dbf075 Gerrit-Change-Number: 84134 Gerrit-PatchSet: 13 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Tarun <tstuli(a)gmail.com>

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
335
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2024