coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[XS] Change in coreboot[main]: mb/google/rauru: reset usb hub in bootblock
by Yu-Ping Wu (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Jarried Lin, Mingjin Ge. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84024?usp=email ) Change subject: mb/google/rauru: reset usb hub in bootblock ...................................................................... Patch Set 8: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84024/comment/b8ab8101_150488a3?us… : PS8, Line 7: usb USB https://review.coreboot.org/c/coreboot/+/84024/comment/817150eb_fcb42060?us… : PS8, Line 8: Explain why this needs to be done in bootblock. -- To view, visit https://review.coreboot.org/c/coreboot/+/84024?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iea793b4b04bd009d0354e2331604bccf30466a23 Gerrit-Change-Number: 84024 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 06:03:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: add usb host support
by Yu-Ping Wu (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84023?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: soc/mediatek/mt8196: add usb host support ...................................................................... Patch Set 8: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/84023/comment/0248e851_892dfef8?us… : PS8, Line 7: usb USB https://review.coreboot.org/c/coreboot/+/84023/comment/2d0e1e6a_d2cb5582?us… : PS8, Line 7: add Add https://review.coreboot.org/c/coreboot/+/84023/comment/8c69b4b6_2cba21df?us… : PS8, Line 9: usb USB -- To view, visit https://review.coreboot.org/c/coreboot/+/84023?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia4efcddac9bf5e04e688648a5c22384075a0b026 Gerrit-Change-Number: 84023 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 06:02:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: mb/google/rauru: add usb host support
by Yu-Ping Wu (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84022?usp=email ) Change subject: mb/google/rauru: add usb host support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84022?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d081ff3e7367b87fab5ebdcb148c9005ab583f5 Gerrit-Change-Number: 84022 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 06:02:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: add usb host support
by Yu-Ping Wu (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Hung-Te Lin, Jarried Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84023?usp=email ) Change subject: soc/mediatek/mt8196: add usb host support ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/84023?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia4efcddac9bf5e04e688648a5c22384075a0b026 Gerrit-Change-Number: 84023 Gerrit-PatchSet: 8 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Mingjin Ge <mingjin.ge(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 06:01:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: soc/mediatek/mt8196: Fix timer reset in BL31
by Yu-Ping Wu (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin. Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83928?usp=email ) Change subject: soc/mediatek/mt8196: Fix timer reset in BL31 ...................................................................... Patch Set 21: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83928/comment/e3c6256f_c4befd9c?us… : PS21, Line 11: from > exceed 72 characters. Let's rewrite these as: ``` After reboot, the system does not need to serve pending IRQ from systimer. Therefore, clear systimer IRQ pending bits in init_timer(). For that to work, the systimer compensation version 2.0 needs to be enabled. ``` File src/soc/mediatek/mt8196/timer_prepare.c: https://review.coreboot.org/c/coreboot/+/83928/comment/800c8627_ca7899b9?us… : PS21, Line 18: void u32 https://review.coreboot.org/c/coreboot/+/83928/comment/77980f10_5a119247?us… : PS21, Line 20: write32(cnttval_con, SYST_CON_IRQ_CLR | SYST_CON_EN); `setbits32(cnttval_con, SYST_CON_IRQ_CLR)` https://review.coreboot.org/c/coreboot/+/83928/comment/6a96ad51_cf99abff?us… : PS21, Line 29: clrbits32p(SYSTIMER_BASE, COMP_FEATURE_MASK); Actually, we should use `mtk_systimer->cntcr` instead. Here please write ``` struct systimer *const mtk_systimer = (void *)SYSTIMER_BASE; clrbits32(mtk_systimer->cntcr, ...); setbits32(mtk_systimer->cntcr, ...); clear_systimer(mtk_systimer); ``` BTW, can we use a single call `clrsetbits32p` to replace `clrbits32+setbits32`? -- To view, visit https://review.coreboot.org/c/coreboot/+/83928?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I520986b81ca153ec3ce56558a80619448cfc0c59 Gerrit-Change-Number: 83928 Gerrit-PatchSet: 21 Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Zhanzhan Ge <zhanzhan.ge(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Attention: Jarried Lin <jarried.lin(a)mediatek.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 06:01:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>

1 0

[M] Change in coreboot[main]: mb/google/brox/jubilant: update dptf settings
by Ren Kuo (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Bob Moragues, Karthik Ramasubramanian, Kenneth Chan, Nick Vaccaro, Peter Ou. Hello Bob Moragues, Karthik Ramasubramanian, Kenneth Chan, Nick Vaccaro, Peter Ou, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/84106?usp=email to look at the new patch set (#3). Change subject: mb/google/brox/jubilant: update dptf settings ...................................................................... mb/google/brox/jubilant: update dptf settings Update dptf settings from thermal team. BUG=None TEST= Build jubilant firmware Check ACPI SSDT table: $ cat /sys/firmware/acpi/tables/SSDT > SSDT $ iasl -d SSDT check SSDT.dsl Change-Id: I0043c728f1302e86c84849653f443dc560a51654 Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brox/variants/jubilant/overridetree.cb 1 file changed, 17 insertions(+), 73 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/84106/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/84106?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0043c728f1302e86c84849653f443dc560a51654 Gerrit-Change-Number: 84106 Gerrit-PatchSet: 3 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Peter Ou <peter.ou(a)quanta.corp-partner.google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Peter Ou <peter.ou(a)quanta.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/nivviks: Prevent camera LED blinking during boot
by Subrata Banik (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rishika Raj, V Sowmya. Subrata Banik has posted comments on this change by V Sowmya. ( https://review.coreboot.org/c/coreboot/+/84019?usp=email ) Change subject: mb/google/nissa/var/nivviks: Prevent camera LED blinking during boot ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/brya/variants/nivviks/overridetree.cb: https://review.coreboot.org/c/coreboot/+/84019/comment/15238319_c5029b2a?us… : PS3, Line 438: # Controls : register "gpio_panel.gpio[0].gpio_num" = "GPP_D15" # EN_PP2800_WCAM_X > When the CCA is opened, the camera service will configure the VCM and Sensor. […] Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/84019?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I979207d1b6d55f78dea20d3366ef4a833ee9c86d Gerrit-Change-Number: 84019 Gerrit-PatchSet: 3 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jayvik Desai <jayvik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-Attention: Jayvik Desai <jayvik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 28 Aug 2024 05:56:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: V Sowmya <v.sowmya(a)intel.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[M] Change in coreboot[main]: soc/intel/common/block/pmc: Add GPE1 functions
by Subrata Banik (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Anil Kumar K, Bora Guvendik, Cliff Huang. Subrata Banik has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/84104?usp=email ) Change subject: soc/intel/common/block/pmc: Add GPE1 functions ...................................................................... Patch Set 3: (2 comments) File src/soc/intel/common/block/pmc/pmclib.c: https://review.coreboot.org/c/coreboot/+/84104/comment/b0ba8628_d94fe061?us… : PS3, Line 367: pmc_clear_std_gpe_status I would have implemented this logic in a more abstract way (w/ an assumption that we have either one Kconfig that tells me if GPE1 exists or use a macro as per https://review.coreboot.org/c/coreboot/+/84103/comment/39abef01_50206d52/ ``` static void pmc_clear_std_gpe_status(void) { print_std_gpe0_sts(reset_std_gpe0_status()); if (GPE1_STS(0)) print_std_gpe1_sts(reset_std_gpe1_status()); } ``` or ``` static void pmc_clear_std_gpe_status(void) { print_std_gpe0_sts(reset_std_gpe0_status()); if (SOC_INTEL_COMMON_BLOCK_ACPI_HAVE_GPE1) print_std_gpe1_sts(reset_std_gpe1_status()); } ``` https://review.coreboot.org/c/coreboot/+/84104/comment/2b108cd3_e09f6e0d?us… : PS3, Line 406: pmc_clear_gpi_gpe0_status why you don't need to clean GPE1 status? -- To view, visit https://review.coreboot.org/c/coreboot/+/84104?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7ac1fbe6d45cbe0c86c3f72911900d92a186168d Gerrit-Change-Number: 84104 Gerrit-PatchSet: 3 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 05:53:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in coreboot[main]: nb/intel/i440bx: Drop self-specific debugging macros
by Felix Singer (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Keith Hui. Felix Singer has posted comments on this change by Keith Hui. ( https://review.coreboot.org/c/coreboot/+/78786?usp=email ) Change subject: nb/intel/i440bx: Drop self-specific debugging macros ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78786/comment/83e53bb5_bae08288?us… : PS3, Line 10: for raminit debug messages. Even if it looks reasonable, I'm missing the "why" here. -- To view, visit https://review.coreboot.org/c/coreboot/+/78786?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I685a2f1f38c1afab6a08ff9de4bf82c9061aebec Gerrit-Change-Number: 78786 Gerrit-PatchSet: 3 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 28 Aug 2024 05:53:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in coreboot[main]: Makefile: Finish switch to Makefile.mak from .inc
by Felix Singer (Code Review) 28 Aug '24

28 Aug '24

Attention is currently required from: Felix Singer. Felix Singer has uploaded a new patch set (#2) to the change originally created by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/80130?usp=email ) The following approvals got outdated and were removed: Code-Review+1 by Felix Singer Change subject: Makefile: Finish switch to Makefile.mak from .inc ...................................................................... Makefile: Finish switch to Makefile.mak from .inc Remove include of Makefile.inc files - they're gone. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: If0dbc7ed204047b5575b303f57f6cf607f688ad9 --- M Makefile 1 file changed, 3 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/80130/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/80130?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: If0dbc7ed204047b5575b303f57f6cf607f688ad9 Gerrit-Change-Number: 80130 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024