coreboot-gerrit August 2024

coreboot-gerrit@coreboot.org

1 participants
3913 discussions

[NoOp] Change in coreboot[main]: TEST: add 0arr.c
by Xixi Chen (Code Review) 02 Aug '24

02 Aug '24

Xixi Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83747?usp=email ) Change subject: TEST: add 0arr.c ...................................................................... TEST: add 0arr.c Signed-off-by: Xi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Change-Id: Ifa7acf7eb889418abd55e3224c9670f263a9d372 --- A 0arr.c 1 file changed, 0 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/83747/1 diff --git a/0arr.c b/0arr.c new file mode 100644 index 0000000..e69de29 --- /dev/null +++ b/0arr.c -- To view, visit https://review.coreboot.org/c/coreboot/+/83747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifa7acf7eb889418abd55e3224c9670f263a9d372 Gerrit-Change-Number: 83747 Gerrit-PatchSet: 1 Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/trulo: Remove mux references from typec port
by Eric Lai (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Kapil Porwal, Nick Vaccaro, Rishika Raj. Eric Lai has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83746?usp=email ) Change subject: mb/google/trulo: Remove mux references from typec port ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a Gerrit-Change-Number: 83746 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Aug 2024 03:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/trulo: Remove mux references from typec port
by Subrata Banik (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj. Subrata Banik has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83746?usp=email ) Change subject: mb/google/trulo: Remove mux references from typec port ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a Gerrit-Change-Number: 83746 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Aug 2024 03:37:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: mb/google/trulo: Remove mux references from typec port
by Subrata Banik (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Amanda Hwang, Dinesh Gehlot, Eric Lai, Kapil Porwal, Nick Vaccaro, Rishika Raj. Subrata Banik has posted comments on this change by Amanda Hwang. ( https://review.coreboot.org/c/coreboot/+/83746?usp=email ) Change subject: mb/google/trulo: Remove mux references from typec port ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83746/comment/b3bcbf04_def4e981?us… : PS1, Line 7: mb/google/trulo nit: mb/google/brya/var/trulo -- To view, visit https://review.coreboot.org/c/coreboot/+/83746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a Gerrit-Change-Number: 83746 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Rishika Raj <rishikaraj(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 02 Aug 2024 03:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: mb/google/trulo: Remove mux references from typec port
by Amanda Hwang (Code Review) 02 Aug '24

02 Aug '24

Amanda Hwang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83746?usp=email ) Change subject: mb/google/trulo: Remove mux references from typec port ...................................................................... mb/google/trulo: Remove mux references from typec port The Type-C kernel driver no longer programs the AP mux. So remove device references to the TCSS Mux control device from the Type-C port driver. BUG=b:351117685 TEST=USB-C drive can be detected after system warm or cold reboot. Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com> --- M src/mainboard/google/brya/variants/trulo/overridetree.cb 1 file changed, 1 insertion(+), 12 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/83746/1 diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb index d7fca12..510053f 100644 --- a/src/mainboard/google/brya/variants/trulo/overridetree.cb +++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb @@ -525,21 +525,10 @@ device ref uart0 on end device ref pch_espi on chip ec/google/chromeec - use conn0 as mux_conn[0] device pnp 0c09.0 on end end end - device ref pmc hidden - chip drivers/intel/pmc_mux - device generic 0 on - chip drivers/intel/pmc_mux/conn - use usb2_port5 as usb2_port - use tcss_usb3_port1 as usb3_port - device generic 0 alias conn0 on end - end - end - end - end + device ref pmc hidden end device ref hda on chip drivers/sof register "spkr_tplg" = "max98360a" -- To view, visit https://review.coreboot.org/c/coreboot/+/83746?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a Gerrit-Change-Number: 83746 Gerrit-PatchSet: 1 Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>

1 0

[S] Change in coreboot[main]: mb/google/hatch: Add FP enable for Dratini
by ChromeOS coreboot bot (Code Review) 02 Aug '24

02 Aug '24

ChromeOS coreboot bot has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/83744?usp=email ) Change subject: mb/google/hatch: Add FP enable for Dratini ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/83744?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b30d70082062bc4a5fdb0e2eeca4b37af1613d9 Gerrit-Change-Number: 83744 Gerrit-PatchSet: 2 Gerrit-Owner: ChromeOS coreboot bot <chromeos-coreboot-bot(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>

1 0

[S] Change in coreboot[main]: mb/google/hatch: Add FP enable for Dratini
by Jon Murphy (Code Review) 02 Aug '24

02 Aug '24

Jon Murphy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83745?usp=email ) Change subject: mb/google/hatch: Add FP enable for Dratini ...................................................................... mb/google/hatch: Add FP enable for Dratini Add FP enable/disable based on SKU ID for Dratini. This is meant to resolve a UMA issue with Dratini devices that had the FPMCU populated on non-fp devices. Since the FPMCU is present, and the firmware enables the power GPIO's based on variant, not SKU, the devices were reporting data on fingerprint errantly. BUG=b:354769653 TEST=Flash to Dratini, test FP. Disable test SKU, flash on Dratini, test FP. Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M src/mainboard/google/hatch/variants/dratini/include/variant/sku.h M src/mainboard/google/hatch/variants/dratini/ramstage.c 2 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/83745/1 diff --git a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h index c44e0db..89f6708 100644 --- a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h +++ b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h @@ -4,6 +4,14 @@ #define __MAINBOARD_SKU_H__ enum { + SKU_1_DRATINI = 1, + SKU_2_DRATINI = 2, + SKU_3_DRATINI = 3, + SKU_4_DRATINI = 4, + SKU_5_DRATINI = 5, + SKU_6_DRATINI = 6, + SKU_7_DRATINI = 7, + SKU_8_DRATINI = 8, SKU_21_DRAGONAIR = 21, SKU_22_DRAGONAIR = 22, SKU_23_DRAGONAIR = 23, diff --git a/src/mainboard/google/hatch/variants/dratini/ramstage.c b/src/mainboard/google/hatch/variants/dratini/ramstage.c index 240bcae..f5c98b5 100644 --- a/src/mainboard/google/hatch/variants/dratini/ramstage.c +++ b/src/mainboard/google/hatch/variants/dratini/ramstage.c @@ -6,13 +6,21 @@ void variant_ramstage_init(void) { - /* - * Enable power to FPMCU, wait for power rail to stabilize, - * and then deassert FPMCU reset. - * Waiting for the power rail to stabilize can take a while, - * a minimum of 400us on Kohaku. - */ - gpio_output(GPP_C11, 1); - mdelay(4); - gpio_output(GPP_A12, 1); + switch (sku_id) { + case SKU_2_DRATINI: + case SKU_4_DRATINI: + case SKU_6_DRATINI: + case SKU_8_DRATINI: + case SKU_21_DRAGONAIR: + case SKU_22_DRAGONAIR: + /* + * Enable power to FPMCU, wait for power rail to stabilize, + * and then deassert FPMCU reset. + * Waiting for the power rail to stabilize can take a while, + * a minimum of 400us on Kohaku. + */ + gpio_output(GPP_C11, 1); + mdelay(4); + gpio_output(GPP_A12, 1); + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/83745?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ifc450f51b00b9c3b62268ce94884f5749a3e18c0 Gerrit-Change-Number: 83745 Gerrit-PatchSet: 1 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com>

1 0

[S] Change in coreboot[main]: mb/google/hatch: Add FP enable for Dratini
by ChromeOS coreboot bot (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Jon Murphy, Nick Vaccaro, Subrata Banik. Hello Jon Murphy, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/83744?usp=email to review the following change. Change subject: mb/google/hatch: Add FP enable for Dratini ...................................................................... mb/google/hatch: Add FP enable for Dratini Add FP enable/disable based on SKU ID for Dratini. This is meant to resolve a UMA issue with Dratini devices that had the FPMCU populated on non-fp devices. Since the FPMCU is present, and the firmware enables the power GPIO's based on variant, not SKU, the devices were reporting data on fingerprint errantly. BUG=b:354769653 TEST=Flash to Dratini, test FP. Disable test SKU, flash on Dratini, test FP. Change-Id: I2b30d70082062bc4a5fdb0e2eeca4b37af1613d9 Signed-off-by: Jon Murphy <jpmurphy(a)google.com> --- M src/mainboard/google/hatch/variants/dratini/include/variant/sku.h M src/mainboard/google/hatch/variants/dratini/ramstage.c 2 files changed, 25 insertions(+), 9 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/83744/1 diff --git a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h index c44e0db..89f6708 100644 --- a/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h +++ b/src/mainboard/google/hatch/variants/dratini/include/variant/sku.h @@ -4,6 +4,14 @@ #define __MAINBOARD_SKU_H__ enum { + SKU_1_DRATINI = 1, + SKU_2_DRATINI = 2, + SKU_3_DRATINI = 3, + SKU_4_DRATINI = 4, + SKU_5_DRATINI = 5, + SKU_6_DRATINI = 6, + SKU_7_DRATINI = 7, + SKU_8_DRATINI = 8, SKU_21_DRAGONAIR = 21, SKU_22_DRAGONAIR = 22, SKU_23_DRAGONAIR = 23, diff --git a/src/mainboard/google/hatch/variants/dratini/ramstage.c b/src/mainboard/google/hatch/variants/dratini/ramstage.c index 240bcae..f5c98b5 100644 --- a/src/mainboard/google/hatch/variants/dratini/ramstage.c +++ b/src/mainboard/google/hatch/variants/dratini/ramstage.c @@ -6,13 +6,21 @@ void variant_ramstage_init(void) { - /* - * Enable power to FPMCU, wait for power rail to stabilize, - * and then deassert FPMCU reset. - * Waiting for the power rail to stabilize can take a while, - * a minimum of 400us on Kohaku. - */ - gpio_output(GPP_C11, 1); - mdelay(4); - gpio_output(GPP_A12, 1); + switch (sku_id) { + case SKU_2_DRATINI: + case SKU_4_DRATINI: + case SKU_6_DRATINI: + case SKU_8_DRATINI: + case SKU_21_DRAGONAIR: + case SKU_22_DRAGONAIR: + /* + * Enable power to FPMCU, wait for power rail to stabilize, + * and then deassert FPMCU reset. + * Waiting for the power rail to stabilize can take a while, + * a minimum of 400us on Kohaku. + */ + gpio_output(GPP_C11, 1); + mdelay(4); + gpio_output(GPP_A12, 1); + } } -- To view, visit https://review.coreboot.org/c/coreboot/+/83744?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2b30d70082062bc4a5fdb0e2eeca4b37af1613d9 Gerrit-Change-Number: 83744 Gerrit-PatchSet: 1 Gerrit-Owner: ChromeOS coreboot bot <chromeos-coreboot-bot(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>

1 0

[XS] Change in coreboot[main]: UPSTREAM: Revert "PPM: Enable driver by default"
by ChromeOS coreboot bot (Code Review) 02 Aug '24

02 Aug '24

1 0

[M] Change in coreboot[main]: UPSTREAM: ec_commands: Add PDC tracing host commands
by ChromeOS coreboot bot (Code Review) 02 Aug '24

02 Aug '24

Attention is currently required from: Caveh Jalali, Forest Mittelberg. ChromeOS coreboot bot has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83742?usp=email ) Change subject: UPSTREAM: ec_commands: Add PDC tracing host commands ...................................................................... UPSTREAM: ec_commands: Add PDC tracing host commands Add EC_CMD_PDC_TRACE_MSG_ENABLE and EC_CMD_PDC_TRACE_GET_ENTRIES host commands for controlling PDC message tracing and capturing on the EC. BUG=b:336660528 TEST=tested with ectool patches later in this series Original-Change-Id: If693006e931149cf3bea44716f56e8a3d9126419 Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/5552811 Original-Code-Coverage: Zoss <zoss-cl-coverage(a)prod.google.com> Original-Tested-by: caveh jalali <caveh(a)chromium.org> Original-Reviewed-by: Tristan Honscheid <honscheid(a)google.com> Original-Commit-Queue: caveh jalali <caveh(a)chromium.org> GitOrigin-RevId: f15e662629c1965787c401b7d99d17de1d4235bb Change-Id: I5f87f11100b362070cafb3504abe8f37876a6cfa --- M src/ec/google/chromeec/ec_cmd_api.h M src/ec/google/chromeec/ec_commands.h 2 files changed, 71 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/83742/1 diff --git a/src/ec/google/chromeec/ec_cmd_api.h b/src/ec/google/chromeec/ec_cmd_api.h index cab69b7..7bdfe17 100644 --- a/src/ec/google/chromeec/ec_cmd_api.h +++ b/src/ec/google/chromeec/ec_cmd_api.h @@ -373,6 +373,8 @@ _CROS_EC_CV_F_P(EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT, 0, override_dedicated_charger_limit, dedicated_charger_limit); _CROS_EC_C0_F_RF(EC_CMD_PCHG_COUNT, pchg_count); +_CROS_EC_C0_F_PF_RF(EC_CMD_PDC_TRACE_MSG_ENABLE, pdc_trace_msg_enable); +_CROS_EC_C0_F_RF(EC_CMD_PDC_TRACE_MSG_GET_ENTRIES, pdc_trace_msg_get_entries); _CROS_EC_CV_F_P(EC_CMD_PD_CHARGE_PORT_OVERRIDE, 0, pd_charge_port_override, charge_port_override); _CROS_EC_CV_F_P_R(EC_CMD_PD_CHIP_INFO, 2, pd_chip_info_v2, pd_chip_info, diff --git a/src/ec/google/chromeec/ec_commands.h b/src/ec/google/chromeec/ec_commands.h index 71cd287..914f580 100644 --- a/src/ec/google/chromeec/ec_commands.h +++ b/src/ec/google/chromeec/ec_commands.h @@ -8053,6 +8053,75 @@ uint32_t time; } __ec_align2; +/* + * Control PDC tracing. + * EC_PDC_TRACE_MSG_PORT_NONE disable tracing + * EC_PDC_TRACE_MSG_PORT_ALL enable tracing on all ports + * else, enable tracing on a specific port. + */ + +#define EC_CMD_PDC_TRACE_MSG_ENABLE 0x0143 + +#define EC_PDC_TRACE_MSG_PORT_NONE 0xff +#define EC_PDC_TRACE_MSG_PORT_ALL 0xfe + +struct ec_params_pdc_trace_msg_enable { + uint8_t port; +}; + +struct ec_response_pdc_trace_msg_enable { + /* Previous port value. */ + uint8_t port; + uint8_t reserved; + /* Number of free bytes in FIFO. */ + uint16_t fifo_free; + /* Running total of dropped messages (may wrap). */ + uint32_t dropped_count; +} __ec_align4; + +/* + * Fetch multiple PDC trace entries. + * + * If no entries are available, pl_size is 0. + * At most MAX_HC_PDC_TRACE_MSG_GET_PAYLOAD bytes worth of entries + * are returned. Only whole entries are returned. + */ + +#define EC_CMD_PDC_TRACE_MSG_GET_ENTRIES 0x0144 +#define MAX_HC_PDC_TRACE_MSG_GET_PAYLOAD 240 + +struct ec_response_pdc_trace_msg_get_entries { + /* Total bytes of payload. */ + uint16_t pl_size; + /* Packed array of pdc_trace_msg_entry structs. */ + uint8_t payload[FLEXIBLE_ARRAY_MEMBER_SIZE]; +}; + +enum pdc_trace_msg_direction { + PDC_TRACE_MSG_DIR_IN = 0, + PDC_TRACE_MSG_DIR_OUT = 1, +}; + +struct pdc_trace_msg_entry { + /* + * Timestamp - least significant 32 bits of EC epoch time + * (microseconds, will wrap around). + */ + uint32_t time32_us; + /* Entry sequence number (wraps around). */ + uint16_t seq_num; + /* Port number associated with this entry. */ + uint8_t port_num; + /* Direction of message (enum pdc_trace_msg_direction) */ + uint8_t direction; + /* Format of pdc_data (PDC chip identifier). */ + uint8_t msg_type; + /* Bytes in pdc_data. */ + uint8_t pdc_data_size; + /* Captured PDC message. */ + uint8_t pdc_data[0]; +} __ec_align1; + /*****************************************************************************/ /* The command range 0x200-0x2FF is reserved for Rotor. */ -- To view, visit https://review.coreboot.org/c/coreboot/+/83742?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f87f11100b362070cafb3504abe8f37876a6cfa Gerrit-Change-Number: 83742 Gerrit-PatchSet: 1 Gerrit-Owner: ChromeOS coreboot bot <chromeos-coreboot-bot(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Forest Mittelberg <bmbm(a)google.com> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org> Gerrit-Attention: Forest Mittelberg <bmbm(a)google.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2024