Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83750?usp=email )
Change subject: mb/google/rex: Skip UART0 config in FSP
......................................................................
mb/google/rex: Skip UART0 config in FSP
UART0 is already configured in coreboot, so this change sets SerialIo
config for UART0 to PchSerialIoSkipInit to skip initialization in FSP.
BUG=none
TEST=Able to build and boot google/rex0. Able to see all debug prints
over CPU uart.
Change-Id: I37744f05083eb82ba8ca579b628b69aa976e3d1f
Signed-off-by: Subrata Banik <subratabanik(a)google.com>
---
M src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/83750/1
diff --git a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
index 1a80e2a..00acbec 100644
--- a/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
+++ b/src/mainboard/google/rex/variants/baseboard/rex/devicetree.cb
@@ -73,7 +73,7 @@
register "skip_ext_gfx_scan" = "1"
register "serial_io_uart_mode" = "{
- [PchSerialIoIndexUART0] = PchSerialIoPci,
+ [PchSerialIoIndexUART0] = PchSerialIoSkipInit,
[PchSerialIoIndexUART1] = PchSerialIoDisabled,
[PchSerialIoIndexUART2] = PchSerialIoDisabled,
}"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83750?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I37744f05083eb82ba8ca579b628b69aa976e3d1f
Gerrit-Change-Number: 83750
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Weimin Wu.
zhongtian wu has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83704?usp=email )
Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb
Gerrit-Change-Number: 83704
Gerrit-PatchSet: 7
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 02 Aug 2024 06:46:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Weimin Wu, zhongtian wu.
Hello Eric Lai, Karthik Ramasubramanian, build bot (Jenkins), zhongtian wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83704?usp=email
to look at the new patch set (#7).
The following approvals got outdated and were removed:
Code-Review+1 by zhongtian wu, Verified+1 by build bot (Jenkins)
Change subject: mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
......................................................................
mb/google/dedede/var/awasuki: Enable ELAN touchscreen with fw_config
1. Change driver form i2c/hid to i2c/generic.
2. Add fw_config for touchscreen.
BUG=b:351968527
TEST=ectool cbi set 6 0x0x10200a0;
touchscreen functions normally;
Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb
Signed-off-by: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/awasuki/overridetree.cb
M src/mainboard/google/dedede/variants/awasuki/ramstage.c
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
3 files changed, 47 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/83704/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/83704?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifd6330be8924d4873f0efab3ce404168a62099eb
Gerrit-Change-Number: 83704
Gerrit-PatchSet: 7
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-CC: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zhongtian wu <wuzhongtian(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Xixi Chen has abandoned this change. ( https://review.coreboot.org/c/blobs/+/71903?usp=email )
Change subject: TEST-ONLY: mt8188: dram LV
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/blobs/+/71903?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I20bdf51103e7f9227b85c075597589484abfe98d
Gerrit-Change-Number: 71903
Gerrit-PatchSet: 3
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Xixi Chen has abandoned this change. ( https://review.coreboot.org/c/blobs/+/71904?usp=email )
Change subject: TEST-ONLY: mt8188: dram HV
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/blobs/+/71904?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: abandon
Gerrit-Project: blobs
Gerrit-Branch: main
Gerrit-Change-Id: I58654e3aba0765494063b3e14aa9d1399352a8e4
Gerrit-Change-Number: 71904
Gerrit-PatchSet: 2
Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com>
Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83746?usp=email )
Change subject: mb/google/brya/var/trulo: Remove mux references from typec port
......................................................................
mb/google/brya/var/trulo: Remove mux references from typec port
The Type-C kernel driver no longer programs the AP mux. So remove device
references to the TCSS Mux control device from the Type-C port driver.
BUG=b:351117685
TEST=USB-C drive can be detected after system warm or cold reboot.
Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a
Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83746
Reviewed-by: Subrata Banik <subratabanik(a)google.com>
Reviewed-by: Dinesh Gehlot <digehlot(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Eric Lai <ericllai(a)google.com>
---
M src/mainboard/google/brya/variants/trulo/overridetree.cb
1 file changed, 1 insertion(+), 12 deletions(-)
Approvals:
Dinesh Gehlot: Looks good to me, approved
Eric Lai: Looks good to me, approved
build bot (Jenkins): Verified
Subrata Banik: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/trulo/overridetree.cb b/src/mainboard/google/brya/variants/trulo/overridetree.cb
index d7fca12..510053f 100644
--- a/src/mainboard/google/brya/variants/trulo/overridetree.cb
+++ b/src/mainboard/google/brya/variants/trulo/overridetree.cb
@@ -525,21 +525,10 @@
device ref uart0 on end
device ref pch_espi on
chip ec/google/chromeec
- use conn0 as mux_conn[0]
device pnp 0c09.0 on end
end
end
- device ref pmc hidden
- chip drivers/intel/pmc_mux
- device generic 0 on
- chip drivers/intel/pmc_mux/conn
- use usb2_port5 as usb2_port
- use tcss_usb3_port1 as usb3_port
- device generic 0 alias conn0 on end
- end
- end
- end
- end
+ device ref pmc hidden end
device ref hda on
chip drivers/sof
register "spkr_tplg" = "max98360a"
--
To view, visit https://review.coreboot.org/c/coreboot/+/83746?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2fd6e8fcebd194da03ba3f264ee89037ca11769a
Gerrit-Change-Number: 83746
Gerrit-PatchSet: 3
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Rishika Raj <rishikaraj(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>