Nico Huber has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: mb/acer/g43t-am3: Rework mainboard for variant mechanism
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Please remove the originals of the duplicated files.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Sun, 18 Aug 2024 13:18:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Elyes Haouas, Julia.
Felix Singer has posted comments on this change by Julia. ( https://review.coreboot.org/c/coreboot/+/83968?usp=email )
Change subject: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2654ca4b198bfea409992be14e89702cf67ea50
Gerrit-Change-Number: 83968
Gerrit-PatchSet: 3
Gerrit-Owner: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:55:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Julia, Michael Büchler, Paul Menzel.
Felix Singer has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: mb/acer/g43t-am3: Rework mainboard for variant mechanism
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57764/comment/08164ad3_6e75e23d?us… :
PS2, Line 9: a new board
> … the new board Acer Q45T-AM …
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Elyes Haouas, Julia, Michael Büchler, Paul Menzel.
Felix Singer has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: mb/acer/g43t-am3: Rework mainboard for variant mechanism
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:54:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Elyes Haouas, Julia.
Felix Singer has posted comments on this change by Julia. ( https://review.coreboot.org/c/coreboot/+/83968?usp=email )
Change subject: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/acer/g43t-am3/variants/q45t-am/early_init.c:
https://review.coreboot.org/c/coreboot/+/83968/comment/266b7e19_34afe590?us… :
PS3, Line 4: <southbridge/intel/i82801jx/i82801jx.h>
> not used
Acknowledged. Will be done in a follow-up.
https://review.coreboot.org/c/coreboot/+/83968/comment/e710b1c5_fd0ad30f?us… :
PS3, Line 7: <superio/ite/it8720f/it8720f.h>
> not used
Acknowledged. Will be done in a follow-up.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2654ca4b198bfea409992be14e89702cf67ea50
Gerrit-Change-Number: 83968
Gerrit-PatchSet: 3
Gerrit-Owner: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:54:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Elyes Haouas, Julia, Michael Büchler, Paul Menzel.
Felix Singer has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: mb/acer/g43t-am3: Rework mainboard for variant mechanism
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/acer/g43t-am3/variants/g43t-am3/early_init.c:
https://review.coreboot.org/c/coreboot/+/57764/comment/2241918c_8e6ea6d3?us… :
PS4, Line 4: #include <southbridge/intel/i82801jx/i82801jx.h>
> looks like this one is not used.
Unrelated to this patch. It only reworks the mainboard that variants can be used. Clean ups can be done later. Done.
https://review.coreboot.org/c/coreboot/+/57764/comment/01c18252_1308236a?us… :
PS4, Line 7: #include <superio/ite/it8720f/it8720f.h>
> this is not used.
Unrelated to this patch. It only reworks the mainboard that variants can be used. Clean ups can be done later. Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:54:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Julia.
Elyes Haouas has posted comments on this change by Julia. ( https://review.coreboot.org/c/coreboot/+/83968?usp=email )
Change subject: mb/acer/g43t-am3: Add Acer Q45T-AM as a variant
......................................................................
Patch Set 3:
(2 comments)
File src/mainboard/acer/g43t-am3/variants/q45t-am/early_init.c:
https://review.coreboot.org/c/coreboot/+/83968/comment/38661357_66b07b46?us… :
PS3, Line 4: <southbridge/intel/i82801jx/i82801jx.h>
not used
https://review.coreboot.org/c/coreboot/+/83968/comment/07819c6d_7473ba07?us… :
PS3, Line 7: <superio/ite/it8720f/it8720f.h>
not used
--
To view, visit https://review.coreboot.org/c/coreboot/+/83968?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2654ca4b198bfea409992be14e89702cf67ea50
Gerrit-Change-Number: 83968
Gerrit-PatchSet: 3
Gerrit-Owner: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:32:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Julia, Michael Büchler, Paul Menzel.
Elyes Haouas has posted comments on this change by Michael Büchler. ( https://review.coreboot.org/c/coreboot/+/57764?usp=email )
Change subject: mb/acer/g43t-am3: Rework mainboard for variant mechanism
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/acer/g43t-am3/variants/g43t-am3/early_init.c:
https://review.coreboot.org/c/coreboot/+/57764/comment/f9d12e6d_7f5abf4c?us… :
PS4, Line 4: #include <southbridge/intel/i82801jx/i82801jx.h>
looks like this one is not used.
https://review.coreboot.org/c/coreboot/+/57764/comment/191824c1_42902c9b?us… :
PS4, Line 7: #include <superio/ite/it8720f/it8720f.h>
this is not used.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57764?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I425852f4bdacf7cb6688a5fb845ac3001373262e
Gerrit-Change-Number: 57764
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Reviewer: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Julia <launchpad.vineyard395(a)passinbox.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net>
Gerrit-Comment-Date: Sun, 18 Aug 2024 10:30:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No