Attention is currently required from: Anil Kumar K.
Subrata Banik has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 11:
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
PS11:
> while i'm all for avoiding duplicate code, i don't like this approach too much, since when adding the drivers_soundwire_alc711 chip in the devicetree, the actual behavior will depend on which kconfig option is selected and those two options will also more or less be mutually exclusive, so its not possible to have both in a system using one firmware image; not even as different codec options where only one will be present on the board
Are you asking if we can build a mainboard with ALC711 or ALC722, and handle both from the same device tree? If we encounter such an issue, then we need to create another variant, because a single board will not be able to select both DRIVERS_SOUNDWIRE_ALC722 and DRIVERS_SOUNDWIRE_ALC711 as they share the same driver.
--
To view, visit https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 11
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Naveen M <naveen.m(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-CC: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:32:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Kapil Porwal, Pranava Y N, Saurabh Mishra, Subrata Banik.
Felix Held has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83962?usp=email )
Change subject: soc/intel/pantherlake: Switch to SOC_INTEL_COMMON_DEBUG_CONSENT
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83962?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36bbe14d02654ed9dbda21df0d9a6a6769b87754
Gerrit-Change-Number: 83962
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Pranava Y N <pranavayn(a)google.com>
Gerrit-Reviewer: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Pranava Y N <pranavayn(a)google.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:27:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Eran Mitrani, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun.
Felix Held has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/83961?usp=email )
Change subject: soc/intel/meteorlake: Switch to SOC_INTEL_COMMON_DEBUG_CONSENT
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83961?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I657d20a38e15eee333a4e45c0c600736148173d4
Gerrit-Change-Number: 83961
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:27:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83629?usp=email )
Change subject: ec/starlabs/merlin: Remove ITE mirror functionality
......................................................................
ec/starlabs/merlin: Remove ITE mirror functionality
Remove the ITE mirror functionality; all devices will mirror
automatically when they exit G3, and this is good enough.
Change-Id: I9b82e1b1386b4607dfe7da9b25ba432ec0303cf8
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83629
Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/ec/starlabs/merlin/Kconfig
M src/ec/starlabs/merlin/ec.h
M src/ec/starlabs/merlin/ite.c
M src/mainboard/starlabs/lite/cmos.default
M src/mainboard/starlabs/lite/cmos.layout
M src/mainboard/starlabs/lite/variants/glkr/cmos.default
M src/mainboard/starlabs/lite/variants/glkr/cmos.layout
M src/mainboard/starlabs/starbook/cmos.default
M src/mainboard/starlabs/starbook/cmos.layout
M src/mainboard/starlabs/starbook/variants/tgl/cmos.default
M src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
11 files changed, 0 insertions(+), 61 deletions(-)
Approvals:
Matt DeVillier: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/ec/starlabs/merlin/Kconfig b/src/ec/starlabs/merlin/Kconfig
index 5a35b51..9f05991 100644
--- a/src/ec/starlabs/merlin/Kconfig
+++ b/src/ec/starlabs/merlin/Kconfig
@@ -64,20 +64,6 @@
help
Select if the mainboard supports limiting the maximum charge of the battery.
-config EC_STARLABS_MIRROR_SUPPORT
- bool "Enable mirror flag support"
- default n
- depends on EC_STARLABS_ITE
- help
- Select if the EC should mirror the EC firmware contained in the coreboot ROM.
-
-config EC_STARLABS_MIRROR_VERSION
- hex "Version of the EC firmware that should be installed."
- depends on EC_STARLABS_MIRROR_SUPPORT
- help
- The version of the EC that should be installed. The mirror flag will be activated
- if this Kconfig option is set and it does not match the current EC version.
-
config EC_STARLABS_MERLIN
bool "Use open-source Merlin EC Firmware"
default n
diff --git a/src/ec/starlabs/merlin/ec.h b/src/ec/starlabs/merlin/ec.h
index 0528816..ca1d081 100644
--- a/src/ec/starlabs/merlin/ec.h
+++ b/src/ec/starlabs/merlin/ec.h
@@ -98,11 +98,6 @@
#define KBL_DISABLED 0x00
#define KBL_ENABLED 0xdd
-/* Mirror Flag */
-#define MIRROR_DISABLED 0x00
-#define MIRROR_ENABLED 0xaa
-
uint16_t ec_get_version(void);
-void ec_mirror_flag(void);
#endif
diff --git a/src/ec/starlabs/merlin/ite.c b/src/ec/starlabs/merlin/ite.c
index c4e0d1e..031447a 100644
--- a/src/ec/starlabs/merlin/ite.c
+++ b/src/ec/starlabs/merlin/ite.c
@@ -25,34 +25,6 @@
return lut[index];
}
-void ec_mirror_flag(void)
-{
- /*
- * For the mirror flag to work, the status of the EC pin must be known
- * at all times, which means external power. This can be either a DC
- * charger, or PD with CCG6. PD with an ANX7447 requires configuration
- * from the EC, so the update will interrupt this.
- *
- * This means we can unconditionally apply the mirror flag to devices
- * that have CCG6, present on devices with TBT, but have a manual
- * flag for devices without it.
- */
- uint16_t ec_version = ec_get_version();
-
- /* Full mirror support was added in EC 1.18 (0x0112) */
- if (ec_version < 0x0112)
- return;
-
- if (CONFIG(EC_STARLABS_MIRROR_SUPPORT) &&
- (CONFIG(DRIVERS_INTEL_USB4_RETIMER) || get_uint_option("mirror_flag", 0)) &&
- (ec_version != CONFIG_EC_STARLABS_MIRROR_VERSION)) {
- printk(BIOS_ERR, "ITE: EC version 0x%x doesn't match coreboot version 0x%x.\n",
- ec_version, CONFIG_EC_STARLABS_MIRROR_VERSION);
-
- ec_write(ECRAM_MIRROR_FLAG, MIRROR_ENABLED);
- }
-}
-
static uint16_t ec_get_chip_id(unsigned int port)
{
return (pnp_read_index(port, ITE_CHIPID1) << 8) |
@@ -84,8 +56,6 @@
return;
}
- ec_mirror_flag();
-
/*
* Restore settings from CMOS into EC RAM:
*
diff --git a/src/mainboard/starlabs/lite/cmos.default b/src/mainboard/starlabs/lite/cmos.default
index 76ea289..7bf045b 100644
--- a/src/mainboard/starlabs/lite/cmos.default
+++ b/src/mainboard/starlabs/lite/cmos.default
@@ -14,7 +14,6 @@
# EC
kbl_timeout=30 seconds
fn_ctrl_swap=Disable
-mirror_flag=Disable
# Functions
fn_lock_state=0x1
trackpad_state=0x1
diff --git a/src/mainboard/starlabs/lite/cmos.layout b/src/mainboard/starlabs/lite/cmos.layout
index d594c76..ca77291 100644
--- a/src/mainboard/starlabs/lite/cmos.layout
+++ b/src/mainboard/starlabs/lite/cmos.layout
@@ -28,8 +28,6 @@
# coreboot config options: EC
600 3 e 4 kbl_timeout
608 1 e 1 fn_ctrl_swap
-616 1 e 1 mirror_flag
-624 4 h 0 mirror_flag_counter
# coreboot config options: check sums
984 16 h 0 check_sum
diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.default b/src/mainboard/starlabs/lite/variants/glkr/cmos.default
index 97cbac9..6bf32d0 100644
--- a/src/mainboard/starlabs/lite/variants/glkr/cmos.default
+++ b/src/mainboard/starlabs/lite/variants/glkr/cmos.default
@@ -15,7 +15,6 @@
kbl_timeout=30 seconds
fn_ctrl_swap=Disable
fast_charge=Normal
-mirror_flag=Disable
# Functions
fn_lock_state=0x1
trackpad_state=0x1
diff --git a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout
index 8fa5725..edca818 100644
--- a/src/mainboard/starlabs/lite/variants/glkr/cmos.layout
+++ b/src/mainboard/starlabs/lite/variants/glkr/cmos.layout
@@ -29,8 +29,6 @@
600 3 e 4 kbl_timeout
608 1 e 1 fn_ctrl_swap
616 1 e 11 fast_charge
-624 1 e 1 mirror_flag
-632 4 h 0 mirror_flag_counter
# coreboot config options: check sums
984 16 h 0 check_sum
diff --git a/src/mainboard/starlabs/starbook/cmos.default b/src/mainboard/starlabs/starbook/cmos.default
index 879ee4f..6f44bdb 100644
--- a/src/mainboard/starlabs/starbook/cmos.default
+++ b/src/mainboard/starlabs/starbook/cmos.default
@@ -18,7 +18,6 @@
# EC
kbl_timeout=30 seconds
fn_ctrl_swap=Disable
-mirror_flag=Disable
# Functions
fn_lock_state=0x1
trackpad_state=0x1
diff --git a/src/mainboard/starlabs/starbook/cmos.layout b/src/mainboard/starlabs/starbook/cmos.layout
index f534630..505f49f 100644
--- a/src/mainboard/starlabs/starbook/cmos.layout
+++ b/src/mainboard/starlabs/starbook/cmos.layout
@@ -38,8 +38,6 @@
608 1 e 1 fn_ctrl_swap
616 2 e 8 max_charge
624 2 e 9 fan_mode
-632 1 e 1 mirror_flag
-640 4 h 0 mirror_flag_counter
# coreboot config options: check sums
984 16 h 0 check_sum
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default
index 6192e41..fada05c 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.default
+++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.default
@@ -18,7 +18,6 @@
# EC
kbl_timeout=30 seconds
fn_ctrl_swap=Disable
-mirror_flag=Disable
# Functions
fn_lock_state=0x1
trackpad_state=0x1
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
index aed755c..51e6c15 100644
--- a/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
+++ b/src/mainboard/starlabs/starbook/variants/tgl/cmos.layout
@@ -38,8 +38,6 @@
608 1 e 1 fn_ctrl_swap
616 2 e 8 max_charge
624 2 e 9 fan_mode
-632 1 e 1 mirror_flag
-640 4 h 0 mirror_flag_counter
# coreboot config options: check sums
984 16 h 0 check_sum
--
To view, visit https://review.coreboot.org/c/coreboot/+/83629?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9b82e1b1386b4607dfe7da9b25ba432ec0303cf8
Gerrit-Change-Number: 83629
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Attention is currently required from: Arthur Heymans, Christian Walter, Cliff Huang, Felix Singer, Fred Reitberger, Jason Glenesk, Jeff Daly, Johnny Lin, Jonathan Zhang, Lance Zhao, Lean Sheng Tan, Martin Roth, Matt DeVillier, Nico Huber, Patrick Rudolph, Raul Rangel, Shuo Liu, Tim Chu, Tim Wawrzynczak, Vanessa Eusebio.
Felix Held has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/76128?usp=email )
Change subject: acpi: Move HPET generation to a common location
......................................................................
Patch Set 13:
(1 comment)
File src/acpi/Kconfig:
https://review.coreboot.org/c/coreboot/+/76128/comment/77568675_00d1a92f?us… :
PS13, Line 134: depends on HAVE_ACPI_TABLES
> +1
ok, so we have a plan :) i'll update the patch when i find some time for that
--
To view, visit https://review.coreboot.org/c/coreboot/+/76128?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I38b9962a8d568267356256a3edc51348b9417e20
Gerrit-Change-Number: 76128
Gerrit-PatchSet: 13
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com>
Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Shuo Liu <shuo.liu(a)intel.com>
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Joel Linn, Matt DeVillier, Nicholas Sudsgaard, Paul Menzel, Vladimir Serbinenko.
Felix Held has posted comments on this change by Vladimir Serbinenko. ( https://review.coreboot.org/c/coreboot/+/82737?usp=email )
Change subject: superio/ite/it8728f: Support setting power state after power failure
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
haven\t checked the datasheet, but since Matt already +2ed the patch and from a quick look it also looks good to me, i'll also +2 it, so that it can be submitted after Matt rebased it
--
To view, visit https://review.coreboot.org/c/coreboot/+/82737?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3dcc4f032bc5f629fb916c4122beb8dc096bab20
Gerrit-Change-Number: 82737
Gerrit-PatchSet: 5
Gerrit-Owner: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nicholas Sudsgaard <devel+coreboot(a)nsudsgaard.com>
Gerrit-Attention: Joel Linn <jl_coreboot(a)conductive.de>
Gerrit-Attention: Vladimir Serbinenko <phcoder(a)gmail.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:09:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Anil Kumar K.
Felix Held has posted comments on this change by Anil Kumar K. ( https://review.coreboot.org/c/coreboot/+/81920?usp=email )
Change subject: drivers/soundwire: Support Realtek ALC722 codec
......................................................................
Patch Set 11:
(1 comment)
File src/drivers/soundwire/alc711/alc711.c:
PS11:
while i'm all for avoiding duplicate code, i don't like this approach too much, since when adding the drivers_soundwire_alc711 chip in the devicetree, the actual behavior will depend on which kconfig option is selected and those two options will also more or less be mutually exclusive, so its not possible to have both in a system using one firmware image; not even as different codec options where only one will be present on the board
--
To view, visit https://review.coreboot.org/c/coreboot/+/81920?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieb16a1c6f3a79321fdc35987468daa8be33b6e49
Gerrit-Change-Number: 81920
Gerrit-PatchSet: 11
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anil Kumar K <anil.kumar.k(a)intel.corp-partner.google.com>
Gerrit-CC: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com>
Gerrit-CC: Naveen M <naveen.m(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-CC: Sathyanarayana Nujella <sathyanarayana.nujella(a)intel.com>
Gerrit-CC: Saurabh Mishra <mishra.saurabh(a)intel.com>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Comment-Date: Tue, 20 Aug 2024 13:08:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No