Attention is currently required from: Dolan Liu, Eric Lai, Lawrence Chang, Weimin Wu.
Karthik Ramasubramanian has posted comments on this change by Weimin Wu. ( https://review.coreboot.org/c/coreboot/+/83496?usp=email )
Change subject: mb/google/dedede/var/awasuki: Initialise overridetree
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83496?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie8194b6eca3e88f08f92e0ac8a9063b8de738652
Gerrit-Change-Number: 83496
Gerrit-PatchSet: 8
Gerrit-Owner: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Dolan Liu <liuyong5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Lawrence Chang <lawrence.chang(a)intel.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 15:52:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Arthur Heymans, Jérémy Compostella, Martin L Roth, Yu-Ping Wu.
Karthik Ramasubramanian has posted comments on this change by Yu-Ping Wu. ( https://review.coreboot.org/c/coreboot/+/83594?usp=email )
Change subject: arch/x86/Kconfig: Stop building ARM verstage with clang
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83594/comment/1c10662b_696a624e?us… :
PS1, Line 9: We have never intended to build ARM verstage with clang (see CB:69701).
> > That was my intention though. Why is building ARM verstage with clang a problem? […]
The moment we try to pull in CMOS related support into ARM/PSP verstage (CB:83495), we are running out of space in PSP SRAM i.e. text, data and bss sections together are going beyond their allocated range in psp_verstage memlayout. This is happening only with clang. GCC builds fine.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83594?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I033458556986ade88fb8e68499b632deae4dd419
Gerrit-Change-Number: 83594
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 15:50:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Arthur Heymans, Elyes Haouas, Krystian Hebel.
Sergii Dmytruk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/coreboot/+/67065?usp=email )
Change subject: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
......................................................................
Patch Set 40:
(1 comment)
File src/soc/ibm/power9/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/67065/comment/02d4a474_bbfa3c70?us… :
PS39, Line 17: ifneq ($(CONFIG_SIGNING_KEYS_DIR),"")
> Isn't it reversed now?
I thought I undone it after considering swapping branches. I thought I updated commit message too...
--
To view, visit https://review.coreboot.org/c/coreboot/+/67065?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d
Gerrit-Change-Number: 67065
Gerrit-PatchSet: 40
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Patrick Georgi
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:51:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Attention is currently required from: Arthur Heymans, Elyes Haouas, Sergii Dmytruk.
Hello Elyes Haouas, Krystian Hebel, Martin L Roth, Michał Żygowski, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/67065?usp=email
to look at the new patch set (#40).
Change subject: 3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
......................................................................
3rdparty/open-power-signing-utils: add SecureBoot utility for OpenPOWER
Signing is performed with test keys by default, set
CONFIG_SIGNING_KEYS_DIR to a non-empty value to use other keys.
Depending on the version of the Talos II firmware this alone might not
allow booting because coreboot replaces only part of the stock firmware
and its newer versions enable secure boot by default (not to be confused
with SecureBoot in EFI). The signing performed in this commit is still
a prerequisite and might as well be done on its own. Fixing operation
with newer stock firmware will be done in a follow-up change.
Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
---
M .gitmodules
A 3rdparty/open-power-signing-utils
M Makefile.mk
M src/soc/ibm/power9/Kconfig
M src/soc/ibm/power9/Makefile.mk
5 files changed, 51 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/67065/40
--
To view, visit https://review.coreboot.org/c/coreboot/+/67065?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id88baef5ecb1f8ffd74a7f464bbbaaaea0ca643d
Gerrit-Change-Number: 67065
Gerrit-PatchSet: 40
Gerrit-Owner: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Patrick Georgi
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83443?usp=email )
Change subject: soc/amd/*/root_complex: introduce and use domain_iohc_info struct
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/root_complex/root_complex.c:
https://review.coreboot.org/c/coreboot/+/83443/comment/132cab02_8c470dc3?us… :
PS1, Line 15: domain->path.domain.domain
> dev_get_domain is the function i was thinking of
ah, no, that one does something different
--
To view, visit https://review.coreboot.org/c/coreboot/+/83443?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifce3d2b540d14ba3cba36f7cbf248fb7c63483fe
Gerrit-Change-Number: 83443
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Fred Reitberger, Jason Glenesk, Martin L Roth, Martin Roth, Matt DeVillier.
Felix Held has posted comments on this change by Felix Held. ( https://review.coreboot.org/c/coreboot/+/83443?usp=email )
Change subject: soc/amd/*/root_complex: introduce and use domain_iohc_info struct
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/common/block/root_complex/root_complex.c:
https://review.coreboot.org/c/coreboot/+/83443/comment/fedec8f5_e3d13917?us… :
PS1, Line 15: domain->path.domain.domain
> yeah, there are bit too many 'domain' in there. […]
dev_get_domain is the function i was thinking of
--
To view, visit https://review.coreboot.org/c/coreboot/+/83443?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ifce3d2b540d14ba3cba36f7cbf248fb7c63483fe
Gerrit-Change-Number: 83443
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:45:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Attention is currently required from: Dinesh Gehlot, Elyes Haouas, Nico Huber, Paul Menzel.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/81522?usp=email )
Change subject: gma display_probing: Make new TGL ports available
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
File common/hw-gfx-gma-display_probing.ads:
https://review.coreboot.org/c/libgfxinit/+/81522/comment/45a768f2_074ad2e9?… :
PS4, Line 26: USBC1_HDMI, USBC2_HDMI, USBC3_HDMI, USBC4_HDMI, USBC5_HDMI, USBC6_HDMI,
> Yeah, what I mean is that I see DP ports being handled, but I don't see where HDMI is handled. […]
Ack
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Gerrit-Change-Number: 81522
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:31:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83598?usp=email )
Change subject: transcoder: Don't try to disable disabled DDI func
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File common/hw-gfx-gma-transcoder.adb:
https://review.coreboot.org/c/libgfxinit/+/83598/comment/9a3b21f1_112171bb?… :
PS1, Line 376: Registers.Is_Set_Mask (Trans.DDI_FUNC_CTL, DDI_FUNC_CTL_ENABLE, Enabled);
(to `Registers.Is_Set_Mask`) WHY are you not a function??? /s
I guess it's because it has side-effects
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Ia505422570d967b192fe2eb8cab10f305aff3dd7
Gerrit-Change-Number: 83598
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:27:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes