Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#34) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67494?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma pipe_setup: Update for TGL & ADL
......................................................................
gma pipe_setup: Update for TGL & ADL
Tiger Lake requires some differences in plane programming over prior
generations, including new chicken bits, wider watermarks, MBUS DBOX
programming and a few bits moved around. Alder Lake brings some more
chicken bits and requires arb-slot programming.
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
---
M common/hw-gfx-gma-config.ads.template
M common/hw-gfx-gma-pipe_setup.adb
M common/hw-gfx-gma-pipe_setup.ads
M common/hw-gfx-gma-transcoder.adb
4 files changed, 152 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/94/67494/34
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67494?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I93329c0a012da83abc379d6782fabe257dc180f3
Gerrit-Change-Number: 67494
Gerrit-PatchSet: 34
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#33) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67496?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons, Code-Review+2 by Nico Huber, Verified+1 by Nico Huber
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: gma tgl: Add combo PHY programming sequence
......................................................................
gma tgl: Add combo PHY programming sequence
This is required before any combo PHY ports can be used, so it will be
performed early in the modeset.
Squashed clean-up:
gma tgl: Refactor code for enhanced modularity
This patch corrects code indentation and incorporates an internal
procedure Propagate_To_Group for enhanced modularity. There are no
changes to functionality.
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
Change-Id: Id0c2495872250e84057c3130cab19dea05a00b75
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M common/tigerlake/Makefile.inc
A common/tigerlake/hw-gfx-gma-combo_phy.adb
A common/tigerlake/hw-gfx-gma-combo_phy.ads
3 files changed, 277 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/96/67496/33
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67496?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Id0c2495872250e84057c3130cab19dea05a00b75
Gerrit-Change-Number: 67496
Gerrit-PatchSet: 33
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-CC: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Jérémy Compostella, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#35) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67495?usp=email )
Change subject: gma tgl: Fill out power and clocks module
......................................................................
gma tgl: Fill out power and clocks module
This is the modeset sequence for the display engine itself. TGL has
similarities to both SKL and BXT, but also adds new programming, like
MBUS credits, Bandwidth Buddy, and of course new chicken bits.
Tested on google/delbin; can still boot successfully to the kernel and
the kernel can still properly perform its own modeset and not crash :)
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Signed-off-by: Jeremy Compostella <jeremy.compostella(a)intel.com>
Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535
---
M common/tigerlake/hw-gfx-gma-power_and_clocks.adb
M common/tigerlake/hw-gfx-gma-power_and_clocks.ads
2 files changed, 796 insertions(+), 22 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/95/67495/35
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67495?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I8f09696588aa73cebc7a44583ae5e029c705a535
Gerrit-Change-Number: 67495
Gerrit-PatchSet: 35
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#39) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67498?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma tgl: Add support for allocating PLLs
......................................................................
gma tgl: Add support for allocating PLLs
This patch adds support for allocating both combo PHY PLLs and USB
Type-C PLLs for Tiger Lake.
Verified Combo PHY (HDMI, eDP) and Type-C (DP Alt mode) on
Google/delbin.
Squashed clean-ups:
gma tgl: Clean up the code for gfx plls
This patch improves code quality through various optimizations, such as
replacing indexed array access with direct value access and simplifying
variable declarations. It also simplifies function rewrites by using
constructs like case-when instead of multiple range mappings or if else
blocks. Additionally, the patch addresses minor typographical errors.
These changes enhance the code's readability and maintainability
without impacting functionality.
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
gma tgl: Rename DKL PLL to Dekel_Phy
This patch changes the name of a PLL "DKL" to "Dekel_Phy" to maintain
consistency with the naming convention of other PHY PLLs
Signed-off-by: Dinesh Gehlot <digehlot(a)google.com>
Change-Id: I9dd7e0d0180f70d73eb50d7e58718261e5e74071
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M common/hw-gfx-gma-config.ads.template
M common/tigerlake/Makefile.inc
A common/tigerlake/hw-gfx-gma-plls-combo_phy.adb
A common/tigerlake/hw-gfx-gma-plls-combo_phy.ads
A common/tigerlake/hw-gfx-gma-plls-dekel_phy.adb
A common/tigerlake/hw-gfx-gma-plls-dekel_phy.ads
M common/tigerlake/hw-gfx-gma-plls.adb
M common/tigerlake/hw-gfx-gma-plls.ads
8 files changed, 910 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/98/67498/39
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67498?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9dd7e0d0180f70d73eb50d7e58718261e5e74071
Gerrit-Change-Number: 67498
Gerrit-PatchSet: 39
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nico Huber.
Hello Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/81523?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+2 by Angel Pons
Change subject: gma: Add `eDP' flag to Port_Config
......................................................................
gma: Add `eDP' flag to Port_Config
Again, we assume that a port with panel controls attached is eDP.
Change-Id: Idd40b4258c08ba88ec7b0ab631e683aba848f9c1
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-config_helpers.adb
M common/hw-gfx-gma.ads
2 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/23/81523/6
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/81523?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Idd40b4258c08ba88ec7b0ab631e683aba848f9c1
Gerrit-Change-Number: 81523
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nick Vaccaro, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#40) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67499?usp=email )
Change subject: gma tgl: Add connector programming
......................................................................
gma tgl: Add connector programming
This patch adds support for enabling displays on both combo PHY ports
and Type-C ports over DP-Alt mode.
Verified eDP, HDMI (not Type-C), and DP Alt mode on google/delbin.
Change-Id: I908e8bef8451d21eecde9ce6defddc2b3df7f738
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-config.ads.template
M common/hw-gfx-gma.adb
M common/hw-gfx-gma.ads
M common/tigerlake/Makefile.inc
A common/tigerlake/hw-gfx-gma-connectors-combo_phy.adb
A common/tigerlake/hw-gfx-gma-connectors-combo_phy.ads
A common/tigerlake/hw-gfx-gma-connectors-tc.adb
A common/tigerlake/hw-gfx-gma-connectors-tc.ads
M common/tigerlake/hw-gfx-gma-connectors.adb
M common/tigerlake/hw-gfx-gma-power_and_clocks.adb
10 files changed, 1,721 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/99/67499/40
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67499?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I908e8bef8451d21eecde9ce6defddc2b3df7f738
Gerrit-Change-Number: 67499
Gerrit-PatchSet: 40
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Nick Vaccaro, Nico Huber, Tarun Tuli, Tim Wawrzynczak.
Nico Huber has uploaded a new patch set (#40) to the change originally created by Tim Wawrzynczak. ( https://review.coreboot.org/c/libgfxinit/+/67500?usp=email )
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma tgl: Add port detection
......................................................................
gma tgl: Add port detection
Block TCCOLD during initialization so that Modular FIA registers can be
accessed. Instead of keeping track of the state of TCCOLD all of the
time (and enabling and re-enabling), this patch just blocks TCCOLD
once during initializaton and leaves it that way.
We don't have any knowledge yet if a TC port is used in legacy DP/HDMI
mode or not, so we always handle hotplug events in both hardware blocks.
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Change-Id: I674e7c2dcd7738e3d76266ff36675dbd52fa5ae2
---
M common/tigerlake/hw-gfx-gma-port_detect.adb
1 file changed, 146 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/00/67500/40
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/67500?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I674e7c2dcd7738e3d76266ff36675dbd52fa5ae2
Gerrit-Change-Number: 67500
Gerrit-PatchSet: 40
Gerrit-Owner: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83356?usp=email )
(
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: soc/intel/alderlake/tcss: Add definition of IOM_READY bit
......................................................................
soc/intel/alderlake/tcss: Add definition of IOM_READY bit
Add definition of the IOM_READY bit in the IOM_TYPEC_STATUS_1
register. Needed by Protectli VP66XX boards to poll for this bit
for about 2 seconds before FSP Silicon Init to have USB functionality.
ME is supposed to start fetching and executing the TCSS IPs FW right
after DRAM Init Done message, which happens after MRC. For most
platforms the time interval between the end of MemoryInit and start of
SiliconInit is enough for IOM_READY to get set.
TEST=Poll the IOM_READY bit on VP66XX platform and observe the
TCSS XHCI is up in lspci.
Change-Id: If868a77852468ebb73526b1571191cbdeb1804b9
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83356
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/soc/intel/alderlake/include/soc/tcss.h
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
diff --git a/src/soc/intel/alderlake/include/soc/tcss.h b/src/soc/intel/alderlake/include/soc/tcss.h
index 014e307..825b6c7 100644
--- a/src/soc/intel/alderlake/include/soc/tcss.h
+++ b/src/soc/intel/alderlake/include/soc/tcss.h
@@ -7,6 +7,10 @@
#define IOM_CSME_IMR_TBT_STATUS 0x14
#define TBT_VALID_AUTHENTICATION (1 << 30)
+/* TCSS IP status */
+#define IOM_TYPEC_STATUS_1 0x50
+#define IOM_READY (1 << 30)
+
/* IOM aux bias control registers in REGBAR MMIO space */
#define IOM_AUX_BIAS_CTRL_PULLUP_OFFSET_0 0x1070
#define IOM_AUX_BIAS_CTRL_PULLUP_OFFSET(x) (IOM_AUX_BIAS_CTRL_PULLUP_OFFSET_0 + (x) * 4)
--
To view, visit https://review.coreboot.org/c/coreboot/+/83356?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If868a77852468ebb73526b1571191cbdeb1804b9
Gerrit-Change-Number: 83356
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>