Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83420?usp=email )
Change subject: vc/google/chromeos: Add configurable compression for logo file in cbfs
......................................................................
vc/google/chromeos: Add configurable compression for logo file in cbfs
This patch enables LZMA or LZ4 compression algorithm for the logo cbfs
file based on BMP_LOGO_COMPRESS_LZMA or BMP_LOGO_COMPRESS_LZ4 Kconfig.
Logo cbfs file is compressed based on CBFS_COMPRESS_FLAG, by default.
Based on logo file content and target platform, enabling LZ4 could
save significant boot time, with increase in file size.
For brox:
cb_logo LZ4 is +1265 bytes than LZMA, saves ~0.760ms in decomp.
cb_plus_logo LZ4 is +2011 bytes than LZMA, saves ~0.880ms in decomp.
BUG=b:337330958
TEST=Able to boot brox and verified firmware splash screen display
with LZMA and LZ4 compression.
Change-Id: I57fbd0d3a39eaba3fb9d61e7a3fb5eeb44e3a839
Signed-off-by: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83420
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/vendorcode/google/chromeos/Makefile.mk
1 file changed, 9 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/vendorcode/google/chromeos/Makefile.mk b/src/vendorcode/google/chromeos/Makefile.mk
index af37a09..44d4d2b 100644
--- a/src/vendorcode/google/chromeos/Makefile.mk
+++ b/src/vendorcode/google/chromeos/Makefile.mk
@@ -23,12 +23,19 @@
ramstage-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += splash.c
# Add logo to the cbfs image
+BMP_LOGO_COMPRESS_FLAG := $(CBFS_COMPRESS_FLAG)
+ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZMA),y)
+ BMP_LOGO_COMPRESS_FLAG := LZMA
+else ifeq ($(CONFIG_BMP_LOGO_COMPRESS_LZ4),y)
+ BMP_LOGO_COMPRESS_FLAG := LZ4
+endif
+
cbfs-files-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += cb_logo.bmp
cb_logo.bmp-file := $(call strip_quotes,$(CONFIG_CHROMEOS_LOGO_PATH))
cb_logo.bmp-type := raw
-cb_logo.bmp-compression := $(CBFS_COMPRESS_FLAG)
+cb_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG)
cbfs-files-$(CONFIG_CHROMEOS_FW_SPLASH_SCREEN) += cb_plus_logo.bmp
cb_plus_logo.bmp-file := $(call strip_quotes,$(CONFIG_CHROMEBOOK_PLUS_LOGO_PATH))
cb_plus_logo.bmp-type := raw
-cb_plus_logo.bmp-compression := $(CBFS_COMPRESS_FLAG)
+cb_plus_logo.bmp-compression := $(BMP_LOGO_COMPRESS_FLAG)
--
To view, visit https://review.coreboot.org/c/coreboot/+/83420?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I57fbd0d3a39eaba3fb9d61e7a3fb5eeb44e3a839
Gerrit-Change-Number: 83420
Gerrit-PatchSet: 7
Gerrit-Owner: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83603?usp=email )
Change subject: gma ironlake: Move FDI override into Connectors.Prepare()
......................................................................
gma ironlake: Move FDI override into Connectors.Prepare()
Change-Id: Iac5334e91b1e706dca21e74845a3227c3b9b6503
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-config_helpers.adb
M common/ironlake/hw-gfx-gma-connectors.adb
2 files changed, 28 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/03/83603/1
diff --git a/common/hw-gfx-gma-config_helpers.adb b/common/hw-gfx-gma-config_helpers.adb
index 5a3ba7e..82f54b6 100644
--- a/common/hw-gfx-gma-config_helpers.adb
+++ b/common/hw-gfx-gma-config_helpers.adb
@@ -14,7 +14,6 @@
with HW.GFX.GMA.Connector_Info;
with HW.GFX.GMA.DP_Info;
-with HW.GFX.GMA.Registers;
with HW.Debug;
@@ -178,25 +177,12 @@
Port_Cfg.Mode.H_Visible = Port_Cfg'Old.Mode.H_Visible and
Port_Cfg.Mode.V_Visible = Port_Cfg'Old.Mode.V_Visible
is
- FDI_TX_CTL_FDI_TX_ENABLE : constant := 1 * 2 ** 31;
- Enabled : Boolean;
begin
Port_Cfg.FDI.Receiver_Caps.Max_Link_Rate := DP_Bandwidth_2_7;
Port_Cfg.FDI.Receiver_Caps.Max_Lane_Count :=
Config.FDI_Lane_Count (Port_Cfg.Port);
Port_Cfg.FDI.Receiver_Caps.Enhanced_Framing := True;
- if Config.Has_FDI_C and then Port_Cfg.Port = DIGI_C then
- -- if DIGI_D enabled: (FDI names are off by one)
- Registers.Is_Set_Mask
- (Register => Registers.FDI_TX_CTL_C,
- Mask => FDI_TX_CTL_FDI_TX_ENABLE,
- Result => Enabled);
- if Enabled then
- Port_Cfg.FDI.Receiver_Caps.Max_Lane_Count := DP_Lane_Count_2;
- end if;
- end if;
-
DP_Info.Preferred_Link_Setting (Port_Cfg.FDI, Port_Cfg.Mode, Success);
end Configure_FDI_Link;
diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb
index c1bec22..a3ce7b0 100644
--- a/common/ironlake/hw-gfx-gma-connectors.adb
+++ b/common/ironlake/hw-gfx-gma-connectors.adb
@@ -14,6 +14,8 @@
--
with HW.GFX.GMA.Config;
+with HW.GFX.GMA.DP_Info;
+with HW.GFX.GMA.Registers;
with HW.GFX.GMA.Panel;
with HW.GFX.GMA.Connectors.EDP;
with HW.GFX.GMA.Connectors.FDI;
@@ -44,8 +46,33 @@
Port_Cfg : in out Port_Config;
Success : out Boolean)
is
+ -- Override lane count for FDI_B if FDI_C is used
+ procedure Override_FDI_Link
+ with
+ Post => Port_Cfg.Mode = Port_Cfg'Old.Mode
+ is
+ FDI_TX_CTL_FDI_TX_ENABLE : constant := 1 * 2 ** 31;
+ Enabled : Boolean;
+ begin
+ if Config.Has_FDI_C and then Port_Cfg.Port = DIGI_C then
+ -- if DIGI_D enabled: (FDI names are off by one)
+ Registers.Is_Set_Mask
+ (Register => Registers.FDI_TX_CTL_C,
+ Mask => FDI_TX_CTL_FDI_TX_ENABLE,
+ Result => Enabled);
+ if Enabled then
+ Port_Cfg.FDI.Receiver_Caps.Max_Lane_Count := DP_Lane_Count_2;
+ end if;
+ end if;
+
+ DP_Info.Preferred_Link_Setting (Port_Cfg.FDI, Port_Cfg.Mode, Success);
+ end Override_FDI_Link;
begin
- Success := True;
+ if Port_Cfg.Is_FDI then
+ Override_FDI_Link;
+ else
+ Success := True;
+ end if;
end Prepare;
----------------------------------------------------------------------------
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83603?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Iac5334e91b1e706dca21e74845a3227c3b9b6503
Gerrit-Change-Number: 83603
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83604?usp=email )
Change subject: gma config: Introduce `First_/Last_TC_Port'
......................................................................
gma config: Introduce `First_/Last_TC_Port'
Similar to `Last_Digital_Port', note the first and last Type-C port
of the configured platform. Odd enough, this is at most TC1..TC4 on
all known Tiger Lake SKUs. Even though the TGL PRM refers to six TC
ports.
It seems ADL uses TC3..TC6, hence we introduce the `First_' config
right away.
Change-Id: I0114e4070a20ae4218f41faf750ad59283e5dc3d
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-config.ads.template
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/04/83604/1
diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template
index 5413937..a67dc78 100644
--- a/common/hw-gfx-gma-config.ads.template
+++ b/common/hw-gfx-gma-config.ads.template
@@ -320,6 +320,11 @@
Last_Digital_Port : <hswsklvar> Digital_Port :=
(if Has_DDI_E then DIGI_E else DIGI_C);
+ First_TC_Port : constant TGL_Digital_Port := DDI_TC1;
+ Last_TC_Port : constant TGL_Digital_Port :=
+ (if not Tigerlake_On then DIGI_E -- Makes First_TC_Port..Last_TC_Port empty.
+ else DDI_TC4);
+
----------------------------------------------------------------------------
type FDI_Per_Port is array (Port_Type) of Boolean;
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83604?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I0114e4070a20ae4218f41faf750ad59283e5dc3d
Gerrit-Change-Number: 83604
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83602?usp=email )
Change subject: gma connectors: Add Claim() and Prepare() steps
......................................................................
gma connectors: Add Claim() and Prepare() steps
Claim() ensures that we have a working connection, e.g. when things
need to be mu'xed for Type-C ports. This is necessary in particular,
before we probe an EDID.
Prepare() will be used to adapt a `Port_Config' to platform quirks.
For instance the FDI usage on Ironlake, USB-C usage on Tiger Lake.
Change-Id: I2fb3ed026077f0371112682b90bea751a28bf994
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/g45/hw-gfx-gma-connectors.adb
M common/haswell_shared/hw-gfx-gma-connectors.adb
M common/hw-gfx-gma-connectors.ads
M common/hw-gfx-gma-display_probing.adb
M common/hw-gfx-gma.adb
M common/ironlake/hw-gfx-gma-connectors.adb
M common/tigerlake/hw-gfx-gma-connectors.adb
7 files changed, 98 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/02/83602/1
diff --git a/common/g45/hw-gfx-gma-connectors.adb b/common/g45/hw-gfx-gma-connectors.adb
index ff689bb..3f1a80b 100644
--- a/common/g45/hw-gfx-gma-connectors.adb
+++ b/common/g45/hw-gfx-gma-connectors.adb
@@ -31,6 +31,22 @@
----------------------------------------------------------------------------
+ procedure Claim (Port : in Active_Port_Type; Success : out Boolean) is
+ begin
+ Success := True;
+ end Claim;
+
+ procedure Prepare
+ (Port : in Active_Port_Type;
+ Port_Cfg : in out Port_Config;
+ Success : out Boolean)
+ is
+ begin
+ Success := True;
+ end Prepare;
+
+ ----------------------------------------------------------------------------
+
procedure Pre_On
(Pipe : in Pipe_Index;
Port_Cfg : in Port_Config;
diff --git a/common/haswell_shared/hw-gfx-gma-connectors.adb b/common/haswell_shared/hw-gfx-gma-connectors.adb
index e81322e..aff510e 100644
--- a/common/haswell_shared/hw-gfx-gma-connectors.adb
+++ b/common/haswell_shared/hw-gfx-gma-connectors.adb
@@ -33,6 +33,24 @@
DDI.Initialize;
end Initialize;
+ ----------------------------------------------------------------------------
+
+ procedure Claim (Port : in Active_Port_Type; Success : out Boolean) is
+ begin
+ Success := True;
+ end Claim;
+
+ procedure Prepare
+ (Port : in Active_Port_Type;
+ Port_Cfg : in out Port_Config;
+ Success : out Boolean)
+ is
+ begin
+ Success := True;
+ end Prepare;
+
+ ----------------------------------------------------------------------------
+
procedure Pre_On
(Pipe : in Pipe_Index;
Port_Cfg : in Port_Config;
diff --git a/common/hw-gfx-gma-connectors.ads b/common/hw-gfx-gma-connectors.ads
index a1d0d1e..c0a24a2 100644
--- a/common/hw-gfx-gma-connectors.ads
+++ b/common/hw-gfx-gma-connectors.ads
@@ -14,14 +14,25 @@
private package HW.GFX.GMA.Connectors is
+ pragma Warnings (GNATprove, Off, "unused variable ""P*""",
+ Reason => "Needed for a common interface");
+ pragma Warnings (GNATprove, Off, """P*"" is not modified, could be IN",
+ Reason => "Needed for a common interface");
pragma Warnings (GNATprove, Off, "subprogram ""*"" has no effect",
Reason => "Only effects some platforms");
procedure Post_Reset_Off;
procedure Initialize;
+ procedure Claim (Port : in Active_Port_Type; Success : out Boolean);
+ procedure Prepare
+ (Port : in Active_Port_Type;
+ Port_Cfg : in out Port_Config;
+ Success : out Boolean)
+ with
+ Post => Port_Cfg.Mode = Port_Cfg'Old.Mode;
+
+ pragma Warnings (GNATprove, On, """P*"" is not modified, could be IN");
pragma Warnings (GNATprove, On, "subprogram ""*"" has no effect");
- pragma Warnings (GNATprove, Off, "unused variable ""P*""",
- Reason => "Needed for a common interface");
procedure Pre_On
(Pipe : in Pipe_Index;
Port_Cfg : in Port_Config;
diff --git a/common/hw-gfx-gma-display_probing.adb b/common/hw-gfx-gma-display_probing.adb
index 4625322..b66650b 100644
--- a/common/hw-gfx-gma-display_probing.adb
+++ b/common/hw-gfx-gma-display_probing.adb
@@ -19,6 +19,7 @@
with HW.GFX.GMA.I2C;
with HW.GFX.GMA.DP_Aux_Ch;
with HW.GFX.GMA.Panel;
+with HW.GFX.GMA.Connectors;
with HW.GFX.GMA.Port_Detect;
with HW.GFX.GMA.Power_And_Clocks;
@@ -62,6 +63,12 @@
begin
pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
+ Connectors.Claim (Port, Success);
+ if not Success then
+ Raw_EDID := (others => 16#00#);
+ return;
+ end if;
+
for I in 1 .. 2 loop
if Config_Helpers.To_Display_Type (Port) = DP then
-- May need power and CDClk to read EDID
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 46fb44b..c6fd909 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -155,6 +155,10 @@
(Port_Cfg, Pipe, Pipe_Cfg.Port, Pipe_Cfg.Mode, Success);
if Success then
+ Connectors.Prepare (Pipe_Cfg.Port, Port_Cfg, Success);
+ end if;
+
+ if Success then
Connector_Info.Preferred_Link_Setting (Port_Cfg, Success);
end if;
@@ -308,6 +312,10 @@
Config_Helpers.Validate_Config
(New_Config.Framebuffer, New_Config.Mode, Pipe);
+ if Success then
+ Connectors.Claim (New_Config.Port, Success);
+ end if;
+
if Success and then Requires_Scaling (New_Config) then
Display_Controller.Reserve_Scaler
(Success, Scaler_Reservation, Pipe);
diff --git a/common/ironlake/hw-gfx-gma-connectors.adb b/common/ironlake/hw-gfx-gma-connectors.adb
index 1c3a243..c1bec22 100644
--- a/common/ironlake/hw-gfx-gma-connectors.adb
+++ b/common/ironlake/hw-gfx-gma-connectors.adb
@@ -32,6 +32,24 @@
procedure Post_Reset_Off is null;
procedure Initialize is null;
+ ----------------------------------------------------------------------------
+
+ procedure Claim (Port : in Active_Port_Type; Success : out Boolean) is
+ begin
+ Success := True;
+ end Claim;
+
+ procedure Prepare
+ (Port : in Active_Port_Type;
+ Port_Cfg : in out Port_Config;
+ Success : out Boolean)
+ is
+ begin
+ Success := True;
+ end Prepare;
+
+ ----------------------------------------------------------------------------
+
function Is_Internal (Port_Cfg : Port_Config) return Boolean
is
begin
diff --git a/common/tigerlake/hw-gfx-gma-connectors.adb b/common/tigerlake/hw-gfx-gma-connectors.adb
index 5e66b96..e084b5c 100644
--- a/common/tigerlake/hw-gfx-gma-connectors.adb
+++ b/common/tigerlake/hw-gfx-gma-connectors.adb
@@ -30,6 +30,24 @@
pragma Debug (Debug.Put_Line (GNAT.Source_Info.Enclosing_Entity));
end Initialize;
+ ---------------------------------------------------------------------
+
+ procedure Claim (Port : in Active_Port_Type; Success : out Boolean) is
+ begin
+ Success := True;
+ end Claim;
+
+ procedure Prepare
+ (Port : in Active_Port_Type;
+ Port_Cfg : in out Port_Config;
+ Success : out Boolean)
+ is
+ begin
+ Success := False;
+ end;
+
+ ---------------------------------------------------------------------
+
procedure Pre_On
(Pipe : in Pipe_Index;
Port_Cfg : in Port_Config;
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83602?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I2fb3ed026077f0371112682b90bea751a28bf994
Gerrit-Change-Number: 83602
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83600?usp=email )
Change subject: gma: Do detection and connectors init after `All_Off'
......................................................................
gma: Do detection and connectors init after `All_Off'
The `Port_Detect.Init' and `Connectors.Init' steps have grown over time.
They used to do one-time initialization that could be done independently
from the current hardware state. However, with the introduction of Tiger
Lake, it becomes more reasonable to ensure a disabled state before those
init steps.
Actually, we already program DDI buffers in `Connectors.Init' that pro-
bably shouldn't change when the hardware is running. It only didn't mat-
ter because everybody is supposed to write the same static values.
Change-Id: Ia707470da385624dcbbe90c0c7f64fe71331b65e
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma.adb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/00/83600/1
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 88a9760..46fb44b 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -599,8 +599,6 @@
end if;
Panel.Setup_PP_Sequencer;
- Port_Detect.Initialize;
- Connectors.Initialize;
if Clean_State then
Power_And_Clocks.Pre_All_Off;
@@ -619,6 +617,8 @@
end if;
-------------------- Now restart from a clean state ---------------------
+ Port_Detect.Initialize;
+ Connectors.Initialize;
Power_And_Clocks.Initialize;
if Config.Has_PCH then
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83600?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Ia707470da385624dcbbe90c0c7f64fe71331b65e
Gerrit-Change-Number: 83600
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/libgfxinit/+/83598?usp=email )
Change subject: transcoder: Don't try to disable disabled DDI func
......................................................................
transcoder: Don't try to disable disabled DDI func
Tiger Lake makes some trouble on the `All_Off' path in case a trans-
coder is already disabled. It somehow seems to be able to seriously
lock things up inside the processor, causing Linux to hang, report
stalled CPUs, and the reset button not to work anymore. This might
be related to disabled power wells, that we do not keep track of on
the `All_Off' path.
As there shouldn't be no harm in skipping the register write for an
already disabled transcoder, just do that.
Change-Id: Ia505422570d967b192fe2eb8cab10f305aff3dd7
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-transcoder.adb
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/98/83598/1
diff --git a/common/hw-gfx-gma-transcoder.adb b/common/hw-gfx-gma-transcoder.adb
index 9e85b75..6eea451 100644
--- a/common/hw-gfx-gma-transcoder.adb
+++ b/common/hw-gfx-gma-transcoder.adb
@@ -373,7 +373,10 @@
end if;
if Config.Has_Pipe_DDI_Func then
- Registers.Write (Trans.DDI_FUNC_CTL, 0);
+ Registers.Is_Set_Mask (Trans.DDI_FUNC_CTL, DDI_FUNC_CTL_ENABLE, Enabled);
+ if Enabled then
+ Registers.Write (Trans.DDI_FUNC_CTL, 0);
+ end if;
end if;
end Trans_Off;
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83598?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Ia505422570d967b192fe2eb8cab10f305aff3dd7
Gerrit-Change-Number: 83598
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Angel Pons, Dinesh Gehlot, Elyes Haouas, Nico Huber, Paul Menzel.
Hello Angel Pons, Elyes Haouas, Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
to look at the new patch set (#6).
The following approvals got outdated and were removed:
Code-Review+1 by Angel Pons
Change subject: gma display_probing: Make new TGL ports available
......................................................................
gma display_probing: Make new TGL ports available
Make all the new ports available that were added to `Port_Type` in
commit 605660bb21 (gma: Begin Tiger Lake (TGL) integration).
Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Signed-off-by: Nico Huber <nico.huber(a)secunet.com>
---
M common/hw-gfx-gma-display_probing.adb
M common/hw-gfx-gma-display_probing.ads
2 files changed, 24 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/libgfxinit refs/changes/22/81522/6
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/81522?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: I9d96673f931be0086536044694ecd127ba2a823d
Gerrit-Change-Number: 81522
Gerrit-PatchSet: 6
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>