Attention is currently required from: Martin Roth, Matt DeVillier.
Jon Murphy has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83606?usp=email )
Change subject: mb/google/dedede/var/galtic: Add fw_config option for touchpad type
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83606/comment/20bfd294_77de5b85?us… :
PS1, Line 12: TOUCHPAD_SOURCE 44 45
> Unless Google actually makes this change as well, setting it as the next bits in the bitfield could […]
+1 on the upper bits. I'll look at what is allocated internally and provide feedback or reserve fields.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83606?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36797eb5c8f262782380f95ff3c2e38443cf00c0
Gerrit-Change-Number: 83606
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jon Murphy <jpmurphy(a)google.com>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 18:22:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Attention is currently required from: Matt DeVillier.
Martin Roth has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83606?usp=email )
Change subject: mb/google/dedede/var/galtic: Add fw_config option for touchpad type
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/galtic/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/83606/comment/c3c73e13_45b942b9?us… :
PS1, Line 12: TOUCHPAD_SOURCE 44 45
Unless Google actually makes this change as well, setting it as the next bits in the bitfield could cause issues if they decide to add something else. Maybe this isn't a concern if they've stopped producing this board.
My recommendation would be to put this in bits 63 & 62 so it's less likely to conflict with anything google does.
If they are still producing this board, maybe google could make this an official change, since this is how it should have been done in the first place.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83606?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36797eb5c8f262782380f95ff3c2e38443cf00c0
Gerrit-Change-Number: 83606
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 17:45:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Matt DeVillier.
Martin Roth has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/83605?usp=email )
Change subject: mb/google/dedede/var/galtic: Group fw_config fields together
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83605?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ad6be9dd67b5adbc9c5b0fcab51ce0c54351173
Gerrit-Change-Number: 83605
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 17:41:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nico Huber.
Matt DeVillier has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/libgfxinit/+/83596?usp=email )
Change subject: gma: Get DPCD 1.1+ displays out of D3
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/libgfxinit/+/83596?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libgfxinit
Gerrit-Branch: main
Gerrit-Change-Id: Ieec3813ba99ed3a2c6f701cb34a5e2b226fc14c0
Gerrit-Change-Number: 83596
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Mon, 22 Jul 2024 17:30:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83606?usp=email )
Change subject: mb/google/dedede/var/galtic: Add fw_config option for touchpad type
......................................................................
mb/google/dedede/var/galtic: Add fw_config option for touchpad type
Galtic has two Elan touchpad options, and since both use the same i2c
address, the runtime i2c detection performed during SSDT generation
can't distinquish between them, leading to both devices being added
to the SSDT. This isn't a problem for Linux, but Windows can't
deal with two touchpads being enabled and using the same resources.
To mitigate this, add a new fw_config field which allows selection
between the two touchpad models, as well as a fallback option for
all devices which are not configured. Users who need to can set the
touchpad type in the SSFC using ectool, and then coreboot will
enable only the selected touchpad at boot.
TEST=build/boot google/dedede (galnat) after setting touchpad type
in SSFC. Verify correct touchpad selected via fw_config, only one
touchpad entry present in SSDT, and touchpad functional under both
Linux and Windows 11.
Change-Id: I36797eb5c8f262782380f95ff3c2e38443cf00c0
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/dedede/variants/galtic/overridetree.cb
1 file changed, 13 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/83606/1
diff --git a/src/mainboard/google/dedede/variants/galtic/overridetree.cb b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
index 51d5a7a..86c9bae 100644
--- a/src/mainboard/google/dedede/variants/galtic/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
@@ -9,6 +9,11 @@
option AUDIO_CODEC_ALC5682 1
option AUDIO_CODEC_ALC5682I_VS 2
end
+ field TOUCHPAD_SOURCE 44 45
+ option TOUCHPAD_UNPROVISIONED 0
+ option TOUCHPAD_ELAN0000 1
+ option TOUCHPAD_ELAN2702 2
+ end
end
chip soc/intel/jasperlake
@@ -144,7 +149,10 @@
register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_B3_IRQ)"
register "wake" = "GPE0_DW0_03"
register "detect" = "1"
- device i2c 15 on end
+ device i2c 15 on
+ probe TOUCHPAD_SOURCE TOUCHPAD_UNPROVISIONED
+ probe TOUCHPAD_SOURCE TOUCHPAD_ELAN0000
+ end
end
chip drivers/i2c/hid
register "generic.hid" = ""ELAN2702""
@@ -153,7 +161,10 @@
register "generic.wake" = "GPE0_DW0_03"
register "generic.detect" = "1"
register "hid_desc_reg_offset" = "0x01"
- device i2c 15 on end
+ device i2c 15 on
+ probe TOUCHPAD_SOURCE TOUCHPAD_UNPROVISIONED
+ probe TOUCHPAD_SOURCE TOUCHPAD_ELAN2702
+ end
end
end
device pci 15.2 on
--
To view, visit https://review.coreboot.org/c/coreboot/+/83606?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I36797eb5c8f262782380f95ff3c2e38443cf00c0
Gerrit-Change-Number: 83606
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83605?usp=email )
Change subject: mb/google/dedede/var/galtic: Group fw_config fields together
......................................................................
mb/google/dedede/var/galtic: Group fw_config fields together
No need to have separate sections, and will be cleaner when adding
another section in a subsequent patch.
Change-Id: I4ad6be9dd67b5adbc9c5b0fcab51ce0c54351173
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/dedede/variants/galtic/overridetree.cb
1 file changed, 0 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/83605/1
diff --git a/src/mainboard/google/dedede/variants/galtic/overridetree.cb b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
index 7eb059d..51d5a7a 100644
--- a/src/mainboard/google/dedede/variants/galtic/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/galtic/overridetree.cb
@@ -4,9 +4,6 @@
option TOUCHSCREEN_ELAN1001 1
option TOUCHSCREEN_ELAN9008 2
end
-end
-
-fw_config
field AUDIO_CODEC_SOURCE 41 43
option AUDIO_CODEC_UNPROVISIONED 0
option AUDIO_CODEC_ALC5682 1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83605?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4ad6be9dd67b5adbc9c5b0fcab51ce0c54351173
Gerrit-Change-Number: 83605
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>