Attention is currently required from: Jakub Czapiga, Martin L Roth.
Nico Huber has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/coreboot/+/70526?usp=email )
Change subject: util/sconfig: Simplify file opening and error handling
......................................................................
Patch Set 5:
(2 comments)
File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/70526/comment/5049bcd5_05a9b6f0?us… :
PS5, Line 2137: goto end;
Not sure why the compiler doesn't warn here. AIUI, this skips the initialization
of the other variables, hence we can't count on them being NULL. Individual jump
labels are the canonical way, I guess. i.e. `fclose()` in the reverse order and
let the first `goto` jump to the last `fclose()`, etc.
https://review.coreboot.org/c/coreboot/+/70526/comment/2abc8a9e_f7956ded?us… :
PS5, Line 2183: return 0;
We shouldn't `return 0` on failure.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70526?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib315b50cdc89ace414ce0b78d3ece02e81b028ad
Gerrit-Change-Number: 70526
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 18:22:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Jakub Czapiga, Martin L Roth.
Nico Huber has posted comments on this change by Jakub Czapiga. ( https://review.coreboot.org/c/coreboot/+/70525?usp=email )
Change subject: util/sconfig: Remove unnecessary strdup() calls
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
Patchset:
PS5:
Sorry, looks like I missed the call back then. Looks good.
--
To view, visit https://review.coreboot.org/c/coreboot/+/70525?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5a27f64077af1c04b06732cd601145b8becacfd
Gerrit-Change-Number: 70525
Gerrit-PatchSet: 5
Gerrit-Owner: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 18:15:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Alexander Couzens, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Martin L Roth, Michael Niewöhner, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford.
Jonathon Hall has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email )
Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727
Gerrit-Change-Number: 83119
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com>
Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 05 Jul 2024 17:57:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2:
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/658edaf0_cbff710f?us… :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
> > Can't say that I know the language. Is there a way to make this not […]
shoot me, please
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:51:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Nicholas Chin.
Angel Pons has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:31:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Nicholas Chin.
Arthur Heymans has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/36196247_eb6ce874?us… :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
> Can't say that I know the language. Is there a way to make this not
> part of the global scope?
iirc go uses casing for scope. Uppercase letter: global, lowercase: local.
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:28:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Attention is currently required from: Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83286?usp=email )
Change subject: autoport: Factor out GPIO config generation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File util/autoport/gpio_common.go:
https://review.coreboot.org/c/coreboot/+/83286/comment/7fa8e16e_4b1f0111?us… :
PS1, Line 10: func writeGPIOSet(ctx Context, sb *os.File,
Can't say that I know the language. Is there a way to make this not
part of the global scope?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83286?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If1f506f6ad10144bd6acc42505592426bb7193b7
Gerrit-Change-Number: 83286
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Felix Singer, Julius Werner, Paul Menzel, Shelley Chen.
Bharath N has posted comments on this change by Bharath N. ( https://review.coreboot.org/c/qc_blobs/+/83305?usp=email )
Change subject: sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/qc_blobs/+/83305/comment/37ecfba6_09d3740c?us… :
PS2, Line 7: blobs binaries
> I would remove "binaries". […]
done
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/83305?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: qc_blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37
Gerrit-Change-Number: 83305
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 05 Jul 2024 16:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Attention is currently required from: Bharath N, Julius Werner, Paul Menzel, Shelley Chen.
Hello Julius Werner, Shelley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/qc_blobs/+/83305?usp=email
to look at the new patch set (#3).
Change subject: sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
......................................................................
sc7180/qtiseclib: Update qtiseclib blobs and release notes from 69 to 71
TEST=Validated on qualcomm sc7180 development board
Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37
Signed-off-by: Bharath N <quic_bharn(a)quicinc.com>
---
M sc7180/qtiseclib/Release_Notes.txt
M sc7180/qtiseclib/libqtisec.a
2 files changed, 18 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/05/83305/3
--
To view, visit https://review.coreboot.org/c/qc_blobs/+/83305?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: qc_blobs
Gerrit-Branch: main
Gerrit-Change-Id: Ia390035cdd591c1d31fd2e28ad53e63d16e91a37
Gerrit-Change-Number: 83305
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath N <quic_bharn(a)quicinc.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Bharath N <quic_bharn(a)quicinc.com>