coreboot-gerrit July 2024

coreboot-gerrit@coreboot.org

1 participants
3025 discussions

[XS] Change in coreboot[main]: mb/starlabs/starbook/rpl: Disconnect SCI/SMI GPIOs
by Matt DeVillier (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83624?usp=email ) Change subject: mb/starlabs/starbook/rpl: Disconnect SCI/SMI GPIOs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83624?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I81470658263f4b601c9964ff5bed86b22d24df3b Gerrit-Change-Number: 83624 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:43:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/rpl: Disconnect wireless GPIOs
by Matt DeVillier (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83625?usp=email ) Change subject: mb/starlabs/starbook/rpl: Disconnect wireless GPIOs ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83625?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7aef1b821420daf5ea9f6ae107021e5d406a5ec3 Gerrit-Change-Number: 83625 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:42:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/rpl: Set I2C0 speed to fast
by Matt DeVillier (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83627?usp=email ) Change subject: mb/starlabs/starbook/rpl: Set I2C0 speed to fast ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83627?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6fdbd3124fca27fcd4dced81d8e2aa2f91fe4651 Gerrit-Change-Number: 83627 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Bob Moragues (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Bob Moragues, David Wu, Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin. Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email ) Change subject: mb/google/brox: Create jubilant variant ...................................................................... Patch Set 30: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/83212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac Gerrit-Change-Number: 83212 Gerrit-PatchSet: 30 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:42:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in coreboot[main]: ec/starlabs/merlin: Remove ITE mirror functionality
by Matt DeVillier (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Sean Rhodes. Matt DeVillier has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/83629?usp=email ) Change subject: ec/starlabs/merlin: Remove ITE mirror functionality ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/83629?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9b82e1b1386b4607dfe7da9b25ba432ec0303cf8 Gerrit-Change-Number: 83629 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:41:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in coreboot[main]: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag
by Subrata Banik (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Dinesh Gehlot, Paul Menzel, Yu-Ping Wu. Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email ) Change subject: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83686/comment/254ef735_c9afe00e?us… : PS2, Line 9: The patch enforces CSE sync when the GBB flag GBB_FLAG_FORCE_CSE_SYNC is : enabled and the system is currently booting from the RO section. > We are intentionally initiating the synchronization process to validate the upstream process, even when the current CSE version matches the CBFS-stored CSE version, hence its `enforcing`. > > Please let me know if you would like me to rephrase the description. We are intentionally initiating the CSE sync process to validate the coreboot update/downgrade logic, even when the current CSE RW version matches the CBFS-stored CSE version, hence its enforcement. There could be scenarios where CSE updater logic in coreboot has been modified, but for in-field devices, we are not upreving the CSE RW FW. In practice, we are only able to test CSE updater logic when we have different CSE blobs (a version uprev/downgrade). Now assume that the CSE blob has not been changed between months, but the code logic that manages the uprev has been updated. How can we ensure that the modified CSE logic in coreboot will be able to handle any future CSE uprev scenario unless it is tested? This CL introduces a GBB that ensures that we are primarily testing two cases: 1. coreboot CSE update logic, as we modify cse_lite.c much more frequently than we actually uprev the CSE blob 2. The ability to boot to the OS after a successful erase/write/read of the CSE RW partition. Can we add a detailed commit msg and test steps like this to ensure reviewers follow what this CL tries to achieve? -- To view, visit https://review.coreboot.org/c/coreboot/+/83686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Gerrit-Change-Number: 83686 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:35:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Dinesh Gehlot <digehlot(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[XL] Change in coreboot[main]: mb/google/brox: Create jubilant variant
by Bob Moragues (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Bob Moragues, David Wu, Karthik Ramasubramanian, Ren Kuo, Shelley Chen, Subrata Banik, Tyler Wang, YH Lin. Bob Moragues has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/83212?usp=email ) Change subject: mb/google/brox: Create jubilant variant ...................................................................... Patch Set 29: (1 comment) Patchset: PS29: Verified coreboot and depthcharge both build for jubilant variant. -- To view, visit https://review.coreboot.org/c/coreboot/+/83212?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic54437697058f8bce2167093bd88c0880d1b7cac Gerrit-Change-Number: 83212 Gerrit-PatchSet: 29 Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)chromium.org> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Attention: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-Attention: Bob Moragues <moragues(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:30:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in coreboot[main]: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag
by Dinesh Gehlot (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Paul Menzel, Yu-Ping Wu. Dinesh Gehlot has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email ) Change subject: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/83686/comment/f0c55d59_5c7ef96c?us… : PS2, Line 7: src: > Wrong prefix? Acknowledged https://review.coreboot.org/c/coreboot/+/83686/comment/b0f2272d_1b4882fe?us… : PS2, Line 9: The patch enforces CSE sync when the GBB flag GBB_FLAG_FORCE_CSE_SYNC is : enabled and the system is currently booting from the RO section. > Why is enforcing this the right thing to do? We are intentionally initiating the synchronization process to validate the upstream process, even when the current CSE version matches the CBFS-stored CSE version, hence its `enforcing`. Please let me know if you would like me to rephrase the description. https://review.coreboot.org/c/coreboot/+/83686/comment/c5ac6544_f5cfa31d?us… : PS2, Line 13: CL:5705989 > It’s not marked up in the upstream Gerrit. Please add a URL. This is a downstream patch. I took out the CL details from the description because the existing description and patch comments has sufficient information. -- To view, visit https://review.coreboot.org/c/coreboot/+/83686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Gerrit-Change-Number: 83686 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:27:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>

1 0

[S] Change in coreboot[main]: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag
by Subrata Banik (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Dinesh Gehlot, Yu-Ping Wu. Subrata Banik has posted comments on this change by Dinesh Gehlot. ( https://review.coreboot.org/c/coreboot/+/83686?usp=email ) Change subject: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > there should be vboot dependency. we need to land the other changes in vboot repo then uprev the vboot git as part of coreboot to land this CL. i could see vboot CL has landed now. can you please now push a vboot uprev CL in submodules then i assume this CL will able to pass build test. -- To view, visit https://review.coreboot.org/c/coreboot/+/83686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Gerrit-Change-Number: 83686 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 31 Jul 2024 17:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com>

1 0

[S] Change in coreboot[main]: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag
by Dinesh Gehlot (Code Review) 31 Jul '24

31 Jul '24

Attention is currently required from: Dinesh Gehlot, Yu-Ping Wu. Hello Subrata Banik, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/83686?usp=email to look at the new patch set (#3). Change subject: soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag ...................................................................... soc/intel/common/block/cse: Enforce CSE sync with pertinent GBB flag The patch enforces CSE sync when the GBB flag GBB_FLAG_FORCE_CSE_SYNC is enabled and the system is currently booting from the RO section. Additionally, it integrates forced CSE sync into eSOL decision-making. BUG=b:353053317 TEST=Verified forced CSE sync on rex0 with GBB 0x200000 Cq-Depend: chromium:5718196 Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Signed-off-by: Dinesh Gehlot <digehlot(a)google.com> --- M src/soc/intel/common/block/cse/cse_lite.c 1 file changed, 30 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/83686/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/83686?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I228bc8ebf58719776f6c39e0bfbb7ad53d9bfb7f Gerrit-Change-Number: 83686 Gerrit-PatchSet: 3 Gerrit-Owner: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>

1 0

← Newer
1
2
3
4
5
6
7
...
303
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2024