Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82770?usp=email )
Change subject: nb/via/cx700: Implement raminit
......................................................................
Patch Set 3: Code-Review+2
(2 comments)
Patchset:
PS3:
> My intention was to push something first that is working and as close […]
I don't mind either, let's leave this commit as-is then.
File src/northbridge/via/cx700/raminit.h:
https://review.coreboot.org/c/coreboot/+/82770/comment/fa92e724_707b75fd?us… :
PS2, Line 7: void sdram_enable(const struct dram_cfg *);
> You mean I should try to fix checkpatch? :D […]
Ack, let's leave as-is
--
To view, visit https://review.coreboot.org/c/coreboot/+/82770?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibc36b4f314cdf47f18c8be0fcb98218c50938e94
Gerrit-Change-Number: 82770
Gerrit-PatchSet: 3
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 09 Jul 2024 18:10:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Attention is currently required from: Nico Huber.
Angel Pons has posted comments on this change by Nico Huber. ( https://review.coreboot.org/c/coreboot/+/82765?usp=email )
Change subject: via: Start template for VIA C7 w/ CX700 northbridge
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
File src/northbridge/via/cx700/clock.c:
https://review.coreboot.org/c/coreboot/+/82765/comment/a59988f4_e90e72ae?us… :
PS1, Line 20: default:
> They are not officially supported. I guess it won't hurt much to add them, though. […]
Ack
File src/northbridge/via/cx700/clock.c:
https://review.coreboot.org/c/coreboot/+/82765/comment/f14aea0c_8ed33448?us… :
PS2, Line 26: return 200;
> Changed this too, because assuming too high makes delays too long, which […]
Makes sense. Although I just recalled CB:49939 and an associated bug that might still exist: logging from `get_timer_fsb()` can result in infinite recursion because the logging functions call the timer stuff.
--
To view, visit https://review.coreboot.org/c/coreboot/+/82765?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I66f678fae0d5a27bb09c0c6c702440900998e574
Gerrit-Change-Number: 82765
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Comment-Date: Tue, 09 Jul 2024 18:05:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>