coreboot-gerrit June 2024

coreboot-gerrit@coreboot.org

1 participants
3528 discussions

[M] Change in coreboot[main]: RFC: util/autoport: Utilize text/template module
by Nicholas Chin (Code Review) 30 Jun '24

30 Jun '24

Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83279?usp=email ) Change subject: RFC: util/autoport: Utilize text/template module ...................................................................... RFC: util/autoport: Utilize text/template module Go has a template system for generating textual output [0]. One annoyance I find with autoport is that multiline blocks of text in between backticks that are intended to be copied verbatim break the indentation of the main code, as any indents to match the outer code will also show up in the code. For example, the code generating gma-mainboard.ads at the bottom of main.go has the first line immediately inside the call to gma.WriteString, which is indended twice, but the subsequent lines must have no indents so that two extra indents do not appear in the output. Template files make the format of the output more obvious as it does not have to work around the indents of surrounding code. Autoport can also make it less obvious about how a certain line in the output was generated, as various lines may be spread across multiple functions in multiple files. By using templates, the exact field or function call that generates a string in a particular file is made more obvious, which may be useful for those wanting to understand how logs correspond to generated code as well as find sections that need to be updated to account for changes in the coreboot src tree. This replaces the output of certain files with a template driven implementation to give an idea of what is possible and some pros and cons of the approach. - gma-mainboard.ads: Previously, the entire content of this file was generated by copying a block of text verbatim with dependancies on the values of certain variables. Thus, the new template for this can simply be the generated file as is, which is essentially just copied to the new mainboard directory. This represents the simplest case of using go templates. In these cases, templates have the advantage of being identical in formatting to the output, and can be trivially edited to account for changes needed to the generated file. - Kconfig.name: Previously, the context of this was simply used Fprintf with members of the ctx struct to generate the content of this file. The new template is essentially the same as the generated file, but uses field arguments [1] to use the values of the ctx fields directly. This is a bit more complex compared to the previous example, but is still rather simple compared to other usages of templates. This represents cases where the values of various text in the output is only dependent on fields in a structure or map, and doesn't need special formatting. This has the advantage of being still being relatively simple to update, and you doesn't need to dig through code to determine where the contents of a file are generated. The formatting of the output is also more obvious compared to format strings or blocks of verbatim text in backticks, as noted earlier. - hda_verb.c: Previously, the contents of this file were generated using several loops to iterate through the codecs and nodes. This is a more complex example, utilizing a range action [2] to loop through the codecs array instead of loops in the code. It also uses the printf template function [3] to format some of the values. This particular approach has the disadvantage of using the more complex template syntax which might be less familiar to developers who are used to more traditional fprintf calls and loops, and is less flexible compared to the full capabilities of normal Go code. For this reason the example here does not yet generate the AZALIA_PIN_CFG lines, as I have not yet figured out how to use the template syntax to implement this. In any case, it may not be possible at all, or require such a complex template that any benefit would be negligible. However, it does seem like arbitrary Go functions can be added to a template's function map, allowing more complex output to be defined using standard Go code. This is probably a better approach for this sort of file. TEST=Generated output is identical to the output before this change (except hda_verb.c for reasons noted above) [0]: https://pkg.go.dev/text/template [1]: https://pkg.go.dev/text/template#hdr-Arguments [2]: https://pkg.go.dev/text/template#hdr-Actions [3]: https://pkg.go.dev/text/template#hde-Functions [4]: https://pkg.go.dev/text/template#Template.Funcs Change-Id: I15934c6ebc8a599dbe1c578481de48f135d97232 Signed-off-by: Nicholas Chin <nic.c3.14(a)gmail.com> --- M util/autoport/azalia.go M util/autoport/main.go A util/autoport/templates/gma-mainboard.ads A util/autoport/templates/hda_verb.c 4 files changed, 56 insertions(+), 62 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/83279/1 diff --git a/util/autoport/azalia.go b/util/autoport/azalia.go index c98b03c..b61dd80 100644 --- a/util/autoport/azalia.go +++ b/util/autoport/azalia.go @@ -1,33 +1,12 @@ package main -import ( - "fmt" - "sort" -) - type azalia struct { } func (i azalia) Scan(ctx Context, addr PCIDevData) { - az := Create(ctx, "hda_verb.c") - defer az.Close() - - Add_gpl(az) - az.WriteString( - `#include <device/azalia_device.h> - -const u32 cim_verb_data[] = { -`) - + createFromTemplate(ctx, "hda_verb.c", ctx) + /* for _, codec := range ctx.InfoSource.GetAzaliaCodecs() { - fmt.Fprintf(az, "\t0x%08x,\t/* Codec Vendor / Device ID: %s */\n", - codec.VendorID, codec.Name) - fmt.Fprintf(az, "\t0x%08x,\t/* Subsystem ID */\n", - codec.SubsystemID) - fmt.Fprintf(az, "\t%d,\t\t/* Number of 4 dword sets */\n", - len(codec.PinConfig)+1) - fmt.Fprintf(az, "\tAZALIA_SUBVENDOR(%d, 0x%08x),\n", - codec.CodecNo, codec.SubsystemID) keys := []int{} for nid, _ := range codec.PinConfig { @@ -42,14 +21,7 @@ } az.WriteString("\n"); } - - az.WriteString( - `}; - -const u32 pc_beep_verbs[0] = {}; - -AZALIA_ARRAY_SIZES; -`) + */ PutPCIDev(addr, "") } diff --git a/util/autoport/main.go b/util/autoport/main.go index b7130b2..0723fef 100644 --- a/util/autoport/main.go +++ b/util/autoport/main.go @@ -10,6 +10,7 @@ "os" "sort" "strings" + "text/template" ) type PCIAddr struct { @@ -154,6 +155,17 @@ return result } +func createFromTemplate(ctx Context, name string, data any) { + f := Create(ctx, name) + defer f.Close() + t := template.Must(template.ParseFiles("templates/" + name)) + err := t.Execute(f, data) + if err != nil { + fmt.Printf("Error: %s", err) + } + +} + func AddBootBlockFile(Name string, Condition string) { BootBlockFiles[Name] = Condition } @@ -527,10 +539,7 @@ } func makeKconfigName(ctx Context) { - kn := Create(ctx, "Kconfig.name") - defer kn.Close() - - fmt.Fprintf(kn, "config %s\n\tbool \"%s\"\n", ctx.KconfigName, ctx.Model) + createFromTemplate(ctx, "Kconfig.name", ctx) } func makeComment(name string) string { @@ -875,32 +884,6 @@ `) if IGDEnabled { - gma := Create(ctx, "gma-mainboard.ads") - defer gma.Close() - - gma.WriteString(`-- SPDX-License-Identifier: GPL-2.0-or-later - -with HW.GFX.GMA; -with HW.GFX.GMA.Display_Probing; - -use HW.GFX.GMA; -use HW.GFX.GMA.Display_Probing; - -private package GMA.Mainboard is - - -- FIXME: check this - ports : constant Port_List := - (DP1, - DP2, - DP3, - HDMI1, - HDMI2, - HDMI3, - Analog, - LVDS, - eDP); - -end GMA.Mainboard; -`) + createFromTemplate(ctx, "gma-mainboard.ads", nil) } } diff --git a/util/autoport/templates/gma-mainboard.ads b/util/autoport/templates/gma-mainboard.ads new file mode 100644 index 0000000..133fde5 --- /dev/null +++ b/util/autoport/templates/gma-mainboard.ads @@ -0,0 +1,23 @@ +-- SPDX-License-Identifier: GPL-2.0-or-later + +with HW.GFX.GMA; +with HW.GFX.GMA.Display_Probing; + +use HW.GFX.GMA; +use HW.GFX.GMA.Display_Probing; + +private package GMA.Mainboard is + + -- FIXME: check this + ports : constant Port_List := + (DP1, + DP2, + DP3, + HDMI1, + HDMI2, + HDMI3, + Analog, + LVDS, + eDP); + +end GMA.Mainboard; diff --git a/util/autoport/templates/hda_verb.c b/util/autoport/templates/hda_verb.c new file mode 100644 index 0000000..7d7f971 --- /dev/null +++ b/util/autoport/templates/hda_verb.c @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <device/azalia_device.h> + +const u32 cim_verb_data[] = { + {{range .InfoSource.GetAzaliaCodecs}} + {{printf "0x%08x" .VendorID}}, /* Codec Vendor / Device ID: {{.Name}} */ + {{printf "0x%08x" .SubsystemID }}, /* Subsystem ID */ + {{len .PinConfig | printf "%d"}}, /* Number of 4 dword sets */ + AZALIA_SUBVENDOR({{printf "%d, 0x%08x" .CodecNo .SubsystemID}}), + {{end}} +}; + +const u32 pc_beep_verbs[0] = {}; + +AZALIA_ARRAY_SIZES; -- To view, visit https://review.coreboot.org/c/coreboot/+/83279?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I15934c6ebc8a599dbe1c578481de48f135d97232 Gerrit-Change-Number: 83279 Gerrit-PatchSet: 1 Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

[M] Change in coreboot[main]: mb: source site-local mainboard Kconfig.name and Kconfig files
by Angel Pons (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Alexander Couzens, David Hendricks, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Martin L Roth, Matt DeVillier, Michael Niewöhner, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford. Angel Pons has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email ) Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I will never understand why people fear local branches ;-) […] Yeah. I've had this problem with my site-local meme magic to auto-add blobs to the build, where I couldn't reference board names that were out-of-tree. I mitigated this by adding some prompts (so I can manually enable the meme magic for out-of-tree boards) -- To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727 Gerrit-Change-Number: 83119 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 30 Jun 2024 16:51:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[M] Change in coreboot[main]: mb: source site-local mainboard Kconfig.name and Kconfig files
by Michael Niewöhner (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Alexander Couzens, Angel Pons, David Hendricks, Evgeny Zinoviev, Felix Held, Felix Singer, Jeremy Soller, Martin L Roth, Matt DeVillier, Michał Żygowski, Philipp Hug, Piotr Król, Ron Minnich, Sean Rhodes, Tim Crawford. Michael Niewöhner has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83119?usp=email ) Change subject: mb: source site-local mainboard Kconfig.name and Kconfig files ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Is there a way to achieve equivalent functionality without having to modify all `src/mainboard/*/Kco […] I will never understand why people fear local branches ;-) Hm, I guess site-local Kconfig.name must be sourced in the mainboard's Kconfig because it's part of a `choice`and AFAIK you can't extend a choice from a separate Kconfig file. -- To view, visit https://review.coreboot.org/c/coreboot/+/83119?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I4106fea7197c979e6648ebbbbaa107070c916727 Gerrit-Change-Number: 83119 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com> Gerrit-Reviewer: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu> Gerrit-Attention: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 30 Jun 2024 16:32:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: David Hendricks <david.hendricks(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>

1 0

[XS] Change in coreboot[main]: util/liveiso/nixos: Update to 24.05
by Felix Singer (Code Review) 30 Jun '24

30 Jun '24

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/83276?usp=email ) Change subject: util/liveiso/nixos: Update to 24.05 ...................................................................... util/liveiso/nixos: Update to 24.05 Change-Id: I62dc3a7fd5b8aef467fc547015f23e41d3260122 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/liveiso/nixos/build.sh M util/liveiso/nixos/common.nix 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/83276/1 diff --git a/util/liveiso/nixos/build.sh b/util/liveiso/nixos/build.sh index 9a3889d..40e39b5 100755 --- a/util/liveiso/nixos/build.sh +++ b/util/liveiso/nixos/build.sh @@ -11,4 +11,4 @@ nix-build '<nixpkgs/nixos>' \ -A config.system.build.isoImage \ -I nixos-config=$config \ - -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-23.11.tar… + -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/refs/heads/nixos-24.05.tar… diff --git a/util/liveiso/nixos/common.nix b/util/liveiso/nixos/common.nix index ff5dfea..362b281 100644 --- a/util/liveiso/nixos/common.nix +++ b/util/liveiso/nixos/common.nix @@ -8,7 +8,7 @@ <nixpkgs/nixos/modules/installer/cd-dvd/iso-image.nix> ]; - system.stateVersion = "23.11"; + system.stateVersion = "24.05"; isoImage = { makeEfiBootable = true; -- To view, visit https://review.coreboot.org/c/coreboot/+/83276?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I62dc3a7fd5b8aef467fc547015f23e41d3260122 Gerrit-Change-Number: 83276 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>

1 0

[XS] Change in coreboot[main]: nb/intel/sandybridge/chipset.cb: Add alias for `cpu_cluster`
by Anastasios Koutian (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Angel Pons. Anastasios Koutian has posted comments on this change by Angel Pons. ( https://review.coreboot.org/c/coreboot/+/83275?usp=email ) Change subject: nb/intel/sandybridge/chipset.cb: Add alias for `cpu_cluster` ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can wait for this change to be merged so I can rebase on top and use it here CB:83269 -- To view, visit https://review.coreboot.org/c/coreboot/+/83275?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id6ead3d98d8fc17cab44ecf0b2af60a23187e036 Gerrit-Change-Number: 83275 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 15:51:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in coreboot[main]: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1)
by Federico Amedeo Izzo (Code Review) 30 Jun '24

30 Jun '24

Federico Amedeo Izzo has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email ) Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1) ...................................................................... Patch Set 17: (1 comment) Patchset: PS17: > coreboot logs the time spent printing, it doesn't seem to be that high. […] You both were right, disabling `CONFIG_CONSOLE_SERIAL` reduced the boot time to 1.895s, which is not much lower, but still lower. This time on the second commit i avoided the MRC cache by disabling it in the config `CONFIG_CACHE_MRC_SETTINGS=n`, as this board always reboots itself on first boot after flashing and reconnecting power, so I was missing the boot without MRC cache. Thanks for all the feedback, It's been a pleasure contributing this port! -- To view, visit https://review.coreboot.org/c/coreboot/+/82010?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9414eb742b6b90459e010b038c1994537e9801a5 Gerrit-Change-Number: 82010 Gerrit-PatchSet: 17 Gerrit-Owner: Federico Amedeo Izzo <federico(a)izzo.pro> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Brandon Weeks <bweeks(a)google.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 15:33:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Federico Amedeo Izzo <federico(a)izzo.pro>

1 0

[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow PL1/PL2 configuration
by Anastasios Koutian (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Angel Pons, Patrick Rudolph. Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email ) Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ...................................................................... Patch Set 1: (1 comment) File src/cpu/intel/model_206ax/chip.h: https://review.coreboot.org/c/coreboot/+/83269/comment/79dc211e_95e59a04?us… : PS1, Line 46: int pl1; /* Long-term power limit*/ : int pl2; /* Short-term power limit*/ > Huh, that's a pretty small unit. Out of curiosity, any reason to use microwatts instead of watts? […] I chose this in order to be consistent with the linux kernel's intel-rapl-msr interface (/sys/devices/virtual/powercap/intel-rapl) which allows to configure these limits from userspace. Also, Intel's manuals commonly use microjoules for MSR energy measurements, so microwatts made sense. -- To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee Gerrit-Change-Number: 83269 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 15:19:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasios Koutian <akoutian2(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow PL1/PL2 configuration
by Anastasios Koutian (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Angel Pons, Patrick Rudolph. Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email ) Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ...................................................................... Patch Set 1: (1 comment) File src/northbridge/intel/sandybridge/northbridge.c: https://review.coreboot.org/c/coreboot/+/83269/comment/55873a5c_a7f0bd86?us… : PS1, Line 354: 28 > Actually, this is the time parameter, Tau. […] Ah, you're right. Personally I have not found it useful. But perhaps a thing to do in the future in order to have feature-completeness. Will note it as a low-priority TODO. -- To view, visit https://review.coreboot.org/c/coreboot/+/83269?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee Gerrit-Change-Number: 83269 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 15:11:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasios Koutian <akoutian2(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[L] Change in coreboot[main]: [WIP] OptiPlex 3050 port
by Máté Kukri (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Angel Pons, Felix Singer. Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email ) Change subject: [WIP] OptiPlex 3050 port ...................................................................... Patch Set 11: (1 comment) File src/mainboard/dell/optiplex_3050/acpi/dptf.asl: PS11: > I would remove it then. I'm not sure if DPTF is of much use on desktops anyway. Okay, I am not disagreeing, I'll get rid of it in the next patchset, I have no use for this. -- To view, visit https://review.coreboot.org/c/coreboot/+/82053?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8d443e39ee684a4eaa19c835a945cfe569c051e2 Gerrit-Change-Number: 82053 Gerrit-PatchSet: 11 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 15:09:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

[S] Change in coreboot[main]: cpu/intel/model_206ax: Allow turbo boost ratio limit configuration
by Anastasios Koutian (Code Review) 30 Jun '24

30 Jun '24

Attention is currently required from: Angel Pons. Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83271?usp=email ) Change subject: cpu/intel/model_206ax: Allow turbo boost ratio limit configuration ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/83271/comment/74e91416_c3c6744c?us… : PS2, Line 9: Tested on ThinkPad T420 with the i7-3940XM. > Sounds good. […] Ack. A potential way to go about this: - Add vendor defaults in devicetree.cb, for now use these values - Implement Kconfig settings: "Use CMOS value" or "Use devicetree value" - Implement CMOS setting -- To view, visit https://review.coreboot.org/c/coreboot/+/83271?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1c65a129478e8ac2c4f66eb3c6aa2507358f82ad Gerrit-Change-Number: 83271 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasios Koutian <akoutian2(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 30 Jun 2024 15:09:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasios Koutian <akoutian2(a)gmail.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>

1 0

← Newer
1
2
3
4
5
6
7
8
...
353
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit June 2024